On 03.02.2017 13:02, Daniel P. Berrange wrote: > The -o arg to the convert command allows specification of format/protocol > options for the newly created image. This adds a -o arg to the dd command > to get feature parity. > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > --- > qemu-img-cmds.hx | 2 +- > qemu-img.c | 32 +++++++++++++++++++++++++++++++- > qemu-img.texi | 6 ++++-- > 3 files changed, 36 insertions(+), 4 deletions(-)
I don't like this patch for the same reasons as for patch 3, but I like it a bit better. The code introduced here is exactly the same as for img_convert(), so merging the two would (or "is going to", I hope) be trivial. So a pretty weak Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
