On 03/02/2017 00:20, Peter Lieven wrote: > Am 02.02.2017 um 22:41 schrieb Paolo Bonzini: >> >> On 31/01/2017 07:36, Peter Lieven wrote: >>> the current implementation fails if we try to freeze an >>> already frozen filesystem. This can happen if a filesystem >>> is mounted more than once (e.g. with a bind mount). >>> >>> Suggested-by: Christian Theune <c...@flyingcircus.io> >>> Cc: qemu-sta...@nongnu.org >>> Signed-off-by: Peter Lieven <p...@kamp.de> >> What happens when you thaw? >> >> Paolo > > If you try to THAW an unfrozen FS you get EINVAL. > The current code thaws until an error is returned. > > So it should work as is. > > If you feel uncomfortable with the EBUSY approach. The other idea would > be to track all devices which have been successfully frozen and skip > consecutive > tries to freeze them.
No, just asking. Reeviewed-by: Paolo Bonzini <pbonz...@redhat.com>
