On 20 January 2017 at 16:32, Julian Brown <jul...@codesourcery.com> wrote: > Thumb-1 code has some issues in BE32 mode (as currently implemented). In > short, since bytes are swapped within words at load time for BE32 > executables, this also swaps pairs of adjacent Thumb-1 instructions. > > This patch un-swaps those pairs of instructions again, both for execution, > and for disassembly. (The previous version of the patch always read four > bytes in arm_read_memory_func and then extracted the proper two bytes, > in a probably misguided attempt to match the behaviour of actual hardware > as described by e.g. the ARM9TDMI TRM, section 3.3 "Endian effects for > instruction fetches". It's less complicated to just read the correct > two bytes though.) >
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM