From: Shannon Zhao
Add power button device in ACPI DSDT table.
Signed-off-by: Shannon Zhao
Signed-off-by: Shannon Zhao
Reviewed-by: Wei Huang
Tested-by: Wei Huang
---
hw/arm/virt-acpi-build.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/
From: Shannon Zhao
Signed-off-by: Shannon Zhao
Signed-off-by: Shannon Zhao
Tested-by: Wei Huang
---
hw/acpi/aml-build.c | 20
include/hw/acpi/aml-build.h | 7 +++
2 files changed, 27 insertions(+)
diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
index
From: Shannon Zhao
Here GPIO pin 3 is used for Power Button, add _E03 in ACPI DSDT table.
Signed-off-by: Shannon Zhao
Signed-off-by: Shannon Zhao
Tested-by: Wei Huang
---
hw/arm/virt-acpi-build.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/hw/arm/virt-acpi-build.c b/h
From: Shannon Zhao
Signed-off-by: Shannon Zhao
Signed-off-by: Shannon Zhao
Tested-by: Wei Huang
---
hw/acpi/aml-build.c | 68 +
include/hw/acpi/aml-build.h | 20 +
2 files changed, 88 insertions(+)
diff --git a/hw/acpi/aml-build
On 2015/12/3 15:21, Yang Hongyang wrote:
On 2015年12月03日 14:48, Hailiang Zhang wrote:
On 2015/12/3 14:25, Wen Congyang wrote:
On 12/03/2015 11:53 AM, Hailiang Zhang wrote:
On 2015/12/3 9:17, Wen Congyang wrote:
On 11/24/2015 05:25 PM, zhanghailiang wrote:
We add each netdev a default filter
From: Shannon Zhao
ACPI 5.0 supports GPIO-signaled ACPI Events. This can be used for
powerdown, hotplug evnets. Add a GPIO controller in machine virt,
to support powerdown, maybe can be used for cpu hotplug. And
here we use pl061.
Signed-off-by: Shannon Zhao
Signed-off-by: Shannon Zhao
Reviewe
From: Shannon Zhao
Currently mach-virt model doesn't support powerdown request. Guest VM
doesn't react to system_powerdown from monitor console (or QMP) because
there is no communication mechanism for such requests. This patch registers
GPIO Pin 3 with powerdown notification. So guest VM can rece
From: Shannon Zhao
ACPI SPEC 5.0 defines GPIO-signaled ACPI Events for Hardware-reduced
platforms(like ARM). It uses GPIO pin to trigger an event to the guest.
For QEMU, here we add PL061 GPIO controller and use PIN 3 for
system_powerdown, reserving PIN 0, 1, 2 for PCI hotplug, CPU hotplug and
me
From: Shannon Zhao
Add GPIO controller in ACPI DSDT table. It can be used for gpio event.
Signed-off-by: Shannon Zhao
Signed-off-by: Shannon Zhao
Tested-by: Wei Huang
---
hw/arm/virt-acpi-build.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/hw/arm/virt-acpi-build.
From: Shannon Zhao
Add a gpio-keys node. This is used for Poweroff for the systems which
use DT not ACPI.
Signed-off-by: Shannon Zhao
Signed-off-by: Shannon Zhao
Tested-by: Wei Huang
---
hw/arm/virt.c | 16
1 file changed, 16 insertions(+)
diff --git a/hw/arm/virt.c b/hw/ar
On Sat, Dec 05, 2015 at 07:52:20PM +0800, Yang Wei wrote:
> The following exception is threw:
> Python Exception name 'long' is not defined:
> Error occurred in Python command: name 'long' is not defined
>
> Python 2.4+, int()/long() have been unified, so replace long
> with int.
>
> Signed-off-
On 2015/12/4 22:10, Igor Mammedov wrote:
> On Mon, 16 Nov 2015 21:23:07 +0800
> shannon.z...@linaro.org wrote:
>
>> From: Shannon Zhao
>>
>> Here GPIO pin 3 is used for Power Button, add _E03 in ACPI DSDT table.
>>
>> Signed-off-by: Shannon Zhao
>> Signed-off-by: Shannon Zhao
>> Tested-by: We
> On Fri, Dec 04, 2015 at 11:52:07AM +0800, Liang Li wrote:
> > There are some flaws in qemu_put_compression_data, this patch tries to
> > fix it. Now it can be used by other code.
> >
> > Signed-off-by: Liang Li
> > ---
> > migration/qemu-file.c | 10 +-
> > 1 file changed, 9 insertions(
On Fri, Dec 04, 2015 at 11:52:07AM +0800, Liang Li wrote:
> There are some flaws in qemu_put_compression_data, this patch tries
> to fix it. Now it can be used by other code.
>
> Signed-off-by: Liang Li
> ---
> migration/qemu-file.c | 10 +-
> 1 file changed, 9 insertions(+), 1 deletion(
On Fri, Dec 04, 2015 at 11:52:07AM +0800, Liang Li wrote:
> There are some flaws in qemu_put_compression_data, this patch tries
> to fix it. Now it can be used by other code.
This commit description is vague and doesn't explain what this patch
does or why it is necessary.
Please try to cover "wha
On Mon, Dec 07, 2015 at 02:21:44PM +0800, Fam Zheng wrote:
> On Mon, 12/07 13:56, Peter Xu wrote:
> > /* send DUMP_COMPLETED message (unconditionally) */
> > -qapi_event_send_dump_completed(!!local_err, (local_err ? \
> > +result = qmp_query_dump(NULL);
> > +/* should never fails *
On Mon, Dec 07, 2015 at 02:14:11PM +0800, Fam Zheng wrote:
> On Mon, 12/07 13:56, Peter Xu wrote:
> > +if (runstate_check(RUN_STATE_INMIGRATE)) {
> > +error_setg(errp, "Dump not allowed during incoming migration.");
> > +return;
> > +}
> > +
>
> Detached dump when "inmigrat
On Thu, Dec 3, 2015 at 10:01 PM, Andrew Baumann
wrote:
> This adds the system mailboxes which are used to communicate with a
> number of GPU peripherals on Pi/Pi2.
>
Are there any publically available specs for this? I found the
peripheral manual which documents the interrupts controller but I
co
>> An error message will be reported like this:
>> "libxl: error: libxl_qmp.c:287:qmp_handle_error_response: received an
>> error message from QMP server: Duplicate ID 'pci-pt-07_10.1' for device"
>>
>> When xen_pt_region_add/del() is called, MemoryRegion may not belong to
>> the XenPCIPassthrou
On Sun, Dec 6, 2015 at 10:03 PM, Andrew Baumann
wrote:
> Hi Peter,
>
>> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com]
>> Sent: Sunday, 6 December 2015 15:47
>> On Sun, Dec 6, 2015 at 1:20 PM, Andrew Baumann
>> wrote:
>> >> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com]
On Mon, 12/07 13:56, Peter Xu wrote:
> v5 changes:
> - patch 1
> - comment English fix [Fam]
> - patch 2
> - pass has_detach=true always in hmp_dump_guest_memory [Paolo]
> - patch 3
> - always use local_err and error_propagate() when need to check
> the result [Fam]
> - patch 8
> - add
On Mon, 12/07 13:56, Peter Xu wrote:
> When dump-guest-memory is requested with detach flag, after its
> return, user could query its status using "query-dump" command (with
> no argument). The result contains:
>
> - status: current dump status
> - completed: bytes written in the latest dump
> - t
On Mon, 12/07 13:56, Peter Xu wrote:
> Signed-off-by: Peter Xu
> ---
> dump.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/dump.c b/dump.c
> index f0ee9a8..aa9d1f8 100644
> --- a/dump.c
> +++ b/dump.c
> @@ -1625,6 +1625,11 @@ void qmp_dump_guest_memory(bool paging, const char
>
On Sun, Dec 06, 2015 at 04:02:14PM -0800, Peter Crosthwaite wrote:
> On Fri, Dec 4, 2015 at 11:24 AM, Kevin O'Connor wrote:
> > On Fri, Dec 04, 2015 at 10:50:21AM -0800, Peter Crosthwaite wrote:
> >> > FWIW, I don't think the SD card will be qdevified because it doesn't
> >> > need a bus. It's si
The added group of operations enables tracking of the changed bits in
the dirty bitmap.
Signed-off-by: Fam Zheng
---
block.c | 46 +-
block/mirror.c| 3 ++-
blockdev.c| 3 ++-
include/block/block.h | 11 +++
Hi Peter,
> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com]
> Sent: Sunday, 6 December 2015 15:47
> On Sun, Dec 6, 2015 at 1:20 PM, Andrew Baumann
> wrote:
> >> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com]
> >> Sent: Saturday, 5 December 2015 22:27
> >> On Fri, Dec 4, 2
Signed-off-by: Fam Zheng
---
tests/test-hbitmap.c | 74
1 file changed, 74 insertions(+)
diff --git a/tests/test-hbitmap.c b/tests/test-hbitmap.c
index abcea0c..6ab9101 100644
--- a/tests/test-hbitmap.c
+++ b/tests/test-hbitmap.c
@@ -23,6 +23,
It will calculate percentage of finished work from completed and
total.
Signed-off-by: Peter Xu
---
hmp-commands-info.hx | 14 ++
hmp.c| 18 ++
hmp.h| 1 +
3 files changed, 33 insertions(+)
diff --git a/hmp-commands-info.hx b/hmp-comm
Vladimir,
This is what I propose to implement meta bitmap. It's implemented in the
HBitmap level to be more efficient, and the interface slightly varies too.
I'd like to use these operations to make dirty bitmap persistence more
efficient too: unchanged dirty bits don't need to be flushed to disk
Signed-off-by: Peter Xu
---
dump.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/dump.c b/dump.c
index f0ee9a8..aa9d1f8 100644
--- a/dump.c
+++ b/dump.c
@@ -1625,6 +1625,11 @@ void qmp_dump_guest_memory(bool paging, const char *file,
DumpState *s;
Error *local_err = NULL;
+
If "detach" is provided, one thread is created to do the dump work,
while main thread will return immediately. For each GuestPhysBlock,
adding one more field "mr" to points to MemoryRegion that it
belongs, also ref the mr before use.
Signed-off-by: Peter Xu
---
dump.c |
The meta bitmap will have the same size and granularity as the tracked
bitmap, and upon each bit toggle, the corresponding bit in the meta
bitmap, at an identical position, will be set.
Signed-off-by: Fam Zheng
---
include/qemu/hbitmap.h | 7 +++
util/hbitmap.c | 22
No functional change. Cleanup only.
Signed-off-by: Peter Xu
---
dump.c| 31 +--
include/sysemu/dump.h | 3 +++
2 files changed, 24 insertions(+), 10 deletions(-)
diff --git a/dump.c b/dump.c
index ccd56c8..f0ee9a8 100644
--- a/dump.c
+++ b/dump.c
@@
When dump-guest-memory is requested with detach flag, after its
return, user could query its status using "query-dump" command (with
no argument). The result contains:
- status: current dump status
- completed: bytes written in the latest dump
- total: bytes to write in the latest dump
>From comp
One new QMP event DUMP_COMPLETED is added. When a dump finishes, one
DUMP_COMPLETED event will occur to notify the user.
Signed-off-by: Peter Xu
---
docs/qmp-events.txt | 16
dump.c | 15 ---
qapi-schema.json| 3 ++-
qapi/event.json | 14 +++
For now, it has no effect. It will be used in dump detach support.
Signed-off-by: Peter Xu
---
dump.c| 13 +
include/qemu-common.h | 4
qmp.c | 14 ++
3 files changed, 31 insertions(+)
diff --git a/dump.c b/dump.c
index b48cec2..ccd5
Here, total_size is the size in bytes to be dumped (raw data, which
means before compression), while written_size are bytes handled (raw
size too).
Signed-off-by: Peter Xu
---
dump.c| 32
include/sysemu/dump.h | 9 +
2 files changed, 41 i
Instead of malloc/free each time for DumpState, make it
static. Added DumpStatus to show status for dump.
This is to be used for detached dump.
Signed-off-by: Peter Xu
---
dump.c| 21 -
include/sysemu/dump.h | 2 ++
qapi-schema.json | 18 +++
v5 changes:
- patch 1
- comment English fix [Fam]
- patch 2
- pass has_detach=true always in hmp_dump_guest_memory [Paolo]
- patch 3
- always use local_err and error_propagate() when need to check
the result [Fam]
- patch 8
- add "DumpQueryResult" in DUMP_COMPLETED event [Eric]
(sin
This patch only adds the interfaces, but does not implement them.
"detach" parameter is made optional, to make sure that all the old
dump-guest-memory requests will still be able to work.
Signed-off-by: Peter Xu
---
dump.c | 5 +++--
hmp-commands.hx | 5 +++--
hmp.c| 9 +++
It might be a little bit confusing and error prone to do
dump_cleanup() in these two functions. A better way is to do
dump_cleanup() before dump finish, no matter whether dump has
succeeded or not.
Signed-off-by: Peter Xu
Reviewed-by: Fam Zheng
---
dump.c | 78 +++---
> From: Jason Wang [mailto:jasow...@redhat.com]
> Sent: Sunday, 6 December 2015 18:44
> On 12/05/2015 02:58 AM, Andrew Baumann wrote:
> > With this change, access to invalid/unimplemented device registers are
> > logged as a "guest error" rather than aborting qemu with
> > hw_error. This enables dr
ping
Wei
2015-12-05 19:52 GMT+08:00 Yang Wei :
> The following exception is threw:
> Python Exception name 'long' is not defined:
> Error occurred in Python command: name 'long' is not defined
>
> Python 2.4+, int()/long() have been unified, so replace long
> with int.
>
> Signed-off-by: Yang W
On Tue, Dec 1, 2015 at 12:25 PM, Jean-Christophe Dubois
wrote:
> Linux on i.MX31/KZM is expecting the CCM to use the CKIH ref clock instead
> of the CKIL plus the FPM multiplier.
>
> We change the CCMR reg reset value to match linux expected config.
>
> This allow the CCM to provide a 39MHz clk (a
This commit fixes migration of a QEMU/KVM guest from kernel >= v3.9 to
kernel <= v3.7 (e.g. from RHEL 7 to RHEL 6). Without this commit a guest
migrated across these kernel versions fails to resume on the target host
as its segment descriptors are invalid.
Two separate kernel commits combined toge
On Tue, Dec 1, 2015 at 12:25 PM, Jean-Christophe Dubois
wrote:
> With this CCM, i.MX25 timer is accurate with "real world time".
>
> Signed-off-by: Jean-Christophe Dubois
> ---
> Changes since v1:
> * rework loging to match other i.MX drivers
>
> Changes since v2:
> * We moved to an inheritance
pc.h defines a SET_MACHINE_COMPAT macro to make setting up compat_props
for the various PC machine versions less verbose. There's nothing
inherently PC specific about it, though, so move it to boards.h where other
versioned machine types (like pseries-*) can use it.
While we're doing that, change
At the moment all the class_init functions and TypeInfo structures for the
various versioned pseries machine types are open-coded. As more versions
are created this is getting increasingly clumsy.
This patch borrows the approach used in PC, using a DEFINE_SPAPR_MACHINE()
macro to construct most o
This tweaks the way the default machine version is controlled, so that
there will be a bit less churn when each new version is introduced.
Signed-off-by: David Gibson
---
hw/ppc/spapr.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/hw/ppc/spapr.c b/hw
Thomas Huth recently posted a patches to switch the default USB
controller for the pseries machine type to xHCI, which necessitated
creating a pseries-2.6 machine type version.
That raised a bunch of comments suggesting better ways we could manage
the machine versioning for pseries.
This is an at
The instance_init() functions for several of the pseries-x.y versioned
machine types explicitly call spapr_machine_initfn(). But that's the
instance_init function for the common parent of all those machine types,
so will already have been called beforehand by the QOM infrastructure.
Remove the re
Currently each of the *_class_options() functions for the pseries-2.1 ..
pseries-2.5 machine types are standalone. This will become harder to
maintain as new versions are added.
This patch restructures them similarly to x86 where each function calls
the one from the next version, then overrides a
To make the spapr_machine_*_class_init() functions a little less bulky.
Signed-off-by: David Gibson
---
hw/ppc/spapr.c | 24
1 file changed, 4 insertions(+), 20 deletions(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index b08d338..3078e60 100644
--- a/hw/ppc/spapr.c
Currently, the versioned spapr machine types put the machine type version
into the description string. PC does not do this, using just the name
itself to distinguish. Doing the same lets us move setting the description
into the common base class, simplifying the code slightly.
Signed-off-by: Dav
98cec76 "machine: Set MachineClass::name automatically" removed the setting
of mc->name for the pseries machine types, since it can be derived
automatically from the type names constructed with MACHINE_TYPE_NAME().
Unfortunately fb0fc8f "spapr: Create pseries-2.5 machine" went in later and
brought
Signed-off-by: David Gibson
---
hw/ppc/spapr.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 8b8eb18..2d57ab0 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -2337,6 +2337,20 @@ static const TypeInfo spapr_machine
hw/ppc/spapr.c has a number of definitions related to the various versioned
machine types ("pseries-2.1" .. "pseries-2.5") it defines. These are
mostly arranged by type of function first, then machine version second, and
it's not consistent about whether it goes in increasing or decreasing
version
From: Andrew Baumann
With this change, access to invalid/unimplemented device registers are
logged as a "guest error" rather than aborting qemu with
hw_error. This enables drivers for similar devices (e.g. SMSC 9221),
by simply ignoring the unimplemented writes. It's also closer to what
real hard
From: Andrew Baumann
There appears to have been a longstanding typo in the implementation
of the "MAC address loaded" bit in the E2P_CMD (EEPROM command)
register. The code was using 0x10, but the controller spec says it
should be bit 8 (0x100).
Signed-off-by: Andrew Baumann
Signed-off-by: Jaso
From: Miao Yan
Macro MAC_FMT and MAC_ARG are not defined, but used in vmxnet3_net_init().
This will cause build error when debug level is raised in
vmxnet3_debug.h (enable all VMXNET3_DEBUG_xxx).
Use VMXNET_MF and VXMNET_MA instead.
Signed-off-by: Miao Yan
Acked-by: Dmitry Fleytman
Signed-off
Backends could provide a packet whose length is greater than buffer
size. Check for this and truncate the packet to avoid rx buffer
overflow in this case.
Cc: Prasad J Pandit
Cc: qemu-sta...@nongnu.org
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Jason Wang
---
hw/net/pcnet.c | 6 ++
1 f
From: "Michael S. Tsirkin"
vmxnet3 always produces a warning under qtest.
This is not a user error, don't warn.
Suggested-by: Paolo Bonzini
Signed-off-by: Michael S. Tsirkin
Signed-off-by: Jason Wang
---
hw/net/vmxnet3.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/net/vmxnet3.c b/
From: Miao Yan
Vmxnet3 uses the following debug macro style:
#ifdef SOME_DEBUG
# define debug(...) do{ printf(...); } while (0)
# else
# define debug(...) do{ } while (0)
#endif
If SOME_DEBUG is undefined, then format string inside the
debug macro will never be checked by compiler. Code
From: Miao Yan
Macro VMW_SHPRN(...) is already defined vmxnet3_debug.h,
so remove the duplication
Signed-off-by: Miao Yan
Reviewed-by: Eric Blake
Signed-off-by: Jason Wang
---
hw/net/vmware_utils.h | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/hw/net/vmware_utils.h
The following changes since commit 61e3aa25b129b48d8a8cb851aae2a787af7ca5e1:
Merge remote-tracking branch
'remotes/mjt/tags/pull-trivial-patches-2015-12-04' into staging (2015-12-04
10:55:03 +)
are available in the git repository at:
https://github.com/jasowang/qemu.git tags/net-pull-r
From: "Denis V. Lunev"
e1000 driver in Win2k12 is really well rotten. It 100% hangs on shutdown
of UP VM under flood ping. The guest checks card state and reinjects
itself interrupt in a loop. This is fatal for UP machine.
There is no good way to fix this misbehavior but to kludge it. The
emulat
From: Prasad J Pandit
In loopback mode, pcnet_receive routine appends CRC code to the
receive buffer. If the data size given is same as the buffer size,
the appended CRC code overwrites 4 bytes after s->buffer. Added a
check to avoid that.
Reported by: Qinghao Tang
Cc: qemu-sta...@nongnu.org
Re
On Fri, Dec 04, 2015 at 02:33:01PM +0800, Stefan Hajnoczi wrote:
> On Mon, Nov 30, 2015 at 04:34:47PM +1100, Sam Bobroff wrote:
> > Hi QEMU programmers,
> >
> > While doing some experimental work on QEMU that has involved adding a lot of
> > new log messages (using qemu_log_mask()), I've discovere
Bug url : http://bugzilla-archived.xenproject.org/bugzilla/show_bug.cgi?id=1905
Above url descripts the bug which i fix in more detail.
Add pci = [ '$VF_BDF', '$VF_BDF', '$VF_BDF'], $VF_BDFs are different.
pci = [ '$VF_BDF1', '$VF_BDF2', '$VF_BDF3'] is a more accurate description.
-Original Me
On 12/05/2015 04:55 PM, Miao Yan wrote:
> Vmxnet3 uses the following debug macro style:
>
> #ifdef SOME_DEBUG
> # define debug(...) do{ printf(...); } while (0)
> # else
> # define debug(...) do{ } while (0)
> #endif
>
> If SOME_DEBUG is undefined, then format string inside the
> debug mac
On 12/05/2015 03:57 AM, Shmulik Ladkani wrote:
> Thanks Jason,
>
> On Fri, 4 Dec 2015 16:49:52 +0800 Jason Wang wrote:
>>> @@ -2257,6 +2262,10 @@ static void vmxnet3_pci_realize(PCIDevice *pci_dev,
>>> Error **errp)
>>>
>>> vmxnet3_net_init(s);
>>>
>>> +if (pci_is_express(pci_dev)
On 12/05/2015 02:58 AM, Andrew Baumann wrote:
> There appears to have been a longstanding typo in the implementation
> of the "MAC address loaded" bit in the E2P_CMD (EEPROM command)
> register. The code was using 0x10, but the controller spec says it
> should be bit 8 (0x100).
>
> Signed-off-by:
On 12/05/2015 03:38 AM, Shmulik Ladkani wrote:
> Thanks Jason,
>
> On Fri, 4 Dec 2015 16:49:23 +0800 Jason Wang wrote:
>>> @@ -18,6 +18,10 @@
>>> .driver = "virtio-pci",\
>>> .property = "migrate-extra",\
>>> .value= "off",\
>>> +},{\
>>> +
On 12/05/2015 02:58 AM, Andrew Baumann wrote:
> With this change, access to invalid/unimplemented device registers are
> logged as a "guest error" rather than aborting qemu with
> hw_error. This enables drivers for similar devices (e.g. SMSC 9221),
> by simply ignoring the unimplemented writes. I
Hi John
On 12/05/2015 01:55 AM, John Snow wrote:
On 12/04/2015 02:47 AM, Cao jin wrote:
Hi,
As you know, there are many PCI devices still using .init() as its
initialization function, I am planning to do the "convert to realize()"
work, and PCI bridge devices are chosen first.
Cédric Le Goater writes:
> On 11/28/2015 08:59 AM, Benjamin Herrenschmidt wrote:
>> On Fri, 2015-11-27 at 11:21 +0100, Alexander Graf wrote:
>>>
>>> How does real hardware store petitboot? If it's flash, you could pass it
>>> in using -pflash and thus model things even more closely and allow users
On Fri, Dec 4, 2015 at 11:24 AM, Kevin O'Connor wrote:
> On Fri, Dec 04, 2015 at 10:50:21AM -0800, Peter Crosthwaite wrote:
>> > FWIW, I don't think the SD card will be qdevified because it doesn't
>> > need a bus. It's similar indeed to SerialState, which was supposed to
>> > be the poster child
On Sun, Dec 6, 2015 at 1:20 PM, Andrew Baumann
wrote:
>> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com]
>> Sent: Saturday, 5 December 2015 22:27
>> On Fri, Dec 4, 2015 at 1:16 PM, Andrew Baumann
>> wrote:
>> > @@ -1563,6 +1592,11 @@ void sd_write_data(SDState *sd, uint8_t value)
>> >
> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com]
> Sent: Saturday, 5 December 2015 22:27
> On Fri, Dec 4, 2015 at 1:16 PM, Andrew Baumann
> wrote:
> > @@ -1563,6 +1592,11 @@ void sd_write_data(SDState *sd, uint8_t value)
> > sd->data_offset = 0;
> > sd->csd[1
Ideally there should be a warning if a user gives discard=unmap and
isn't using the SCSI bus. Using the following options allows the guest
to detect the drive as a thinly provisioned drive.
-drive discard=unmap,detect-
zeroes=unmap,cache=none,file=vms/win10.hd.img.vmdk,format=vmdk,if=none,id=hd
-d
** Attachment added: "2015-12-06-19:20:59-screenshot.png"
https://bugs.launchpad.net/qemu/+bug/1523246/+attachment/4530556/+files/2015-12-06-19%3A20%3A59-screenshot.png
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.
cvt.s.d and cvt.d.s are FP operations and thus need to convert input
sNaN into corresponding qNaN. Explicitely use the floatXX_maybe_silence_nan
functions for that as the floatXX_to_floatXX functions do not do that.
Cc: Leon Alrae
Signed-off-by: Aurelien Jarno
---
target-mips/op_helper.c | 2 ++
Public bug reported:
When model=virtio is used, TRIM is not supported.
# mount -o discard /dev/vda4 /mnt
# mount | tail -1
/dev/vda4 on /mnt type fuseblk
(rw,nosuid,nodev,relatime,user_id=0,group_id=0,allow_other,blksize=4096)
# fstrim /mnt/
fstrim: /mnt/: the discard operation is not supported
> > Add pci = [ '$VF_BDF', '$VF_BDF', '$VF_BDF'] in
>
> This is a bit confusing: it is not actually correct to assign the same
> device, even
> an SR_IOV VF, multiple times, so these must be all different. More like:
>
> pci = [ '$VF_BDF1', '$VF_BDF2', '$VF_BDF3']
>
>
> > hvm guest configurati
> >> - blen could still be smaller that compressBound(size), you need to
> >> recheck
> >> - blen could have changed, but you don't take that in account for the
> >> following caller.
> >>
> >> So, I think code has a bug?
> >
> > Yes, there is a bug, I should consider the case QEMUFile with emp
85 matches
Mail list logo
