On Mon, Dec 07, 2015 at 02:21:44PM +0800, Fam Zheng wrote: > On Mon, 12/07 13:56, Peter Xu wrote: > > /* send DUMP_COMPLETED message (unconditionally) */ > > - qapi_event_send_dump_completed(!!local_err, (local_err ? \ > > + result = qmp_query_dump(NULL); > > + /* should never fails */ > > s/fails/fail/
Got. > > > diff --git a/qmp-commands.hx b/qmp-commands.hx > > index 7b6f915..eb5bfe2 100644 > > --- a/qmp-commands.hx > > +++ b/qmp-commands.hx > > @@ -858,8 +858,9 @@ Arguments: > > - "protocol": destination file(started with "file:") or destination file > > descriptor (started with "fd:") (json-string) > > - "detach": if specified, command will return immediately rather than > > waiting > > - for the dump completion. A DUMP_COMPLETED event will occur at > > - the end. (json-bool) > > + for the dump completion. The user can track progress using > > + "query-dump" A DUMP_COMPLETED event will occur at the > > Missing "." before "A DUMP_COMPLETED"? Possibly... Changing both. Thanks! Peter > > > + end. (json-bool)
