On 12/05/2015 03:38 AM, Shmulik Ladkani wrote: > Thanks Jason, > > On Fri, 4 Dec 2015 16:49:23 +0800 Jason Wang <jasow...@redhat.com> wrote: >>> @@ -18,6 +18,10 @@ >>> .driver = "virtio-pci",\ >>> .property = "migrate-extra",\ >>> .value = "off",\ >>> + },{\ >>> + .driver = "vmxnet3",\ >>> + .property = "x-old-msi-offsets",\ >>> + .value = "on",\ >>> }, >> To have a better bisection behavior, we'd better enable this and compat >> it in patch 2. > Did you mean the following: > > #1 Introduce the new functionality with its 'x-old-msi-offsets' > property, with the property set to true by default > > #2 Change 'x-old-msi-offsets' default value to false, and introduce the > above compat > > Regards, > Shmulik
Sorry for being unclear, I mean we'd better, keep the compat flag like what has been done in the patch but introduce the property bit and compat it in next patch.