> From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Sunday, 6 December 2015 18:44 > On 12/05/2015 02:58 AM, Andrew Baumann wrote: > > With this change, access to invalid/unimplemented device registers are > > logged as a "guest error" rather than aborting qemu with > > hw_error. This enables drivers for similar devices (e.g. SMSC 9221), > > by simply ignoring the unimplemented writes. It's also closer to what > > real hardware does. > > > > Signed-off-by: Andrew Baumann <andrew.baum...@microsoft.com> > > --- > > hw/net/lan9118.c | 12 ++++++++---- > > 1 file changed, 8 insertions(+), 4 deletions(-) > > Applied in my -net for 2.5. Thanks > > Btw, looks like there're two more hw_error() in this file, better remove > them also?
Yeah, I considered doing that, but figured that those cases (incorrectly-sized register writes in 16-bit mode) are indicative of a pretty badly screwed-up guest, and was going for a minimal patch. It probably makes sense to change them for consistency, though. Andrew
