[Qemu-devel] [PATCH] slirp: Fix non blocking connect for w32

2015-09-16 Thread Stefan Weil
Signed-off-by: Stefan Weil --- This is a hack to fix networking for latest git master and stable. Regards Stefan slirp/tcp_input.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/slirp/tcp_input.c b/slirp/tcp_input.c index f946db8..00a77b4 100644 --- a/slirp/tcp_inpu

[Qemu-devel] [PATCH] vmdk: Create streamOptimized as version 3

2015-09-16 Thread Fam Zheng
VMware products accept only version 3 for streamOptimized, let's bump the version. Reported-by: Radoslav Gerganov Signed-off-by: Fam Zheng --- block/vmdk.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/block/vmdk.c b/block/vmdk.c index be0d640..37326c3 100644 --- a/

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-16 Thread Markus Armbruster
Wen Congyang writes: > On 09/16/2015 07:18 PM, Markus Armbruster wrote: >> Wen Congyang writes: >> >>> On 09/16/2015 04:21 PM, Markus Armbruster wrote: Wen Congyang writes: > On 09/15/2015 07:12 PM, Markus Armbruster wrote: >> Wen Congyang writes: >> >>> On 09/15/201

Re: [Qemu-devel] [PATCH 0/2] target-ppc: vector instruction fixes

2015-09-16 Thread Richard Henderson
On 09/13/2015 02:03 PM, Aurelien Jarno wrote: This patchset fixes some vector instructions which are incorrectly decoded or implemented. The first patch is needed to run recent version of openssl, as it enabled POWER8 instrutctions when it detects such a CPU. Aurelien Jarno (2): target-ppc: f

Re: [Qemu-devel] [Bug 1006655] Re: Can't convert to vmdk with the streamOptimized subformat

2015-09-16 Thread Fam Zheng
On Wed, 09/16 15:32, Kevin Wolf wrote: > Am 16.09.2015 um 14:11 hat Radoslav Gerganov geschrieben: > > My patch has landed: > > https://github.com/qemu/qemu/commit/3efffc3292d94271a15b1606b4a56adf6c6f04ed > > > > I think we can resolve this bug as fixed. Just one note for those how > > are tryin

Re: [Qemu-devel] [PATCH] scsi-generic: let guests recognize readonly=on on passthrough devices

2015-09-16 Thread Fam Zheng
On Wed, 09/16 17:29, Paolo Bonzini wrote: > Passed-through SCSI devices can be opened with the readonly=on option. > When this happens, Linux filters away write commands so that the guest > cannot overwrite the contents of the device. > > However, the guest does not know that the device is read-on

Re: [Qemu-devel] [RFC PATCH 2/2] target-ppc: add CPU IRQ state to PPC VMStateDescription

2015-09-16 Thread Alexey Kardashevskiy
On 09/16/2015 07:09 AM, Mark Cave-Ayland wrote: On 15/09/15 00:10, Alexey Kardashevskiy wrote: On 09/15/2015 05:30 AM, Mark Cave-Ayland wrote: Commit a90db15 "target-ppc: Convert ppc cpu savevm to VMStateDescription" appears to drop the internal CPU IRQ state from the migration stream. Whilst

[Qemu-devel] [PATCH] hw/arm/virt-acpi-build: Fix wrong size of flash

2015-09-16 Thread shannon . zhao
From: Shannon Zhao While virt machine creates two flash devices with total size 0x0800, it wrongly uses this total size for each one. So it will overlap other MMIO spaces. Signed-off-by: Shannon Zhao --- hw/arm/virt-acpi-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[Qemu-devel] [Bug 893208] Re: qemu on ARM hosts can't boot i386 image

2015-09-16 Thread PeteVine
Just for laughs I 've tested my qemu build with this guy's x86 kernel and it's working as expected: https://github.com/mopp/Axel the difference being it was using -cdrom switch to boot from an .iso image -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object

2015-09-16 Thread Yang Hongyang
Hi Eric, On 09/17/2015 05:09 AM, Eric Blake wrote: On 09/16/2015 06:15 AM, Yang Hongyang wrote: Add a netfilter object based on QOM. A netfilter is attached to a netdev, captures all network packets that pass through the netdev. When we delete the netdev, we also delete the netfilter object at

Re: [Qemu-devel] [Qemu-block] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-16 Thread Wen Congyang
On 09/16/2015 10:53 PM, Eric Blake wrote: > On 09/16/2015 05:18 AM, Markus Armbruster wrote: > Perhaps it could be as simple as { 'struct': 'BlockdevOptionsNBD', 'data': { 'addr: 'SocketAddress', 'export': 'str' } } >>> >>> The problem is that:

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-16 Thread Wen Congyang
On 09/16/2015 07:18 PM, Markus Armbruster wrote: > Wen Congyang writes: > >> On 09/16/2015 04:21 PM, Markus Armbruster wrote: >>> Wen Congyang writes: >>> On 09/15/2015 07:12 PM, Markus Armbruster wrote: > Wen Congyang writes: > >> On 09/15/2015 03:37 PM, Markus Armbruster wrot

Re: [Qemu-devel] [PULL 16/24] tcg: Move tci_tb_ptr to -common

2015-09-16 Thread Peter Crosthwaite
On Wed, Sep 16, 2015 at 12:58 PM, Stefan Weil wrote: > Am 16.09.2015 um 21:14 schrieb Peter Crosthwaite: >> On Wed, Sep 16, 2015 at 10:50 AM, Stefan Weil wrote: >>> Am 16.09.2015 um 14:29 schrieb Paolo Bonzini: From: Peter Crosthwaite This requires global visibility to common code

Re: [Qemu-devel] Could not boot a guest vm from kvm mode based on APM X-Gene Host and latest qemu

2015-09-16 Thread liang yan
On 09/16/2015 08:34 AM, Alex Bennée wrote: liang yan writes: Hello, All, I am trying to enable kvm for a guest vm on an APM X-Gene Host with latest qemu, but could not make it work. The host is APM X-Gene 8-core, Linux kernel is 4.1.0-rc7-1-arm64, Guest kernel is linux-3.16rc3 QEMU is la

Re: [Qemu-devel] Could not boot a guest vm from kvm mode based on APM X-Gene Host and latest qemu

2015-09-16 Thread liang yan
On 09/16/2015 03:24 AM, Tushar Jagad wrote: Hi, On Mon, Sep 14, 2015 at 06:03:48PM -0600, liang yan wrote: Hello, All, I am trying to enable kvm for a guest vm on an APM X-Gene Host with latest qemu, but could not make it work. The host is APM X-Gene 8-core, Linux kernel is 4.1.0-rc7-1-arm6

[Qemu-devel] [Bug 893208] Re: qemu on ARM hosts can't boot i386 image

2015-09-16 Thread PeteVine
I was about to file a bug with the exact symptoms. I can't boot a (possibly the very one) debian wheezy standard qcow2 image on my Odroid C1 (works fine on x86-32 with the same command line) using qemu-system-i386 that I built yesterday from git source. Is there a workaround or has nobody needed

[Qemu-devel] [PATCH] cpu-exec: Add "nochain" debug flag

2015-09-16 Thread Richard Henderson
Respect it to avoid linking TBs together. Signed-off-by: Richard Henderson --- cpu-exec.c | 3 ++- include/qemu/log.h | 1 + qemu-log.c | 3 +++ 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/cpu-exec.c b/cpu-exec.c index 8945533..b219421 100644 --- a/cpu-exec.c ++

Re: [Qemu-devel] [PULL 00/35] TileGX basic instructions

2015-09-16 Thread Chen Gang
According to RTH implementation, I am sure, his current implementation must have fixed some issues which my original implementation will meet, next. At present, I shall firstly focus on the current status - merge original implementation to current implementation. And after comparing the test, th

Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object

2015-09-16 Thread Eric Blake
On 09/16/2015 06:15 AM, Yang Hongyang wrote: > Add a netfilter object based on QOM. > > A netfilter is attached to a netdev, captures all network packets > that pass through the netdev. When we delete the netdev, we also > delete the netfilter object attached to it, because if the netdev is > remo

Re: [Qemu-devel] [wiki] New wiki page - vhost-user setup with ovs/dpdk backend

2015-09-16 Thread Flavio Leitner
On Thu, Sep 10, 2015 at 10:51:19PM +0300, Marcel Apfelbaum wrote: > Hi, > > The page describes how to setup an environment that allows testing/developing > vhost-user using ovs (with dpdk) as backend. > > A regular pc machine can be used, no need for several hosts, a 'dpdk enabled' > NIC or 1G h

Re: [Qemu-devel] [RFC 00/20] Do away with TB retranslation

2015-09-16 Thread Richard Henderson
On 09/16/2015 01:59 AM, Alex Bennée wrote: > > Richard Henderson writes: > >> On 09/10/2015 11:55 AM, Alex Bennée wrote: >>> I've only had a quick glance so far but I'm fairly familiar with the >>> concept from a previous life. I'll aim to do a full review later once >>> I've gotten through my M

Re: [Qemu-devel] [PATCH v3 00/46] ivshmem improvements (please review)

2015-09-16 Thread Marc-André Lureau
Hi On Wed, Sep 16, 2015 at 6:52 PM, Vladimir Sementsov-Ogievskiy wrote: > Are there any plans of continuing development of ivshmem guest driver, > including it to kernel tree, etc? I have no further plans yet. regards -- Marc-André Lureau

Re: [Qemu-devel] [PATCH v8 25/26] qapi: New QMP command query-qmp-schema for QMP introspection

2015-09-16 Thread Eric Blake
On 09/16/2015 05:06 AM, Markus Armbruster wrote: > qapi/introspect.json defines the introspection schema. It's designed > for QMP introspection, but should do for similar uses, such as QGA. > > > Signed-off-by: Markus Armbruster > --- Produces the same introspection string as v7, and the Make

Re: [Qemu-devel] [PULL 16/24] tcg: Move tci_tb_ptr to -common

2015-09-16 Thread Stefan Weil
Am 16.09.2015 um 21:14 schrieb Peter Crosthwaite: > On Wed, Sep 16, 2015 at 10:50 AM, Stefan Weil wrote: >> Am 16.09.2015 um 14:29 schrieb Paolo Bonzini: >>> From: Peter Crosthwaite >>> >>> This requires global visibility to common code. Move to tcg-common. >>> >>> Cc: Stefan Weil >>> Signed-off

Re: [Qemu-devel] [PULL 16/24] tcg: Move tci_tb_ptr to -common

2015-09-16 Thread Peter Crosthwaite
On Wed, Sep 16, 2015 at 10:50 AM, Stefan Weil wrote: > Am 16.09.2015 um 14:29 schrieb Paolo Bonzini: >> From: Peter Crosthwaite >> >> This requires global visibility to common code. Move to tcg-common. >> >> Cc: Stefan Weil >> Signed-off-by: Peter Crosthwaite >> Message-Id: >> >> Signed-off-b

Re: [Qemu-devel] [PATCH] ui/cocoa.m: remove open dialog code

2015-09-16 Thread Programmingkid
On Sep 14, 2015, at 11:43 AM, Peter Maydell wrote: > On 11 September 2015 at 01:49, Programmingkid > wrote: >> Remove the open dialog code that runs when no arguments are supplied with >> QEMU. >> Not everyone needs a hard drive or cdrom to boot their target. A user might >> only >> need to use

Re: [Qemu-devel] [PATCH 2/2] target-mips: remove gen_mfc0_load64() and use tcg_gen_ld32s_tl()

2015-09-16 Thread Leon Alrae
On 16/09/15 19:14, Richard Henderson wrote: > On 09/14/2015 05:45 AM, Leon Alrae wrote: >> -static inline void gen_mfc0_load64 (TCGv arg, target_ulong off) >> -{ >> -tcg_gen_ld_tl(arg, cpu_env, off); >> -tcg_gen_ext32s_tl(arg, arg); >> -} >> - >> static inline void gen_mtc0_store32 (TCGv a

Re: [Qemu-devel] [PATCH v7 32/42] Page request: Consume pages off the post-copy queue

2015-09-16 Thread Dr. David Alan Gilbert
* Amit Shah (amit.s...@redhat.com) wrote: > On (Tue) 16 Jun 2015 [11:26:45], Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > When transmitting RAM pages, consume pages that have been queued by > > MIG_RPCOMM_REQPAGE commands and send them ahead of normal page scanni

Re: [Qemu-devel] [PATCH v7 32/42] Page request: Consume pages off the post-copy queue

2015-09-16 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > When transmitting RAM pages, consume pages that have been queued by > > MIG_RPCOMM_REQPAGE commands and send them ahead of normal page scanning. > > > > Note: > > a) A

Re: [Qemu-devel] [PATCH v2 0/2] Block: don't do copy-on-read in before_write_notifier

2015-09-16 Thread Jeff Cody
On Tue, Sep 08, 2015 at 11:28:31AM +0800, Wen Congyang wrote: > If we do copy-on-read in before_write_notifier, qemu will be crashed. The > backtrace is: > Program terminated with signal 6, Aborted. > #0 0x7f5d69207b55 in raise () from /lib64/libc.so.6 > (gdb) bt > #0 0x7f5d69207b55 in ra

Re: [Qemu-devel] [PATCH 2/2] target-mips: remove gen_mfc0_load64() and use tcg_gen_ld32s_tl()

2015-09-16 Thread Richard Henderson
On 09/14/2015 05:45 AM, Leon Alrae wrote: > -static inline void gen_mfc0_load64 (TCGv arg, target_ulong off) > -{ > -tcg_gen_ld_tl(arg, cpu_env, off); > -tcg_gen_ext32s_tl(arg, arg); > -} > - > static inline void gen_mtc0_store32 (TCGv arg, target_ulong off) > { > TCGv_i32 t0 = tcg_t

[Qemu-devel] [PATCH 1/2] Move dirty page search state into separate structure

2015-09-16 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Pull the sarch state for one iteration of the dirty page search into a structure. Signed-off-by: Dr. David Alan Gilbert --- migration/ram.c | 54 ++ 1 file changed, 34 insertions(+), 20 deletions(-) diff --git

[Qemu-devel] [PATCH 0/2] Split up ram_find_and_save_block

2015-09-16 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Chop up ram_find_and_save_block so it's smaller again. (from comments on my postcopy patch that adds more to it). This pair is based on top of my previous 5 patch cleanup series posted in August, but rebased on current qemu master. Dave Dr. David Alan Gilbert (2

[Qemu-devel] [PATCH 2/2] ram_find_and_save_block: Split out the finding

2015-09-16 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Split out the finding of the dirty page and all the wrap detection into a separate function since it was getting a bit hairy. Signed-off-by: Dr. David Alan Gilbert --- migration/ram.c | 87 - 1 file changed,

Re: [Qemu-devel] Compiling Qemu from Cygwin

2015-09-16 Thread Mike Ladouceur
Thanks for the reply. I will try to cross-compile via cygwin seeing as I've had no luck installing and configuring mingw64. On Tue, Sep 15, 2015 at 4:44 PM, Eric Blake wrote: > On 09/15/2015 02:10 PM, Stefan Weil wrote: > >> > >> CCqga/commands-win32.o > >>> qga/commands-win32.c: In functi

Re: [Qemu-devel] [PULL 16/24] tcg: Move tci_tb_ptr to -common

2015-09-16 Thread Stefan Weil
Am 16.09.2015 um 14:29 schrieb Paolo Bonzini: > From: Peter Crosthwaite > > This requires global visibility to common code. Move to tcg-common. > > Cc: Stefan Weil > Signed-off-by: Peter Crosthwaite > Message-Id: > > Signed-off-by: Paolo Bonzini > --- > tcg/tcg-common.c | 4 > tci.c

Re: [Qemu-devel] Could not boot a guest vm from kvm mode based on APM X-Gene Host and latest qemu

2015-09-16 Thread Marc Zyngier
On 16/09/15 15:34, Alex Bennée wrote: > > liang yan writes: > >> Hello, All, >> >> I am trying to enable kvm for a guest vm on an APM X-Gene Host with >> latest qemu, but could not make it work. >> >> The host is APM X-Gene 8-core, Linux kernel is 4.1.0-rc7-1-arm64, >> >> Guest kernel is linux-

Re: [Qemu-devel] [PATCH v8 06/26] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions

2015-09-16 Thread Eric Blake
On 09/16/2015 05:06 AM, Markus Armbruster wrote: > Fixes flat unions to get the base's base members. Test case is from > commit 2fc0043, in qapi-schema-test.json: > > > Flat union visitors remain broken. They'll be fixed next. > > Two ugly special cases for simple unions now stand out like so

Re: [Qemu-devel] [PATCH v8 09/26] qapi: De-duplicate enum code generation

2015-09-16 Thread Eric Blake
On 09/16/2015 05:06 AM, Markus Armbruster wrote: > Duplicated in commit 21cd70d. Yes, we can't import qapi-types, but > that's no excuse. Move the helpers from qapi-types.py to qapi.py, and > replace the duplicates in qapi-event.py. > > The generated event enumeration type's lookup table becomes

Re: [Qemu-devel] [PATCH v8 07/26] qapi-visit: Convert to QAPISchemaVisitor, fixing bugs

2015-09-16 Thread Eric Blake
On 09/16/2015 05:06 AM, Markus Armbruster wrote: > Fixes flat unions to visit the base's base members (the previous > commit merely added them to the struct). Same test case. > > Test cases updated for the bug fix. > > Fixes alternates to generate a visitor for their implicit enumeration > type

Re: [Qemu-devel] [PATCH v8 13/26] qapi: Clean up after recent conversions to QAPISchemaVisitor

2015-09-16 Thread Eric Blake
On 09/16/2015 05:06 AM, Markus Armbruster wrote: > Generate just 'FOO' instead of 'struct FOO' when possible. > > Drop helper functions that are now unused. > > Make pep8 and pylint reasonably happy. > > Rename generate_FOO() functions to gen_FOO() for consistency. > > Use more consistent and s

Re: [Qemu-devel] [PULL 0/6] target-i386 exception improvments

2015-09-16 Thread Peter Maydell
On 15 September 2015 at 20:40, Richard Henderson wrote: > Quite a few fixes to icounting and missed updates to cc_op, > all obviated by using the restore state path. > > > r~ > > > The following changes since commit 619622424dba749feef752d76d79ef2569f7f250: > > Merge remote-tracking branch > 'r

[Qemu-devel] MIPS qemu build failure

2015-09-16 Thread Steve Ellcey
Is anyone else seeing this qemu build failure? I am building qemu for MIPS from the top-of-tree sources. make[1]: *** No rule to make target `../qom/object.o', needed by `qemu-mips'. Stop. make: *** [subdir-mips-linux-user] Error 2 Error: Make command failed, stopping build. Steve Ellcey se

Re: [Qemu-devel] [PATCH 3/3] monitor: remove old entries from event hash table

2015-09-16 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Do not let the hash table grow without limit, schedule a cleanup for > outdated event. > > Signed-off-by: Marc-André Lureau > --- > monitor.c | 47 ++- > 1 file changed, 46 insertions(+

Re: [Qemu-devel] [PATCH v3 00/46] ivshmem improvements (please review)

2015-09-16 Thread Vladimir Sementsov-Ogievskiy
Hi Marc-André, I have one question relative to these series: Are there any plans of continuing development of ivshmem guest driver, including it to kernel tree, etc? On 15.09.2015 19:07, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Hi, This series is mostly about adding the

Re: [Qemu-devel] [PATCH 1/2] utils: rename strtosz to use qemu prefix

2015-09-16 Thread Paolo Bonzini
On 16/09/2015 18:02, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Not only it makes sense, but it gets rid of checkpatch warning: > WARNING: consider using qemu_strtosz in preference to strtosz Oops. :) However, we also need something like this: --- 8< ---

Re: [Qemu-devel] iotests failure of 128

2015-09-16 Thread Max Reitz
On 15.09.2015 16:34, Eric Blake wrote: > On 09/15/2015 12:03 AM, Fam Zheng wrote: >> Since commit 934659c460d46c948cf348822fda1d38556ed9a4 (iotests: Do not >> suppress >> segfaults in bash tests), sudo in 128 complains about unknown command >> "_qemu_io_wrapper", but I don't know how to fix that.

Re: [Qemu-devel] [PATCH 2/3] monitor: throttle QAPI_EVENT_VSERPORT_CHANGE by "id"

2015-09-16 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Use a hash table to lookup the pending event corresponding to the "id" > field. The hash table may grow without limit here, the following patch > will add some cleaning. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Eric Bla

Re: [Qemu-devel] [PATCH 1/2] utils: rename strtosz to use qemu prefix

2015-09-16 Thread Eric Blake
On 09/16/2015 10:02 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Not only it makes sense, but it gets rid of checkpatch warning: > WARNING: consider using qemu_strtosz in preference to strtosz Indeed, POSIX reserves the entire str*() namespace for future extension, so avo

Re: [Qemu-devel] [PATCH 1/2] utils: rename strtosz to use qemu prefix

2015-09-16 Thread Marc-André Lureau
- Original Message - > On 09/16/2015 10:02 AM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Not only it makes sense, but it gets rid of checkpatch warning: > > WARNING: consider using qemu_strtosz in preference to strtosz > > Indeed, POSIX reserves the entire

Re: [Qemu-devel] [PATCH v3 34/46] ivshmem-server: fix hugetlbfs support

2015-09-16 Thread Vladimir Sementsov-Ogievskiy
On 15.09.2015 19:07, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau As pointed out on the ML by Andrew Jones, glibc no longer permits creating POSIX shm on hugetlbfs directly. When given a hugetlbfs path, create a shareable file there. Signed-off-by: Marc-André Lureau --- contri

Re: [Qemu-devel] [PATCH v3 34/46] ivshmem-server: fix hugetlbfs support

2015-09-16 Thread Marc-André Lureau
- Original Message - > On 15.09.2015 19:07, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > As pointed out on the ML by Andrew Jones, glibc no longer permits > > creating POSIX shm on hugetlbfs directly. When given a hugetlbfs path, > > create a shareable file ther

Re: [Qemu-devel] [PATCH 2/2] tests: add some qemu_strtosz() tests

2015-09-16 Thread Eric Blake
On 09/16/2015 10:02 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > While reading the function I decided to write some tests. > > Signed-off-by: Marc-André Lureau > --- > tests/test-cutils.c | 91 > + > 1 file changed, 9

[Qemu-devel] [PATCH 2/2] tests: add some qemu_strtosz() tests

2015-09-16 Thread marcandre . lureau
From: Marc-André Lureau While reading the function I decided to write some tests. Signed-off-by: Marc-André Lureau --- tests/test-cutils.c | 91 + 1 file changed, 91 insertions(+) diff --git a/tests/test-cutils.c b/tests/test-cutils.c index

[Qemu-devel] [PATCH 1/2] utils: rename strtosz to use qemu prefix

2015-09-16 Thread marcandre . lureau
From: Marc-André Lureau Not only it makes sense, but it gets rid of checkpatch warning: WARNING: consider using qemu_strtosz in preference to strtosz Also remove get rid of tabs to please checkpatch. Signed-off-by: Marc-André Lureau --- include/qemu-common.h | 27 ++-

Re: [Qemu-devel] [PATCH] virtio-net: unbreak self announcement and guest offloads after migration

2015-09-16 Thread Greg Kurz
On Fri, 11 Sep 2015 10:30:21 +0200 Cornelia Huck wrote: > On Fri, 11 Sep 2015 16:01:56 +0800 > Jason Wang wrote: > > > After commit 019a3edbb25f1571e876f8af1ce4c55412939e5d ("virtio: make > > features 64bit wide"). Device's guest_features was actually set after > > vdc->load(). This breaks the

Re: [Qemu-devel] [PATCH] virtio-net: unbreak self announcement and guest offloads after migration

2015-09-16 Thread Greg Kurz
On Fri, 11 Sep 2015 16:01:56 +0800 Jason Wang wrote: > After commit 019a3edbb25f1571e876f8af1ce4c55412939e5d ("virtio: make > features 64bit wide"). Device's guest_features was actually set after > vdc->load(). This breaks the assumption that device specific load() Yeah... subsections are loaded

[Qemu-devel] [PULL v2 00/24] Misc patches for 2015-09-16

2015-09-16 Thread Paolo Bonzini
The following changes since commit 007e620a7576e4ce2ea6955541e87d8ae8ed32ae: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2015-09-14 18:51:09 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch

Re: [Qemu-devel] [PATCH 0/4] ahci: clean up signature generation

2015-09-16 Thread John Snow
On 09/01/2015 04:50 PM, John Snow wrote: > Ultimately, clean up the signature generation and as a result, tidy up > the port_reset and init_d2h functions. > > > > For convenience, this branch is available at: > htt

Re: [Qemu-devel] [PATCH v3 1/1] atapi: abort transfers with 0 byte limits

2015-09-16 Thread John Snow
On 09/16/2015 11:09 AM, Markus Armbruster wrote: > John Snow writes: > >> On 09/15/2015 04:06 AM, Markus Armbruster wrote: >>> John Snow writes: >>> We're supposed to abort on transfers like this, unless we fill Word 125 of our IDENTIFY data with a default transfer size, which w

Re: [Qemu-devel] [PULL 00/24] Misc patches for 2015-09-16

2015-09-16 Thread Paolo Bonzini
On 16/09/2015 17:08, Peter Maydell wrote: > On 16 September 2015 at 13:29, Paolo Bonzini wrote: >> The following changes since commit 007e620a7576e4ce2ea6955541e87d8ae8ed32ae: >> >> Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into >> staging (2015-09-14 18:51:09 +0100) >> >

[Qemu-devel] [PATCH] trace: remove malloc tracing

2015-09-16 Thread Paolo Bonzini
The malloc vtable is not supported anymore in glib, because it broke when constructors called g_malloc. Remove tracing of g_malloc, g_realloc and g_free calls. Note that, for systemtap users, glib also provides tracepoints glib.mem_alloc, glib.mem_free, glib.mem_realloc, glib.slice_alloc and glib

Re: [Qemu-devel] [PULL 11/35] target-tilegx: Framework for decoding bundles

2015-09-16 Thread Chen Gang
On 9/15/15 23:03, Richard Henderson wrote: [...] > +/* > + * QEMU TILE-Gx CPU > + * > + * Copyright (c) 2015 Chen Gang > + * Since you rewrite this file, I guess, the copyright name need be also improved. > + * This library is free software; you can redistribute it and/or > + * modify it unde

Re: [Qemu-devel] Could not boot a guest vm from kvm mode based on APM X-Gene Host and latest qemu

2015-09-16 Thread Marc Zyngier
On 16/09/15 15:34, Alex Bennée wrote: > > liang yan writes: > >> Hello, All, >> >> I am trying to enable kvm for a guest vm on an APM X-Gene Host with >> latest qemu, but could not make it work. >> >> The host is APM X-Gene 8-core, Linux kernel is 4.1.0-rc7-1-arm64, >> >> Guest kernel is linux-

[Qemu-devel] [PATCH] scsi-generic: let guests recognize readonly=on on passthrough devices

2015-09-16 Thread Paolo Bonzini
Passed-through SCSI devices can be opened with the readonly=on option. When this happens, Linux filters away write commands so that the guest cannot overwrite the contents of the device. However, the guest does not know that the device is read-only, and accepts writes. The writes only fail later

Re: [Qemu-devel] [PATCH v8 05/26] tests/qapi-schema: Convert test harness to QAPISchemaVisitor

2015-09-16 Thread Eric Blake
On 09/16/2015 05:06 AM, Markus Armbruster wrote: > The old code prints the result of parsing (list of expression > dictionaries), and partial results of semantic analysis (list of enum > dictionaries, list of struct dictionaries). > > The new code prints a trace of a schema visit, i.e. what the ba

Re: [Qemu-devel] [PULL 35/35] target-tilegx: Handle v1shl, v1shru, v1shrs

2015-09-16 Thread Chen Gang
On 9/15/15 23:04, Richard Henderson wrote: [...] > +/* > + * QEMU TILE-Gx helpers > + * > + * Copyright (c) 2015 Chen Gang This file is totally implemented by you, so I guess, the Copyright name need be changed, too. :-) > + * > + * This library is free software; you can redistribute it and/o

Re: [Qemu-devel] [PATCH v3 42/46] ivshmem: make ivshmem_get_size() more generic

2015-09-16 Thread Marc-André Lureau
Hi - Original Message - > Hi! > > On 15.09.2015 19:07, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Use a more explicit function name parse_mem_size(). I guess such > > function could be common (or exists already somewhere). > > strtosz() from include/qemu-comm

Re: [Qemu-devel] [PATCH v3 1/1] atapi: abort transfers with 0 byte limits

2015-09-16 Thread Markus Armbruster
John Snow writes: > On 09/15/2015 04:06 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> We're supposed to abort on transfers like this, unless we fill >>> Word 125 of our IDENTIFY data with a default transfer size, which >>> we don't currently do. >>> >>> This is an ATA error, not a SC

Re: [Qemu-devel] [PATCH v3 42/46] ivshmem: make ivshmem_get_size() more generic

2015-09-16 Thread Vladimir Sementsov-Ogievskiy
Hi! On 15.09.2015 19:07, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Use a more explicit function name parse_mem_size(). I guess such function could be common (or exists already somewhere). strtosz() from include/qemu-common.h is appropriate Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH v3 1/1] atapi: abort transfers with 0 byte limits

2015-09-16 Thread John Snow
On 09/16/2015 11:09 AM, Markus Armbruster wrote: > John Snow writes: > >> On 09/15/2015 04:06 AM, Markus Armbruster wrote: >>> John Snow writes: >>> We're supposed to abort on transfers like this, unless we fill Word 125 of our IDENTIFY data with a default transfer size, which w

Re: [Qemu-devel] [PATCH v3 42/46] ivshmem: make ivshmem_get_size() more generic

2015-09-16 Thread Vladimir Sementsov-Ogievskiy
Hi! On 15.09.2015 19:07, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Use a more explicit function name parse_mem_size(). I guess such function could be common (or exists already somewhere). include/qemu-common.h : strtosz() may be used here Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH v8 04/26] qapi: New QAPISchemaVisitor

2015-09-16 Thread Eric Blake
On 09/16/2015 05:06 AM, Markus Armbruster wrote: > The visitor will help keeping the code generation code simple and > reasonably separated from QAPISchema details. > > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 64 > + > 1

Re: [Qemu-devel] [PATCH v8 02/26] qapi: New QAPISchema intermediate reperesentation

2015-09-16 Thread Eric Blake
On 09/16/2015 05:06 AM, Markus Armbruster wrote: > The QAPI code generators work with a syntax tree (nested dictionaries) > plus a few symbol tables (also dictionaries) on the side. > Nothing uses the new intermediate representation just yet, thus no > change to generated files. > > Signed-off-by

Re: [Qemu-devel] [PATCH v8 13/26] qapi: Clean up after recent conversions to QAPISchemaVisitor

2015-09-16 Thread Daniel P. Berrange
On Wed, Sep 16, 2015 at 01:06:16PM +0200, Markus Armbruster wrote: > Generate just 'FOO' instead of 'struct FOO' when possible. > > Drop helper functions that are now unused. > > Make pep8 and pylint reasonably happy. > > Rename generate_FOO() functions to gen_FOO() for consistency. > > Use mor

Re: [Qemu-devel] [PULL 00/24] Misc patches for 2015-09-16

2015-09-16 Thread Peter Maydell
On 16 September 2015 at 13:29, Paolo Bonzini wrote: > The following changes since commit 007e620a7576e4ce2ea6955541e87d8ae8ed32ae: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2015-09-14 18:51:09 +0100) > > are available in the git repository at: > > git:

Re: [Qemu-devel] [PATCH v8 03/26] qapi: QAPISchema code generation helper methods

2015-09-16 Thread Eric Blake
On 09/16/2015 05:06 AM, Markus Armbruster wrote: > New methods c_name(), c_type(), c_null(), json_type(), > alternate_qtype(). > > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 94 > - > 1 file changed, 87 insertions(+), 7 del

Re: [Qemu-devel] [PULL 00/35] TileGX basic instructions

2015-09-16 Thread Chen Gang
OK, thanks. I got them in qemu master tree, and they have passed several simple tests. Next, I shall send several patches based on it (except floating point insns) for my current steps. Then continue to test gcc testsuite, hope we can finish it within this month. Thanks. On 9/15/15 23:03, Ric

Re: [Qemu-devel] [PATCH v8 00/26] qapi: QMP introspection

2015-09-16 Thread Daniel P. Berrange
On Wed, Sep 16, 2015 at 01:06:03PM +0200, Markus Armbruster wrote: > Series needs my "[PATCH for-2.4 0/2] qom: Fix misuse of Error API" to > pass tests. It's in Andreas's qom-next (currently at commit de1da05), > so I based on that. > > You can fetch it from my git://repo.or.cz/qemu/armbru.git br

Re: [Qemu-devel] [PATCH] hw/ide/ahci: advance IO buffer offset in multi-sector PIO transfer

2015-09-16 Thread Laszlo Ersek
On 09/16/15 16:11, John Snow wrote: > > > On 09/15/2015 10:17 PM, Laszlo Ersek wrote: >> The "MdeModulePkg/Bus/Ata/AtaAtapiPassThru" driver in edk2 submits a three >> sector long PIO read, when booting off various Fedora installer ISOs in >> UEFI mode. With DEBUG_IDE, DEBUG_IDE_ATAPI, DEBUG_AIO a

Re: [Qemu-devel] [PATCH v8 11/26] qapi-event: Convert to QAPISchemaVisitor, fixing data with base

2015-09-16 Thread Daniel P. Berrange
On Wed, Sep 16, 2015 at 01:06:14PM +0200, Markus Armbruster wrote: > Fixes events whose data is struct with base to include the struct's > base members. Test case is qapi-schema-test.json's event > __org.qemu_x-command: > > { 'event': '__ORG.QEMU_X-EVENT', 'data': '__org.qemu_x-Struct' } > >

Re: [Qemu-devel] [PATCH v8 07/26] qapi-visit: Convert to QAPISchemaVisitor, fixing bugs

2015-09-16 Thread Daniel P. Berrange
On Wed, Sep 16, 2015 at 01:06:10PM +0200, Markus Armbruster wrote: > Fixes flat unions to visit the base's base members (the previous > commit merely added them to the struct). Same test case. > > Patch's effect on visit_type_UserDefFlatUnion(): > > static void visit_type_UserDefFlatUnion_f

Re: [Qemu-devel] [PATCH 4/8] target-i386: Re-introduce optimal breakpoint removal

2015-09-16 Thread Paolo Bonzini
On 16/09/2015 16:57, Richard Henderson wrote: >>> >> +/* Fold the global and local enable bits together into the >>> >> + global fields, then xor to show which registers have >>> >> + changed collective enable state. */ >>> >> +int mod = ((old_dr7 | old_dr7 *

Re: [Qemu-devel] [PATCH v8 09/26] qapi: De-duplicate enum code generation

2015-09-16 Thread Daniel P. Berrange
On Wed, Sep 16, 2015 at 01:06:12PM +0200, Markus Armbruster wrote: > Duplicated in commit 21cd70d. Yes, we can't import qapi-types, but > that's no excuse. Move the helpers from qapi-types.py to qapi.py, and > replace the duplicates in qapi-event.py. > > The generated event enumeration type's lo

Re: [Qemu-devel] [PATCH v8 08/26] qapi-commands: Convert to QAPISchemaVisitor

2015-09-16 Thread Daniel P. Berrange
On Wed, Sep 16, 2015 at 01:06:11PM +0200, Markus Armbruster wrote: > Output unchanged apart from reordering and white-space. > > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake > --- > scripts/qapi-commands.py | 159 > +++ > scripts/qapi.p

Re: [Qemu-devel] [PATCH v8 03/26] qapi: QAPISchema code generation helper methods

2015-09-16 Thread Daniel P. Berrange
On Wed, Sep 16, 2015 at 01:06:06PM +0200, Markus Armbruster wrote: > New methods c_name(), c_type(), c_null(), json_type(), > alternate_qtype(). > > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 94 > - > 1 file changed, 87 in

Re: [Qemu-devel] [PATCH 4/8] target-i386: Re-introduce optimal breakpoint removal

2015-09-16 Thread Richard Henderson
On 09/16/2015 01:57 AM, Paolo Bonzini wrote: > > > On 15/09/2015 20:45, Richard Henderson wrote: >> +/* Fold the global and local enable bits together into the >> + global fields, then xor to show which registers have >> + changed collective enable state. */ >> +

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-16 Thread Eric Blake
On 09/16/2015 01:11 AM, Wen Congyang wrote: Possible workaround in the meantime - instead of trying to go with a nice flat union (where all QMP keys are in the same {} level), we can use nesting (structs that add another {} to include the unions). >>> >>> How to include the unions t

Re: [Qemu-devel] [Qemu-block] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-16 Thread Eric Blake
On 09/16/2015 05:18 AM, Markus Armbruster wrote: >>> Perhaps it could be as simple as >>> >>> { 'struct': 'BlockdevOptionsNBD', >>> 'data': { 'addr: 'SocketAddress', 'export': 'str' } } >> >> The problem is that: NBD doesn't use the fd. > > Is that fundame

Re: [Qemu-devel] [PULL 00/35] TileGX basic instructions

2015-09-16 Thread Peter Maydell
On 15 September 2015 at 16:03, Richard Henderson wrote: > With typos fixed from final review. > > > r~ > > > The following changes since commit b76a0d5db25ad9f81346930230092fdf1e88a5a1: > > Merge remote-tracking branch 'remotes/stefanha/tags/net-pull-request' into > staging (2015-09-15 13:03:53

Re: [Qemu-devel] [PATCH v8 06/26] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions

2015-09-16 Thread Daniel P. Berrange
On Wed, Sep 16, 2015 at 01:06:09PM +0200, Markus Armbruster wrote: > Fixes flat unions to get the base's base members. Test case is from > commit 2fc0043, in qapi-schema-test.json: > > { 'union': 'UserDefFlatUnion', > 'base': 'UserDefUnionBase', > 'discriminator': 'enum1', >

Re: [Qemu-devel] [PATCH v8 02/26] qapi: New QAPISchema intermediate reperesentation

2015-09-16 Thread Daniel P. Berrange
On Wed, Sep 16, 2015 at 01:06:05PM +0200, Markus Armbruster wrote: > The QAPI code generators work with a syntax tree (nested dictionaries) > plus a few symbol tables (also dictionaries) on the side. > > They have clearly outgrown these simple data structures. There's lots > of rummaging around i

Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support

2015-09-16 Thread Yuanhan Liu
On Wed, Sep 16, 2015 at 08:15:59AM -0600, Eric Blake wrote: > On 09/15/2015 08:06 PM, Yuanhan Liu wrote: > > >> Up to here is mostly fine for the commit message. Meanwhile... > >> > >>> v9: per suggested by Jason Wang, we could invoke qemu_chr_add_handlers() > >>> once only, and invoke qemu_f

Re: [Qemu-devel] [PATCH v8 05/26] tests/qapi-schema: Convert test harness to QAPISchemaVisitor

2015-09-16 Thread Daniel P. Berrange
On Wed, Sep 16, 2015 at 01:06:08PM +0200, Markus Armbruster wrote: > The old code prints the result of parsing (list of expression > dictionaries), and partial results of semantic analysis (list of enum > dictionaries, list of struct dictionaries). > > The new code prints a trace of a schema visit

Re: [Qemu-devel] [PATCH v3 00/16] vhost-user: add migration log support (for 2.5)

2015-09-16 Thread Michael S. Tsirkin
On Thu, Aug 06, 2015 at 02:40:36PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Hi, > > The following series implement shareable log for vhost-user to support > memory tracking during live migration. On qemu-side, the solution is > fairly straightfoward since vhost alr

Re: [Qemu-devel] [PATCH v8 04/26] qapi: New QAPISchemaVisitor

2015-09-16 Thread Daniel P. Berrange
On Wed, Sep 16, 2015 at 01:06:07PM +0200, Markus Armbruster wrote: > The visitor will help keeping the code generation code simple and > reasonably separated from QAPISchema details. > > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 64 >

Re: [Qemu-devel] Could not boot a guest vm from kvm mode based on APM X-Gene Host and latest qemu

2015-09-16 Thread Alex Bennée
liang yan writes: > Hello, All, > > I am trying to enable kvm for a guest vm on an APM X-Gene Host with > latest qemu, but could not make it work. > > The host is APM X-Gene 8-core, Linux kernel is 4.1.0-rc7-1-arm64, > > Guest kernel is linux-3.16rc3 > > QEMU is latest version > > Host has thes

Re: [Qemu-devel] [PULL 00/24] Misc patches for 2015-09-16

2015-09-16 Thread Eric Blake
On 09/16/2015 06:29 AM, Paolo Bonzini wrote: > The following changes since commit 007e620a7576e4ce2ea6955541e87d8ae8ed32ae: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2015-09-14 18:51:09 +0100) > > are available in the git repository at: > > git://git

Re: [Qemu-devel] [PATCH v1 2/2] qemu-nbd: convert to use the QAPI SocketAddress object

2015-09-16 Thread Eric Blake
On 09/16/2015 08:13 AM, Daniel P. Berrange wrote: > On Wed, Sep 16, 2015 at 08:08:35AM -0600, Eric Blake wrote: >> On 09/16/2015 07:52 AM, Daniel P. Berrange wrote: >>> The qemu-nbd program currently uses a QemuOpts objects >>> when setting up sockets. Switch it over to use the >>> QAPI SocketAddre

Re: [Qemu-devel] [PATCH v1 2/2] qemu-nbd: convert to use the QAPI SocketAddress object

2015-09-16 Thread Paolo Bonzini
On 16/09/2015 16:13, Daniel P. Berrange wrote: > > The qapi type is gross for requiring port as a string. But we have plans > > to clean that up, not a showstopper for this patch. > > On the contrary - QAPI is correct in requiring this, as it lets you > provide a service name (as defined in /etc/

  1   2   3   >