On 09/01/2015 04:50 PM, John Snow wrote: > Ultimately, clean up the signature generation and as a result, tidy up > the port_reset and init_d2h functions. > > ________________________________________________________________________________ > > For convenience, this branch is available at: > https://github.com/jnsnow/qemu.git branch ahci-sigfix > https://github.com/jnsnow/qemu/tree/ahci-sigfix > > This version is tagged ahci-sigfix-v1: > https://github.com/jnsnow/qemu/releases/tag/ahci-sigfix-v1 > > John Snow (4): > ahci: remove dead reset code > ahci: fix signature generation > ahci: remove cmd_fis argument from write_fis_d2h > ahci: clean up initial d2h semantics > > hw/ide/ahci.c | 53 ++++++++++++++++++++++++++++++----------------------- > 1 file changed, 30 insertions(+), 23 deletions(-) >
Ping -- Stefan, you had some comments on the predecessor to this patch for 2.4, does this look saner to you?