Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/2] util - add automated ID generation utility

2015-09-01 Thread Alberto Garcia
On Wed 02 Sep 2015 12:30:15 AM CEST, Jeff Cody wrote: > Multiple sub-systems in QEMU may find it useful to generate IDs > for objects that a user may reference via QMP or HMP. This patch > presents a standardized way to do it, so that automatic ID generation > follows the same rules. > + > +typ

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 0/4] target-ppc: Add FWNMI support in qemu for powerKVM guests

2015-09-01 Thread Sam Bobroff
On Tue, Sep 01, 2015 at 04:37:51PM +0530, Aravinda Prasad wrote: > > > On Monday 10 August 2015 09:35 AM, Sam Bobroff wrote: > > On Sun, Aug 09, 2015 at 03:53:02PM +0200, Alexander Graf wrote: > >> > >> > >> On 07.08.15 05:37, Sam Bobroff wrote: > >>> Hello Aravinda and all, > >>> > >>> On Wed, J

Re: [Qemu-devel] [PATCH] target-arm: Fix arm_el_is_aa64() function to support EL2 and EL3

2015-09-01 Thread Sergey Sorokin
01.09.2015, 19:26, "Peter Maydell" : > On 17 July 2015 at 17:01, Sergey Sorokin wrote: >>  Function arm_el_is_aa64() was fixed to support EL2 and EL3. >>  It is needed for a future support of EL2 and/or EL3, >>  and 32 bit EL1 support for ARMv8 cpu. >>  ARM_FEATURE_AARCH64 flag means that the hig

[Qemu-devel] [PATCH 19/20] tcg: Remove gen_intermediate_code_pc

2015-09-01 Thread Richard Henderson
It's no longer used, so tidy up everything reached by it. This includes the gen_opc_* arrays, the search_pc parameter and the inline gen_intermediate_code_internal functions. Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 1 - target-alpha/translate.c | 41 ---

[Qemu-devel] [PATCH 18/20] tcg: Save insn data and use it in cpu_restore_state_from_tb

2015-09-01 Thread Richard Henderson
We can now restore state without retranslation. Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 1 + tcg/tcg.c | 11 - tcg/tcg.h | 3 +- translate-all.c | 129 +--- 4 files changed, 100 insert

[Qemu-devel] [PATCH 14/20] tcg: Merge cpu_gen_code into tb_gen_code

2015-09-01 Thread Richard Henderson
As it's only caller, this tidies things a bit. Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 2 - translate-all.c | 126 ++-- 2 files changed, 58 insertions(+), 70 deletions(-) diff --git a/include/exec/exec-all.h b/include/

[Qemu-devel] [PATCH 20/20] tcg: Remove tcg_gen_code_search_pc

2015-09-01 Thread Richard Henderson
It's no longer used, so tidy up everything reached by it. Signed-off-by: Richard Henderson --- tcg/tcg.c | 59 +++ tcg/tcg.h | 2 -- 2 files changed, 19 insertions(+), 42 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 3541d4c..98aa

[Qemu-devel] [PATCH 12/20] target-sparc: Remove gen_opc_jump_pc

2015-09-01 Thread Richard Henderson
Since jump_pc[1] is always npc + 4, and since we only continue translation when pc + 4 == npc, we can infer that jump_pc[1] == pc + 8. Because of that, we can encode the branch destination into a single word, and store that in npc. Signed-off-by: Richard Henderson --- target-sparc/translate.c |

[Qemu-devel] [PATCH 13/20] target-sparc: Add npc state to insn_start

2015-09-01 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sparc/cpu.h | 1 + target-sparc/translate.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/target-sparc/cpu.h b/target-sparc/cpu.h index 0522b65..40b6625 100644 --- a/target-sparc/cpu.h +++ b/target-sparc/cpu.h @@ -236,6 +23

[Qemu-devel] [PATCH 17/20] tcg: Pass data argument to restore_state_to_opc

2015-09-01 Thread Richard Henderson
The gen_opc_* arrays are already redundant with the data stored in the insn_start arguments. Transition restore_state_to_opc to use data from the later. Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 2 +- target-alpha/translate.c | 5 +++-- target-arm/translate.c

[Qemu-devel] [PATCH 09/20] target-cris: Mirror gen_opc_pc into insn_start

2015-09-01 Thread Richard Henderson
This perhaps isn't ideal in terms of (ab)using the "pc" field to encode both pc and ppc + delay branch state, as one has to be aware of this when examining opcode dumps. But it preserves existing logic, which will be good for bisection, and it certainly does save storage space. Signed-off-by: Ric

[Qemu-devel] [PATCH 10/20] target-sparc: Tidy gen_branch_a interface

2015-09-01 Thread Richard Henderson
We always pass pc2 == dc->npc and r_cond == cpu_cond, and always set is_br afterward. Infer all of that. Signed-off-by: Richard Henderson --- target-sparc/translate.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/target-sparc/translate.c b/target-sp

[Qemu-devel] [PATCH 08/20] target-sh4: Add flags state to insn_start

2015-09-01 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-sh4/cpu.h | 1 + target-sh4/translate.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/target-sh4/cpu.h b/target-sh4/cpu.h index 34bb3d7..4fc7b1d 100644 --- a/target-sh4/cpu.h +++ b/target-sh4/cpu.h @@ -122,6 +122,7 @@ typed

[Qemu-devel] [PATCH 06/20] target-mips: Add delayed branch state to insn_start

2015-09-01 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-mips/cpu.h | 1 + target-mips/translate.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/target-mips/cpu.h b/target-mips/cpu.h index c91883d..0a53568 100644 --- a/target-mips/cpu.h +++ b/target-mips/cpu.h @@ -132,6 +132,7 @

[Qemu-devel] [PATCH 11/20] target-sparc: Split out gen_branch_n

2015-09-01 Thread Richard Henderson
Unify three copies of this code from different branch types. Fix the case when npc == DYNAMIC_PC, i.e. a branch within a delay slot. Signed-off-by: Richard Henderson --- target-sparc/translate.c | 55 1 file changed, 28 insertions(+), 27 deletion

[Qemu-devel] [PATCH 16/20] tcg: Add TCG_MAX_INSNS

2015-09-01 Thread Richard Henderson
Adjust all translators to respect it. Signed-off-by: Richard Henderson --- target-alpha/translate.c | 3 +++ target-arm/translate-a64.c| 3 +++ target-arm/translate.c| 6 +- target-cris/translate.c | 3 +++ target-i386/translate.c | 6 +- target-lm32/tra

[Qemu-devel] [PATCH 02/20] target-*: Unconditionally emit tcg_gen_insn_start

2015-09-01 Thread Richard Henderson
While we're at it, emit the opcode adjacent to where we currently record data for search_pc. This puts gen_io_start et al on the "correct" side of the marker. Signed-off-by: Richard Henderson --- target-alpha/translate.c | 6 ++ target-arm/translate-a64.c| 5 + target-arm/tra

[Qemu-devel] [PATCH 07/20] target-s390x: Add cc_op state to insn_start

2015-09-01 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-s390x/cpu.h | 1 + target-s390x/translate.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/target-s390x/cpu.h b/target-s390x/cpu.h index 63aebf4..6515351 100644 --- a/target-s390x/cpu.h +++ b/target-s390x/cpu.h @@ -43,6 +43,

[Qemu-devel] [PATCH 04/20] target-arm: Add condexec state to insn_start

2015-09-01 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-arm/cpu.h | 1 + target-arm/translate-a64.c | 2 +- target-arm/translate.c | 3 ++- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 31825d3..8d5ae3e 100644 --- a/target-arm/cpu.h +++

[Qemu-devel] [PATCH 15/20] target-*: Drop cpu_gen_code define

2015-09-01 Thread Richard Henderson
This symbol no longer exists. Signed-off-by: Richard Henderson --- target-alpha/cpu.h | 1 - target-arm/cpu.h| 1 - target-cris/cpu.h | 1 - target-i386/cpu.h | 1 - target-lm32/cpu.h | 1 - target-m68k/cpu.h | 1 - target-microblaze/cpu.h | 1 - target-mips/

[Qemu-devel] [PATCH 05/20] target-i386: Add cc_op state to insn_start

2015-09-01 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-i386/cpu.h | 1 + target-i386/translate.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index 74b674d..f0e381c 100644 --- a/target-i386/cpu.h +++ b/target-i386/cpu.h @@ -793,6 +793,7 @@

[Qemu-devel] [PATCH 03/20] tcg: Allow extra data to be attached to insn_start

2015-09-01 Thread Richard Henderson
With an eye toward having this data replace the gen_opc_* arrays that each target collects in order to enable restore_state_from_tb. Signed-off-by: Richard Henderson --- tcg/tcg-op.h | 52 tcg/tcg-opc.h | 4 ++-- tcg/tcg.c | 14 -

[Qemu-devel] [RFC 00/20] Do away with TB retranslation

2015-09-01 Thread Richard Henderson
I've been looking at this problem off and on for the last week or so, prompted by the sparc performance work. Although I havn't been able to get a proper sparc64 guest install working, I see the exact same problem with a mips guest. On alpha or x86, which seem to perform well, perf numbers for th

Re: [Qemu-devel] [PATCH v6 1/2] vhost-user: add multi queue support

2015-09-01 Thread Ouyang, Changchun
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Tuesday, September 1, 2015 10:10 PM > To: Yuanhan Liu > Cc: snabb-de...@googlegroups.com; thibaut.col...@6wind.com; qemu- > de...@nongnu.org; n.nikol...@virtualopensystems.com; l...@snabb.co; > Long, Thomas;

Re: [Qemu-devel] [PATCH 0/2] Optimization with AVX2 instruction

2015-09-01 Thread Amit Shah
On (Fri) 28 Aug 2015 [16:54:11], Liang Li wrote: > The buffer_find_nonzero_offset() will be called to check the zero page > during live migration, it's a hot function. buffer_find_nonzero_offset() > has already been optimized with SSE2 instructions, for platform that > supports AVX2, we can optimiz

Re: [Qemu-devel] [PATCH v2 2/2] ppc/spapr_hcall: Implement H_RANDOM hypercall in QEMU

2015-09-01 Thread Amit Shah
On (Mon) 31 Aug 2015 [20:46:02], Thomas Huth wrote: > The PAPR interface provides a hypercall to pass high-quality > hardware generated random numbers to guests. So let's provide > this call in QEMU, too, so that guests that do not support > virtio-rnd yet can get good random numbers, too. virtio-

Re: [Qemu-devel] Adding secondary ARM processor

2015-09-01 Thread Marcin Krzemiński
Thanks Peter, Now I am know where I need to start digging and reading so it really helped! Regards, Marcin 2015-09-01 22:12 GMT+02:00 Peter Crosthwaite : > On Tue, Sep 1, 2015 at 11:27 AM, mar.krzeminski > wrote: > > W dniu 01.09.2015 o 19:45, Peter Crosthwaite pisze: > >> > >> On Tue, Sep 1,

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-09-01 Thread Dennis Luehring
i will try that - thx Am 27.08.2015 um 17:29 schrieb Artyom Tarasenko: On Tue, Jul 28, 2015 at 9:52 AM, Dennis Luehring wrote: > (i've posted the question already on qemu-disc...@nongnu.org but was toled > to better use this mailing list) > > i've prepared an Debian 7.8.0 image for SPARC64/qemu

Re: [Qemu-devel] [RFC PATCH v0] spapr: Disable memory hotplug when HTAB size is insufficient

2015-09-01 Thread Bharata B Rao
On Mon, Aug 24, 2015 at 09:01:51AM +0530, Bharata B Rao wrote: > The hash table size allocated to guest depends on the maxmem size. > If the host isn't able to allocate the required hash table size but > instead allocates less than the optimal requested size, then it will > not be possible to grow

[Qemu-devel] [PATCH V2 7/8] virtio-pci: introduce pio notification capability for modern device

2015-09-01 Thread Jason Wang
We used to use mmio for notification. This could be slow on some arch (e.g on x86 without EPT). So this patch introduces pio bar and a pio notification cap for modern device. This ability is enabled through property "modern-pio-notify" for virtio pci devices and was disabled by default. Management

[Qemu-devel] [PATCH V2 8/8] virtio-pci: unbreak queue_enable read

2015-09-01 Thread Jason Wang
Guest always get zero when reading queue_enable. This violates spec. Fixing this by setting the queue_enable to true during any guest writing and setting it to zero during reset. Cc: Michael S. Tsirkin Signed-off-by: Jason Wang --- hw/virtio/virtio-pci.c | 7 +++ 1 file changed, 7 insertion

[Qemu-devel] [PATCH V2 5/8] memory: don't try to adjust endianness for zero length eventfd

2015-09-01 Thread Jason Wang
There's no need to adjust endianness for zero length eventfd since the data wrote was actually ignored by kernel. So skip the adjust in this case to fix a possible crash when trying to use wildcard mmio eventfd in ppc. Cc: Greg Kurz Cc: Peter Maydell Cc: Paolo Bonzini Signed-off-by: Jason Wang

[Qemu-devel] [PATCH V2 6/8] virtio-pci: use wildcard mmio eventfd for 1.0 notification cap

2015-09-01 Thread Jason Wang
We use data match eventfd for 1.0 notification currently. This could be slow since software decoding is needed for mmio exit. To speed this up, we can switch to use wild card mmio eventfd for 1.0 notification since we can examine the queue index directly from the writing address. KVM kernel module

[Qemu-devel] [PATCH V2 3/8] pc: Introduce pc-*-2.5 machine classes

2015-09-01 Thread Jason Wang
From: Eduardo Habkost Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c| 14 +- hw/i386/pc_q35.c | 12 +++- include/hw/compat.h | 3 +++ include/hw/i386/pc.h | 4 4 files changed, 31 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/p

[Qemu-devel] [PATCH V2 4/8] virtio-pci: fix 1.0 virtqueue migration

2015-09-01 Thread Jason Wang
We don't migrate the followings fields for virtio-pci: uint32_t dfselect; uint32_t gfselect; uint32_t guest_features[2]; struct { uint16_t num; bool enabled; uint32_t desc[2]; uint32_t avail[2]; uint32_t used[2]; } vqs[VIRTIO_QUEUE_MAX]; This will confuse driver if migrating d

[Qemu-devel] [PATCH V2 1/8] q35: Move options common to all classes to pc_q35_machine_options()

2015-09-01 Thread Jason Wang
From: Eduardo Habkost The existing default_machine_opts, default_display, no_floppy, and no_tco settings will still apply to future machine classes. So it makes sense to move them to pc_q35_machine_options() instead of keeping them in a version-specific machine_options function. Signed-off-by: E

[Qemu-devel] [PATCH V2 0/8] virtio 1.0 pci optimizations and fixes

2015-09-01 Thread Jason Wang
Hi all: This series tries to fix the following issues: - qemu abort when trying to adjust endianness for zero length eventfd, this prevent fast mmio eventfd from being used in ppc. Fixing by skip the endianness adjustment for zero length eventfd. - 1.0 mmio is slow since it was using datamatc

[Qemu-devel] [PATCH V2 2/8] q35: Move options common to all classes to pc_i440fx_machine_options()

2015-09-01 Thread Jason Wang
From: Eduardo Habkost The existing default_machine_opts and default_display settings will still apply to future machine classes. So it makes sense to move them to pc_i440fx_machine_options() instead of keeping them in a version-specific machine_options function. Signed-off-by: Eduardo Habkost -

Re: [Qemu-devel] [PATCH] linux-user: fix cmsg conversion in case of multiple headers

2015-09-01 Thread Jonathan Neuschäfer
On Tue, Sep 01, 2015 at 04:45:12PM +0100, Peter Maydell wrote: > Code-wise this looks good; thanks. There are a few minor style > nits caught by scripts/checkpatch.pl, which it would be nice if > you can fix. (They're mostly things that were present in the code > already, but we like to fix the sty

Re: [Qemu-devel] [PATCH v4 2/2] rtl8139: Do not consume the packet during overflow in standard mode.

2015-09-01 Thread Jason Wang
On 09/01/2015 11:26 PM, Vladislav Yasevich wrote: > When operation in standard mode, we currently return the size > of packet during buffer overflow. This consumes the overflow > packet. Return 0 instead so we can re-process the overflow packet > when we have room. > > This fixes issues with lo

Re: [Qemu-devel] [PATCH v4 1/2] rtl8139: Fix receive buffer overflow check

2015-09-01 Thread Jason Wang
On 09/01/2015 11:26 PM, Vladislav Yasevich wrote: > rtl8139_do_receive() tries to check for the overflow condition > by making sure that packet_size + 8 does not exceed the > available buffer space. The issue here is that RxBuffAddr, > used to calculate available buffer space, is aligned to a >

Re: [Qemu-devel] [PATCH qemu] pseries: Update SLOF firmware image to qemu-slof-20150813

2015-09-01 Thread Alexey Kardashevskiy
On 08/14/2015 01:32 PM, Alexey Kardashevskiy wrote: On 08/13/2015 07:24 PM, Alexey Kardashevskiy wrote: The changes are: 1. GPT support; 2. Much faster VGA support. The full changelog is: > Add missing half word access case to _FASTRMOVE and _FASTMOVE > Remove unused RMOVE64 stub > fbu

Re: [Qemu-devel] [PATCH v9 05/10] move out net queue structs define

2015-09-01 Thread Yang Hongyang
On 09/01/2015 10:43 PM, Stefan Hajnoczi wrote: On Tue, Sep 01, 2015 at 05:06:18PM +0800, Yang Hongyang wrote: This will be used by the next patch in this series. Signed-off-by: Yang Hongyang Reviewed-by: Thomas Huth --- include/net/queue.h | 19 +++ net/queue.c | 19

[Qemu-devel] [PATCH 2/2] linux-user: remove MAX_ARG_PAGES limit

2015-09-01 Thread Stefan Brüns
Instead of creating a temporary copy for the whole environment and the arguments, directly copy everything to the target stack. For this to work, we have to change the order of stack creation and copying the arguments. Signed-off-by: Stefan Brüns --- v2: fixed scratch pointer type, fixed checkpa

Re: [Qemu-devel] [PATCH v9 01/10] net: add a new object netfilter

2015-09-01 Thread Yang Hongyang
Hi Stefan, On 09/01/2015 10:36 PM, Stefan Hajnoczi wrote: On Tue, Sep 01, 2015 at 05:06:14PM +0800, Yang Hongyang wrote: Add the framework for a new netfilter object and a new -netfilter CLI option as a basis for the following patches. Note that the new added document in qemu-options.hx indicat

[Qemu-devel] [PATCH 1/2] linux-user: remove unused image_info members

2015-09-01 Thread Stefan Brüns
Signed-off-by: Stefan Brüns --- linux-user/elfload.c | 3 --- linux-user/qemu.h| 2 -- 2 files changed, 5 deletions(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 9c999ac..e44f989 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -1447,7 +1447,6 @@ static abi

Re: [Qemu-devel] [Patch for-2.5 v2 5/6] qmp: add monitor command to add/remove a child

2015-09-01 Thread Wen Congyang
On 09/01/2015 11:34 PM, Eric Blake wrote: > On 08/31/2015 06:55 PM, Wen Congyang wrote: > +This command is still a work in progress. It doesn't support all +block drivers. Stay away from it unless you want it to help with +its development. >>> >>> Maybe we should name it 'x-child-ad

Re: [Qemu-devel] [PATCH] linux-user: remove MAX_ARG_PAGES limit

2015-09-01 Thread Stefan Bruens
On Tuesday 01 September 2015 19:42:26 you wrote: > >> > --- a/linux-user/linuxload.c > >> > +++ b/linux-user/linuxload.c > >> > @@ -137,8 +137,7 @@ int loader_exec(int fdexec, const char *filename, > >> > char > >> > **argv, char **envp,> > >> > > >> > int retval; > >> > int i; > >> > >

[Qemu-devel] [PATCH] ui/cocoa.m: Add Mount image file menu item

2015-09-01 Thread Programmingkid
Add "Mount Image File..." and a "Eject Image File" menu items to cocoa interface. This patch makes sharing files between the host and the guest user-friendly. The "Mount Image File..." menu item displays a dialog box having the user pick an image file to use in QEMU. The image file is setup as a U

Re: [Qemu-devel] [PATCH v2 1/2] util - add automated ID generation utility

2015-09-01 Thread John Snow
On 09/01/2015 06:30 PM, Jeff Cody wrote: > Multiple sub-systems in QEMU may find it useful to generate IDs > for objects that a user may reference via QMP or HMP. This patch > presents a standardized way to do it, so that automatic ID generation > follows the same rules. > > This patch enforces

Re: [Qemu-devel] [PATCH v2 1/2] util - add automated ID generation utility

2015-09-01 Thread Jeff Cody
On Tue, Sep 01, 2015 at 04:55:16PM -0600, Eric Blake wrote: > On 09/01/2015 04:30 PM, Jeff Cody wrote: > > Multiple sub-systems in QEMU may find it useful to generate IDs > > for objects that a user may reference via QMP or HMP. This patch > > presents a standardized way to do it, so that automati

Re: [Qemu-devel] rfc: vhost user enhancements for vm2vm communication

2015-09-01 Thread Nakajima, Jun
On Tue, Sep 1, 2015 at 9:28 AM, Jan Kiszka wrote: > On 2015-09-01 18:02, Michael S. Tsirkin wrote: ... >> You don't need to be able to map all guest memory if you know >> guest won't try to allow device access to all of it. >> It's a question of how good is the bus address allocator. > > But those

Re: [Qemu-devel] [PATCH V4 2/8] Introduce AUX bus.

2015-09-01 Thread Alistair Francis
On Tue, Sep 1, 2015 at 2:48 PM, Alistair Francis wrote: > On Tue, Jul 21, 2015 at 10:17 AM, wrote: >> From: KONRAD Frederic >> >> This introduces a new bus: aux-bus. >> >> It contains an address space for aux slaves devices and a bridge to an I2C >> bus >> for I2C through AUX transactions. >>

Re: [Qemu-devel] [PATCH V4 5/8] hw/i2c-ddc.c: Implement DDC I2C slave

2015-09-01 Thread Alistair Francis
On Tue, Jul 21, 2015 at 10:17 AM, wrote: > From: Peter Maydell > > Implement an I2C slave which implements DDC and returns the > EDID data for an attached monitor. > > Signed-off-by: Peter Maydell > > - Rebased on the current master. > - Modified for QOM. > > Signed-off-by: KONRAD Frederic

Re: [Qemu-devel] [PULL 0/1] virtio-serial: disable event throttling

2015-09-01 Thread Amit Shah
On (Tue) 01 Sep 2015 [17:32:07], Peter Maydell wrote: > On 1 September 2015 at 13:47, Amit Shah wrote: > > On (Tue) 01 Sep 2015 [14:27:48], Marc-André Lureau wrote: > >> Hi Amit > >> > >> Out of curiosity, did you check the series "monitor: throttle > >> VSERPORT_CHANGED by id"? That would fix the

Re: [Qemu-devel] [PATCH V4 4/8] introduce dpcd module.

2015-09-01 Thread Alistair Francis
On Tue, Jul 21, 2015 at 10:17 AM, wrote: > From: KONRAD Frederic > > This introduces a DPCD module. It wires on a aux-bus and can be accessed by > driver to get lane-speed, etc. "the driver" Also, the commit titles are a little messy. The capitalisation should be consistent and there shouldn't

Re: [Qemu-devel] rfc: vhost user enhancements for vm2vm communication

2015-09-01 Thread Nakajima, Jun
My previous email has been bounced by virtio-...@lists.oasis-open.org. I tried to subscribed it, but to no avail... On Tue, Sep 1, 2015 at 1:17 AM, Michael S. Tsirkin wrote: > On Mon, Aug 31, 2015 at 11:35:55AM -0700, Nakajima, Jun wrote: >> On Mon, Aug 31, 2015 at 7:11 AM, Michael S. Tsirkin wr

Re: [Qemu-devel] [PATCH v2 1/2] util - add automated ID generation utility

2015-09-01 Thread Eric Blake
On 09/01/2015 04:30 PM, Jeff Cody wrote: > Multiple sub-systems in QEMU may find it useful to generate IDs > for objects that a user may reference via QMP or HMP. This patch > presents a standardized way to do it, so that automatic ID generation > follows the same rules. > > This patch enforces t

Re: [Qemu-devel] [PATCH V4 3/8] i2c: implement broadcast write.

2015-09-01 Thread Alistair Francis
On Tue, Jul 21, 2015 at 10:17 AM, wrote: > From: KONRAD Frederic > > This does a write to every slaves when the I2C bus get a write to address 0. > > Signed-off-by: KONRAD Frederic Reviewed-by: Alistair Francis Tested-By: Hyun Kwon Thanks, Alistair > --- > hw/i2c/core.c | 130 > +++

Re: [Qemu-devel] [PATCH V4 1/8] i2cbus: remove unused dev field.

2015-09-01 Thread Alistair Francis
On Tue, Sep 1, 2015 at 1:58 PM, Alistair Francis wrote: > On Tue, Jul 21, 2015 at 10:17 AM, wrote: >> From: KONRAD Frederic >> >> Seems this field is not needed. > > The commit message should be updated to represent the patch. > >> >> Signed-off-by: KONRAD Frederic > > Otherwise: > > Reviewed-

[Qemu-devel] [PATCH v2 0/2] Auto-generated IDs

2015-09-01 Thread Jeff Cody
Changes from RFC v1: Patch 1: Several typos / grammatical errors (thanks Eric, John) Make id_subsys_str[] const pointer to const strings (thanks Eric) Moved id_subsys_str[] out from id_generate() (thanks John) Assert on null string for given id (thanks E

[Qemu-devel] [PATCH v2 1/2] util - add automated ID generation utility

2015-09-01 Thread Jeff Cody
Multiple sub-systems in QEMU may find it useful to generate IDs for objects that a user may reference via QMP or HMP. This patch presents a standardized way to do it, so that automatic ID generation follows the same rules. This patch enforces the following rules when generating an ID: 1.) Guaran

[Qemu-devel] [PATCH v2 2/2] block: auto-generated node-names

2015-09-01 Thread Jeff Cody
If a node-name is not specified, automatically generate the node-name. Generated node-names will use the "block" sub-system identifier. Reviewed-by: Eric Blake Reviewed-by: John Snow Signed-off-by: Jeff Cody --- block.c | 25 - 1 file changed, 16 insertions(+), 9 delet

Re: [Qemu-devel] [RFC] docs: describe QEMU's VMGenID design

2015-09-01 Thread Eric Blake
On 09/01/2015 04:05 PM, Laszlo Ersek wrote: > > (3) I couldn't decide if this text file should go under docs/, or > docs/specs. The tricky fact about this specific vmgenid design is that > the guest will "know" about it, but no *specific* guest code needs to be > written for it. > > First, the A

Re: [Qemu-devel] [RFC] docs: describe QEMU's VMGenID design

2015-09-01 Thread Laszlo Ersek
On 09/01/15 21:47, Eric Blake wrote: > On 08/28/2015 02:18 PM, Laszlo Ersek wrote: >> Cc: Paolo Bonzini >> Cc: Gal Hammer >> Cc: Igor Mammedov >> Cc: "Michael S. Tsirkin" >> Signed-off-by: Laszlo Ersek >> --- >> >> Notes: >> This is based on the super long private email discussion we had t

Re: [Qemu-devel] [PATCH] arm: Ensure LSB of BLX is set

2015-09-01 Thread Meador Inge
On Tue, Sep 01, 2015 at 05:28:10PM +0100, Peter Maydell wrote: > On 6 July 2015 at 19:09, wrote: > > From: Meador Inge > > > > This small patch adds a sanity check when disassembling > > the BLX instruction. The use case came to light when > > doing toolchain development and a similar check was

Re: [Qemu-devel] [PATCH V4 2/8] Introduce AUX bus.

2015-09-01 Thread Alistair Francis
On Tue, Jul 21, 2015 at 10:17 AM, wrote: > From: KONRAD Frederic > > This introduces a new bus: aux-bus. > > It contains an address space for aux slaves devices and a bridge to an I2C bus > for I2C through AUX transactions. > > Signed-off-by: KONRAD Frederic > --- > default-configs/aarch64-sof

[Qemu-devel] [trivial PATCH] hw/pci: fix pci_update_mappings() trace events

2015-09-01 Thread Laszlo Ersek
The current trace prototypes and (matching) trace calls lead to "unorthodox" PCI BDF notation in at least the stderr trace backend. For example, the four BARs of a QXL video card at 00:01.0 (bus 0, slot 1, function 0) are traced like this (PID and timestamps removed): pci_update_mappings_add d=0

Re: [Qemu-devel] [PATCH v5 5/5] migration: Disambiguate MAX_THROTTLE

2015-09-01 Thread Eric Blake
On 09/01/2015 08:46 AM, Jason J. Herne wrote: > Migration has a define for MAX_THROTTLE. Update comment to clarify that this > is > used for throttling transfer speed. Hopefully this will prevent it from being > confused with a guest cpu throttling entity. > > Signed-off-by: Jason J. Herne > Rev

Re: [Qemu-devel] [PATCH v5 4/5] qmp/hmp: Add throttle ratio to query-migrate and info migrate

2015-09-01 Thread Eric Blake
On 09/01/2015 08:46 AM, Jason J. Herne wrote: > Report throttle percentage in info migrate and query-migrate responses when > cpu throttling is active. > > Signed-off-by: Jason J. Herne > Reviewed-by: Dr. David Alan Gilbert > --- > hmp.c | 5 + > migration/migration.c | 5 ++

Re: [Qemu-devel] [PATCH v5 3/5] migration: Dynamic cpu throttling for auto-converge

2015-09-01 Thread Eric Blake
On 09/01/2015 08:46 AM, Jason J. Herne wrote: > Remove traditional auto-converge static 30ms throttling code and replace it > with a dynamic throttling algorithm. > > Additionally, be more aggressive when deciding when to start throttling. > Previously we waited until four unproductive memory pass

Re: [Qemu-devel] [PATCH v5 2/5] migration: Parameters for auto-converge cpu throttling

2015-09-01 Thread Eric Blake
On 09/01/2015 08:46 AM, Jason J. Herne wrote: > Add migration parameters to allow the user to adjust the parameters > that control cpu throttling when auto-converge is in effect. The added > parameters are as follows: > > x-cpu-throttle-initial : Initial percantage of time guest cpus are throttled

Re: [Qemu-devel] [PATCH v5 1/5] cpu: Provide vcpu throttling interface

2015-09-01 Thread Eric Blake
On 09/01/2015 08:45 AM, Jason J. Herne wrote: > Provide a method to throttle guest cpu execution. CPUState is augmented with > timeout controls and throttle start/stop functions. To throttle the guest cpu > the caller simply has to call the throttle set function and provide a > percentage > of thr

Re: [Qemu-devel] [PATCH RFC 4/5] net/dump: Provide the dumping facility as a net filter

2015-09-01 Thread Thomas Huth
On 01/09/15 21:52, Eric Blake wrote: > On 08/26/2015 08:33 PM, Thomas Huth wrote: >> Add glue code to use the dumping functions as a netdev >> filter, too. >> >> Signed-off-by: Thomas Huth >> --- >> net/dump.c | 54 ++ >> net/filter.c

Re: [Qemu-devel] [PATCH V4 0/8] Xilinx DisplayPort.

2015-09-01 Thread Alistair Francis
On Tue, Sep 1, 2015 at 10:24 AM, Peter Maydell wrote: > On 21 July 2015 at 18:17, wrote: >> From: KONRAD Frederic >> >> This is the fourth version of this patch-set of the implementation of the >> Xilinx >> DisplayPort and DPDMA. >> >> This fourth version fix some functional bad behaviours. >>

Re: [Qemu-devel] [PATCH V4 1/8] i2cbus: remove unused dev field.

2015-09-01 Thread Alistair Francis
On Tue, Jul 21, 2015 at 10:17 AM, wrote: > From: KONRAD Frederic > > Seems this field is not needed. The commit message should be updated to represent the patch. > > Signed-off-by: KONRAD Frederic Otherwise: Reviewed-by: Alistair Francis Thanks, Alistair > --- > hw/i2c/core.c | 1 - >

[Qemu-devel] [PATCH 4/4] ahci: clean up initial d2h semantics

2015-09-01 Thread John Snow
with write_fis_d2h and signature generation tidied up, let's adjust the initial d2h semantics to make more sense. The initial d2h is considered delivered if there is guest memory to save it to. Signed-off-by: John Snow --- hw/ide/ahci.c | 27 --- 1 file changed, 16 inser

[Qemu-devel] [PATCH 3/4] ahci: remove cmd_fis argument from write_fis_d2h

2015-09-01 Thread John Snow
It's no longer used. We used to generate a D2H FIS based upon the command FIS that prompted the update, but in reality, the D2H FIS is generated purely from register state. cmd_fis is vestigial, so get rid of it. Signed-off-by: John Snow --- hw/ide/ahci.c | 11 --- 1 file changed, 4 ins

[Qemu-devel] [PATCH 2/4] ahci: fix signature generation

2015-09-01 Thread John Snow
The initial register device-to-host FIS no longer needs to specially set certain fields, as these can be handled generically by setting those fields explicitly with the signatures we want at port reset time. (1) Signatures are decomposed into their four component registers and set upon (AHCI)

[Qemu-devel] [PATCH 1/4] ahci: remove dead reset code

2015-09-01 Thread John Snow
This check is dead due to an earlier conditional. AHCI does not currently support hotplugging, so checks to see if devices are present or not are useless. Remove it. Reported-by: Stefan Hajnoczi Signed-off-by: John Snow --- hw/ide/ahci.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-

[Qemu-devel] [PATCH 0/4] ahci: clean up signature generation

2015-09-01 Thread John Snow
Ultimately, clean up the signature generation and as a result, tidy up the port_reset and init_d2h functions. For convenience, this branch is available at: https://github.com/jnsnow/qemu.git branch ahci-sigfix https:

Re: [Qemu-devel] [PATCH v2 1/5] fw_cfg: document fw_cfg_modify_iXX() update functions

2015-09-01 Thread Peter Maydell
On 1 September 2015 at 21:27, Gabriel L. Somlo wrote: > Right, that's what I'm trying to do -- expose fw_cfg in > /sys/firmware/... on the guest -- which involves figuring out how > to determine if it is present (DT on ARM, blindly poking port 0x510 > on x86 for now, hence my interest in having it

Re: [Qemu-devel] [RFC 3/3] monitor: remove old entries from event hash table

2015-09-01 Thread Eric Blake
On 08/12/2015 01:46 PM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Do not let the hash table grow without limit, schedule a cleanup for > outdated event. > > Signed-off-by: Marc-André Lureau > --- > monitor.c | 51 --- > 1 f

[Qemu-devel] [PATCH v2] linux-user: add name_to_handle_at/open_by_handle_at

2015-09-01 Thread Laurent Vivier
This patch allows to run example given by open_by_handle_at(2): The following shell session demonstrates the use of these two programs: $ echo 'Can you please think about it?' > cecilia.txt $ ./t_name_to_handle_at cecilia.txt > fh $ ./t_open_by_handle_at < f

Re: [Qemu-devel] [PATCH v2 1/5] fw_cfg: document fw_cfg_modify_iXX() update functions

2015-09-01 Thread Gabriel L. Somlo
On Tue, Sep 01, 2015 at 09:10:23PM +0100, Peter Maydell wrote: > On 1 September 2015 at 20:13, Gabriel L. Somlo wrote: > > Also, since I'll be tinkering with fw_cfg again, and you mentioned > > using DT on arm and ACPI on x86 to auto-detect the presence (and location) > > of fw_cfg from the guest-

Re: [Qemu-devel] [RFC 2/3] monitor: throttle QAPI_EVENT_VSERPORT_CHANGE by "id"

2015-09-01 Thread Eric Blake
On 08/12/2015 01:46 PM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Use a hash table to lookup the pending event corresponding to the "id" > field. The hash table may grow without limit here, the following patch > will add some cleaning. > > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH RFC v3 30/32] qapi: New QMP command query-schema for QMP schema introspection

2015-09-01 Thread Michael Roth
Quoting Eric Blake (2015-09-01 14:12:24) > On 09/01/2015 12:40 PM, Michael Roth wrote: > > Quoting Markus Armbruster (2015-08-04 10:58:14) > >> Caution, rough edges. > >> > >> qapi/introspect.json defines the introspection schema. It should do > >> for uses other than QMP. > >> FIXME it's almost e

Re: [Qemu-devel] [RFC 1/3] monitor: split MonitorQAPIEventState

2015-09-01 Thread Eric Blake
On 08/12/2015 01:46 PM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Create a seperate pending event structure MonitorQAPIEventPending. s/seperate/separate/ > Use a MonitorQAPIEventDelay callback to handle the delaying. This > allows other implementations of throttling. > >

Re: [Qemu-devel] [RFC 35/38] cputlb: use cpu_tcg_sched_work for tlb_flush_all

2015-09-01 Thread Peter Maydell
On 1 September 2015 at 20:38, Emilio G. Cota wrote: > I can replicate it; what's happening is that tlb_flush_all calls > cpu_loop_exit(), then re-enters the cpu loop, performs the > job while other CPUs are asleep(i.e. __tlb_flush_all in this case), > but then when it continues execution it loads

Re: [Qemu-devel] Adding secondary ARM processor

2015-09-01 Thread Peter Crosthwaite
On Tue, Sep 1, 2015 at 11:27 AM, mar.krzeminski wrote: > W dniu 01.09.2015 o 19:45, Peter Crosthwaite pisze: >> >> On Tue, Sep 1, 2015 at 10:19 AM, mar.krzeminski >> wrote: >>> >>> Hello, >>> >>> I have board with A9 processor (playing with vexpress model), >>> for test I want to also add to this

Re: [Qemu-devel] [PATCH v2 1/5] fw_cfg: document fw_cfg_modify_iXX() update functions

2015-09-01 Thread Peter Maydell
On 1 September 2015 at 20:13, Gabriel L. Somlo wrote: > Also, since I'll be tinkering with fw_cfg again, and you mentioned > using DT on arm and ACPI on x86 to auto-detect the presence (and location) > of fw_cfg from the guest-side in a related thread: I meant DT or ACPI on ARM, actually. I don't

Re: [Qemu-devel] [PATCH] tcg/aarch64: Fix tcg_out_qemu_{ld, st} for linux-user

2015-09-01 Thread Richard Henderson
On 09/01/2015 09:31 AM, Andreas Färber wrote: -0x006cd98c: f83f6a95 str x21, [x20, xzr] +0x006cd98c: f8346bf5 str x21, [sp, x20] Thanks. Sorry it took me so long to get back to this. I've sent a patch to the list. I intended to cc you, but somehow forgot at the last second. r~

[Qemu-devel] [PATCH] tcg/aarch64: Fix tcg_out_qemu_{ld, st} for guest_base == 0

2015-09-01 Thread Richard Henderson
In ffc6372851d8631a9f9fa56ec613b3244dc635b9, we swapped the guest base to the address base register from the address index register. Except that 31 in the base slot is SP not XZR, so we need to be more intelligent about which reg gets placed in which slot. Cc: Paolo Bonzini Cc: Aurelien Jarno Cc

Re: [Qemu-devel] [PATCH RFC 4/5] net/dump: Provide the dumping facility as a net filter

2015-09-01 Thread Eric Blake
On 08/26/2015 08:33 PM, Thomas Huth wrote: > Add glue code to use the dumping functions as a netdev > filter, too. > > Signed-off-by: Thomas Huth > --- > net/dump.c | 54 ++ > net/filter.c | 1 + > net/filters.h| 2 ++ > qapi-sc

Re: [Qemu-devel] [RFC] docs: describe QEMU's VMGenID design

2015-09-01 Thread Eric Blake
On 08/28/2015 02:18 PM, Laszlo Ersek wrote: > Cc: Paolo Bonzini > Cc: Gal Hammer > Cc: Igor Mammedov > Cc: "Michael S. Tsirkin" > Signed-off-by: Laszlo Ersek > --- > > Notes: > This is based on the super long private email discussion we had two > months ago, plus on the IRL discussion

Re: [Qemu-devel] [PULL 00/26] qemu-ga patch queue for 2015-09-01

2015-09-01 Thread John Snow
On 09/01/2015 02:37 PM, Peter Maydell wrote: > On 1 September 2015 at 19:33, Michael Roth wrote: >> Quoting Peter Maydell (2015-09-01 12:12:39) >>> That function wasn't added to glib until 2.28, and our minimum is >>> 2.22. >> >> Sorry for missing this, will send a v2 shortly. >> >> Do you happe

Re: [Qemu-devel] [RFC 35/38] cputlb: use cpu_tcg_sched_work for tlb_flush_all

2015-09-01 Thread Emilio G. Cota
On Tue, Sep 01, 2015 at 17:10:30 +0100, Alex Bennée wrote: > > Emilio G. Cota writes: > > > Signed-off-by: Emilio G. Cota > > --- > > cputlb.c | 41 +++-- > > 1 file changed, 11 insertions(+), 30 deletions(-) > > I bisected my Jessie boot failure to this co

Re: [Qemu-devel] [RFC PATCH 1/2] util - add automated ID generation utility

2015-09-01 Thread Jeff Cody
On Tue, Sep 01, 2015 at 03:13:52PM -0400, John Snow wrote: > > > On 09/01/2015 01:23 PM, Jeff Cody wrote: > > Multiple sub-systems in QEMU may find it useful to generated IDs > > generate > > > for objects that a user may reference via QMP or HMP. This patch > > presents a standardized way to

Re: [Qemu-devel] [RFC PATCH 2/2] block: auto-generated node-names

2015-09-01 Thread John Snow
On 09/01/2015 01:23 PM, Jeff Cody wrote: > If a node-name is not specified, automatically generate the node-name. > > Generated node-names will use the "block" sub-system identifier. > > Signed-off-by: Jeff Cody > --- > block.c | 25 - > 1 file changed, 16 insertions(+

Re: [Qemu-devel] [PATCH RFC v3 30/32] qapi: New QMP command query-schema for QMP schema introspection

2015-09-01 Thread Eric Blake
On 09/01/2015 12:40 PM, Michael Roth wrote: > Quoting Markus Armbruster (2015-08-04 10:58:14) >> Caution, rough edges. >> >> qapi/introspect.json defines the introspection schema. It should do >> for uses other than QMP. >> FIXME it's almost entirely devoid of comments. >> >> The introspection sch

  1   2   3   4   >