On Tuesday 01 September 2015 19:42:26 you wrote: > >> > --- a/linux-user/linuxload.c > >> > +++ b/linux-user/linuxload.c > >> > @@ -137,8 +137,7 @@ int loader_exec(int fdexec, const char *filename, > >> > char > >> > **argv, char **envp,> > >> > > >> > int retval; > >> > int i; > >> > > >> > - bprm->p = TARGET_PAGE_SIZE*MAX_ARG_PAGES-sizeof(unsigned int); > >> > - memset(bprm->page, 0, sizeof(bprm->page)); > >> > + bprm->p = 0; > >> > >> Nothing actually uses this value -- both the elfload and the flatload > >> code > >> paths now either ignore bprm->p or set it themselves. It would be > >> better to delete this and also the dead assignment "p = bprm->p" at > >> the top of load_flt_binary(). > > > > OK to do this in a followup patch? > > If you want to remove the dead assignment in its own patch > I would do that before this patch, rather than after.
Before is not really possible, as it depends on the reordering. Regards, Stefan -- Stefan Brüns / Bergstraße 21 / 52062 Aachen home: +49 241 53809034 mobile: +49 151 50412019 work: +49 2405 49936-424
