On Wed, Aug 05, 2015 at 02:12:26PM +0800, Jason Wang wrote:
> 1.0 does not requires physically-contiguous pages layout for a
> virtqueue. So we could not infer avail and used from desc. This means
> we need to migrate vring.avail and vring.used when host support virtio
> 1.0. This fixes malfunction
Hello!
> > -memory_region_init_io(&s->cpuiomem[0], OBJECT(s), &gic_thiscpu_ops, s,
> > - "gic_cpu", 0x100);
>
> This memory region is size 0x100, as the comment says it must be...
>
> > +if (s->revision != REV_NVIC) {
> > +/* CPU interface (NVIC doesn't
Eric Blake writes:
> On 08/04/2015 09:57 AM, Markus Armbruster wrote:
>> The old code prints the result of parsing (list of expression
>> dictionaries), and partial results of semantic analysis (list of enum
>> dictionaries, list of struct dictionaries).
>>
>> The new code prints a trace of a sc
Eric Blake writes:
> On 08/04/2015 09:57 AM, Markus Armbruster wrote:
>> The visitor will help keeping the code generation code simple and
>> reasonably separated from QAPISchema details.
>>
>> Signed-off-by: Markus Armbruster
>> Reviewed-by: Eric Blake
>> ---
>> scripts/qapi.py | 46
Eric Blake writes:
> On 08/04/2015 09:57 AM, Markus Armbruster wrote:
>> The QAPI code generators work with a syntax tree (nested dictionaries)
>> plus a few symbol tables (also dictionaries) on the side.
>>
>> They have clearly outgrown these simple data structures. There's lots
>> of rummagin
1.0 does not requires physically-contiguous pages layout for a
virtqueue. So we could not infer avail and used from desc. This means
we need to migrate vring.avail and vring.used when host support virtio
1.0. This fixes malfunction of virtio 1.0 device after migration.
Cc: Michael S. Tsirkin
Cc:
Eric Blake writes:
> On 08/04/2015 03:18 AM, Markus Armbruster wrote:
>> Reproducer: with
>>
>> { 'command': 'user_def_cmd4', 'returns': { 'a': 'int' } }
>>
>> added to qapi-schema-test.json, qapi-commands.py dies when it tries to
>> generate the command handler function
>>
>> Tracebac
Eric Blake writes:
> On 08/04/2015 03:17 AM, Markus Armbruster wrote:
>> A flat union's tag member gets renamed to 'kind' in the generated
>> code. Breaks when another member is named 'kind' exists.
>
> Too many verbs. Drop either 'is' or 'exists'.
Will fix.
>>
>> Example, adapted from qapi-s
On Tue, Aug 04, 2015 at 09:33:56AM -0500, Nathan Fontenot wrote:
> On 08/03/2015 12:35 AM, Bharata B Rao wrote:
> > Don't represent non-hotluggable memory under drconf node. With this
> > we don't have to create DRC objects for them.
> >
> > The effect of this patch is that we revert back to memor
Seems pretty good overall~
For the part of migration parameters command, we have discussed before and
Markus promised to reconstruct this part in qemu 2.5 cycle. But for now,
it is OK.
Cc: Markus Armbruster
On 2015/8/5 3:26, Dr. David Alan Gilbert (git) wrote:
From: "Dr. David Alan Gilbert"
This patch corrects a logic error when handling 64-bt bar with
more than 4G size.
With 64-bit Bar, it has two items in PCIDevice: io_regions[x]
and io_regions[x+1], io_regions[x] has all the informations for
this BAR, while io_regions[x+1] contains nothing, so we need to
get the size from io_regio
On Tue, Aug 04, 2015 at 08:55:29PM +1000, Gavin Shan wrote:
> On Tue, Aug 04, 2015 at 05:23:30PM +1000, Alexey Kardashevskiy wrote:
> >On 08/04/2015 05:16 PM, Gavin Shan wrote:
> >>On Tue, Aug 04, 2015 at 02:49:14PM +1000, Alexey Kardashevskiy wrote:
> >>>On 08/03/2015 01:32 PM, Gavin Shan wrote:
>
On Tue, Aug 04, 2015 at 10:27:31AM +0200, Laurent Vivier wrote:
> We use muldiv64() to compute the time to wait:
>
> timeout = muldiv64(get_ticks_per_sec(), timeout, 3300);
>
> but get_ticks_per_sec() is 10^9 (30 bit value) and timeout
> is a 35 bit value.
>
> Whereas muldiv64 is:
>
>
Same situation here:
Firefox can't handle ~/.mozilla to be a virtio-9p mount.
Here the subvolume is ext4, mounted only at /home.
I also noticed that chromium is working, but it complains about some errors:
getrlimit(RLIMIT_NOFILE) failed
[4809:4839:0804/230514:ERROR:backend_impl.cc(1365)] Unable t
On Tue, Aug 4, 2015 at 5:53 AM, Peter Lieven wrote:
> Am 04.08.2015 um 14:29 schrieb Peter Lieven:
>
>> Am 04.08.2015 um 14:09 schrieb Paolo Bonzini:
>>
>>>
>>> On 04/08/2015 13:57, Peter Lieven wrote:
>>>
Okay, what I found out is that in aio_poll I get revents = POLLIN for
the nfs fil
On 08/04/2015 09:58 AM, Markus Armbruster wrote:
> The effect of the previous few patches on generated files is hard to
> review, because stuff gets generated in different order, which renders
> diffs of the generated files useless.
>
> To get reviewable diffs, we need to split the generated files
On 08/04/2015 09:57 AM, Markus Armbruster wrote:
> The effect of the next few patches on generated files is hard to
> review, because stuff gets generated in different order, which renders
> diffs of the generated files useless.
>
> To get reviewable diffs, we need to split the generated files int
On 08/04/2015 09:57 AM, Markus Armbruster wrote:
> One of the next patches will among other things generate a separate
> typedef for some struct types, i.e.
>
> typedef struct FOO FOO;
>
> struct FOO {
> ...
> };
>
> instead of
>
> typedef struct FOO {
> ...
> } FOO;
On 08/04/2015 09:57 AM, Markus Armbruster wrote:
> The old code prints the result of parsing (list of expression
> dictionaries), and partial results of semantic analysis (list of enum
> dictionaries, list of struct dictionaries).
>
> The new code prints a trace of a schema visit, i.e. what the ba
On 08/04/2015 09:57 AM, Markus Armbruster wrote:
> The visitor will help keeping the code generation code simple and
> reasonably separated from QAPISchema details.
>
> Signed-off-by: Markus Armbruster
> Reviewed-by: Eric Blake
> ---
> scripts/qapi.py | 46 ++
On 08/04/2015 09:57 AM, Markus Armbruster wrote:
> New methods c_name(), c_type(), c_null(), json_type(),
> alternate_qtype().
>
> Signed-off-by: Markus Armbruster
> ---
> scripts/qapi.py | 72
> +++--
> 1 file changed, 65 insertions(+), 7 del
On 08/04/2015 09:57 AM, Markus Armbruster wrote:
> The QAPI code generators work with a syntax tree (nested dictionaries)
> plus a few symbol tables (also dictionaries) on the side.
>
> They have clearly outgrown these simple data structures. There's lots
> of rummaging around in dictionaries, an
On Tue, Aug 04, 2015 at 07:21:25PM +0300, Victor Kaplansky wrote:
> Rebuilding QEMU after switching versions from git can cause make failure
> if IASL is enabled. This is caused by including stale *.d info from
> previous build.
>
> To prevent this in the future we generate dependency info for gen
Hi guys.
I'm trying to run the QEMU tests for i386 and x86_64 architectures but
they are returning some errors.
I'm using the most update version from git tree and my system is Ubuntu 14.04.
Take a look at this segfault errors.
$ make test
[...]
../../i386-linux-user/qemu-i386 ./test-mmap
pagesiz
On 4 August 2015 at 17:21, Victor Kaplansky wrote:
> Rebuilding QEMU after switching versions from git can cause make failure
> if IASL is enabled. This is caused by including stale *.d info from
> previous build
> # Flags for dependency generation
> QEMU_DGFLAGS += -MMD -MP -MT $@ -MF $(*D)/$(
Rebuilding QEMU after switching versions from git can cause make failure
if IASL is enabled. This is caused by including stale *.d info from
previous build.
To prevent this in the future we generate dependency info for generated
ACPI sources in *.dep instead regular *.d and include them explicitly
Output unchanged apart from reordering and white-space.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
scripts/qapi-commands.py | 154 ++-
scripts/qapi.py | 2 +-
2 files changed, 86 insertions(+), 70 deletions(-)
diff --git
On Tue, Aug 04, 2015 at 09:00:47PM +0200, Luke Gorrie wrote:
> Hi Michael,
>
> Sorry I didn't see this mail sooner -
>
> On 30 July 2015 at 10:36, Michael S. Tsirkin wrote:
>
> This reverts commit 294ce717e0f212ed0763307f3eab72b4a1bdf4d0.
>
> vhost stop happens e.g. when guest unloads
On Tue, Aug 04, 2015 at 07:21:25PM +0300, Victor Kaplansky wrote:
> Rebuilding QEMU after switching versions from git can cause make failure
> if IASL is enabled. This is caused by including stale *.d info from
> previous build.
>
> To prevent this in the future we generate dependency info for gen
The effect of the previous few patches on generated files is hard to
review, because stuff gets generated in different order, which renders
diffs of the generated files useless.
To get reviewable diffs, we need to split the generated files into
suitable parts: put every top-level declaration in a
Fixes flat unions to get the base's base members. Test case is from
commit 2fc0043, in qapi-schema-test.json:
{ 'union': 'UserDefFlatUnion',
'base': 'UserDefUnionBase',
'discriminator': 'enum1',
'data': { 'value1' : 'UserDefA',
'value2' : 'UserDefB',
On 08/04/2015 03:18 AM, Markus Armbruster wrote:
> Reproducer: with
>
> { 'command': 'user_def_cmd4', 'returns': { 'a': 'int' } }
>
> added to qapi-schema-test.json, qapi-commands.py dies when it tries to
> generate the command handler function
>
> Traceback (most recent call last):
>
On 08/04/2015 10:03 AM, Programmingkid wrote:
> I was wondering if the online documentation for QEMU could be updated
> here: http://qemu.weilnetz.de/qemu-doc.html. In the USB section the
> "(experimental, works only on Linux hosts)" part should be removed.
> After doing several test on a Mac OS
On 08/04/2015 10:22 AM, Alex Bennée wrote:
>
> Richard Henderson writes:
>
>> On 08/04/2015 08:15 AM, Peter Maydell wrote:
>>> On 4 August 2015 at 16:11, Alex Bennée wrote:
Aurelien Jarno writes:
> On 2015-08-03 10:14, Alex Bennée wrote:
> In practice this is not true for linked T
On 08/04/2015 03:17 AM, Markus Armbruster wrote:
> A flat union's tag member gets renamed to 'kind' in the generated
> code. Breaks when another member is named 'kind' exists.
Too many verbs. Drop either 'is' or 'exists'.
>
> Example, adapted from qapi-schema-test.json:
>
> { 'struct': 'Us
On 08/04/2015 03:17 AM, Markus Armbruster wrote:
> The struct generated for a flat union is weird: the members of its
> base are at the end, except for the union tag, which is at the
> beginning.
>
> Change to put all base members at the beginning, unadulterated. Not
> only is this easier to und
The visitor will help keeping the code generation code simple and
reasonably separated from QAPISchema details.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
scripts/qapi.py | 46 ++
1 file changed, 46 insertions(+)
diff --git a/script
From: "Dr. David Alan Gilbert"
Automatically switch into a passive checkpoint mode when checkpoints are
repeatedly short. This saves CPU time on the SVM (since it's not running)
and the network traffic and PVM CPU time for the comparison processing.
Signed-off-by: Dr. David Alan Gilbert
---
h
On 08/04/2015 03:18 AM, Markus Armbruster wrote:
> In generated command handlers, the assignment to retval dominates its
> only use. Therefore, its initialization is useless. Drop it.
>
> Suggested-by: Eric Blake
> Signed-off-by: Markus Armbruster
> ---
> docs/qapi-code-gen.txt | 2 +-
> sc
From: "Dr. David Alan Gilbert"
COLO (experimentally) transfers RAM in the background when the amount
to transfer reaches a limit; allow this limit to be set via the
parameter mechanism.
Signed-off-by: Dr. David Alan Gilbert
---
hmp.c | 8
migration/colo.c | 6 ++
From: "Dr. David Alan Gilbert"
Signed-off-by: Dr. David Alan Gilbert
---
hmp-commands.hx| 15 -
hmp.c | 31 --
hmp.h | 1 -
migration/colo.c | 32 ++-
migration/migration.c | 59 ++
From: "Dr. David Alan Gilbert"
Hi,
This is an experimental adition to COLO, based off the colo-v1.5-developing
branch. It's not ready for inclusion.
The first patch, adds a 'hybrid mode' where the SVM is sent checkpoints
from the primary but does not run, and is thus much similar to a normal
Fixes flat unions to visit the base's base members (the previous
commit merely added them to the struct). Same test case.
Patch's effect on visit_type_UserDefFlatUnion():
static void visit_type_UserDefFlatUnion_fields(Visitor *m,
UserDefFlatUnion **obj, Error **errp)
{
Error
On 08/04/2015 12:08 PM, Alex Bennée wrote:
>>> Would that make sense as a debug option or should we have a specific set
>>> of TCG options to alter its behaviour?
>>
>>
>> That's what I'm saying -- probably a separate debug option is better.
>
> Sorry I meant should we add it to -d (as in -d nocha
Rename gen_marshal_input() to gen_marshal(), because the generated
function marshals both arguments and results.
Rename gen_visitor_input_containers_decl() to gen_marshal_vars(), and
move the other variable declarations there, too.
Rename gen_visitor_input_block() to gen_marshal_input_visit(), an
On 2015-08-04 13:55, Alex Bennée wrote:
>
> Aurelien Jarno writes:
>
> > On 2015-08-04 08:39, Alex Bennée wrote:
> >>
> >> Paolo Bonzini writes:
> >>
> >> > On 03/08/2015 11:14, Alex Bennée wrote:
> >> >> This allows the perf tool to map samples to each individual translation
> >> >> block. T
Richard Henderson writes:
> On 08/04/2015 10:22 AM, Alex Bennée wrote:
>>
>> Richard Henderson writes:
>>
>>> On 08/04/2015 08:15 AM, Peter Maydell wrote:
On 4 August 2015 at 16:11, Alex Bennée wrote:
> Aurelien Jarno writes:
>> On 2015-08-03 10:14, Alex Bennée wrote:
>> In
On 08/04/2015 03:18 AM, Markus Armbruster wrote:
> Clean up white-space, brace placement, and superfluous #ifdef
> QAPI_TYPES_BUILTIN_CLEANUP_DEF.
>
> Signed-off-by: Markus Armbruster
> ---
> docs/qapi-code-gen.txt | 12 -
> scripts/qapi-commands.py | 1 +
> scripts/qapi-event.py|
Still RFC, because it has a couple of FIXMEs and TODOs.
* PATCH 01-24 basically replace the interemediate representation. The
replacement isn't complete, but fully functional. See PATCH 02 for
rationale and future work.
PATCH 06-09 and 16-17 are temporary scaffolding to ease review. I
Hi Michael,
Sorry I didn't see this mail sooner -
On 30 July 2015 at 10:36, Michael S. Tsirkin wrote:
> This reverts commit 294ce717e0f212ed0763307f3eab72b4a1bdf4d0.
>
> vhost stop happens e.g. when guest unloads the driver,
> so closing the backend connection is not the right
> thing to do her
Hi Thibaut
On Mon, Aug 3, 2015 at 11:22 AM, Thibaut Collet
wrote:
> Some vhost user backends are able to support live migration.
> To provide this service the following features must be added:
> 1. Add the VIRTIO_NET_F_GUEST_ANNOUNCE capability to vhost-net when netdev
>backend is vhost-user.
Quoting Peter Lieven (2015-07-31 03:35:38)
> Am 31.07.2015 um 10:22 schrieb Paolo Bonzini:
> >
> > On 31/07/2015 10:12, Peter Lieven wrote:
> >> Hi Paolo, hi Stefan,
> >>
> >> you submitted some fixes for 2.4 recently. None of the folloing had
> >> qemu-stable in CC. Is this not stable material?
>
On 08/04/2015 10:26 AM, Alex Bennée wrote:
>
> Richard Henderson writes:
>
>> On 08/03/2015 02:14 AM, Alex Bennée wrote:
>>> Each individual architecture needs to use the qemu_log_in_addr_range()
>>> feature for enabling in_asm and marking blocks for op/opt_op output.
>>>
>>> Signed-off-by: Alex
On 4 August 2015 at 16:53, Peter Maydell wrote:
> On 4 August 2015 at 16:50, Eduardo Habkost wrote:
>> No problem. If you want to, I have just published a signed tag ready for
>> pulling:
>
> Great, I'll use that.
Applied, thanks.
-- PMM
Richard Henderson writes:
> On 08/04/2015 08:15 AM, Peter Maydell wrote:
>> On 4 August 2015 at 16:11, Alex Bennée wrote:
>>> Aurelien Jarno writes:
On 2015-08-03 10:14, Alex Bennée wrote:
In practice this is not true for linked TB. Should we also disable TB
linking when this op
Quoting Michael Roth (2015-07-30 06:32:15)
> Hi everyone,
>
> The following new patches are queued for QEMU stable v2.3.1:
>
> https://github.com/mdroth/qemu/commits/stable-2.3-staging
>
> The release is planned for 2015-08-11:
>
> http://wiki.qemu.org/Planning/2.3
>
> Please respond here
On 08/04/2015 03:18 AM, Markus Armbruster wrote:
> A command's or event's 'data' must be a struct type, given either as a
> dictionary, or as struct type name.
>
> Commit dd883c6 tightened the checking there, but not enough: we still
> accept 'union'. Fix to reject it.
>
> We may want to support
On 08/04/2015 03:18 AM, Markus Armbruster wrote:
> Since every schema entity has 'data', the data- prefix conveys no
> information. These tests actually exercise commands. Only commands
> have arguments, so change the prefix to to args-.
>
> Signed-off-by: Markus Armbruster
> ---
> tests/Makef
On 08/04/2015 03:18 AM, Markus Armbruster wrote:
> We don't actually enforce our "other than downstream extensions [...],
> all names should begin with a letter" rule. Add a FIXME.
>
> We should reject names that differ only in '_' vs. '.' vs. '-',
> because they're liable to clash in generated
Richard Henderson writes:
> On 08/03/2015 02:14 AM, Alex Bennée wrote:
>> Each individual architecture needs to use the qemu_log_in_addr_range()
>> feature for enabling in_asm and marking blocks for op/opt_op output.
>>
>> Signed-off-by: Alex Bennée
>> ---
>> target-arm/translate-a64.c | 6 ++
To eliminate the temptation for clients to look up types by name
(which are not ABI), replace all type names by meaningless strings.
Reduces output of query-schema by 13 out of 85KiB.
TODO Either generate comments with the true type names, or provide an
option to generate without type name hiding
One of the next patches will among other things generate a separate
typedef for some struct types, i.e.
typedef struct FOO FOO;
struct FOO {
...
};
instead of
typedef struct FOO {
...
} FOO;
To make the generated files easier to diff, anticipate the change.
Signed-
Provides a better description of the audio device to the
guest operating system.
Signed-off-by: John Arbuckle
---
hw/usb/dev-audio.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/usb/dev-audio.c b/hw/usb/dev-audio.c
index f092bb8..4e151db 100644
--- a/hw/usb/dev-
'gen': false needs to stay for now, because netdev_add is still using
it.
Signed-off-by: Markus Armbruster
---
docs/qapi-code-gen.txt| 18 ++
scripts/qapi.py | 20
tests/Makefile| 2 +-
On 08/04/2015 09:41 AM, Peter Maydell wrote:
> Do you object if I just apply it to master? I'd like to get
> the next rc out today or tomorrow and I'm not sure we have
> any other outstanding for-2.4 fixes...
https://lists.gnu.org/archive/html/qemu-devel/2015-08/msg00412.html
looks like a regressi
On 08/04/2015 09:44 AM, Markus Armbruster wrote:
> Markus Armbruster writes:
>
>> Commit 05dfb26 added eatspace stripping to mcgen(). Move it to
>> cgen(), just in case somebody gets tempted to use cgen() directly
>> instead of via mcgen().
>>
>> Output doesn't change
>>
>> Signed-off-by: Marku
On 08/04/2015 08:48 AM, Sascha Silbe wrote:
> Commit 488981a4 [block: convert quorum blockdrv to use crypto APIs]
> broke qemu-iotest 041 on hosts with GnuTLS < 2.10.0. It converted a
> compile-time check to a run-time check at device open time. The result
> is that we now advertise a feature (the
I will be hosting another key signing party at this year's KVM Forum.
I expect there will be enough people wanting keys signed that
we will use the same formal process that Anthony used last
year. The main aim here is for maintainers and submaintainers
to sign each others' keys so we can do signed
Sorry Jeff, my "Cc:" line in the commit description wasn't picked up.
Please merge through your block/jobs tree for QEMU 2.5.
Thanks,
Stefan
On Wed, Jul 1, 2015 at 3:45 PM, Stefan Hajnoczi wrote:
> If mirror has more free buffers than IOV_MAX, preadv(2)/pwritev(2)
> EINVAL failures may be encoun
Caution, rough edges.
qapi/introspect.json defines the introspection schema. It should do
for uses other than QMP.
FIXME it's almost entirely devoid of comments.
The introspection schema does not reflect all the rules and
restrictions that apply to QAPI schemata. A valid QAPI schema has an
intr
The QAPI code generators work with a syntax tree (nested dictionaries)
plus a few symbol tables (also dictionaries) on the side.
They have clearly outgrown these simple data structures. There's lots
of rummaging around in dictionaries, and information is recomputed on
the fly. For the work I'm g
Generate just 'FOO' instead of 'struct FOO' when possible.
Drop helper functions that are now unused.
Make pylint reasonably happy.
Rename generate_FOO() functions to gen_FOO() for consistency.
Use more consistent and sensible variable names.
Consistently use c_ for mapping keys when their val
This reverts commit 33048fffa49175099f8a93056884f27cc8845ea3.
Signed-off-by: Markus Armbruster
---
scripts/qapi-commands.py | 7 ---
scripts/qapi-event.py| 9 -
scripts/qapi-types.py| 8
scripts/qapi-visit.py| 9 -
scripts/qapi.py | 8
5
gen_marshal_output() uses its parameter name only for name of the
generated function. Name it after the type being marshaled instead of
its caller, and drop duplicates.
Saves 7 copies of qmp_marshal_output_int() in qemu-ga, and one copy of
qmp_marshal_output_str() in qemu-system-*.
Signed-off-by
These functions marshal both input and output.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
docs/qapi-code-gen.txt| 4 +-
docs/writing-qmp-commands.txt | 8 +-
monitor.c | 2 +-
qmp-commands.hx | 240 +--
It doesn't take a 'props' argument, let alone one in the format
"NAME=VALUE,..."
The bogus arguments specification doesn't matter due to 'gen': false.
Clean it up to be incomplete rather than wrong, and document the
incompleteness.
While there, improve netdev_add usage example in the manual: add
Move gen_visit_decl() to a better place. Inline
generate_visit_struct_body().
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
scripts/qapi-visit.py | 43 +--
1 file changed, 17 insertions(+), 26 deletions(-)
diff --git a/scripts/qapi-visit.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
scripts/qapi-event.py | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/scripts/qapi-event.py b/scripts/qapi-event.py
index aed45d6..537da17 100644
--- a/scripts/qapi-event.py
+++ b/scripts/qapi-event.py
@@ -137,7 +
It's first class, because unlike '**', it actually works, i.e. doesn't
require 'gen': false.
'**' will go away next.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
docs/qapi-code-gen.txt | 1 +
include/qapi/visitor-impl.h| 2 +
is_c_ptr() looks whether the end of the C text for the type looks like
a pointer. Works, but is fragile.
We now have a better tool: use QAPISchemaType method c_null(). The
initializers for non-pointers become prettier: 0, false or the
enumeration constant with the value 0 instead of {0}.
One pl
The old code prints the result of parsing (list of expression
dictionaries), and partial results of semantic analysis (list of enum
dictionaries, list of struct dictionaries).
The new code prints a trace of a schema visit, i.e. what the back-ends
are going to use. Built-in and array types are omi
Generated qapi-event.[ch] lose line breaks. No change otherwise.
Signed-off-by: Markus Armbruster
---
scripts/qapi-commands.py | 11 ++-
scripts/qapi-event.py| 18 +++---
scripts/qapi.py | 16
3 files changed, 21 insertions(+), 24 deletions(-)
Fixes events whose data is struct with base to include the struct's
base members. Test case is qapi-schema-test.json's event
__org.qemu_x-command:
{ 'event': '__ORG.QEMU_X-EVENT', 'data': '__org.qemu_x-Struct' }
{ 'struct': '__org.qemu_x-Struct', 'base': '__org.qemu_x-Base',
'data'
Clarify how they map to JSON. Add how they map to C. Fix the
reference to StringInputVisitor.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
docs/qapi-code-gen.txt | 29 ++---
1 file changed, 18 insertions(+), 11 deletions(-)
diff --git a/docs/qapi-code-
With the previous commit, the generated marshalers just work, and save
us a bit of handwritten code.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
include/monitor/monitor.h | 3 ---
qapi-schema.json | 9 +++--
qmp-commands.hx | 6 +++---
qmp.c
The effect of the next few patches on generated files is hard to
review, because stuff gets generated in different order, which renders
diffs of the generated files useless.
To get reviewable diffs, we need to split the generated files into
suitable parts: put every top-level declaration in a file
This reverts commit 7aa8d05011251e777ad72241ec8919f73d8d8273.
Signed-off-by: Markus Armbruster
---
scripts/qapi-commands.py | 7 ---
scripts/qapi-event.py| 12
scripts/qapi-types.py| 18 --
scripts/qapi-visit.py| 12
scripts/qapi.py
How many bits we use internally is an implementation detail. It could
be pressed into external interface service as a very approximate range
information, but that's probably a bad idea. If we need range
information, we better do it properly.
Reduces output of query-schema by a negligible 0.5 out
Duplicated in commit 21cd70d. Yes, we can't import qapi-types, but
that's no excuse. Move the helpers from qapi-types.py to qapi.py, and
replace the duplicates in qapi-event.py.
The generated event enumeration type's lookup table becomes
const-correct (see commit 2e4450f), and uses explicit inde
New methods c_name(), c_type(), c_null(), json_type(),
alternate_qtype().
Signed-off-by: Markus Armbruster
---
scripts/qapi.py | 72 +++--
1 file changed, 65 insertions(+), 7 deletions(-)
diff --git a/scripts/qapi.py b/scripts/qapi.py
index 34
I want to name a new class QAPISchema.
While there, make it a new-style class.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
scripts/qapi.py | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/scripts/qapi.py b/scripts/qapi.py
index 56efb18..6297656 10064
This reverts commit c5790fa910530f82cb605778bcd74318c9290279.
Signed-off-by: Markus Armbruster
---
scripts/qapi-types.py | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py
index 124a788..d162ca2 100644
--- a/scrip
On 29 July 2015 at 12:54, Pavel Fedin wrote:
> Just speficying ops = NULL in some cases can be more convenient than having
> two functions.
>
> Signed-off-by: Pavel Fedin
> Acked-by: Paolo Bonzini
Reviewed-by: Peter Maydell
thanks
-- PMM
On Tue, Aug 4, 2015 at 4:40 PM, Peter Maydell wrote:
> * Can we as a project do more to advertise the features
>and improvements we make?
The QEMU Google+ page can do Hangouts On Air video streaming.
Community members can give presentations or tutorials that will be
archived on YouTube. Liv
On 4 August 2015 at 16:50, Eduardo Habkost wrote:
> On Tue, Aug 04, 2015 at 04:41:44PM +0100, Peter Maydell wrote:
>> On 4 August 2015 at 16:10, Michael S. Tsirkin wrote:
>> > On Tue, Aug 04, 2015 at 04:27:53PM +0200, Andreas Färber wrote:
>> >> Am 04.08.2015 um 16:17 schrieb Radim Krčmář:
>> >>
object if I just apply it to master? I'd like to get
> the next rc out today or tomorrow and I'm not sure we have
> any other outstanding for-2.4 fixes...
No problem. If you want to, I have just published a signed tag ready for
pulling:
-
The following changes
On Tue, Aug 04, 2015 at 04:41:44PM +0100, Peter Maydell wrote:
> On 4 August 2015 at 16:10, Michael S. Tsirkin wrote:
> > On Tue, Aug 04, 2015 at 04:27:53PM +0200, Andreas Färber wrote:
> >> Am 04.08.2015 um 16:17 schrieb Radim Krčmář:
> >> > Previous patch changed xlevel and missed the compatibil
On 29 July 2015 at 12:54, Pavel Fedin wrote:
> This small inline returns correct GIC class name depending on whether we
> use KVM acceleration or not. Avoids duplicating the condition everywhere.
>
> Signed-off-by: Pavel Fedin
> ---
> hw/arm/virt.c| 7 +++
> hw/cpu/a15mpcore.c | 8
On 29 July 2015 at 12:54, Pavel Fedin wrote:
> Extracted duplicated initialization code from SW-emulated and KVM GIC
> implementations and put into gic_init_irqs_and_mmio()
>
> Signed-off-by: Pavel Fedin
> @@ -1110,28 +1090,19 @@ static void arm_gic_realize(DeviceState *dev, Error
> **errp)
>
Markus Armbruster writes:
> Commit 05dfb26 added eatspace stripping to mcgen(). Move it to
> cgen(), just in case somebody gets tempted to use cgen() directly
> instead of via mcgen().
>
> cgen() indents blank lines. No such lines get generated right now,
> but fix it anyway.
>
> We use triple-
1 - 100 of 245 matches
Mail list logo
