On 08/04/2015 09:57 AM, Markus Armbruster wrote: > New methods c_name(), c_type(), c_null(), json_type(), > alternate_qtype(). > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > scripts/qapi.py | 72 > +++++++++++++++++++++++++++++++++++++++++++++++++++------ > 1 file changed, 65 insertions(+), 7 deletions(-) >
> def _def_predefineds(self):
> - for t in ['str', 'number', 'int', 'int8', 'int16', 'int32', 'int64',
> - 'uint8', 'uint16', 'uint32', 'uint64', 'size', 'bool',
> '**']:
> - self._def_builtin_type(t)
> + for t in [('str', 'string', 'char' + pointer_suffix, 'NULL'),
> + ('number', 'number', 'double', '0'),
So neither of us argued strongly enough for using '0.0' as the preferred
initializer for a double :)
The real fix compared to v2 was the handling of an empty enum, and that
looks correct.
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
