Re: [Qemu-devel] [PATCH 4/4] arm: enable Bochs PCI VGA

2015-01-06 Thread Paolo Bonzini
On 06/01/2015 22:42, Alexander Graf wrote: > I've not moved CIRRUS or QXL yet though. When I tried, cirrus didn't > work - it probably needs access to the legacy VGA regions that don't get > mapped with the gpex phb. Yes, Bochs VGA has the registers-in-BAR thing, so it always works. Paolo

Re: [Qemu-devel] [PATCH 0/6] relicense QEMU softfloat from 2b to to 2a

2015-01-06 Thread Paolo Bonzini
On 25/11/2014 15:17, Peter Maydell wrote: > Questions for review: > * can we do the git cherry-pick thing I mention above? I'm afraid that would double the size of the repository (in terms of number of commits). One possibility is this: git checkout 158142c2 git cherry-pick this-serie

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/1] Do not hang on full PTY

2015-01-06 Thread Paolo Bonzini
On 30/12/2014 00:41, Peter Maydell wrote: > On 29 December 2014 at 20:27, Don Slutz wrote: >> I was not sure on this being trivial also, but it looked like it could >> be to me. The uses of this FD all looked that they handle non-blocking. > > Does g_io_channel_read_chars() definitely return G

Re: [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash

2015-01-06 Thread Paolo Bonzini
On 06/01/2015 22:54, Alexander Graf wrote: > > > On 06.01.15 21:41, Paolo Bonzini wrote: >> >> >> On 06/01/2015 20:48, Paolo Bonzini wrote: >>> I like the way you structured the series! >>> >>> Reviewed-by: Paolo Bonzini >> >> Hmm, actually doesn't this break -machine usb=no? > > I think it d

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-06 Thread Paolo Bonzini
On 07/01/2015 00:57, Programmingkid wrote: > Just curious, if someone installed a cirrus vga video card into a > PowerMac with Mac OS 10.2 installed, and it had the same color issue > that QEMU has, would you be convinced that this problem is an issue > with Mac OS X? G 3 replied that he's not u

Re: [Qemu-devel] [PATCH] vfio-pci: Fix BAR size overflow

2015-01-06 Thread Alex Williamson
- Original Message - > On 01/06/15 19:03, Alex Williamson wrote: > > We use an unsigned int when working with the PCI BAR size, which can > > obviously overflow if the BAR is 4GB or larger. This needs to change > > to an unsigned long. A similar issue is possible, though even more > > unl

Re: [Qemu-devel] [PATCH v3 0/13] migration: Add a new feature to do live migration

2015-01-06 Thread Li, Liang Z
Hi All, Have you returned from vacation? If so, could you help to review my patches I have submitted three weeks ago? Thanks a lot. Liang > -Original Message- > From: Li, Liang Z > Sent: Friday, December 12, 2014 9:29 AM > To: qemu-devel@nongnu.org > Cc: quint...@redhat.com; lcapit

Re: [Qemu-devel] [PATCH] vfio-pci: Fix BAR size overflow

2015-01-06 Thread Don Slutz
On 01/06/15 19:03, Alex Williamson wrote: We use an unsigned int when working with the PCI BAR size, which can obviously overflow if the BAR is 4GB or larger. This needs to change to an unsigned long. A similar issue is possible, though even more unlikely, when mapping the region above an MSI-X

[Qemu-devel] [Bug 1408152] Re: latest qemu git doesn't load

2015-01-06 Thread Tiejun Chen
This issue seems to be similar to 1406706 and 1407454. Looks Marcel is working on a fix, and he also posted something to first address USB stuff, https://www.mail-archive.com/qemu-devel@nongnu.org/msg272607.html -- You received this bug notification because you are a member of qemu- devel-ml, wh

Re: [Qemu-devel] [RFC][PATCH] qemu_opt_get_bool_helper: back finding desc by name just if !opt->desc

2015-01-06 Thread Chen, Tiejun
On 2015/1/6 22:56, Stefan Hajnoczi wrote: On Tue, Jan 06, 2015 at 10:39:13AM +0800, Chen, Tiejun wrote: On 2015/1/6 9:21, Chen, Tiejun wrote: On 2015/1/6 1:13, Eric Blake wrote: On 01/04/2015 10:35 PM, Tiejun Chen wrote: After one commit 49d2e648e808, "machine: remove qemu_machine_opts global

[Qemu-devel] [Bug 1408152] Re: latest qemu git doesn't load

2015-01-06 Thread Nigel Horne
Seems to be failing to parse kernel_irqchip=on correctly. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1408152 Title: latest qemu git doesn't load Status in QEMU: New Bug description: commit

[Qemu-devel] [PATCH] vfio-pci: Fix BAR size overflow

2015-01-06 Thread Alex Williamson
We use an unsigned int when working with the PCI BAR size, which can obviously overflow if the BAR is 4GB or larger. This needs to change to an unsigned long. A similar issue is possible, though even more unlikely, when mapping the region above an MSI-X table. The start of the table must be belo

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-06 Thread Programmingkid
Just curious, if someone installed a cirrus vga video card into a PowerMac with Mac OS 10.2 installed, and it had the same color issue that QEMU has, would you be convinced that this problem is an issue with Mac OS X?

[Qemu-devel] [Bug 1408152] [NEW] latest qemu git doesn't load

2015-01-06 Thread Nigel Horne
Public bug reported: commit ab0302ee764fd702465aef6d88612cdff4302809This is with qemu-system-x86_64: util/qemu-option.c:387: qemu_opt_get_bool_helper: Assertion `opt->desc && opt->desc->type == QEMU_OPT_BOOL' failed. /home/njh/bin/kfreebsd-amd64: line 7: 32549 Aborted (core dump

[Qemu-devel] [PATCH v3 1/2] zynq_gpio: GPIO model for Zynq SoC

2015-01-06 Thread Colin Leitner
Based on the pl061 model. This model implements all four banks with 32 I/Os each. The I/Os are placed in named groups: * bankX_in for the 32 inputs of each bank * bankX_out for the 32 outputs of each bank Basic I/O and IRQ support tested with the Zynq GPIO driver in Linux 3.12. Signed-off-by:

[Qemu-devel] [PATCH v3 2/2] xilinx_zynq: Add zynq-gpio to the machine

2015-01-06 Thread Colin Leitner
Signed-off-by: Colin Leitner --- hw/arm/xilinx_zynq.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c index 06e6e24..6d8c0d9 100644 --- a/hw/arm/xilinx_zynq.c +++ b/hw/arm/xilinx_zynq.c @@ -202,6 +202,8 @@ static void zynq_init(MachineState *ma

[Qemu-devel] [PATCH v3 0/2] Reworked Zynq GPIO model

2015-01-06 Thread Colin Leitner
Hello everyone, this is the third version of the Zynq GPIO model patch. It includes * mostly code cleanup (variable naming, removed unneeded casts, added some local vars for better readability) * moved zynq-gpio.h to include/hw/gpio * enhancement in the reset/init logic to ensure that reset

Re: [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash

2015-01-06 Thread Alexander Graf
On 06.01.15 21:41, Paolo Bonzini wrote: > > > On 06/01/2015 20:48, Paolo Bonzini wrote: >> I like the way you structured the series! >> >> Reviewed-by: Paolo Bonzini > > Hmm, actually doesn't this break -machine usb=no? I think it does, but I don't think we really need to care. We can just a

Re: [Qemu-devel] [PATCH 1/6] hw/ppc: modified the condition for usb controllers to be created for some ppc machines

2015-01-06 Thread Alexander Graf
On 06.01.15 14:29, Marcel Apfelbaum wrote: > Some ppc machines create a default usb controller based on a 'machine > condition'. > Until now the logic was: create the usb controller if: > - the usb option was supplied in cli and value is true or > - the usb option was absent and both set_def

Re: [Qemu-devel] [PATCH 4/4] arm: enable Bochs PCI VGA

2015-01-06 Thread Alexander Graf
On 06.01.15 22:28, Peter Maydell wrote: > On 6 January 2015 at 21:08, Alexander Graf wrote: >> On 06.01.15 17:16, Peter Maydell wrote: >>> On 6 January 2015 at 16:03, Alexander Graf wrote: +CONFIG_VGA_PCI=y >>> >>> Why isn't this just in pci.mak like all the other PCI devices? >> >> Honest

[Qemu-devel] [Bug 1274170] Re: qemu window hides in the background on osx

2015-01-06 Thread Stefan Weil
** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1274170 Title: qemu window hides in the background on osx Status in QEMU: Confirmed Bug descrip

[Qemu-devel] [Bug 1404278] Re: tap connections not working on windows host

2015-01-06 Thread timsoft
I have also run the 64bit version of qemu with the slight modification of the batch/cmd line cd "c:\program files\qemu" qemu-system-x86_64w.exe -m 512 -net nic -net tap,ifname=tap01 -hda "c:\\data\\images\\test.img" and get the same output both for the client(ip addr; ip route; ip tables -L -n

Re: [Qemu-devel] [PATCH v3 1/5] QJSON: Add JSON writer

2015-01-06 Thread Alexander Graf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06.01.15 16:41, Eric Blake wrote: > On 12/26/2014 07:42 AM, Alexander Graf wrote: >> To support programmatic JSON assembly while keeping the code that >> generates it readable, this patch introduces a simple JSON >> writer. It emits JSON serially

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-06 Thread G 3
I start the guest like this: qemu-system-ppc -hdd ~/machd.img -boot c -prom-env boot-args=-v Hope this is what you wanted: 00:00.0 Host bridge: Motorola MPC106 [Grackle] (prog-if 01) Subsystem: Qumranet, Inc. Device 1100 Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop-

Re: [Qemu-devel] [PATCH v3 5/5] Add migration stream analyzation script

2015-01-06 Thread Alexander Graf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06.01.15 17:05, Eric Blake wrote: > On 12/26/2014 07:42 AM, Alexander Graf wrote: >> This patch adds a python tool to the scripts directory that can >> read a dumped migration stream if it contains the JSON >> description of the device states. I c

Re: [Qemu-devel] [PATCH 4/4] arm: enable Bochs PCI VGA

2015-01-06 Thread Peter Maydell
On 6 January 2015 at 21:08, Alexander Graf wrote: > On 06.01.15 17:16, Peter Maydell wrote: >> On 6 January 2015 at 16:03, Alexander Graf wrote: >>> +CONFIG_VGA_PCI=y >> >> Why isn't this just in pci.mak like all the other PCI devices? > > Honestly, I have no idea. Maybe Michael knows? But if eve

Re: [Qemu-devel] [PATCH v3 4/5] migration: Append JSON description of migration stream

2015-01-06 Thread Alexander Graf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06.01.15 16:56, Eric Blake wrote: > On 12/26/2014 07:42 AM, Alexander Graf wrote: >> One of the annoyances of the current migration format is the fact >> that it's not self-describing. In fact, it's not properly >> describing at all. Some code ran

[Qemu-devel] [Bug 1404278] Re: tap connections not working on windows host

2015-01-06 Thread timsoft
output as requested from the guest: ip addr 1: lo: mtu 65536 qdisc noqueue state UNKOWN link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 inet 127.0.0.1/8 scope host lo valid_lft forever preferred_lft forever inet6 ::1/128 scope host valid_lft forever preferred_lft f

Re: [Qemu-devel] [PATCH v3 2/5] QJSON: Add JSON writer

2015-01-06 Thread Alexander Graf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06.01.15 16:44, Eric Blake wrote: > On 12/26/2014 07:42 AM, Alexander Graf wrote: >> To support programmatic JSON assembly while keeping the code that >> generates it readable, this patch introduces a simple JSON >> writer. It emits JSON serially

Re: [Qemu-devel] [PATCH 4/4] arm: enable Bochs PCI VGA

2015-01-06 Thread Alexander Graf
On 06.01.15 17:16, Peter Maydell wrote: > On 6 January 2015 at 16:03, Alexander Graf wrote: >> Some ARM platforms can successfully map PCI devices into the guest, so it >> only >> makes sense to also add support for the Bochs virtual VGA adapter on those. >> >> Signed-off-by: Alexander Graf >>

Re: [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic

2015-01-06 Thread Paolo Bonzini
On 06/01/2015 14:29, Marcel Apfelbaum wrote: > @@ -1484,9 +1484,10 @@ static void ppc_spapr_init(MachineState *machine) > /* Graphics */ > if (spapr_vga_init(phb->bus)) { > spapr->has_graphics = true; > +machine->usb |= defaults_enabled(); > } Could the solution b

Re: [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash

2015-01-06 Thread Paolo Bonzini
On 06/01/2015 20:48, Paolo Bonzini wrote: > I like the way you structured the series! > > Reviewed-by: Paolo Bonzini Hmm, actually doesn't this break -machine usb=no? Paolo

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-06 Thread Paolo Bonzini
On 06/01/2015 19:07, Programmingkid wrote: > http://www.mcamafia.de/pdf/ibm_vgaxga_trm2.pdf This file is the > specifications to the VGA standard. It makes no mention of pixel > endian format. There is no mention of bit order in the > specifications. It's probably assumed to be little endian. Th

Re: [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash

2015-01-06 Thread Paolo Bonzini
On 06/01/2015 14:29, Marcel Apfelbaum wrote: > Patch e79d5a6 ("machine: remove qemu_machine_opts global list") removed option > descriptions from the -machine QemuOptsList to avoid repeating MachineState's > QOM properties. > > This resulted in a Qemu crash: > $ qemu-system-x86_64 -usb > qemu-s

Re: [Qemu-devel] qemu sources and makefile system

2015-01-06 Thread Paolo Bonzini
On 06/01/2015 13:25, Vasile Catalin-B50542 wrote: > I'm new to qemu-devel and I'm trying to add a ".c" source to qemu. > To be more specific, I'm trying to add a file into src>/hw/virtio/. I've added "common-obj-y += virtio-src.o" to the > src>Makefile.objs in that folder > and when I'm compilin

Re: [Qemu-devel] [PATCH] vl.c: fix regression when reading machine type from config file

2015-01-06 Thread Paolo Bonzini
On 06/01/2015 18:41, Marcel Apfelbaum wrote: > After 'Machine as QOM' series the machine type input triggers > the creation of the machine class. > If the machine type is set in the configuration file, the machine > class is not updated accordingly and remains the default. > > Fixed that by quer

Re: [Qemu-devel] [PATCH v8 3/3] hw/arm/virt: add dynamic sysbus device support

2015-01-06 Thread Peter Maydell
On 5 January 2015 at 16:14, Eric Auger wrote: > Allows sysbus devices to be instantiated from command line by > using -device option. Machvirt creates a platform bus at init. > The dynamic sysbus devices are attached to this platform bus device. > @@ -59,6 +61,8 @@ > #define GIC_FDT_IRQ_PPI_CPU_

Re: [Qemu-devel] [PATCH] char: disable stdio echo on resume from suspend.

2015-01-06 Thread Gal Hammer
- Original Message - > From: "Peter Maydell" > To: "Gal Hammer" > Cc: "Paolo Bonzini" , "QEMU Developers" > > Sent: Tuesday, January 6, 2015 4:36:19 PM > Subject: Re: [Qemu-devel] [PATCH] char: disable stdio echo on resume from > suspend. > > On 6 January 2015 at 14:30, Gal Hamme

Re: [Qemu-devel] [PATCH v8 1/3] hw/arm/sysbus-fdt: helpers for platform bus nodes addition

2015-01-06 Thread Peter Maydell
On 5 January 2015 at 16:14, Eric Auger wrote: > This new C module will be used by ARM machine files to generate > platform bus node and their dynamic sysbus device tree nodes. > > Dynamic sysbus device node addition is done in a machine init > done notifier. arm_register_platform_bus_fdt_creator d

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-06 Thread Programmingkid
https://opensource.apple.com/source/IOGraphics/IOGraphics-45.3/IOGraphicsFamily/IOBootFramebuffer.cpp This file is used for the frame buffer in Mac OS 10.2. There is no mention of the endian format for the pixels. That seems to indicate an oversight on Apple's part. http://www.mcamafia.de/pdf/i

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-06 Thread Programmingkid
On Jan 6, 2015, at 12:30 PM, Peter Maydell wrote: > On 6 January 2015 at 17:19, Programmingkid wrote: >> After investigating the TARGET_WORDS_BIGENDIAN code, I noticed >> that s->default_endian_fb was being set to true. So I undefined >> the macro and then ran QEMU. The i386 target showed no cha

Re: [Qemu-devel] [PATCH] block: limited request size in write zeroes unsupported path

2015-01-06 Thread Denis V. Lunev
On 06/01/15 18:43, Stefan Hajnoczi wrote: On Mon, Jan 05, 2015 at 03:34:07PM +0300, Denis V. Lunev wrote: Though pls consider my patch v3, it avoids allocation of 16 Mb here and uses only 1 Mb of memory. Once your patch has Reviewed-by: it will show up on my radar for merge. If you and Peter

[Qemu-devel] [PATCH v2 11/12] block/dmg: support bzip2 block entry types

2015-01-06 Thread Peter Wu
This patch adds support for bzip2-compressed block entries as introduced with OS X 10.4 (source: https://en.wikipedia.org/wiki/Apple_Disk_Image). It was tested against a 5.2G "OS X Yosemite" installation image which stores the BLXX block in the XML property list (instead of resource forks) and has

Re: [Qemu-devel] [PATCH v8 2/3] hw/arm/boot: arm_load_kernel implemented as a machine init done notifier

2015-01-06 Thread Peter Maydell
On 5 January 2015 at 16:14, Eric Auger wrote: > Device tree nodes for the platform bus and its children dynamic sysbus > devices are added in a machine init done notifier. To load the dtb once, > after those latter nodes are built and before ROM freeze, the actual > arm_load_kernel existing code i

[Qemu-devel] [PATCH v2 02/12] block/dmg: extract mish block decoding functionality

2015-01-06 Thread Peter Wu
Extract the mish block decoder such that this can be used for other formats in the future. A new DmgHeaderState struct is introduced to share state while decoding. The code is kept unchanged as much as possible, a "fail" label is added for example where a simple return would probably do. In dmg_op

[Qemu-devel] [PATCH v2 12/12] block/dmg: improve zeroes handling

2015-01-06 Thread Peter Wu
Disk images may contain large all-zeroes gaps (1.66k sectors or 812 MiB is seen in the real world). These blocks (type 2) do not need to be extracted into a temporary buffer, there is no need to allocate memory for these blocks nor to check its length. (For the test image, the maximum uncompressed

[Qemu-devel] [PATCH v2 10/12] block/dmg: factor out block type check

2015-01-06 Thread Peter Wu
In preparation for adding bzip2 support, split the type check into a separate function. Make all offsets relative to the begin of a chunk such that it is easier to recognize the position without having to add up all offsets. Some comments are added to describe the fields. There is no functional ch

[Qemu-devel] [PATCH v2 03/12] block/dmg: extract processing of resource forks

2015-01-06 Thread Peter Wu
Besides the offset, also read the resource length. This length is now used in the extracted function to verify the end of the resource fork against "count" from the resource fork. Instead of relying on the value of offset to conclude whether the resource fork is available or not (info_begin==0), c

[Qemu-devel] [PATCH v2 06/12] block/dmg: process XML plists

2015-01-06 Thread Peter Wu
The format is simple enough to avoid using a full-blown XML parser. It assumes that all BLKX items begin with the "mish" magic word, therefore it is not a problem if other values get matched which are not a BLKX block. The offsets are based on the description at http://newosxbook.com/DMG.html Sig

[Qemu-devel] [PATCH v2 07/12] block/dmg: set virtual size to a non-zero value

2015-01-06 Thread Peter Wu
Right now the virtual size is always reported as zero which makes it impossible to convert between formats. After this patch, the number of sectors will be read from the trailer ("koly" block). To verify the behavior, the output of `dmg2img foo.dmg foo.img` was compared against `qemu-img convert

[Qemu-devel] [PATCH v2 08/12] block/dmg: fix sector data offset calculation

2015-01-06 Thread Peter Wu
This patch addresses two issues: - The data fork offset was not taken into account, resulting in failure to read an InstallESD.dmg file (5164763151 bytes) which had a non-zero DataForkOffset field. - The offset of the previous block ("partition") was unconditionally added to the current

[Qemu-devel] [PATCH v2 09/12] block/dmg: use SectorNumber from BLKX header

2015-01-06 Thread Peter Wu
Previously the sector table parsing relied on the previous offset of the DMG file. Now it uses the sector number from the BLKX header (see http://newosxbook.com/DMG.html). The implementation of dmg2img (from vu1tur) does not base the output sector on the location of the terminator (0x) eit

[Qemu-devel] [PATCH v2 01/12] block/dmg: properly detect the UDIF trailer

2015-01-06 Thread Peter Wu
DMG files have a variable length with a UDIF trailer at the end of a file. This UDIF trailer is essential as it describes the contents of the image. At the moment however, the start of this trailer is almost always incorrect as bdrv_getlength() returns a multiple of the block size (rounded up). Thi

[Qemu-devel] [PATCH v2 00/12] block/dmg: (compatibility) fixes and bzip2 support

2015-01-06 Thread Peter Wu
Hi, This is the second revision of improvements to DMG image file support. See [1] for an overview of the previous patchset. Thanks to John Snow for his efforts in reviewing patches and providing suggestions. The errp suggestion from Stefan Hajnoczi is also incorporated. An overview of changes s

[Qemu-devel] [PATCH v2 05/12] block/dmg: validate chunk size to avoid overflow

2015-01-06 Thread Peter Wu
Previously the chunk size was not checked, allowing for a large memory allocation. This patch checks whether the chunks size is within the resource fork length, and whether the resource fork is below the trailer of the dmg file. Signed-off-by: Peter Wu --- v2: added resource fork offset check --

[Qemu-devel] [PATCH v2 04/12] block/dmg: process a buffer instead of reading ints

2015-01-06 Thread Peter Wu
As the decoded plist XML is not a pointer in the file, dmg_read_mish_block must be able to process a buffer instead of a file pointer. Since the full buffer must be processed, let's change the return value again to just a success flag. Signed-off-by: Peter Wu Reviewed-by: John Snow --- v2: adde

[Qemu-devel] [PATCH] vl.c: fix regression when reading machine type from config file

2015-01-06 Thread Marcel Apfelbaum
After 'Machine as QOM' series the machine type input triggers the creation of the machine class. If the machine type is set in the configuration file, the machine class is not updated accordingly and remains the default. Fixed that by querying the machine options after the configuration file is lo

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-06 Thread Peter Maydell
On 6 January 2015 at 17:19, Programmingkid wrote: > After investigating the TARGET_WORDS_BIGENDIAN code, I noticed > that s->default_endian_fb was being set to true. So I undefined > the macro and then ran QEMU. The i386 target showed no change > in colors. The ppc target still had the same incorr

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-06 Thread Programmingkid
On Jan 6, 2015, at 11:46 AM, Peter Maydell wrote: > On 6 January 2015 at 16:30, Programmingkid wrote: >> I was doing some searching and thought I should show you this: >> file: vga.c >> >> This indicates that all operations are expected to be in the little endian >> format. > > That controls

[Qemu-devel] [PATCH v2] target-openrisc: bugfix for dec_sys to decode instructions correctly

2015-01-06 Thread David Morrison
Fixed the decoding of "system" instructions (starting with 0x2) in dec_sys() in translate.c. In particular, the l.trap instruction is now correctly decoded, which enables for singlestepping and breakpoints to be set in GDB. Signed-off-by: David R. Morrison --- target-openrisc/translate.c | 2 +-

Re: [Qemu-devel] [PATCH] vl.c: fix -usb option assertion failure in qemu_opt_get_bool_helper()

2015-01-06 Thread Marcel Apfelbaum
On 01/06/2015 11:01 AM, Chen, Tiejun wrote: On 2015/1/6 14:20, Shannon Zhao wrote: On 2015/1/6 10:37, Chen, Tiejun wrote: On 2015/1/5 20:14, Marcel Apfelbaum wrote: On 01/05/2015 01:50 PM, Stefan Hajnoczi wrote: On Mon, Jan 5, 2015 at 11:37 AM, Jan Kiszka wrote: On 2015-01-05 12:22, Stefan

Re: [Qemu-devel] [RFC][PATCH] qemu_opt_get_bool_helper: back finding desc by name just if !opt->desc

2015-01-06 Thread Marcel Apfelbaum
On 01/06/2015 04:56 PM, Stefan Hajnoczi wrote: On Tue, Jan 06, 2015 at 10:39:13AM +0800, Chen, Tiejun wrote: On 2015/1/6 9:21, Chen, Tiejun wrote: On 2015/1/6 1:13, Eric Blake wrote: On 01/04/2015 10:35 PM, Tiejun Chen wrote: After one commit 49d2e648e808, "machine: remove qemu_machine_opts g

Re: [Qemu-devel] [PATCH v2 07/10] rocker: add new rocker switch device

2015-01-06 Thread Scott Feldman
On Tue, Jan 6, 2015 at 7:12 AM, Stefan Hajnoczi wrote: > On Mon, Jan 05, 2015 at 06:24:58PM -0800, sfel...@gmail.com wrote: >> From: Scott Feldman >> >> Rocker is a simulated ethernet switch device. The device supports up to 62 >> front-panel ports and supports L2 switching and L3 routing functi

Re: [Qemu-devel] [PATCH 4/4] arm: enable Bochs PCI VGA

2015-01-06 Thread Peter Maydell
On 6 January 2015 at 16:03, Alexander Graf wrote: > Some ARM platforms can successfully map PCI devices into the guest, so it only > makes sense to also add support for the Bochs virtual VGA adapter on those. > > Signed-off-by: Alexander Graf > --- > default-configs/arm-softmmu.mak | 1 + > 1 fi

[Qemu-devel] [PATCH 1/4] pci: Split pcie_host_mmcfg_map()

2015-01-06 Thread Alexander Graf
The mmcfg space is a memory region that allows access to PCI config space in the PCIe world. To maintain abstraction layers, I would like to expose the mmcfg space as a sysbus mmio region rather than have it mapped straight into the system's memory address space though. So this patch splits the in

Re: [Qemu-devel] [PATCH v3 5/5] Add migration stream analyzation script

2015-01-06 Thread Eric Blake
On 12/26/2014 07:42 AM, Alexander Graf wrote: > This patch adds a python tool to the scripts directory that can read > a dumped migration stream if it contains the JSON description of the > device states. I constructs a human readable JSON stream out of it. > > It's very simple to use: > > $ qe

[Qemu-devel] [PATCH 2/4] pci: Add generic PCIe host bridge

2015-01-06 Thread Alexander Graf
With simple exposure of MMFG, ioport window, mmio window and an IRQ line we can successfully create a workable PCIe host bridge that can be mapped anywhere and only needs to get described to the OS using whatever means it likes. This patch implements such a "generic" host bridge. It only supports

[Qemu-devel] [PATCH 0/4] ARM: Add support for a generic PCI Express host bridge

2015-01-06 Thread Alexander Graf
Linux implements a nice binding to describe a "generic" PCI Express host bridge using only device tree. This patch set adds enough emulation logic to expose the parts that are "generic" as a simple sysbus device and maps it into ARM's virt machine. With this patch set, we can finally spawn PCI de

[Qemu-devel] [PATCH 3/4] arm: Add PCIe host bridge in virt machine

2015-01-06 Thread Alexander Graf
Now that we have a working "generic" PCIe host bridge driver, we can plug it into ARMs virt machine to always have PCIe available to normal ARM VMs. I've successfully managed to expose a Bochs VGA device, XHCI and an e1000 into an AArch64 VM with this and they all lived happily ever after. Signed

[Qemu-devel] [PATCH 4/4] arm: enable Bochs PCI VGA

2015-01-06 Thread Alexander Graf
Some ARM platforms can successfully map PCI devices into the guest, so it only makes sense to also add support for the Bochs virtual VGA adapter on those. Signed-off-by: Alexander Graf --- default-configs/arm-softmmu.mak | 1 + 1 file changed, 1 insertion(+) diff --git a/default-configs/arm-sof

Re: [Qemu-devel] [PATCH v3 4/5] migration: Append JSON description of migration stream

2015-01-06 Thread Eric Blake
On 12/26/2014 07:42 AM, Alexander Graf wrote: > One of the annoyances of the current migration format is the fact that > it's not self-describing. In fact, it's not properly describing at all. > Some code randomly scattered throughout QEMU elaborates roughly how to > read and write a stream of byte

Re: [Qemu-devel] [PATCH v3 3/5] qemu-file: Add fast ftell code path

2015-01-06 Thread Eric Blake
On 12/26/2014 07:42 AM, Alexander Graf wrote: > For ftell we flush the output buffer to ensure that we don't have anything > lingering in our internal buffers. This is a very safe thing to do. > > However, with the dynamic size measurement that the dynamic vmstate > description will bring this wou

Re: [Qemu-devel] [PATCH v3 2/5] QJSON: Add JSON writer

2015-01-06 Thread Eric Blake
On 12/26/2014 07:42 AM, Alexander Graf wrote: > To support programmatic JSON assembly while keeping the code that generates it > readable, this patch introduces a simple JSON writer. It emits JSON serially > into a buffer in memory. > > The nice thing about this writer is its simplicity and low me

Re: [Qemu-devel] [PATCH] block: limited request size in write zeroes unsupported path

2015-01-06 Thread Stefan Hajnoczi
On Mon, Jan 05, 2015 at 03:34:07PM +0300, Denis V. Lunev wrote: > Though pls consider my patch v3, it avoids allocation of 16 Mb here and > uses only 1 Mb of memory. Once your patch has Reviewed-by: it will show up on my radar for merge. If you and Peter need a 2nd opinion in your discussions abo

Re: [Qemu-devel] [PATCH] block: limited request size in write zeroes unsupported path

2015-01-06 Thread Stefan Hajnoczi
On Mon, Jan 05, 2015 at 12:29:49PM +0100, Peter Lieven wrote: > If bs->bl.max_write_zeroes is large and we end up in the unsupported > path we might allocate a lot of memory for the iovector and/or even > generate an oversized requests. > > Fix this by limiting the request by the minimum of the re

Re: [Qemu-devel] [PATCH v3 1/5] QJSON: Add JSON writer

2015-01-06 Thread Eric Blake
On 12/26/2014 07:42 AM, Alexander Graf wrote: > To support programmatic JSON assembly while keeping the code that generates it > readable, this patch introduces a simple JSON writer. It emits JSON serially > into a buffer in memory. > > The nice thing about this writer is its simplicity and low me

Re: [Qemu-devel] [PATCH v2 0/7] coroutine: optimizations

2015-01-06 Thread Stefan Hajnoczi
On Tue, Dec 02, 2014 at 12:05:43PM +0100, Paolo Bonzini wrote: > As discussed in the other thread, this brings speedups from > dropping the coroutine mutex (which serializes multiple iothreads, > too) and using ELF thread-local storage. > > The speedup in perf/cost is about 50% (190->125). Window

Re: [Qemu-devel] [PATCH v2 08/10] qmp: add rocker device support

2015-01-06 Thread Stefan Hajnoczi
On Mon, Jan 05, 2015 at 06:24:59PM -0800, sfel...@gmail.com wrote: > From: Scott Feldman > > Add QMP/HMP support for rocker devices. This is mostly for debugging purposes > to see inside the device's tables and port configurations. Some examples: > > (qemu) rocker sw1 > name: sw1 > id: 0x0

Re: [Qemu-devel] [PATCH v2 07/10] rocker: add new rocker switch device

2015-01-06 Thread Stefan Hajnoczi
On Mon, Jan 05, 2015 at 06:24:58PM -0800, sfel...@gmail.com wrote: > From: Scott Feldman > > Rocker is a simulated ethernet switch device. The device supports up to 62 > front-panel ports and supports L2 switching and L3 routing functions, as well > as L2/L3/L4 ACLs. The device presents a singl

Re: [Qemu-devel] [PATCH v4] block/raw-posix.c: Fixes raw_getlength() on Mac OS X so that it reports the correct length of a real CD

2015-01-06 Thread Programmingkid
On Jan 6, 2015, at 9:02 AM, Stefan Hajnoczi wrote: > On Fri, Jan 02, 2015 at 04:44:38PM -0500, Programmingkid wrote: >> Removes redundant ret variable and renames sectorSize variable to meet QEMU >> coding standards. > > This is a changelog item for v4 of this patch. Changelogs should go > be

Re: [Qemu-devel] [PATCH] vl.c: fix -usb option assertion failure in qemu_opt_get_bool_helper()

2015-01-06 Thread Stefan Hajnoczi
On Tue, Jan 06, 2015 at 10:37:25AM +0800, Chen, Tiejun wrote: > On 2015/1/5 20:14, Marcel Apfelbaum wrote: > >On 01/05/2015 01:50 PM, Stefan Hajnoczi wrote: > >>On Mon, Jan 5, 2015 at 11:37 AM, Jan Kiszka > >>wrote: > >>>On 2015-01-05 12:22, Stefan Hajnoczi wrote: > Commit 49d2e648e8087d154d8b

Re: [Qemu-devel] [RFC][PATCH] qemu_opt_get_bool_helper: back finding desc by name just if !opt->desc

2015-01-06 Thread Stefan Hajnoczi
On Tue, Jan 06, 2015 at 10:39:13AM +0800, Chen, Tiejun wrote: > On 2015/1/6 9:21, Chen, Tiejun wrote: > >On 2015/1/6 1:13, Eric Blake wrote: > >>On 01/04/2015 10:35 PM, Tiejun Chen wrote: > >>>After one commit 49d2e648e808, "machine: remove qemu_machine_opts > >>>global list", is introduced, QEMU d

Re: [Qemu-devel] [PATCH v4 0/7] tests: Add check-block to "make check"

2015-01-06 Thread Stefan Hajnoczi
On Sun, Jan 04, 2015 at 09:53:45AM +0800, Fam Zheng wrote: > qemu-iotests contains useful tests that have a nice coverage of block layer > code. Adding check-block (which calls tests/qemu-iotests-quick.sh) to "make > check" is good for developers' self-testing. > > v4: 06: Use CONFIG_LINUX instead

Re: [Qemu-devel] [Xen-devel] [v3 1/5] Qemu-Xen-vTPM: Support for Xen stubdom vTPM command line options

2015-01-06 Thread Xu, Quan
> -Original Message- > From: xen-devel-boun...@lists.xen.org > [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Eric Blake > Sent: Tuesday, January 06, 2015 12:07 AM > To: Xu, Quan; qemu-devel@nongnu.org > Cc: lcapitul...@redhat.com; arm...@redhat.com; xen-de...@lists.xen.org > Subje

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-06 Thread Programmingkid
On Jan 6, 2015, at 5:04 AM, Peter Maydell wrote: > On 6 January 2015 at 09:47, Peter Maydell wrote: >> Yes, but it's basically making the user manually toggle a >> setting which we should be getting right ourselves. We >> should find out what QEMU's actually not doing correctly >> and fix that.

Re: [Qemu-devel] [PATCH] char: disable stdio echo on resume from suspend.

2015-01-06 Thread Peter Maydell
On 6 January 2015 at 14:30, Gal Hammer wrote: > On 06/01/2015 15:49, Peter Maydell wrote: >> >> On 5 January 2015 at 09:21, Gal Hammer wrote: >>> >>> The monitor's auto-completion feature stopped working when stdio is used >>> as an input and qemu was resumed after it was suspended (using ctrl-z)

Re: [Qemu-devel] [PATCH] char: disable stdio echo on resume from suspend.

2015-01-06 Thread Gal Hammer
On 06/01/2015 15:49, Peter Maydell wrote: On 5 January 2015 at 09:21, Gal Hammer wrote: The monitor's auto-completion feature stopped working when stdio is used as an input and qemu was resumed after it was suspended (using ctrl-z). Signed-off-by: Gal Hammer --- qemu-char.c | 11 +++

Re: [Qemu-devel] Custom machine configuration for QEMU

2015-01-06 Thread Peter Maydell
On 6 January 2015 at 14:20, Radha Krishna Srimanthula wrote: > If it was a symmetric CPU cluster, how do I go about creating a machine > configuration? Any pointers please? Look at an existing board model (preferably one that has been recently added or maintained) and see what it does... -- PMM

Re: [Qemu-devel] Custom machine configuration for QEMU

2015-01-06 Thread Radha Krishna Srimanthula
On Tue Jan 06 2015 at 19:30:02 Peter Maydell wrote: > On 6 January 2015 at 11:26, Radha Krishna Srimanthula > wrote: > > We have a board that has a multicore processor - an ARM9 core and a R4 > core > > - and a few peripherals around. We run embedded linux on the ARM9 core > and a > > realtime O

Re: [Qemu-devel] [PATCH v4] block/raw-posix.c: Fixes raw_getlength() on Mac OS X so that it reports the correct length of a real CD

2015-01-06 Thread Stefan Hajnoczi
On Fri, Jan 02, 2015 at 04:44:38PM -0500, Programmingkid wrote: > Removes redundant ret variable and renames sectorSize variable to meet QEMU > coding standards. This is a changelog item for v4 of this patch. Changelogs should go below the '---' line so they are not merged into git history. Th

Re: [Qemu-devel] Custom machine configuration for QEMU

2015-01-06 Thread Peter Maydell
On 6 January 2015 at 11:26, Radha Krishna Srimanthula wrote: > We have a board that has a multicore processor - an ARM9 core and a R4 core > - and a few peripherals around. We run embedded linux on the ARM9 core and a > realtime OS on the R4 core with a custom protocol providing for the > communic

[Qemu-devel] qemu sources and makefile system

2015-01-06 Thread Vasile Catalin-B50542
Hi, I'm new to qemu-devel and I'm trying to add a ".c" source to qemu. To be more specific, I'm trying to add a file into /hw/virtio/. I've added "common-obj-y += virtio-src.o" to the src>Makefile.objs in that folder and when I'm compiling qemu it seems to compile the sources, but I don't know if

[Qemu-devel] Sources and makefile system

2015-01-06 Thread Vasile Catalin-B50542
I'm new to qemu-devel and I'm trying to add a ".c" source to qemu. To be more specific, I'm trying to add a file into /hw/virtio/. I've added "common-obj-y += virtio-src.o" to the src>Makefile.objs in that folder and when I'm compiling qemu it seems to compile the sources, but I don't know if they

[Qemu-devel] Custom machine configuration for QEMU

2015-01-06 Thread Radha Krishna Srimanthula
Hi, I am posting here after searching in vain for quite sometime. Hopefully I've reached the right forum, and hope that I'll get an answer to my questions. We have a board that has a multicore processor - an ARM9 core and a R4 core - and a few peripherals around. We run embedded linux on the ARM9

[Qemu-devel] qemu sources and makefile system

2015-01-06 Thread Catalin Vasile
Hi, I'm new to qemu-devel and I'm trying to add a ".c" source to qemu. To be more specific, I'm trying to add a file into /hw/virtio/. I've added "common-obj-y += virtio-src.o" to the Makefile.objs in that folder and when I'm compiling qemu it seems to compile the sources, but I don't know if they

[Qemu-devel] qemu sources and makefile system

2015-01-06 Thread Vasile Catalin-B50542
Hi, I'm new to qemu-devel and I'm trying to add a ".c" source to qemu. To be more specific, I'm trying to add a file into /hw/virtio/. I've added "common-obj-y += virtio-src.o" to the Makefile.objs in that folder and when I'm compiling qemu it seems to compile the sources, but I don't know if

[Qemu-devel] Sources and makefile system

2015-01-06 Thread Vasile Catalin-B50542
I'm new to qemu-devel and I'm trying to add a ".c" source to qemu. To be more specific, I'm trying to add a file into /hw/virtio/. I've added "common-obj-y += virtio-src.o" to the src>Makefile.objs in that folder and when I'm compiling qemu it seems to compile the sources, but I don't know if they

[Qemu-devel] [Bug 491345] Re: remote migration fails with message "load of migration failed"

2015-01-06 Thread yogananth Subramanian
The bug can be closed since I do not have access to VM now to re-verify the issue. ** Changed in: qemu Status: Incomplete => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/491345 Titl

Re: [Qemu-devel] [PATCH] char: disable stdio echo on resume from suspend.

2015-01-06 Thread Peter Maydell
On 5 January 2015 at 09:21, Gal Hammer wrote: > The monitor's auto-completion feature stopped working when stdio is used > as an input and qemu was resumed after it was suspended (using ctrl-z). > > Signed-off-by: Gal Hammer > --- > qemu-char.c | 11 +++ > 1 file changed, 11 insertions(+

[Qemu-devel] qemu sources and makefile system

2015-01-06 Thread Catalin Vasile
Hi, I'm new to qemu-devel and I'm trying to add a ".c" source to qemu. To be more specific, I'm trying to add a file into /hw/virtio/. I've added "common-obj-y += virtio-src.o" to the Makefile.objs in that folder and when I'm compiling qemu it seems to compile the sources, but I don't know if they

  1   2   >