[Qemu-devel] [PULL 8/8] target-i386: the x86 CPL is stored in CS.selector - auto update hflags accordingly.

2014-05-09 Thread Paolo Bonzini
From: Kevin O'Connor Instead of manually calling cpu_x86_set_cpl() when the CPL changes, check for CPL changes on calls to cpu_x86_load_seg_cache(R_CS). Every location that called cpu_x86_set_cpl() also called cpu_x86_load_seg_cache(R_CS), so cpu_x86_set_cpl() is no longer required. This fixes

[Qemu-devel] [PULL 0/8] KVM changes for 2014-05-08

2014-05-09 Thread Paolo Bonzini
The following changes since commit 3a87f8b6859e6221b827ab4737779dddb37553ec: Merge remote-tracking branch 'remotes/afaerber/tags/ppc-for-2.0' into staging (2014-03-20 11:45:38 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master for y

[Qemu-devel] [PULL 7/8] target-i386: set eflags prior to calling cpu_x86_load_seg_cache() in seg_helper.c

2014-05-09 Thread Paolo Bonzini
From: Kevin O'Connor The cpu_x86_load_seg_cache() function inspects eflags, so make sure all changes to eflags are done prior to loading the segment caches. Signed-off-by: Kevin O'Connor Signed-off-by: Paolo Bonzini --- target-i386/seg_helper.c | 38 +++--- 1 f

[Qemu-devel] [PULL 3/8] pci-assign: Fix a bug when map MSI-X table memory failed

2014-05-09 Thread Paolo Bonzini
From: Gonglei when map MSI-X table memory failed, the dev->msix_table not be set to NULL, the assigned_dev_unregister_msix_mmio() will case a segfault when munmap the failed dev->msix_table. Signed-off-by: Gonglei Arei Reviewed-by: Michael S. Tsirkin Signed-off-by: Paolo Bonzini --- hw/i386/

[Qemu-devel] [PULL 5/8] target-i386: set eflags prior to calling svm_load_seg_cache() in svm_helper.c

2014-05-09 Thread Paolo Bonzini
From: Kevin O'Connor The svm_load_seg_cache() function calls cpu_x86_load_seg_cache() which inspects env->eflags. So, make sure all changes to eflags are done prior to loading the segment cache. Signed-off-by: Kevin O'Connor Signed-off-by: Paolo Bonzini --- target-i386/svm_helper.c | 7 ++---

[Qemu-devel] [PULL 6/8] target-i386: set eflags and cr0 prior to calling cpu_x86_load_seg_cache() in smm_helper.c

2014-05-09 Thread Paolo Bonzini
From: Kevin O'Connor The cpu_x86_load_seg_cache() function inspects cr0 and eflags, so make sure all changes to eflags and cr0 are done prior to loading the segment caches. Signed-off-by: Kevin O'Connor Signed-off-by: Paolo Bonzini --- target-i386/smm_helper.c | 34 +--

[Qemu-devel] [PULL 2/8] kvm: add set_one_reg/get_one_reg helpers

2014-05-09 Thread Paolo Bonzini
From: Alexey Kardashevskiy This adds QEMU wrappers for KVM_SET_ONE_REG/KVM_GET_ONE_REG ioctls. Signed-off-by: Alexey Kardashevskiy Signed-off-by: Paolo Bonzini --- include/sysemu/kvm.h | 20 kvm-all.c| 18 ++ 2 files changed, 38 insertions(+)

[Qemu-devel] [PULL 4/8] pci-assign: limit # of msix vectors

2014-05-09 Thread Paolo Bonzini
From: "Michael S. Tsirkin" KVM only supports MSIX table size up to 256 vectors, but some assigned devices support more vectors, at the moment attempts to assign them fail with EINVAL. Tweak the MSIX capability exposed to guest to limit table size to a supported value. Signed-off-by: Michael S.

[Qemu-devel] [PULL 1/8] target-i386: Remove unused data from local array

2014-05-09 Thread Paolo Bonzini
From: Stefan Weil Signed-off-by: Stefan Weil Signed-off-by: Paolo Bonzini --- target-i386/kvm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 7a295f6..114f9e1 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -130,14 +

Re: [Qemu-devel] QEMU build broken

2014-05-09 Thread Brad Smith
On 10/05/14 2:25 AM, Markus Armbruster wrote: Brad Smith writes: On 09/05/14 7:35 PM, Peter Maydell wrote: On 10 May 2014 00:02, Brad Smith wrote: On 08/05/14 10:54 AM, Peter Maydell wrote: Ah, bsd-user. Do you actually use it, or is it just in the default compile that you're running? I

Re: [Qemu-devel] QEMU build broken

2014-05-09 Thread Markus Armbruster
Brad Smith writes: > On 09/05/14 7:35 PM, Peter Maydell wrote: >> On 10 May 2014 00:02, Brad Smith wrote: >>> On 08/05/14 10:54 AM, Peter Maydell wrote: Ah, bsd-user. Do you actually use it, or is it just in the default compile that you're running? >> >>> I do not use it personally but

[Qemu-devel] [Bug 1318091] [NEW] Perfctr MSRs not available to Guest OS on AMD Phenom II

2014-05-09 Thread Barret
Public bug reported: The AMD Phenom(tm) II X4 965 Processor (family 16, model 4, stepping 3) has the 4 architecturally supported perf counters at MSRs. The selectors are c001000-c001003, and the counters are c001004-c001007. I've verified that the MSRs are there and working by manually setting t

Re: [Qemu-devel] '.' IDs and certain names breaks -global and -set

2014-05-09 Thread Alistair Francis
On Tue, Apr 15, 2014 at 8:32 PM, Peter Crosthwaite wrote: > On Tue, Apr 15, 2014 at 1:38 AM, Andreas Färber wrote: >> Am 14.04.2014 09:13, schrieb Markus Armbruster: >>> Alistair Francis writes: >>> On Wed, Apr 9, 2014 at 9:58 PM, Peter Crosthwaite wrote: > On Wed, Apr 9, 2014 at

Re: [Qemu-devel] QEMU build broken

2014-05-09 Thread Peter Maydell
On 10 May 2014 00:49, Brad Smith wrote: > This is just excuses and points out poor project process. > There could easily be a staging branch to deal with this. I have no objection if you'd like to sort out our build and test infrastructure. thanks -- PMM

[Qemu-devel] [PATCH 3/4] block: replace fprintf(stderr, ...) with error_report() in block/

2014-05-09 Thread Le Tan
Replace fprintf(stderr,...) with error_report() in files block/*, block.c, block-migration.c and blockdev.c. The trailing "\n"s of the @fmt argument have been removed because @fmt of error_report() should not contain newline. Signed-off-by: Le Tan --- block-migration.c |4 +- block.c

[Qemu-devel] [PATCH 4/4] bsd-user: replace fprintf(stderr, ...) with error_report()

2014-05-09 Thread Le Tan
Replace fprintf(stderr,...) with error_report() in files bsd-user/*. The trailing "\n"s of the @fmt argument have been removed because @fmt of error_report() should not contain newline. Signed-off-by: Le Tan --- bsd-user/bsdload.c |2 +- bsd-user/elfload.c |2 +- bsd-user/main.c| 1

[Qemu-devel] [PATCH 1/4] arch_init: replace fprintf(stderr, ...) with error_report() in arch_init.c

2014-05-09 Thread Le Tan
Replace fprintf(stderr,...) with error_report() in the file arch_init.c. The trailing "\n"s of the @fmt argument have been removed because @fmt of error_report() should not contain newline. Signed-off-by: Le Tan --- arch_init.c | 36 +--- 1 file changed, 17 inse

[Qemu-devel] [PATCH 0/4] replace some fprintf(stderr, ...) with error_report()

2014-05-09 Thread Le Tan
This series of patches replaces some more occurrences of fprintf(stderr, ...) with error_report() and removes the trailing "\n". Some of them are not changed because I am not sure if they should be changed. There are some inconsistency while dealing with macros that involves fprintf(stderr,...), th

[Qemu-devel] [PATCH 2/4] audio: replace fprintf(stderr, ...) with error_report() in audio

2014-05-09 Thread Le Tan
Replace fprintf(stderr,...) with error_report() in files audio/*. The trailing "\n"s of the @fmt argument have been removed because @fmt of error_report() should not contain newline. Signed-off-by: Le Tan --- audio/spiceaudio.c |2 +- audio/wavcapture.c |4 ++-- 2 files changed, 3 insert

Re: [Qemu-devel] QEMU build broken

2014-05-09 Thread Brad Smith
On 09/05/14 7:35 PM, Peter Maydell wrote: On 10 May 2014 00:02, Brad Smith wrote: On 08/05/14 10:54 AM, Peter Maydell wrote: Ah, bsd-user. Do you actually use it, or is it just in the default compile that you're running? I do not use it personally but it is common sense that commits must no

Re: [Qemu-devel] [PATCH 6/8] hw/timer/exynos4210_mct: Avoid overflow in exynos4210_ltick_recalc_count

2014-05-09 Thread Peter Crosthwaite
On Fri, May 9, 2014 at 4:46 AM, Peter Maydell wrote: > Add casts to avoid potentially overflowing the multiplications > of 32 bit quantities in exynos4210_ltick_recalc_count(). > > Signed-off-by: Peter Maydell Reviewed-by: Peter Crosthwaite > --- > hw/timer/exynos4210_mct.c | 4 ++-- > 1 file

Re: [Qemu-devel] [PATCH 5/8] hw/dma/omap_dma: Add (uint32_t) casts when shifting uint16_t by 16

2014-05-09 Thread Peter Crosthwaite
On Fri, May 9, 2014 at 4:46 AM, Peter Maydell wrote: > Add missing (uint32_t) casts in cases where we're trying to > put a uint16_t value into the top half of a 32-bit field. > These were already present in some but not all places. > > Signed-off-by: Peter Maydell Reviewed-by: Peter Crosthwaite

Re: [Qemu-devel] [PATCH 4/8] hw/arm/omap1: Avoid unintended sign extension writing omap_rtc YEARS_REG

2014-05-09 Thread Peter Crosthwaite
On Fri, May 9, 2014 at 4:46 AM, Peter Maydell wrote: > When writing to the YEARS_REG register, if the year value is > 99 then the multiplication by 31536000 will overflow into > the sign bit of a 32 bit value and then be erroneously > sign-extended if time_t is 64 bits. Add a cast to avoid this. >

[Qemu-devel] [Bug 1307473] Re: guest hang due to missing clock interrupt

2014-05-09 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: qemu (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1307473 Title: gues

Re: [Qemu-devel] QEMU build broken

2014-05-09 Thread Peter Maydell
On 10 May 2014 00:02, Brad Smith wrote: > On 08/05/14 10:54 AM, Peter Maydell wrote: >> Ah, bsd-user. Do you actually use it, or is it just >> in the default compile that you're running? > I do not use it personally but it is common sense that commits > must not be breaking the build. I generall

Re: [Qemu-devel] [PATCH 3/8] hw/display/pxa2xx_lcd: Fix 16bpp+alpha and 18bpp+alpha palette formats

2014-05-09 Thread Peter Crosthwaite
On Fri, May 9, 2014 at 4:46 AM, Peter Maydell wrote: > The pxa2xx palette entry "16bpp plus transparency" format is > xxxTR000GG00B000, and "18bpp plus transparency" is > xxxTRR00GG00BB00. > > Correct errors in the code for reading these and converting > them to the

Re: [Qemu-devel] QEMU build broken

2014-05-09 Thread Brad Smith
On 08/05/14 10:54 AM, Peter Maydell wrote: On 8 May 2014 15:47, Brad Smith wrote: The following commit broke the build of QEMU.. linux-user: remove configure option for setting uname release http://git.qemu.org/?p=qemu.git;a=commit;h=e586822a58b6609edb5ea929e8a4aa394d32389f http://buildbot.b

Re: [Qemu-devel] [PATCH 2/8] hw/net/cadence_gem: Remove dead code

2014-05-09 Thread Peter Crosthwaite
On Fri, May 9, 2014 at 4:46 AM, Peter Maydell wrote: > Commit 191946c moved the code to handle padding to minimum > length from after the handling of the CRC to before it. > This means that the CRC code doesn't need to cope with the > possibility that the size is less than 60; remove this > dead c

Re: [Qemu-devel] [PULL 08/38] pci-assign: accept Error from monitor_handle_fd_param2()

2014-05-09 Thread Eric Blake
On 05/08/2014 12:52 PM, Luiz Capitulino wrote: > From: Laszlo Ersek > > Propagate any errors in monitor fd handling up to get_real_device(), and > report them there. We'll continue the propagation upwards when > get_real_device() becomes a leaf itself (when none of its callees will > report error

Re: [Qemu-devel] [PATCH 1/8] hw/intc/allwinner-a10-pic: Add missing 'break'

2014-05-09 Thread Peter Crosthwaite
On Fri, May 9, 2014 at 4:46 AM, Peter Maydell wrote: > Add missing 'break' after handling of AW_A10_PIC_BASE_ADDR write. > > Signed-off-by: Peter Maydell Reviewed-by: Peter Crosthwaite > --- > hw/intc/allwinner-a10-pic.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/intc/allwinn

Re: [Qemu-devel] [Xen-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Ross Philipson
On 05/09/2014 12:00 PM, Konrad Rzeszutek Wilk wrote: On Fri, May 09, 2014 at 10:38:49AM -0400, Ross Philipson wrote: On 05/09/2014 09:31 AM, Ian Campbell wrote: On Fri, 2014-05-09 at 09:25 -0400, Konrad Rzeszutek Wilk wrote: On Fri, May 09, 2014 at 11:26:35AM +0100, Ian Campbell wrote: On Fri

[Qemu-devel] [PULL 06/10] Makefile: use $(INSTALL_LIB) for modules not $(INSTALL_PROG)

2014-05-09 Thread Paolo Bonzini
From: Michael Tokarev We have $(INSTALL_LIB) which is the same as $(INSTALL_PROG) but uses correct permissions. Loadable objects (modules) are like shared libraries, not like programs. Signed-off-by: Michael Tokarev Cc: Fam Zheng Cc: Paolo Bonzini Signed-off-by: Paolo Bonzini --- Makefile

Re: [Qemu-devel] [Xen-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Ross Philipson
On 05/09/2014 10:46 AM, Ian Campbell wrote: On Fri, 2014-05-09 at 10:38 -0400, Ross Philipson wrote: Can it be used to patch the DSDT? Or were you (Ian) thinking that the bulk of the ACPI PCI stuff can be moved there ? I think it can "shadow" or extend existing DSDT stuff, I don't think it can

Re: [Qemu-devel] [Xen-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Ross Philipson
On 05/09/2014 12:12 PM, Ian Campbell wrote: On Fri, 2014-05-09 at 12:00 -0400, Konrad Rzeszutek Wilk wrote: So we could just then gat the _EJ0 functionality based on values that are present (or not) in the SSDT ? AIUI the very presence of _EJ0 is what marks the device as being ejectable (e.g.

[Qemu-devel] [PULL 09/10] build: simplify and fix fix-obj-vars

2014-05-09 Thread Paolo Bonzini
fix-obj-vars has the undesired side effect of breaking -cflags -objs and -libs variables in the toplevel Makefile.objs. The variables in the toplevel Makefile.objs do not need any fix, so fix-obj-vars need not do anything. Since we are touching it, remove the now unnecessary $(if) in the callers.

[Qemu-devel] [PULL 02/10] build: simplify Makefile.target a bit, use just one rule for softmmu

2014-05-09 Thread Paolo Bonzini
From: Michael Tokarev On win*, we build QEMU_PROGW (GUI) and create a console app QEMU_PROG from it, while on non-win*, we make only QEMU_PROG using the same rules as used for QEMU_PROGW on win*. Make just one rule for building main executable, and an additional rule for win* to make console app

Re: [Qemu-devel] [Xen-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Ross Philipson
On 05/09/2014 09:31 AM, Ian Campbell wrote: On Fri, 2014-05-09 at 09:25 -0400, Konrad Rzeszutek Wilk wrote: On Fri, May 09, 2014 at 11:26:35AM +0100, Ian Campbell wrote: On Fri, 2014-05-09 at 10:15 +, Gonglei (Arei) wrote: Hi, First, please forgive me for my bad English. It's so sad. --

Re: [Qemu-devel] [PATCH v3.1 00/31] NUMA series, and hostmem improvements

2014-05-09 Thread Paolo Bonzini
Il 09/05/2014 19:54, Eduardo Habkost ha scritto: On Fri, May 09, 2014 at 04:29:49PM +0800, Hu Tao wrote: On Thu, May 08, 2014 at 04:51:56PM +0200, Paolo Bonzini wrote: Il 06/05/2014 11:27, Hu Tao ha scritto: This series includes work on QOMifying the memory backends. the idea is to delegate al

Re: [Qemu-devel] [Xen-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Ross Philipson
On 05/09/2014 12:34 PM, Paul Durrant wrote: -Original Message- From: Ian Campbell Sent: 09 May 2014 17:12 To: Konrad Rzeszutek Wilk Cc: Ross Philipson; ke...@koconnor.net; Huangweidong (C); Hanweidong (Randy); m...@redhat.com; qemu-devel@nongnu.org; xen- de...@lists.xen.org; fabio.fant...

Re: [Qemu-devel] [PATCH V3 0/3] Quorum maintainance operations

2014-05-09 Thread Benoît Canet
The Friday 14 Mar 2014 à 16:18:39 (+0100), Benoît Canet wrote : Stefan, Kevin: Ping, I made this a dependency of Fam's nbd series to simplify his work on the job blockers. However Fam's series is a lot of work and takes time to merge. This patchset is the only thing I _must_ succeed to merge i

[Qemu-devel] [PULL 08/10] build: convert some obj-specific CFLAGS to use new foo.o-cflags syntax

2014-05-09 Thread Paolo Bonzini
From: Michael Tokarev Current Makefile system allows using foo.o-cflags variables to store object-specific CFLAGS. Convert some usages of old syntax (using QEMU_CFLAGS += construct) to the new syntax. Do not touch multifile modules for now, as build system isn't ready for this. Signed-off-by:

[Qemu-devel] [PULL 10/10] libcacard: remove libcacard-specific CFLAGS and LIBS from global vars

2014-05-09 Thread Paolo Bonzini
From: Michael Tokarev Currently all what's needed for single file libcacard/vcard_emul_nss.c (libnss cflags) and hw/usb/ccid-card-emulated.c (libcacard includes) together with the libs is added to global QEMU_CFLAGS and libs_softmmu. Use the cflags only where really used (for two mentioned files

[Qemu-devel] [PULL 07/10] build: add support for per-object -cflags and -libs to all rules

2014-05-09 Thread Paolo Bonzini
This is needed in order to use per-object flags variables. Reviewed-by: Michael Tokarev Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini --- rules.mak | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/rules.mak b/rules.mak index 7038576..73efafe 100644 --- a/rul

[Qemu-devel] [PULL 03/10] build: simplify Makefile.target around unnest-vars invocations

2014-05-09 Thread Paolo Bonzini
No need to save/restore obj-y, we can just build all-obj-y incrementally. Reviewed-by: Fam Zheng Signed-off-by: Paolo Bonzini --- Makefile.target | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/Makefile.target b/Makefile.target index 2726b74..261de9e 100644 --- a

[Qemu-devel] [PULL 05/10] Makefile.target: use $(INSTALL_PROG) for installing, not $(INSTALL)

2014-05-09 Thread Paolo Bonzini
From: Michael Tokarev $(INSTALL_PROG) is evaluated to libtool if using libtool, while $(INSTALL) is not. Use $(INSTALL_PROG) so that libtool is used with target too when necessary. This allows, for example, to link qemu with shared libcacard. Signed-off-by: Michael Tokarev Cc: Fam Zheng Cc:

[Qemu-devel] [PULL 00/10] Build system changes for 2014-05-09

2014-05-09 Thread Paolo Bonzini
The following changes since commit 6b342cc9c872e82620fdd32730cd92affa8a19b3: Merge remote-tracking branch 'remotes/spice/tags/pull-spice-7' into staging (2014-05-08 10:57:25 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git configure for you to fetch changes

[Qemu-devel] [PULL 01/10] build: Fix per-object variables for Makefile.target

2014-05-09 Thread Paolo Bonzini
The compiling is done in a subdir, so the extraction of per-object libs and cflags are referencing objects with ../ prefixed. So prefix the per-object variables "foo.o-cflags" and "foo.o-libs" to "../foo.o-cflags" and "../foo.o-libs". Signed-off-by: Fam Zheng Reviewed-by: Michael Tokarev Signed-

[Qemu-devel] [PULL 04/10] Makefile: strip tools and modules too

2014-05-09 Thread Paolo Bonzini
From: Michael Tokarev Commit 52ba784d3 replaced $(STRIP_OPT) with $(STRIP) in some places (for example, Makefile.target), but not all of them. There are a few places remain in main Makefile which still uses $(STRIP_OPT). Replace these places with $(STRIP) too. While at it, simplify variable pat

Re: [Qemu-devel] Migration from older Qemu to Qemu 2.0.0 does not work

2014-05-09 Thread Stefan Priebe
) Am 09.05.2014 19:05, schrieb Paolo Bonzini: Il 09/05/2014 15:13, Stefan Priebe - Profihost AG ha scritto: I see no output at the monitor of Qemu 2.0. # migrate -d tcp:a.b.c.d:6000 # info migrate capabilities: xbzrle: off x-rdma-pin-all: off auto-converge: on zero-blocks: off Migration stat

Re: [Qemu-devel] Migration from older Qemu to Qemu 2.0.0 does not work

2014-05-09 Thread Stefan Priebe
Am 09.05.2014 18:29, schrieb Dr. David Alan Gilbert: * Stefan Priebe - Profihost AG (s.pri...@profihost.ag) wrote: Am 09.05.2014 um 15:41 schrieb "Dr. David Alan Gilbert" : * Stefan Priebe - Profihost AG (s.pri...@profihost.ag) wrote: Hello list, i was trying to migrate older Qemu (1.5 and

[Qemu-devel] [PULL 04/17] block/nfs: Check for NULL server part

2014-05-09 Thread Stefan Hajnoczi
From: Max Reitz After the URL has been parsed make sure the server part is valid in order to avoid a segmentation fault when calling nfs_mount(). Signed-off-by: Max Reitz Signed-off-by: Stefan Hajnoczi --- block/nfs.c | 4 1 file changed, 4 insertions(+) diff --git a/block/nfs.c b/block

[Qemu-devel] [PULL 08/17] vmdk: Implement .bdrv_get_info()

2014-05-09 Thread Stefan Hajnoczi
From: Fam Zheng This will return cluster_size and needs_compressed_writes to caller, if all the extents have the same value (or there's only one extent). Otherwise return -ENOTSUP. cluster_size is only reported for sparse formats. Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- b

[Qemu-devel] [PULL 13/17] block/raw-posix: Try both FIEMAP and SEEK_HOLE

2014-05-09 Thread Stefan Hajnoczi
From: Max Reitz The current version of raw-posix always uses ioctl(FS_IOC_FIEMAP) if FIEMAP is available; lseek with SEEK_HOLE/SEEK_DATA are not even compiled in in this case. However, there may be implementations which support the latter but not the former (e.g., NFSv4.2) as well as vice versa.

[Qemu-devel] [PULL 00/17] Block patches

2014-05-09 Thread Stefan Hajnoczi
The following changes since commit 43cbeffb19877c62cbe0aaf08b2f235d98d71340: Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' into staging (2014-05-08 12:38:01 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request

[Qemu-devel] [PULL 17/17] glib: fix g_poll early timeout on windows

2014-05-09 Thread Stefan Hajnoczi
From: Sangho Park g_poll has a problem on Windows when using timeouts < 10ms, in glib/gpoll.c: /* If not, and we have a significant timeout, poll again with * timeout then. Note that this will return indication for only * one event, or only for messages. We ignore timeouts less than * ten mil

[Qemu-devel] [PULL 14/17] block: qemu-iotests - add common.qemu, for bash-controlled qemu tests

2014-05-09 Thread Stefan Hajnoczi
From: Jeff Cody This creates some common functions for bash language qemu-iotests to control, and communicate with, a running QEMU process. 4 functions are introduced: 1. _launch_qemu() This launches the QEMU process(es), and sets up the file descriptors and fifos for commun

[Qemu-devel] [PULL 15/17] block: qemu-iotests - update 085 to use common.qemu

2014-05-09 Thread Stefan Hajnoczi
From: Jeff Cody The new functionality of common.qemu implements the QEMU control and communication functionality that was originally in test 085. This removes that now-duplicate functionality, and uses the common.qemu functions. The QEMU commandline changes slightly due to this; in addition to

[Qemu-devel] [PULL 12/17] gluster: Correctly propagate errors when volume isn't accessible

2014-05-09 Thread Stefan Hajnoczi
From: Peter Krempa The docs for glfs_init suggest that the function sets errno on every failure. In fact it doesn't. As other functions such as qemu_gluster_open() in the gluster block code report their errors based on this fact we need to make sure that errno is set on each failure. This fixes

[Qemu-devel] [PULL 11/17] vl.c: remove init_clocks call from main

2014-05-09 Thread Stefan Hajnoczi
From: Kirill Batuzov Clocks are initialized in qemu_init_main_loop. They are not needed before it. Initializing them twice is not only unnecessary but is harmful: it results in memory leak and potentially can lead to a situation where different parts of QEMU use different sets of timers. To avoi

[Qemu-devel] [PULL 16/17] block: qemu-iotests - test for live migration

2014-05-09 Thread Stefan Hajnoczi
From: Jeff Cody This is an initial, simple live migration test from one running VM to another, using monitor commands. This is also an example of using the new common.qemu functions for controlling multiple running qemu instances, for tests that need a live qemu vm. Reviewed-by: Fam Zheng Sign

[Qemu-devel] [PULL 10/17] block: Fix open flags with BDRV_O_SNAPSHOT

2014-05-09 Thread Stefan Hajnoczi
From: Kevin Wolf The immediately visible effect of this patch is that it fixes committing a temporary snapshot to its backing file. Previously, it would fail with a "permission denied" error because bdrv_inherited_flags() forced the backing file to be read-only, ignoring the r/w reopen of bdrv_co

[Qemu-devel] [PULL 09/17] qemu-iotests: Test converting to streamOptimized from small cluster size

2014-05-09 Thread Stefan Hajnoczi
From: Fam Zheng Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/059 | 7 +++ tests/qemu-iotests/059.out | 7 +++ 2 files changed, 14 insertions(+) diff --git a/tests/qemu-iotests/059 b/tests/qemu-iotests/059 index ca5aa16..26a2fd3 100755 --- a/tests/

[Qemu-devel] [PULL 06/17] qemu-img: Convert by cluster size if target is compressed

2014-05-09 Thread Stefan Hajnoczi
From: Fam Zheng If target block driver forces compression, qemu-img convert needs to write by cluster size as well as "-c" option. Particularly, this applies for converting to VMDK streamOptimized format. Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- include/block/block.h | 4 +

[Qemu-devel] [PULL 05/17] block/iscsi: bump year in copyright notice

2014-05-09 Thread Stefan Hajnoczi
From: Peter Lieven Signed-off-by: Peter Lieven Signed-off-by: Stefan Hajnoczi --- block/iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index a30202b..52355b8 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -2,7 +2,7 @@ * QEMU Block

[Qemu-devel] [PULL 03/17] qemu-img: sort block formats in help message

2014-05-09 Thread Stefan Hajnoczi
From: Mike Day The help message for qemu-img lists the supported block formats, of which there are 27 as of version 2.0.50. The formats are printed in the order of their driver's position in a linked list, which appears random. This patch prints the formats in sorted order, making it easier to re

[Qemu-devel] [PULL 01/17] qcow2: Fix alloc_clusters_noref() overflow detection

2014-05-09 Thread Stefan Hajnoczi
From: Max Reitz If the very first allocation has a length of 0, the free_cluster_index is still 0 after the for loop, which means that subtracting one from it will underflow and signal an invalid range of clusters by returning -EFBIG. However, there is no such range, as its length is 0. Fix this

[Qemu-devel] [PULL 07/17] vmdk: Implement .bdrv_write_compressed

2014-05-09 Thread Stefan Hajnoczi
From: Fam Zheng Add a wrapper function to support "compressed" path in qemu-img convert. Only support streamOptimized subformat case for now (num_extents == 1 and extent compression is true). Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- block/vmdk.c | 14 ++ 1 file

[Qemu-devel] [PULL 02/17] iotests: Use configured python

2014-05-09 Thread Stefan Hajnoczi
From: Max Reitz Currently, QEMU's iotests rely on /usr/bin/env to start the correct Python (that is, at least Python 2.4, but not 3). On systems where Python 3 is the default, the user has no clean way of making the iotests use the correct binary. This commit makes the iotests use the Python sel

Re: [Qemu-devel] [RFC PATCH 01/11] hw: use ld_p/st_p instead of ld_raw/st_raw

2014-05-09 Thread Paolo Bonzini
Il 09/05/2014 20:18, Peter Maydell ha scritto: The virtio parts of this look dubious. What actual endianness does the virtio spec say that things like the block device geometry should have in memory? I suspect we should be using the use-the-virtio-endianness accessors Greg's on-list patches imple

Re: [Qemu-devel] [PATCH v5] glib: fix g_poll early timeout on windows

2014-05-09 Thread Stefan Hajnoczi
On Thu, May 08, 2014 at 12:47:10PM +0400, Stanislav Vorobiov wrote: > From: Sangho Park > > g_poll has a problem on Windows when using > timeouts < 10ms, in glib/gpoll.c: > > /* If not, and we have a significant timeout, poll again with > * timeout then. Note that this will return indication fo

[Qemu-devel] [PATCH 2/2] CAN bus Kvaser PCI CAN-S (single SJA1000 channel) emulation added.

2014-05-09 Thread Pavel Pisa
Signed-off-by: Pavel Pisa --- hw/net/Makefile.objs| 1 + hw/net/can_kvaser_pci.c | 355 2 files changed, 356 insertions(+) create mode 100644 hw/net/can_kvaser_pci.c diff --git a/hw/net/Makefile.objs b/hw/net/Makefile.objs index 28679fc..3d

[Qemu-devel] [PATCH 0/2] CAN SJA100 controller emulation and SocketCAN based host CAN bus access

2014-05-09 Thread Pavel Pisa
Hello everybody, I have invested some time to wrap-up and get back on the track 2013 GSoC Jin Yang work on QEMU CAN bus emulation done in frame of RTEMS project preparation for future RTEMS CAN bus infrastructure preparation. I think that code is important for much wider community. RTEMS page fo

Re: [Qemu-devel] [RFC PATCH 01/11] hw: use ld_p/st_p instead of ld_raw/st_raw

2014-05-09 Thread Peter Maydell
On 8 May 2014 17:09, Paolo Bonzini wrote: > The ld_raw and st_raw definitions are only needed in code that > must compile for both user-mode and softmmu emulation. Device > models can use the equivalent ld_p/st_p which are simple > pointer accessors. > > The checkpatch situation of nseries.c and

Re: [Qemu-devel] [Xen-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Konrad Rzeszutek Wilk
On Fri, May 09, 2014 at 01:32:58PM -0400, Ross Philipson wrote: > On 05/09/2014 12:34 PM, Paul Durrant wrote: > >>-Original Message- > >>From: Ian Campbell > >>Sent: 09 May 2014 17:12 > >>To: Konrad Rzeszutek Wilk > >>Cc: Ross Philipson; ke...@koconnor.net; Huangweidong (C); Hanweidong > >>

Re: [Qemu-devel] [PATCH v3.1 00/31] NUMA series, and hostmem improvements

2014-05-09 Thread Eduardo Habkost
On Fri, May 09, 2014 at 04:29:49PM +0800, Hu Tao wrote: > On Thu, May 08, 2014 at 04:51:56PM +0200, Paolo Bonzini wrote: > > Il 06/05/2014 11:27, Hu Tao ha scritto: > > > This series includes work on QOMifying the memory backends. > > > the idea is to delegate all properties of the memory backend t

Re: [Qemu-devel] QEMU build broken

2014-05-09 Thread Stacey Son
On May 9, 2014, at 4:55 AM, Peter Maydell wrote: > On 9 May 2014 09:57, Riku Voipio wrote: >> On 8 May 2014 17:54, Peter Maydell wrote: >>> Ah, bsd-user. Do you actually use it, or is it just >>> in the default compile that you're running? > >> One year since last bsd-user specific patch, I t

Re: [Qemu-devel] Migration from older Qemu to Qemu 2.0.0 does not work

2014-05-09 Thread Paolo Bonzini
Il 09/05/2014 15:13, Stefan Priebe - Profihost AG ha scritto: I see no output at the monitor of Qemu 2.0. # migrate -d tcp:a.b.c.d:6000 # info migrate capabilities: xbzrle: off x-rdma-pin-all: off auto-converge: on zero-blocks: off Migration status: failed total time: 0 milliseconds The targe

Re: [Qemu-devel] [PATCH v3 2/2] ssi: Name the CS GPIO.

2014-05-09 Thread Peter Maydell
On 8 May 2014 07:59, Peter Crosthwaite wrote: > To get it out of the default GPIO list. This allows child devices to > use the un-named GPIO namespace without having to be SSI aware. That > is, there is no more need for machines to know about the obscure > policy where GPIO 0 is the SSI chip-selec

Re: [Qemu-devel] [PATCH v3 1/2] qdev: Implement named GPIOs

2014-05-09 Thread Peter Maydell
On 8 May 2014 07:59, Peter Crosthwaite wrote: > Implement named GPIOs on the Device layer. Listifies the existing GPIOs > stuff using string keys. Legacy un-named GPIOs are preserved by using > a NULL name string - they are just a single matchable element in the > name list. > > Signed-off-by: Pet

[Qemu-devel] [PATCH] spice: return unspecified address according to protocol

2014-05-09 Thread Amos Kong
Commit 4f60af9a changed '0.0.0.0' to '*' to indicate unspecified address. "::" is used to indicate unspecified address in IPV6. This patch returns different address for different protocol, it's more meaningful for the protocol specification than returning '*'. Signed-off-by: Amos Kong --- ui/s

Re: [Qemu-devel] [Xen-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Paul Durrant
> -Original Message- > From: Ian Campbell > Sent: 09 May 2014 17:12 > To: Konrad Rzeszutek Wilk > Cc: Ross Philipson; ke...@koconnor.net; Huangweidong (C); Hanweidong > (Randy); m...@redhat.com; qemu-devel@nongnu.org; xen- > de...@lists.xen.org; fabio.fant...@m2r.biz; > johannes.kra...@goog

Re: [Qemu-devel] Migration from older Qemu to Qemu 2.0.0 does not work

2014-05-09 Thread Dr. David Alan Gilbert
* Stefan Priebe - Profihost AG (s.pri...@profihost.ag) wrote: > > > Am 09.05.2014 um 15:41 schrieb "Dr. David Alan Gilbert" > > : > > > > * Stefan Priebe - Profihost AG (s.pri...@profihost.ag) wrote: > >> Hello list, > >> > >> i was trying to migrate older Qemu (1.5 and 1.7.2) to a machine runn

Re: [Qemu-devel] [PATCH 3/5] block: Use bdrv_nb_sectors() when sectors, not bytes are wanted

2014-05-09 Thread Markus Armbruster
Markus Armbruster writes: > Instead of bdrv_nb_sectors(). > > Aside: a few of these callers don't handle errors. I didn't > investigate whether they should. > > Signed-off-by: Markus Armbruster > --- [...] > diff --git a/block.c b/block.c > index 44e1f57..1b99cb1 100644 > --- a/block.c > +++ b/

Re: [Qemu-devel] Migration from older Qemu to Qemu 2.0.0 does not work

2014-05-09 Thread Stefan Priebe - Profihost AG
> Am 09.05.2014 um 15:41 schrieb "Dr. David Alan Gilbert" : > > * Stefan Priebe - Profihost AG (s.pri...@profihost.ag) wrote: >> Hello list, >> >> i was trying to migrate older Qemu (1.5 and 1.7.2) to a machine running >> Qemu 2.0. >> >> I started the target machine with: >> >> -machine type=p

Re: [Qemu-devel] [Xen-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Ian Campbell
On Fri, 2014-05-09 at 12:00 -0400, Konrad Rzeszutek Wilk wrote: > So we could just then gat the _EJ0 functionality based on values that > are present (or not) in the SSDT ? AIUI the very presence of _EJ0 is what marks the device as being ejectable (e.g. in the Windows device manager). It would b

[Qemu-devel] [PATCH v2 3/4] a9scu: Use qom_private to mark private fields

2014-05-09 Thread Peter Maydell
Use the new qom_private infrastructure to mark private fields in the QOM device struct. Signed-off-by: Peter Maydell --- hw/misc/a9scu.c | 2 ++ include/hw/misc/a9scu.h | 16 +++- 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/hw/misc/a9scu.c b/hw/misc/a9scu

[Qemu-devel] [PATCH v2 0/4] Allow QOM struct fields to be marked as private

2014-05-09 Thread Peter Maydell
This patch series provides infrastructure and documentation for marking QOM struct fields as private to the class implementation. Patch 1 is the implementation (which is a trivial five lines!) and documentation of the code pattern that it's intended to be used with. Patches 2, 3 and 4 are example

[Qemu-devel] [PATCH v2 4/4] arm11scu: Use qom_private to mark private fields

2014-05-09 Thread Peter Maydell
Mark the arm11scu private fields as qom_private. Signed-off-by: Peter Maydell --- hw/misc/arm11scu.c | 2 ++ include/hw/misc/arm11scu.h | 14 ++ 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/hw/misc/arm11scu.c b/hw/misc/arm11scu.c index a791675..d8d5b2b 100

[Qemu-devel] [PATCH v2 2/4] arm_gic: Use new qom_private macro to mark private fields

2014-05-09 Thread Peter Maydell
Use the new qom_private macro infrastructure to mark private fields for the arm_gic classes. Signed-off-by: Peter Maydell --- hw/intc/arm_gic.c| 3 ++ hw/intc/arm_gic_common.c | 2 ++ hw/intc/arm_gic_kvm.c| 2 ++ hw/intc/armv7m_nvic.c| 2 ++ in

Re: [Qemu-devel] [Xen-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Konrad Rzeszutek Wilk
On Fri, May 09, 2014 at 10:38:49AM -0400, Ross Philipson wrote: > On 05/09/2014 09:31 AM, Ian Campbell wrote: > >On Fri, 2014-05-09 at 09:25 -0400, Konrad Rzeszutek Wilk wrote: > >>On Fri, May 09, 2014 at 11:26:35AM +0100, Ian Campbell wrote: > >>>On Fri, 2014-05-09 at 10:15 +, Gonglei (Arei) w

[Qemu-devel] [PATCH v2 1/4] Provide infrastructure for marking private QOM struct fields

2014-05-09 Thread Peter Maydell
Provide infrastructure for marking private QOM struct fields, so that a compiler warning is generated when a user of the QOM object attempts to access them directly. This is implemented using GCC's 'deprecated' attribute; preprocessor macros arrange that when compiling the class implementation, no

Re: [Qemu-devel] [PATCH v5 0/3] Add common QEMU control functionality to qemu-iotests

2014-05-09 Thread Stefan Hajnoczi
On Wed, Apr 30, 2014 at 10:55:07AM -0400, Jeff Cody wrote: > Prior cover letter details: > > Changes from v4: > > > Patch 1: - Allow option in _send_qemu_cmd() to not exit on error, similar > to _timed_wait_for() (Thanks Fam) > - Renamed the option variable to not exit on

Re: [Qemu-devel] [PULL 00/38] QMP queue

2014-05-09 Thread Peter Maydell
On 9 May 2014 14:50, Luiz Capitulino wrote: > On Fri, 9 May 2014 12:57:43 +0100 > Peter Maydell wrote: > >> On 8 May 2014 19:52, Luiz Capitulino wrote: >> > The following changes since commit >> > 6b342cc9c872e82620fdd32730cd92affa8a19b3: >> > >> > Merge remote-tracking branch 'remotes/spice/

[Qemu-devel] [PATCH V2] qapi: Let redundant includes be skipped excepted the first occurrence.

2014-05-09 Thread Benoît Canet
The purpose of this change is to help create a json file containing common definitions; each bit of generated C code must be spitted only one time. A second history global to all QAPISchema instances has been added to detect when a file is included more than one time and skip these includes. It do

[Qemu-devel] [PATCH V2] Let the C generated bits of QAPI be generated only once when identical includes are done

2014-05-09 Thread Benoît Canet
in V2: Keep the cycle detection [Markus] Don't talk about idempottent [Markus] Benoît Canet (1): qapi: Let redundant includes be skipped excepted the first occurrence. scripts/qapi.py | 14 +++--- tests/Makefile

Re: [Qemu-devel] [PATCH 0/5] Clean up around bdrv_getlength()

2014-05-09 Thread Stefan Hajnoczi
On Fri, May 09, 2014 at 11:48:13AM +0200, Markus Armbruster wrote: > Issues addressed in this series: > > * BlockDriver method bdrv_getlength() generally returns -errno, but > some implementations return -1 instead. Fix them [PATCH 1]. > > * Frequent conversions between sectors and bytes compl

Re: [Qemu-devel] [PATCH 4] block/raw-posix: Try both FIEMAP and SEEK_HOLE

2014-05-09 Thread Stefan Hajnoczi
On Thu, May 08, 2014 at 08:57:55PM +0200, Max Reitz wrote: > The current version of raw-posix always uses ioctl(FS_IOC_FIEMAP) if > FIEMAP is available; lseek with SEEK_HOLE/SEEK_DATA are not even > compiled in in this case. However, there may be implementations which > support the latter but not t

[Qemu-devel] [PATCH v2] qcow2: Patch for shrinking qcow2 disk image

2014-05-09 Thread Jun Li
As the realization of raw shrinking, so when do qcow2 shrinking, do not check l1 entries. When resize to size1(size1 < "disk size"), the custemer knows this will destory the data. So no need to check the l1 entries which is used or not. This is v2 of the original patch. thx. Signed-off-by: Jun Li

[Qemu-devel] [PATCH] bsd-user: Remove reference to CONFIG_UNAME_RELEASE

2014-05-09 Thread Peter Maydell
Commit e586822a5 broke the bsd-user build when it removed the CONFIG_UNAME_RELEASE define but forgot to remove the use of it in bsd-user. Fix this in the simplest possible way (bsd-user doesn't make any use at all of the qemu_uname_release variable except to allow it to be pointlessly set by the us

[Qemu-devel] uvesafb doesn't work with seabios

2014-05-09 Thread Bernhard Walle
Hello, I'm using QEmu 2.0.0 on a Linux host (x86-64) with a quite special target system that uses uvesafb ('video=uvesafb:1024x768-32'). I get following errors in the target system: uvesafb: Getting mode info block for mode 0x2 failed (eax=0x4f01, err=1) uvesafb: Getting mode info block f

  1   2   >