On Fri, May 09, 2014 at 11:48:13AM +0200, Markus Armbruster wrote: > Issues addressed in this series: > > * BlockDriver method bdrv_getlength() generally returns -errno, but > some implementations return -1 instead. Fix them [PATCH 1]. > > * Frequent conversions between sectors and bytes complicate the code > needlessly. Clean up some [PATCH 2+3]. > > * bdrv_getlength() always returns a multiple of BDRV_SECTOR_SIZE, but > some places appear to be confused about that, and align the result > up or down. Don't [PATCH 4]. > > * bdrv_get_geometry() hides errors. Don't use it in places where > errors should be detected [PATCH 5]. > > Issues not addressed: > > * There are quite a few literals left in the code where > BDRV_SECTOR_SIZE, BDRV_SECTOR_BITS or BDRV_SECTOR_MASK should be > used instead. > > * Error handling is missing in places, but it's not always obvious > whether errors can actually happen, and if yes, how to handle them. > > Markus Armbruster (5): > raw-posix: Fix raw_getlength() to always return -errno on error > block: New bdrv_nb_sectors() > block: Use bdrv_nb_sectors() when sectors, not bytes are wanted
There's a regression in this patch. Dropped from the block queue because qemu-iotests ./check -qcow2 030 seems to go into an infinite loop or at least takes a long time. Stefan
