On Fri, May 9, 2014 at 4:46 AM, Peter Maydell <peter.mayd...@linaro.org> wrote:
> Add casts to avoid potentially overflowing the multiplications
> of 32 bit quantities in exynos4210_ltick_recalc_count().
>
> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
Reviewed-by: Peter Crosthwaite <peter.crosthwa...@xilinx.com>
> ---
> hw/timer/exynos4210_mct.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/timer/exynos4210_mct.c b/hw/timer/exynos4210_mct.c
> index 86f4fcd..69dbecd 100644
> --- a/hw/timer/exynos4210_mct.c
> +++ b/hw/timer/exynos4210_mct.c
> @@ -824,14 +824,14 @@ static void exynos4210_ltick_recalc_count(struct
> tick_timer *s)
> */
>
> if (s->last_tcnto) {
> - to_count = s->last_tcnto * s->last_icnto;
> + to_count = (uint64_t)s->last_tcnto * s->last_icnto;
> } else {
> to_count = s->last_icnto;
> }
> } else {
> /* distance is passed, recalculate with tcnto * icnto */
> if (s->icntb) {
> - s->distance = s->tcntb * s->icntb;
> + s->distance = (uint64_t)s->tcntb * s->icntb;
> } else {
> s->distance = s->tcntb;
> }
> --
> 1.9.2
>
>
