The Friday 14 Mar 2014 à 16:18:39 (+0100), Benoît Canet wrote : Stefan, Kevin:
Ping, I made this a dependency of Fam's nbd series to simplify his work on the job blockers. However Fam's series is a lot of work and takes time to merge. This patchset is the only thing I _must_ succeed to merge in time for 2.1. Would it be better to remove the dependency on the new blockers infrastructure to make it merge faster ? If not could one of the block maintainer have a look a this series so it will be ready to apply once Fam's series get merged ? Best regards Benoît > Hello, > > This series for 2.1 add the missing maintainance feature for Quorum. > > The first patch allows quorum to correct corrupted reads by rewriting them. > > The second add the drive-mirror-replace command to be used on a drive-mirrored > device to replace a target bs by the mirror. > > The series apply on top of Fam's NBD image feecing patches. > > Best regards > > Benoît > > in V3: > > patch 2: > remove buggy assert [Max] > clarify qapi-schema.json comment [Max] > > patch 3: > use sync=full [Max] > use iotest.notrun() [Max] > > in V2: > > Made all change suggested by Max > > patch 1 > s/callback/callbacks/ > s/concurency/concurrency/ > s/;;/;/g > s/actived/enabled/ > Changed test order > Add Max reviewed by > > patch 2 > s/file/SAN or NAS/g > add assert in bdrv_assign_node_name > The code must a target with the new mirror > as this could result in > s/check target/check that the target/ > Get the block driver state to be replaced > s/to replace/to be replaced/ > s/are/is/ > s/usefull/useful/g > avoid leaking s->new_node_name > s/switch/switches/ > s/replace/replaces/ > > Benoît Canet (3): > quorum: Add the rewrite-corrupted parameter to quorum. > block: Add drive-mirror-replace command to repair quorum files. > qemu-iotests: Add 088 new test for drive-mirror-replace. > > block.c | 8 +- > block/mirror.c | 116 +++++++++++++++++++++- > block/quorum.c | 97 +++++++++++++++++-- > blockdev.c | 27 ++++++ > include/block/block.h | 3 + > include/block/block_int.h | 15 +++ > qapi-schema.json | 38 +++++++- > qmp-commands.hx | 5 + > tests/qemu-iotests/041 | 34 +------ > tests/qemu-iotests/081 | 15 ++- > tests/qemu-iotests/081.out | 10 ++ > tests/qemu-iotests/088 | 219 > ++++++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/088.out | 5 + > tests/qemu-iotests/group | 1 + > tests/qemu-iotests/iotests.py | 33 +++++++ > trace-events | 1 + > 16 files changed, 580 insertions(+), 47 deletions(-) > create mode 100755 tests/qemu-iotests/088 > create mode 100644 tests/qemu-iotests/088.out > > -- > 1.8.3.2 >
