Re: [Qemu-devel] [PATCH v22 02/25] qapi: output def_value_str when query command line options

2014-03-10 Thread Hu Tao
On Mon, Mar 10, 2014 at 03:31:38PM +0800, Chunyan Liu wrote: > Change qapi interfaces to output the newly added def_value_str when querying > command line options. > > Signed-off-by: Dong Xu Wang Not a valid email address.

Re: [Qemu-devel] [PATCH v22 05/25] add some QemuOpts functions for replace work

2014-03-10 Thread Chunyan Liu
2014-03-11 7:28 GMT+08:00 Eric Blake : > On 03/10/2014 01:31 AM, Chunyan Liu wrote: > > Add some qemu_opt functions to replace the same functionality of > > QEMUOptionParameter handling. > > > > Signed-off-by: Dong Xu Wang > > Signed-off-by: Chunyan Liu > > --- > > include/qemu/option.h | 9 +

Re: [Qemu-devel] [PATCH v22 06/25] add convert functions between QEMUOptionParameter to QemuOpts

2014-03-10 Thread Eric Blake
On 03/10/2014 01:31 AM, Chunyan Liu wrote: > Add two temp convert functions between QEMUOptionParameter to QemuOpts, so > that > next patch can use it. It will simplify next patch for easier review. > > Signed-off-by: Chunyan Liu > --- > include/qemu/option.h | 2 + > util/qemu-option.c|

Re: [Qemu-devel] [PATCH v22 07/25] change block layer to support both QemuOpts and QEMUOptionParamter

2014-03-10 Thread Eric Blake
On 03/10/2014 01:31 AM, Chunyan Liu wrote: > Change block layer to support both QemuOpts and QEMUOptionParameter. > After this patch, it will change backend drivers one by one. At the end, > QEMUOptionParameter will be removed and only QemuOpts is kept. > > Signed-off-by: Dong Xu Wang > Signed-of

Re: [Qemu-devel] [PATCH 2.1 17/28] memory: move mem_path handling to memory_region_allocate_system_memory

2014-03-10 Thread Hu Tao
On Tue, Mar 04, 2014 at 03:00:45PM +0100, Paolo Bonzini wrote: > Like the previous patch did in exec.c, split memory_region_init_ram and > memory_region_init_ram_from_file, and push mem_path one step further up. > Other RAM regions than system memory will now be backed by regular RAM. This changes

Re: [Qemu-devel] AmigaOS 4.x on QEMU

2014-03-10 Thread xalaris
BALATON Zoltan wrote > I almost managed to get it to boot in QEMU with some changes in OpenBIOS > but it seems there are still more bugs to hunt down and then not > everything needed is in QEMU yet (most importantly supported graphics card > emulation) so I don't know how far I can get with it b

Re: [Qemu-devel] [PATCH v22 00/25] replace QEMUOptionParameter with QemuOpts

2014-03-10 Thread Chunyan Liu
2014-03-11 4:22 GMT+08:00 Stefan Hajnoczi : > On Mon, Mar 10, 2014 at 03:31:36PM +0800, Chunyan Liu wrote: > > This patch series is to replace QEMUOptionParameter with QemuOpts, so > that only > > one Qemu Option structure is kept in QEMU code. > > > > --- > > Changes to v21: > > * update veriso

[Qemu-devel] [Bug 1290558] [NEW] color issue (ppc as guest)

2014-03-10 Thread Joe Mert
Public bug reported: Hi, on my qemu 1.6.1 -- installed via fink on host Mac OS X 10.8 -- guest PowerPc with Mac OS X 10.4 from original install disk, boots fine but I observe a color issue exactly as described here: http://virtuallyfun.superglobalmegacorp.com/?p=3197 http://virtuallyfun.superg

Re: [Qemu-devel] AmigaOS 4.x on QEMU

2014-03-10 Thread BALATON Zoltan
On Mon, 10 Mar 2014, xalaris wrote: Running MorphOS has been probably already achieved long ago. Not sure if it's just rumors, but it has been said that someone from the OS team has managed to do that. http://bigfoot.morphos-team.net/test/qemu.png But it seems they never relased that and have n

[Qemu-devel] KVM call agenda for 2014-03-18

2014-03-10 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. Thanks, Juan. Call details: 09:00 AM to 10:00 AM EDT Every two weeks If you need phone number details, contact me privately

[Qemu-devel] [PATCH v4 4/4] migration: add more traces

2014-03-10 Thread Alexey Kardashevskiy
This replaces DPRINTF macro with tracepoints. This moves some messages from migration.c to savevm.c. This adds tracepoint to signal about fileds failed to migrate. Signed-off-by: Alexey Kardashevskiy --- Changes: v4: * made use of new qemu_ether_ntoa to make it compiling in mingw32 --- migrati

[Qemu-devel] [PATCH v4 3/4] migration: extend section_start/end traces

2014-03-10 Thread Alexey Kardashevskiy
This adds @idstr to savevm_section_start and savevm_section_end tracepoints. Signed-off-by: Alexey Kardashevskiy --- savevm.c | 12 ++-- trace-events | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/savevm.c b/savevm.c index 7329fc5..d094fbb 100644 --- a/save

[Qemu-devel] [PATCH v4 0/4] migration: add more traces

2014-03-10 Thread Alexey Kardashevskiy
This reworks/adds traces for migration. v4: * added qemu_ether_ntoa helper and used it for trace_qemu_announce_self_iter v2: * rework of an original single patch with the same subject. Alexey Kardashevskiy (4): util: add qemu_ether_ntoa vl: add system_wakeup_request tracepoint migration: e

[Qemu-devel] [PATCH v4 1/4] util: add qemu_ether_ntoa

2014-03-10 Thread Alexey Kardashevskiy
This adds a helper to format ethernet MAC address. Signed-off-by: Alexey Kardashevskiy --- include/qemu-common.h | 2 ++ util/cutils.c | 14 ++ 2 files changed, 16 insertions(+) diff --git a/include/qemu-common.h b/include/qemu-common.h index c8a58a8..a998e8d 100644 --- a/i

[Qemu-devel] [PATCH v4 2/4] vl: add system_wakeup_request tracepoint

2014-03-10 Thread Alexey Kardashevskiy
It might be useful for tracing migration. Signed-off-by: Alexey Kardashevskiy --- trace-events | 1 + vl.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/trace-events b/trace-events index 580281d..91a2edc 100644 --- a/trace-events +++ b/trace-events @@ -486,6 +486,7 @@ runstate_s

Re: [Qemu-devel] [PATCH v22 05/25] add some QemuOpts functions for replace work

2014-03-10 Thread Eric Blake
On 03/10/2014 01:31 AM, Chunyan Liu wrote: > Add some qemu_opt functions to replace the same functionality of > QEMUOptionParameter handling. > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > include/qemu/option.h | 9 +++ > util/qemu-option.c| 188 > ++

Re: [Qemu-devel] [PATCH 1/3] qcow2: Check bs->drv in copy_sectors()

2014-03-10 Thread Laszlo Ersek
On 03/10/14 23:44, Max Reitz wrote: > Before dereferencing bs->drv for a call to its member bdrv_co_readv(), > copy_sectors() should check whether that pointer is indeed valid, since > it may have been set to NULL by e.g. a concurrent write triggering the > corruption prevention mechanism. > > Sig

Re: [Qemu-devel] [PATCH v22 00/25] replace QEMUOptionParameter with QemuOpts

2014-03-10 Thread Eric Blake
On 03/10/2014 01:31 AM, Chunyan Liu wrote: > This patch series is to replace QEMUOptionParameter with QemuOpts, so that > only > one Qemu Option structure is kept in QEMU code. Uggh. The more I learn about QemuOpts while reviewing this patch, the more I KNOW it has lurking bugs waiting to bite u

[Qemu-devel] [PATCH 2/3] block: bs->drv may be NULL in bdrv_debug_resume()

2014-03-10 Thread Max Reitz
Currently, bdrv_debug_resume() requires every bs->drv in the BDS stack to be NULL until a bs->drv with an implementation of bdrv_debug_resume() is found. For a normal function, this would be fine, but this is a function for debugging purposes and should therefore allow intermediate BDS not to have

[Qemu-devel] [PATCH 3/3] iotests: Test corruption during COW request

2014-03-10 Thread Max Reitz
Extend test file 060 by a test case for corruption occuring concurrently to a COW request. QEMU should not crash but rather return an appropriate error message. Signed-off-by: Max Reitz --- tests/qemu-iotests/060 | 26 ++ tests/qemu-iotests/060.out | 15 ++

[Qemu-devel] [PATCH 0/3] qcow2: Fix crash during copy_sectors() after corruption

2014-03-10 Thread Max Reitz
This series fixes a call to a NULL function pointer during copy_sectors(), if a concurrent write request triggered the corruption prevention mechanism. Max Reitz (3): qcow2: Check bs->drv in copy_sectors() block: bs->drv may be NULL in bdrv_debug_resume() iotests: Test corruption during COW

[Qemu-devel] [PATCH 1/3] qcow2: Check bs->drv in copy_sectors()

2014-03-10 Thread Max Reitz
Before dereferencing bs->drv for a call to its member bdrv_co_readv(), copy_sectors() should check whether that pointer is indeed valid, since it may have been set to NULL by e.g. a concurrent write triggering the corruption prevention mechanism. Signed-off-by: Max Reitz --- To be precise, this s

Re: [Qemu-devel] [PATCH v3] migration: add more traces

2014-03-10 Thread Juan Quintela
Alexey Kardashevskiy wrote: > On 03/11/2014 04:17 AM, Amit Shah wrote: >> On (Wed) 05 Mar 2014 [02:14:56], Alexey Kardashevskiy wrote: >>> This replaces DPRINTF macro with tracepoints. >>> >>> This moves some messages from migration.c to savevm.c. >>> >>> This adds tracepoint to signal about filed

Re: [Qemu-devel] [PATCH v3] migration: add more traces

2014-03-10 Thread Alexey Kardashevskiy
On 03/11/2014 04:17 AM, Amit Shah wrote: > On (Wed) 05 Mar 2014 [02:14:56], Alexey Kardashevskiy wrote: >> This replaces DPRINTF macro with tracepoints. >> >> This moves some messages from migration.c to savevm.c. >> >> This adds tracepoint to signal about fileds failed to migrate. >> >> Signed-off

Re: [Qemu-devel] [PATCH 00/12] Avoid shifting left into sign bit

2014-03-10 Thread Michael S. Tsirkin
On Mon, Mar 10, 2014 at 07:10:36PM +, Peter Maydell wrote: > This is a set of patches which silence clang -fsanitize=undefined > warnings about shifting left into the sign bit of a signed value. > Typically this is the result of "1 << 31" and similar constructs; > the fix is to add a "U" suffix

Re: [Qemu-devel] [PATCH 12/12] hw/pci-host/apb.c: Avoid shifting left into sign bit

2014-03-10 Thread Michael S. Tsirkin
On Mon, Mar 10, 2014 at 07:10:48PM +, Peter Maydell wrote: > Add U suffix to avoid undefined behaviour. > > Signed-off-by: Peter Maydell While not required for correctness, it would be cleaner to change all constants around this line to 1U <<, for consistency. > --- > hw/pci-host/apb.c | 2

Re: [Qemu-devel] [PATCH 03/12] hw/pci/pci_host.c: Avoid shifting left into sign bit

2014-03-10 Thread Michael S. Tsirkin
On Mon, Mar 10, 2014 at 07:10:39PM +, Peter Maydell wrote: > Add U suffix to avoid undefined behaviour. > > Signed-off-by: Peter Maydell Reviewed-by: Michael S. Tsirkin > --- > hw/pci/pci_host.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/pci/pci_host.c

Re: [Qemu-devel] [PATCH 01/12] target-i386: Avoid shifting left into sign bit

2014-03-10 Thread Michael S. Tsirkin
On Mon, Mar 10, 2014 at 07:10:37PM +, Peter Maydell wrote: > Add 'U' suffixes where necessary to avoid (1 << 31) which > shifts left into the sign bit, which is undefined behaviour. > > Signed-off-by: Peter Maydell While not required for correctness, I think it would be cleaner to change the

Re: [Qemu-devel] [PATCH 04/12] hw/i386/acpi_build.c: Avoid shifting left into sign bit

2014-03-10 Thread Michael S. Tsirkin
On Mon, Mar 10, 2014 at 07:10:40PM +, Peter Maydell wrote: > Add U suffix to avoid undefined behaviour. > > Signed-off-by: Peter Maydell Reviewed-by: Michael S. Tsirkin > --- > hw/i386/acpi-build.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/i386/acpi-buil

Re: [Qemu-devel] [PATCH 02/12] hw/intc/apic.c: Use uint32_t for mask word in foreach_apic

2014-03-10 Thread Michael S. Tsirkin
On Mon, Mar 10, 2014 at 07:10:38PM +, Peter Maydell wrote: > Use unsigned arithmetic for operations on the mask word > in the foreach_apic() macro, to avoid relying on undefined > behaviour when shifting into the sign bit. > > Signed-off-by: Peter Maydell Reviewed-by: Michael S. Tsirkin >

Re: [Qemu-devel] [PATCH 03/12] hw/pci/pci_host.c: Avoid shifting left into sign bit

2014-03-10 Thread Michael S. Tsirkin
On Mon, Mar 10, 2014 at 09:03:08PM +0100, Stefan Weil wrote: > Am 10.03.2014 20:10, schrieb Peter Maydell: > > Add U suffix to avoid undefined behaviour. > > > > Signed-off-by: Peter Maydell > > --- > > hw/pci/pci_host.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff -

Re: [Qemu-devel] [PATCH v22 04/25] improve assertion in qemu_opt_get functions

2014-03-10 Thread Eric Blake
On 03/10/2014 01:31 AM, Chunyan Liu wrote: > In qemu_opt_set functions, if desc doen't exist but opts_accepts_any is true, > it s/doen't/doesn't/ I mentioned the same problem against v20. It is very depressing when review comments are not addressed. > won't report error, but can still alloc an

Re: [Qemu-devel] [PATCH v22 03/25] improve some functions in qemu-option.c

2014-03-10 Thread Eric Blake
On 03/10/2014 02:29 PM, Eric Blake wrote: >> +opt = qemu_opt_find(opts, name); >> +if (opt) { >> +g_free((char *)opt->str); > > ...which means the cast is pointless here. > > Hmm. This means that you are giving opt_set() the behavior of 'last > version wins', by silently overwri

Re: [Qemu-devel] AmigaOS 4.x on QEMU

2014-03-10 Thread xalaris
Running MorphOS has been probably already achieved long ago. Not sure if it's just rumors, but it has been said that someone from the OS team has managed to do that. http://bigfoot.morphos-team.net/test/qemu.png As about cpu variety, Morph has been covered by most of the G4 PowerMacs, and as far as

Re: [Qemu-devel] [PATCH v5] target-sparc: Add and use CPU_FEATURE_CASA

2014-03-10 Thread Richard Henderson
On 03/09/2014 04:02 AM, Sebastian Huber wrote: > #endif > +#if !defined(CONFIG_USER_ONLY) || defined(TARGET_SPARC64) > +case 0x3c: /* V9 or LEON3 casa */ > +CHECK_IU_FEATURE(dc, CASA); > +#ifndef TARGET_SPARC64 > +if (IS_IMM) { > +

Re: [Qemu-devel] [PATCH v22 03/25] improve some functions in qemu-option.c

2014-03-10 Thread Eric Blake
On 03/10/2014 01:31 AM, Chunyan Liu wrote: > Improve opt_get and opt_set group of functions. For opt_get, check and handle > NULL input; for opt_set, when set to an existing option, rewrite the option > with new value. > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > include

Re: [Qemu-devel] [PATCH v22 00/25] replace QEMUOptionParameter with QemuOpts

2014-03-10 Thread Stefan Hajnoczi
On Mon, Mar 10, 2014 at 03:31:36PM +0800, Chunyan Liu wrote: > This patch series is to replace QEMUOptionParameter with QemuOpts, so that > only > one Qemu Option structure is kept in QEMU code. > > --- > Changes to v21: > * update verison info in patch 2/25 > * others are not changed except

Re: [Qemu-devel] SMBIOS (Set of 10 patches)

2014-03-10 Thread Eric Blake
On 03/10/2014 01:14 PM, Eric Blake wrote: > Upstream git.git has included send-email for years; but many distros > ship it as a separate package because of the additional dependencies it > drags in. On Fedora systems, it is part of the 'git-email' package. > Hmm - something to add to the SubmitAPa

[Qemu-devel] [PATCH 05/12] target-mips: Avoid shifting left into sign bit

2014-03-10 Thread Peter Maydell
Add U suffix to various places where we shift a 1 left by 31, to avoid undefined behaviour. Signed-off-by: Peter Maydell --- target-mips/cpu.h| 2 +- target-mips/helper.c | 8 target-mips/op_helper.c | 2 +- target-mips/translate_init.c | 22 +++--

Re: [Qemu-devel] [PATCH v2] q35: Correct typo BRDIGE -> BRIDGE

2014-03-10 Thread Michael S. Tsirkin
On Fri, Feb 28, 2014 at 11:28:03AM +0100, BALATON Zoltan wrote: > Signed-off-by: BALATON Zoltan Applied, thanks! > --- > > v2: Sorry, I was too fast to send it. Found two more places to change. > > hw/pci-host/q35.c | 10 +- > include/hw/i386/ich9.h| 2 +- > include/hw/pc

Re: [Qemu-devel] [PATCH 03/12] hw/pci/pci_host.c: Avoid shifting left into sign bit

2014-03-10 Thread Stefan Weil
Am 10.03.2014 20:10, schrieb Peter Maydell: > Add U suffix to avoid undefined behaviour. > > Signed-off-by: Peter Maydell > --- > hw/pci/pci_host.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/pci/pci_host.c b/hw/pci/pci_host.c > index 77c7d1f..2c17916 100644 >

Re: [Qemu-devel] [PATCH v22 02/25] qapi: output def_value_str when query command line options

2014-03-10 Thread Eric Blake
On 03/10/2014 01:31 AM, Chunyan Liu wrote: > Change qapi interfaces to output the newly added def_value_str when querying > command line options. > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > qapi-schema.json | 6 +- > qmp-commands.hx| 2 ++ > util/qemu-config.c

[Qemu-devel] [PATCH v2] acpi-build: don't access unaligned addresses

2014-03-10 Thread Michael S. Tsirkin
casting an unaligned address to e.g. uint32_t can trigger undefined behaviour in C. Replace cast + assignment with memcpy. Reported-by: Peter Maydell Signed-off-by: Michael S. Tsirkin --- Changes from v1: no need to export bswap_le anymore hw/i386/acpi-build.c | 31 ---

[Qemu-devel] [PATCH 04/12] hw/i386/acpi_build.c: Avoid shifting left into sign bit

2014-03-10 Thread Peter Maydell
Add U suffix to avoid undefined behaviour. Signed-off-by: Peter Maydell --- hw/i386/acpi-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index b1a7ebb..46d4e60 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@

Re: [Qemu-devel] [PATCH v22 01/25] add def_value_str to QemuOptDesc

2014-03-10 Thread Eric Blake
On 03/10/2014 01:31 AM, Chunyan Liu wrote: > Add def_value_str (default value) to QemuOptDesc, to replace function of the > default value in QEMUOptionParameter. And improved related functions. > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > include/qemu/option.h | 3 ++- >

[Qemu-devel] [PATCH 2/2] acpi-build: don't access unaligned addresses

2014-03-10 Thread Michael S. Tsirkin
casting an unaligned address to e.g. uint32_t can trigger undefined behaviour in C. Replace cast + assignment with memcpy. Reported-by: Peter Maydell Signed-off-by: Michael S. Tsirkin --- hw/i386/acpi-build.c | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-

[Qemu-devel] [PATCH 1/2] bswap.h: export bswap_le

2014-03-10 Thread Michael S. Tsirkin
it's a handy API for cases where we want to get size in bits as a parameter. Signed-off-by: Michael S. Tsirkin --- include/qemu/bswap.h | 5 - 1 file changed, 5 deletions(-) diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h index 0cb7c05..4489ad9 100644 --- a/include/qemu/bswap.h +++

Re: [Qemu-devel] [PATCH 02/12] hw/intc/apic.c: Use uint32_t for mask word in foreach_apic

2014-03-10 Thread Stefan Weil
Am 10.03.2014 20:10, schrieb Peter Maydell: > Use unsigned arithmetic for operations on the mask word > in the foreach_apic() macro, to avoid relying on undefined > behaviour when shifting into the sign bit. > > Signed-off-by: Peter Maydell > --- > hw/intc/apic.c | 5 +++-- > 1 file changed, 3 i

Re: [Qemu-devel] [PATCH 0/2] tests: Fix possible deadlock in qtest initialization

2014-03-10 Thread Stefan Hajnoczi
On Mon, Mar 10, 2014 at 05:21:17PM +0200, Marcel Apfelbaum wrote: > On Mon, 2014-03-10 at 16:02 +0100, Stefan Hajnoczi wrote: > > On Mon, Mar 10, 2014 at 02:12:12PM +0200, Marcel Apfelbaum wrote: > > > 'socket_accept' waits for Qemu to init its unix socket. > > > If Qemu encounters an error during

Re: [Qemu-devel] SMBIOS (Set of 10 patches)

2014-03-10 Thread Eric Blake
On 03/10/2014 11:55 AM, Eric Blake wrote: > On 03/10/2014 10:56 AM, Gabriel L. Somlo wrote: >> Hi, >> >> This patch set builds full smbios tables in QEMU, and sends them to >> the bios via fw_cfg as SMBIOS_TABLE_ENTRY blobs. >> > > 'qemu send-email -10 --annotate --cover-letter' defaults to the p

[Qemu-devel] [PATCH 00/12] Avoid shifting left into sign bit

2014-03-10 Thread Peter Maydell
This is a set of patches which silence clang -fsanitize=undefined warnings about shifting left into the sign bit of a signed value. Typically this is the result of "1 << 31" and similar constructs; the fix is to add a "U" suffix to the 1 so that we do unsigned arithmetic rather than signed arithmet

Re: [Qemu-devel] [PATCH] tap: avoid deadlocking rx

2014-03-10 Thread Neil Skrypuch
On Saturday 08 March 2014 16:00:43 Stefan Hajnoczi wrote: > The net subsystem has a control flow mechanism so peer NetClientStates > can tell each other to stop sending packets. This is used to stop > monitoring the tap file descriptor for incoming packets if the guest rx > ring has no spare buffe

Re: [Qemu-devel] SMBIOS (Set of 10 patches)

2014-03-10 Thread Eric Blake
On 03/10/2014 12:17 PM, Gabriel L. Somlo wrote: >> but instead create 1 top-level thread with all patches under the cover >> letter: >> >> 0/10 >> |- 1/10 >> |- 2/10 >> ... >> |- 10/10 > > OK, so I screwed up, now what ? Should I re-send the 10 patches > in-reply-to the existing cover letter, or l

[Qemu-devel] [PATCH 02/12] hw/intc/apic.c: Use uint32_t for mask word in foreach_apic

2014-03-10 Thread Peter Maydell
Use unsigned arithmetic for operations on the mask word in the foreach_apic() macro, to avoid relying on undefined behaviour when shifting into the sign bit. Signed-off-by: Peter Maydell --- hw/intc/apic.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/intc/apic.c b/

[Qemu-devel] [PATCH 11/12] hw/intc/xilinx_intc: Avoid shifting left into sign bit

2014-03-10 Thread Peter Maydell
Avoid undefined behaviour shifting left into the sign bit. Signed-off-by: Peter Maydell --- hw/intc/xilinx_intc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/intc/xilinx_intc.c b/hw/intc/xilinx_intc.c index 4a10398..1b228ff 100644 --- a/hw/intc/xilinx_intc.c +++ b/hw

Re: [Qemu-devel] [PATCH] New feature - RFC3931 L2TPv3 network transport using static Ethernet over L2TPv3 tunnels

2014-03-10 Thread Anton Ivanov (antivano)
On 10/03/14 18:04, Stefan Hajnoczi wrote: > On Mon, Mar 10, 2014 at 08:49:01AM +, Anton Ivanov wrote: >> You are correct. My test is wrong. >> >> However, the result is the same - it wants a non-zero proto there. >> >> $ sudo ./gaitest >> src ai_family 2 ai_socketype 3 ai_protocol 0 >> socket c

[Qemu-devel] [PATCH 01/12] target-i386: Avoid shifting left into sign bit

2014-03-10 Thread Peter Maydell
Add 'U' suffixes where necessary to avoid (1 << 31) which shifts left into the sign bit, which is undefined behaviour. Signed-off-by: Peter Maydell --- target-i386/cpu.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index 0014ac

[Qemu-devel] [PATCH 10/12] hw/intc/slavio_intctl: Avoid shifting left into sign bit

2014-03-10 Thread Peter Maydell
Add 'U' suffix to avoid undefined behaviour. Signed-off-by: Peter Maydell --- hw/intc/slavio_intctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/intc/slavio_intctl.c b/hw/intc/slavio_intctl.c index 41a1672..b10fb66 100644 --- a/hw/intc/slavio_intctl.c +++ b/hw/intc/sl

[Qemu-devel] [PATCH 06/12] hw/usb/hcd-ohci.c: Avoid shifting left into sign bit

2014-03-10 Thread Peter Maydell
Add U suffix to avoid undefined behaviour. Signed-off-by: Peter Maydell --- hw/usb/hcd-ohci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index 3d35058b..9dcfb99 100644 --- a/hw/usb/hcd-ohci.c +++ b/hw/usb/hcd-ohci.c @@ -242,7 +

[Qemu-devel] [PATCH 09/12] tests/libqos/pci-pc: Avoid shifting left into sign bit

2014-03-10 Thread Peter Maydell
Add U suffix when doing "1 << 31" to avoid undefined behaviour. Signed-off-by: Peter Maydell --- tests/libqos/pci-pc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/libqos/pci-pc.c b/tests/libqos/pci-pc.c index 3bde8ab..bf741a4 100644 --- a/tests/libqos/p

[Qemu-devel] [PATCH 08/12] hw/ppc: Avoid shifting left into sign bit

2014-03-10 Thread Peter Maydell
Add U suffix to various places where we were doing "1 << 31", which is undefined behaviour. Signed-off-by: Peter Maydell --- hw/ppc/ppc.c | 2 +- hw/ppc/ppc440_bamboo.c | 4 ++-- hw/ppc/ppc4xx_devs.c | 2 +- hw/ppc/ppc_booke.c | 4 ++-- hw/ppc/virtex_ml507.c | 4 ++-- 5 files ch

[Qemu-devel] [PATCH 07/12] hw/intc/openpic: Avoid shifting left into sign bit

2014-03-10 Thread Peter Maydell
Add U suffix to avoid undefined behaviour. Signed-off-by: Peter Maydell --- hw/intc/openpic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/intc/openpic.c b/hw/intc/openpic.c index 7df72f4..cfd7f06 100644 --- a/hw/intc/openpic.c +++ b/hw/intc/openpic.c @@ -123,7 +123

[Qemu-devel] [PATCH 12/12] hw/pci-host/apb.c: Avoid shifting left into sign bit

2014-03-10 Thread Peter Maydell
Add U suffix to avoid undefined behaviour. Signed-off-by: Peter Maydell --- hw/pci-host/apb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-host/apb.c b/hw/pci-host/apb.c index 1b399dd..a6869b8 100644 --- a/hw/pci-host/apb.c +++ b/hw/pci-host/apb.c @@ -58,7 +58,7 @@

[Qemu-devel] [PATCH 03/12] hw/pci/pci_host.c: Avoid shifting left into sign bit

2014-03-10 Thread Peter Maydell
Add U suffix to avoid undefined behaviour. Signed-off-by: Peter Maydell --- hw/pci/pci_host.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/pci/pci_host.c b/hw/pci/pci_host.c index 77c7d1f..2c17916 100644 --- a/hw/pci/pci_host.c +++ b/hw/pci/pci_host.c @@ -142,8 +142,9

[Qemu-devel] [PATCH 5/6] target-arm: Use Common Tables in AES Instructions

2014-03-10 Thread Tom Musta
This patch refactors the ARM cryptographic instructions to use the (newly) added common tables from include/qemu/aes.h. Signed-off-by: Tom Musta diff --git a/target-arm/crypto_helper.c b/target-arm/crypto_helper.c index f94be69..9dc0c8e 100644 --- a/target-arm/crypto_helper.c +++ b/target-arm/cr

[Qemu-devel] [PATCH 3/6] util: Add InvMixColumns

2014-03-10 Thread Tom Musta
This patch adds the table implementation of the Advanced Encryption Standard (AES) InvMixColumns transformation. The patch is intentionally asymmetrical -- the MixColumns table is not added because there is no known use for it at this time. Signed-off-by: Tom Musta diff --git a/include/qemu/a

[Qemu-devel] [PATCH 1/6] util: Add S-Box and InvS-Box Arrays to Common AES Utils

2014-03-10 Thread Tom Musta
This patch adds tables for the S-Box and InvS-Box transformations commonly used by various Advanced Encription Standard (AES) instruction models. Signed-off-by: Tom Musta diff --git a/include/qemu/aes.h b/include/qemu/aes.h index e79c707..a4044f5 100644 --- a/include/qemu/aes.h +++ b/include/qe

[Qemu-devel] [PATCH 6/6] target-ppc: Refactor AES Instructions

2014-03-10 Thread Tom Musta
This patch refactors the PowerPC Advanced Encryption Standard (AES) instructions to use the common AES tables (include/qemu/aes.h). Specifically: - vsbox is recoded to use the AES_sbox table. - vcipher, vcipherlast and vncipherlast are all recoded to use the optimized AES_t[ed][0-4]

[Qemu-devel] [PATCH 2/6] util: Add AES ShiftRows and InvShiftRows Tables

2014-03-10 Thread Tom Musta
This patch adds tables that implement the Advanced Encryption Standard (AES) ShiftRows and InvShiftRows transformations. These are commonly used in instruction models. Signed-off-by: Tom Musta diff --git a/include/qemu/aes.h b/include/qemu/aes.h index a4044f5..c45bc57 100644 --- a/include/qem

Re: [Qemu-devel] [PULL v3 00/14] acpi, pc, pci, virtio, memory bug fixes

2014-03-10 Thread Michael S. Tsirkin
On Mon, Mar 10, 2014 at 03:38:11PM +, Peter Maydell wrote: > On 9 March 2014 19:19, Michael S. Tsirkin wrote: > > Changes from v2: > > fix for OSx by Gabriel > > fixed build on systems without IASL > > > > The following changes since commit f53f3d0a00b6df39ce8dfca942608e5b6a9a4f71: > >

[Qemu-devel] [PATCH 4/6] target-i386: Use Common ShiftRows and InvShiftRows Tables

2014-03-10 Thread Tom Musta
This patch eliminates the (now) redundant copy of the Advanced Encryption Standard (AES) ShiftRows and InvShiftRows tables; the code is updated to use the common tables declared in include/qemu/aes.h. Signed-off-by: Tom Musta diff --git a/target-i386/ops_sse.h b/target-i386/ops_sse.h index eb2

[Qemu-devel] [PATCH 0/6] Refactor AES Instructions

2014-03-10 Thread Tom Musta
This patch series addresses concerns raised by Richard Henderson regarding redundant copies of Advanced Encryption Standard (AES) data and code (see http://lists.nongnu.org/archive/html/qemu-devel/2014-02/msg04391.html). The patches declare commonly used AES tables in the include/qemu/aes.h heade

Re: [Qemu-devel] [PATCH] New feature - RFC3931 L2TPv3 network transport using static Ethernet over L2TPv3 tunnels

2014-03-10 Thread Stefan Hajnoczi
On Mon, Mar 10, 2014 at 08:49:01AM +, Anton Ivanov wrote: > You are correct. My test is wrong. > > However, the result is the same - it wants a non-zero proto there. > > $ sudo ./gaitest > src ai_family 2 ai_socketype 3 ai_protocol 0 > socket creation failed, errno = 93 You are right! I got

Re: [Qemu-devel] [PATCH 1/2] tests/libqtest: Fix possible deadlock in qtest initialization

2014-03-10 Thread Stefan Hajnoczi
On Mon, Mar 10, 2014 at 02:12:13PM +0200, Marcel Apfelbaum wrote: > @@ -123,6 +125,11 @@ QTestState *qtest_init(const char *extra_args) > sock = init_socket(socket_path); > qmpsock = init_socket(qmp_socket_path); > > +setsockopt(sock, SOL_SOCKET, SO_RCVTIMEO, (void *)&socket_timeout

Re: [Qemu-devel] [PATCH] Rewrite block filter snapshot authorization mechanism

2014-03-10 Thread Benoît Canet
The Monday 03 Mar 2014 à 19:11:33 (+0100), Benoît Canet wrote : > Rewrite the snapshot authorization mechanism for block filter as suggested by > Paolo. > > run testsuite > > and > > Tested BlockBackend snapshots > Tested quorum snapshot > Tested that snapshot below or above the active qcow2 fil

Re: [Qemu-devel] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-03-10 Thread BALATON Zoltan
Ping! http://patchwork.ozlabs.org/patch/324674/ On Thu, 27 Feb 2014, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan --- hw/char/serial-pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/char/serial-pci.c b/hw/char/serial-pci.c index 991c99f..e662b77 100644 --- a/hw/char/serial-pci

Re: [Qemu-devel] [PATCH v2] q35: Correct typo BRDIGE -> BRIDGE

2014-03-10 Thread BALATON Zoltan
Ping! Also here: http://patchwork.ozlabs.org/patch/325129/ On Fri, 28 Feb 2014, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan --- v2: Sorry, I was too fast to send it. Found two more places to change. hw/pci-host/q35.c | 10 +- include/hw/i386/ich9.h| 2 +- include/hw

Re: [Qemu-devel] SMBIOS (Set of 10 patches)

2014-03-10 Thread Gabriel L. Somlo
On Mon, Mar 10, 2014 at 02:17:25PM -0400, Gabriel L. Somlo wrote: > > 'qemu send-email -10 --annotate --cover-letter' defaults to the proper > > threading, along with letting you modify your cover letter in your > > editor before actually sending. > > That sounds awesome, but there's no "send-emai

Re: [Qemu-devel] [PATCH v2 4/5] w32: Replace Windows specific data types in common header files

2014-03-10 Thread Stefan Weil
Am 10.03.2014 16:17, schrieb Stefan Hajnoczi: > On Fri, Mar 07, 2014 at 11:17:46PM +0100, Stefan Weil wrote: >> diff --git a/include/qemu/thread-win32.h b/include/qemu/thread-win32.h >> index 7ade61a..b8b8e61 100644 >> --- a/include/qemu/thread-win32.h >> +++ b/include/qemu/thread-win32.h >> @@ -1,

Re: [Qemu-devel] [PATCH] net: L2TPv3 transport

2014-03-10 Thread Anton Ivanov (antivano)
On 10/03/14 15:05, Stefan Hajnoczi wrote: > On Mon, Mar 10, 2014 at 11:31:38AM +, anton.iva...@kot-begemot.co.uk > wrote: >> From: Anton Ivanov >> >> This tranport allows to connect a qemu nic to a static Ethernet >> over L2TPv3 tunnel. The transport supports all options present >> in the lin

Re: [Qemu-devel] test-qapi-visit causes clang -fsanitize=undefined warning

2014-03-10 Thread Markus Armbruster
Peter Maydell writes: > On 10 March 2014 13:36, Markus Armbruster wrote: >> Peter Maydell writes: >> Turns out my clang installation doesn't support -fsanitize=undefined: it >> lacks libclang_rt.san-x86_64.a. >> >> Test works fine without -fsanitize=undefined. I set a breakpoint on >> visit_ty

Re: [Qemu-devel] [PATCH v6] vl.c: Output error on invalid machine type

2014-03-10 Thread Andreas Färber
Hi, Am 10.03.2014 09:35, schrieb Miroslav Rezanina: > Hi, > is there any issue with this patch? It conflicts with Marcel's machine rework that I have queued. I wonder if we can avoid the reindent to minimize the collision by adding an exit(EXIT_FAILURE) in the new if? Regards, Andreas > Mirek

Re: [Qemu-devel] SMBIOS (Set of 10 patches)

2014-03-10 Thread Gabriel L. Somlo
On Mon, Mar 10, 2014 at 11:55:13AM -0600, Eric Blake wrote: > On 03/10/2014 10:56 AM, Gabriel L. Somlo wrote: > > Not quite right. The cover letter should not have In-Reply-To, but the > remaining patches SHOULD be in-reply-to the cover letter. That is, you > don't want to create 11 top-level th

Re: [Qemu-devel] [PATCH] target-arm: Fix intptr_t vs tcg_target_long

2014-03-10 Thread Richard Henderson
On 03/10/2014 09:06 AM, Peter Maydell wrote: > which I am proposing would be better written as > tcg_gen_exit_tb(NULL, 0) > tcg_gen_exit_tb(tb, 0) > tcg_gen_exit_tb(tb, n) > > and letting tcg_gen_exit_tb() do the cast to uintptr_t > and add. Oh, I see. Yes, that would be fine. r~

[Qemu-devel] [PATCH v2] Add qga/qapi-generated to .gitignore

2014-03-10 Thread Gabriel L. Somlo
The folder "qga/qapi-generated" shows up after building QEMU, and gets in the way during e.g. "git add ."; Add it to .gitignore to keep it from accidentally ending up in the wrong place. Signed-off-by: Gabriel Somlo --- On Mon, Mar 10, 2014 at 11:57:18AM -0600, Eric Blake wrote: > Why didn't you

Re: [Qemu-devel] [PATCH] Add qga/qapi-generated to .gitignore

2014-03-10 Thread Eric Blake
On 03/10/2014 11:14 AM, Gabriel L. Somlo wrote: > The folder "qga/qapi-generated" shows up after building QEMU, and > gets in the way during e.g. "git add ."; Add it to .gitignore to > keep it from accidentally ending up in the wrong place. > > Signed-off-by: Gabriel Somlo > --- > .gitignore | 1

Re: [Qemu-devel] SMBIOS (Set of 10 patches)

2014-03-10 Thread Eric Blake
On 03/10/2014 10:56 AM, Gabriel L. Somlo wrote: > Hi, > > This patch set builds full smbios tables in QEMU, and sends them to > the bios via fw_cfg as SMBIOS_TABLE_ENTRY blobs. > > I'm resending these without the "In-Reply-To" line to avoid having > them getting buried under a bunch of other emai

[Qemu-devel] [PATCH v3 1/2] virtio-console: QOM cast cleanup for VirtConsole

2014-03-10 Thread Andreas Färber
Introduce type constant, cast macro and rename parent field. Signed-off-by: Andreas Färber --- hw/char/virtio-console.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/hw/char/virtio-console.c b/hw/char/virtio-console.c index 2e00ad2..73e18

[Qemu-devel] [PATCH v3 0/2] QOM realize for virtio-console

2014-03-10 Thread Andreas Färber
Hello, This series converts VirtIOSerialPort to QOM realize/unrealize. v3 minimizes changes by adopting Anthony's new scheme of just replacing fields, as done for VirtioDevices already. I have simple qtests for virtio-serial-bus and virtio-console on a different branch that I'll submit shortly,

Re: [Qemu-devel] [PATCH v4 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-10 Thread Eric Blake
On 03/07/2014 02:54 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 03/05/2014 07:36 PM, Amos Kong wrote: >>> vm_config_groups[] only contains part of the options which have >>> argument, and all options which have no argument aren't added >>> to vm_config_groups[]. Current query-comman

Re: [Qemu-devel] [PATCH v2 1/5] w32: Add and use intermediate include file for windows.h

2014-03-10 Thread Stefan Weil
Am 10.03.2014 09:56, schrieb Markus Armbruster: > Stefan Weil writes: > >> Including windows.h from the new file include/qemu/winapi.h allows >> better tracking of the files which depend on the Windows API. >> >> 1864 *.o files depend on windows.h in a typical build, only 88 *.o files >> don't. >

[Qemu-devel] [PATCH v3 2/2] virtio-serial-port: Convert to QOM realize/unrealize

2014-03-10 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/char/virtio-console.c | 28 ++--- hw/char/virtio-serial-bus.c | 52 --- include/hw/virtio/virtio-serial.h | 14 +-- 3 files changed, 47 insertions(+), 47 deletions(-) diff --git a/hw/c

Re: [Qemu-devel] Trying to get fstrim / discard=unmap to work

2014-03-10 Thread Richard W.M. Jones
On Mon, Mar 10, 2014 at 05:57:01PM +0100, Paolo Bonzini wrote: > Il 10/03/2014 17:14, Richard W.M. Jones ha scritto: > >On Mon, Mar 10, 2014 at 04:11:20PM +, Richard W.M. Jones wrote: > >>Guest: > >> - guest kernel: 3.13.4-200.fc20.x86_64 > >> - ext4 guest filesystem > >> - fstrim from util-lin

[Qemu-devel] [PATCH] Add qga/qapi-generated to .gitignore

2014-03-10 Thread Gabriel L. Somlo
The folder "qga/qapi-generated" shows up after building QEMU, and gets in the way during e.g. "git add ."; Add it to .gitignore to keep it from accidentally ending up in the wrong place. Signed-off-by: Gabriel Somlo --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/

Re: [Qemu-devel] [PATCH v3] migration: add more traces

2014-03-10 Thread Amit Shah
On (Wed) 05 Mar 2014 [02:14:56], Alexey Kardashevskiy wrote: > This replaces DPRINTF macro with tracepoints. > > This moves some messages from migration.c to savevm.c. > > This adds tracepoint to signal about fileds failed to migrate. > > Signed-off-by: Alexey Kardashevskiy > --- > > This is v

Re: [Qemu-devel] [PATCH for-2.0 v2] pseries: Update SLOF firmware image to qemu-slof-20140304

2014-03-10 Thread Andreas Färber
Am 10.03.2014 13:07, schrieb Alexey Kardashevskiy: > The changelog is: > > version: update to 20140304 > > Introduce dummy console device > > vio-vscsi: Fix CRQ allocation alignment > > version: update to 20140204 > > virtio-9p: disable unused structure > > Make "boot net:dhcp" boot fro

[Qemu-devel] [PATCH 10/10] SMBIOS: Build full smbios v2.3 compliant type 16 and 17 tables

2014-03-10 Thread Gabriel L. Somlo
Build full smbios type 16 (physical memory array) and type 17 (memory device) tables, and make them available to the bios via fw_cfg. Type 17 tables will comply with smbios v2.3, which helps prevent the OS X GUI from crashing when "about this mac" is selected. Signed-off-by: Gabriel Somlo --- Th

[Qemu-devel] [PATCH 8/10] SMBIOS: Build full type 3 table

2014-03-10 Thread Gabriel L. Somlo
Build smbios type 3 (system enclosure) table, and make it available to the bios via fw_cfg. Signed-off-by: Gabriel Somlo --- hw/i386/smbios.c | 64 1 file changed, 64 insertions(+) diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c index 54

[Qemu-devel] [PATCH 7/10] SMBIOS: Remove unused code for passing individual fields to bios

2014-03-10 Thread Gabriel L. Somlo
This patch removes smbios_add_field() and the old code to insert individual fields for types 0 and 1 into fw_cfg. Signed-off-by: Gabriel Somlo --- hw/i386/smbios.c | 80 1 file changed, 80 deletions(-) diff --git a/hw/i386/smbios.c b/hw/i

[Qemu-devel] [PATCH 4/10] SMBIOS: Use bitmaps to check for smbios table collisions

2014-03-10 Thread Gabriel L. Somlo
Replace existing smbios_check_collision() functionality with a pair of bitmaps: have_binfile_bitmap and have_fields_bitmap. Bits corresponding to each smbios type are set by smbios_entry_add(), which also uses the bitmaps to ensure that binary blobs and field values are never accepted for the same

  1   2   3   >