On Mon, Mar 10, 2014 at 07:10:39PM +0000, Peter Maydell wrote:
> Add U suffix to avoid undefined behaviour.
>
> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
> ---
> hw/pci/pci_host.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/pci/pci_host.c b/hw/pci/pci_host.c
> index 77c7d1f..2c17916 100644
> --- a/hw/pci/pci_host.c
> +++ b/hw/pci/pci_host.c
> @@ -142,8 +142,9 @@ static uint64_t pci_host_data_read(void *opaque,
> {
> PCIHostState *s = opaque;
> uint32_t val;
> - if (!(s->config_reg & (1 << 31)))
> + if (!(s->config_reg & (1u << 31))) {
> return 0xffffffff;
> + }
> val = pci_data_read(s->bus, s->config_reg | (addr & 3), len);
> PCI_DPRINTF("read addr " TARGET_FMT_plx " len %d val %x\n",
> addr, len, val);
> --
> 1.9.0
>
