[Qemu-devel] [PATCH 04/13 v7] dump: add API to write vmcore

2014-01-16 Thread qiaonuohan
Function is used to write vmcore in flatten format. In flatten format, data is written block by block, and in front of each block, a struct MakedumpfileDataHeader is stored there to indicate the offset and size of the data block. struct MakedumpfileDataHeader { int64_t offset; int64_t buf_

[Qemu-devel] [PATCH 12/13 v7] dump: make kdump-compressed format available for 'dump-guest-memory'

2014-01-16 Thread qiaonuohan
Make monitor command 'dump-guest-memory' be able to dump in kdump-compressed format. The command's usage: dump [-p] protocol [begin] [length] [format] 'format' is used to specified the format of vmcore and can be: 1. 'elf': ELF format, without compression 2. 'kdump-zlib': kdump-compressed forma

[Qemu-devel] [PATCH 08/13 v7] dump: add API to write dump header

2014-01-16 Thread qiaonuohan
the functions are used to write header of kdump-compressed format to vmcore. Header of kdump-compressed format includes: 1. common header: DiskDumpHeader32 / DiskDumpHeader64 2. sub header: KdumpSubHeader32 / KdumpSubHeader64 3. extra information: only elf notes here Signed-off-by: Qiao Nuohan Re

[Qemu-devel] [PATCH 02/13 v7] dump: add argument to write_elfxx_notes

2014-01-16 Thread qiaonuohan
write_elf32_notes/wirte_elf64_notes use fd_write_vmcore to write elf notes to vmcore. Adding parameter "WriteCoreDumpFunction f" makes it available to choose the method of writing elf notes Signed-off-by: Qiao Nuohan Reviewed-by: Laszlo Ersek --- dump.c | 16 1 files changed,

[Qemu-devel] [PATCH 03/13 v7] dump: add API to write header of flatten format

2014-01-16 Thread qiaonuohan
flatten format will be used when writing kdump-compressed format. The format is also used by makedumpfile, you can refer to the following URL to get more detailed information about flatten format of kdump-compressed format: http://sourceforge.net/projects/makedumpfile/ The two functions here are u

[Qemu-devel] [PATCH 13/13 v7] dump: add 'query-dump-guest-memory-capability' command

2014-01-16 Thread qiaonuohan
'query-dump-guest-memory-capability' is used to query whether option 'format' is available for 'dump-guest-memory' and the available format. The output of the command will be like: -> { "execute": "query-dump-guest-memory-capability" } <- { "return": { "format-option": "optional",

[Qemu-devel] [PATCH 05/13 v7] dump: add API to write elf notes to buffer

2014-01-16 Thread qiaonuohan
the function can be used by write_elf32_notes/write_elf64_notes to write notes to a buffer. If fd_write_vmcore is used, write_elf32_notes/write_elf64_notes will write elf notes to vmcore directly. Instead, if buf_write_note is used, elf notes will be written to opaque->note_buf at first. Signed-of

[Qemu-devel] [PATCH 07/13 v7] dump: add members to DumpState and init some of them

2014-01-16 Thread qiaonuohan
add some members to DumpState that will be used in writing vmcore in kdump-compressed format. some of them, like page_size, will be initialized in the patch. Signed-off-by: Qiao Nuohan --- dump.c| 30 ++ include/sysemu/dump.h |7 +++ 2 files

[Qemu-devel] [PATCH 06/13 v7] dump: add support for lzo/snappy

2014-01-16 Thread qiaonuohan
kdump-compressed format supports three compression format, zlib/lzo/snappy. Currently, only zlib is available. This patch is used to support lzo/snappy. '--enable-lzo/--enable-snappy' is needed to be specified with configure to make lzo/snappy available for qemu Signed-off-by: Qiao Nuohan Reviewe

[Qemu-devel] [PATCH 01/13 v7] dump: const-qualify the buf of WriteCoreDumpFunction

2014-01-16 Thread qiaonuohan
WriteCoreDumpFunction is a function pointer that points to the function used to write content in "buf" into core file, so "buf" should be const-qualify. Signed-off-by: Qiao Nuohan --- dump.c|2 +- include/qom/cpu.h |3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) dif

Re: [Qemu-devel] [PATCH v2] docs/specs/qcow2.txt: fix incorrect bits of offsets in entries

2014-01-16 Thread Stefan Hajnoczi
On Mon, Dec 30, 2013 at 04:00:17PM +0800, Hu Tao wrote: > Fix incorrect bits of offsets in refcount table entry, l1 table > entry and l2 table entry. See REFT_OFFSET_MASK, L1E_OFFSET_MASK > and L2E_OFFSET_MASK. > > Fix a typo while at the file. > > Signed-off-by: Hu Tao > --- > > v2: update com

Re: [Qemu-devel] [PATCH 1/2] block: resize backing file image during offline commit, if necessary

2014-01-16 Thread Stefan Hajnoczi
On Mon, Jan 13, 2014 at 03:18:45PM -0500, Jeff Cody wrote: > @@ -1904,7 +1904,19 @@ int bdrv_commit(BlockDriverState *bs) > } > } > > -total_sectors = bdrv_getlength(bs) >> BDRV_SECTOR_BITS; > +length = bdrv_getlength(bs); > + > +/* If our top snapshot is larger than the

Re: [Qemu-devel] [PATCH 0/2] block: commits of snapshots larger than backing files

2014-01-16 Thread Stefan Hajnoczi
On Mon, Jan 13, 2014 at 03:18:44PM -0500, Jeff Cody wrote: > If a snapshot is larger than a backing file, then the offline bdrv_commit and > the live active layer commit will fail with an i/o error (usually). A live > commit of a non-active layer will complete successfully, as it runs > bdrv_trunc

Re: [Qemu-devel] [PATCH v1 0/4] -object/object-add add 2nd stage initialization

2014-01-16 Thread Stefan Hajnoczi
On Thu, Jan 16, 2014 at 05:34:35PM +0100, Igor Mammedov wrote: > Adds UserCreatable interface that objects must inherit from > If they need to be created with help of -object/object-add > commands. > > Interface also provides an optional complete() callback, > that is called after object propertie

Re: [Qemu-devel] ?????? ?????? ?????? ?????? ?????? ?????? qemu vm big network latency when met heavy io

2014-01-16 Thread Josh Durgin
On 01/15/2014 10:12 PM, ?? wrote: Hi Josh # strings /usr/bin/qemu-system-x86_64 | grep rbd_aio rbd_aio_write rbd_aio_flush rbd_aio_read rbd_aio_create_completion rbd_aio_release rbd_aio_discard rbd_aio_get_return_value So, librbd's asynchronous flush is being used. I set log settings, fetc

[Qemu-devel] Question on pointers in the qemu user space emulation

2014-01-16 Thread Erik de Castro Lopo
Hi all, I'm currently working on implementing a missing part of a linux-user syscall. This syscall includes a function pointer for a callback. If one has a 64 bit user space emulation running on a 32 bit host, how does one handle the fact that the pointer might be 64 bits? Does the fact that the

[Qemu-devel] [PATCH] spapr: fix H_SET_MODE to sync LPCR with KVM

2014-01-16 Thread Alexey Kardashevskiy
The kvm_cpu_exec() only puts registers to KVM if the @kvm_vcpu_dirty flag has been set. This adds registers sync which also sets @kvm_vcpu_dirty so we store new LPCR to KVM before continuing with the KVM_RUN ioctl. Signed-off-by: Alexey Kardashevskiy --- hw/ppc/spapr_hcall.c | 2 ++ 1 file chan

Re: [Qemu-devel] [PULL 11/11] vl: Add a blank space between the variable and '='

2014-01-16 Thread Kewei Yu
Thanks, I will send patch with prefix to indicate which file of the codebase after this. Regard Kewei 2014/1/17 Michael Tokarev > From: Kewei Yu > > Signed-off-by: Kewei Yu > Signed-off-by: Michael Tokarev > --- > vl.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --g

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/1] Add a blank space between the variable and '='

2014-01-16 Thread Kewei Yu
2014/1/16 Peter Maydell > On 16 January 2014 10:50, Michael Tokarev wrote: > > Thanks, applied. > > Can you fix the subject line in your tree to have a > prefix indicating which area of the codebase it affects, > please? > OK, Thanks for your review. I will send it again. > > thanks > -- PMM >

Re: [Qemu-devel] [PATCH 1/6] qemu-fd-exchange: provide common methods for exchange fd

2014-01-16 Thread Lei Li
On 01/16/2014 11:26 PM, Eric Blake wrote: On 01/08/2014 02:12 AM, Lei Li wrote: Signed-off-by: Lei Li --- include/qemu/fd-exchange.h | 25 +++ util/Makefile.objs |1 + util/qemu-fd-exchange.c| 97 3 files changed, 123

Re: [Qemu-devel] [PATCH 4/6] virtfs-proxy-helper: replace send_fd with qemu_send_with_fd

2014-01-16 Thread Lei Li
On 01/16/2014 06:15 PM, Daniel P. Berrange wrote: On Wed, Jan 08, 2014 at 05:12:54PM +0800, Lei Li wrote: Signed-off-by: Lei Li --- fsdev/virtfs-proxy-helper.c | 51 ++ hw/9pfs/virtio-9p-proxy.h |5 2 files changed, 8 insertions(+), 48 de

Re: [Qemu-devel] [PATCH 5/6] virtio-9p-proxy: replace v9fs_receivefd with qemu_recv_with_fd

2014-01-16 Thread Lei Li
On 01/16/2014 06:16 PM, Daniel P. Berrange wrote: On Wed, Jan 08, 2014 at 05:12:55PM +0800, Lei Li wrote: Signed-off-by: Lei Li --- hw/9pfs/virtio-9p-proxy.c | 60 ++-- 1 files changed, 3 insertions(+), 57 deletions(-) diff --git a/hw/9pfs/virtio-9p

Re: [Qemu-devel] [PATCH 1/6] qemu-fd-exchange: provide common methods for exchange fd

2014-01-16 Thread Lei Li
On 01/16/2014 11:16 PM, Eric Blake wrote: On 01/08/2014 02:12 AM, Lei Li wrote: Signed-off-by: Lei Li --- include/qemu/fd-exchange.h | 25 +++ util/Makefile.objs |1 + util/qemu-fd-exchange.c| 97 3 files changed, 123

Re: [Qemu-devel] [PATCH v2 2/6] net: removing tap_using_vnet_hdr() function

2014-01-16 Thread Stefan Hajnoczi
On Thu, Jan 16, 2014 at 11:29:34AM +0200, Michael S. Tsirkin wrote: > On Tue, Jan 14, 2014 at 11:59:46AM +0100, Vincenzo Maffione wrote: > > This function was used to set the using_vnet_hdr field into the > > TAPState struct. However, it is always called immediately before > > (see virtio-net.c) or

Re: [Qemu-devel] [PATCH v2 0/6] Add netmap backend offloadings support

2014-01-16 Thread Stefan Hajnoczi
On Thu, Jan 16, 2014 at 04:00:36PM +0100, Vincenzo Maffione wrote: > 2014/1/16 Stefan Hajnoczi > > > On Tue, Jan 14, 2014 at 11:59:44AM +0100, Vincenzo Maffione wrote: > > > (3) There is actually an important problem. In the previous patch > > version, TCP/UDP traffic was > > > supported betw

Re: [Qemu-devel] [PATCH v2 1/2] hw/net: add support for Allwinner EMAC Fast Ethernet controller

2014-01-16 Thread Stefan Hajnoczi
On Thu, Jan 16, 2014 at 10:52:19PM +1000, Peter Crosthwaite wrote: > > Perhaps we should just rely on > > NetClient->link_ok. > > > > I think we are in agreement then? There is no need for phy.link_ok as > same information is captured in NetClient. This means there is no > link_ok field to migrate

Re: [Qemu-devel] [PATCH V7 3/6] qemu-iotests: add 058 internal snapshot export with qemu-nbd case

2014-01-16 Thread Wenchao Xia
于 2014/1/16 20:52, Kevin Wolf 写道: Am 04.12.2013 um 10:10 hat Wenchao Xia geschrieben: This case can't run when IMGPROTO=nbd, since it needs to create some internal snapshot which would fail for EOF write request, even when TEST_IMG is exported with "-f raw" in common.rc, so set _supported_proto

Re: [Qemu-devel] [PATCH v2 13/24] block: Introduce bdrv_co_do_pwritev()

2014-01-16 Thread Fam Zheng
On Thu, 01/16 13:25, Kevin Wolf wrote: > Am 13.12.2013 um 14:22 hat Kevin Wolf geschrieben: > > This is going to become the bdrv_co_do_preadv() equivalent for writes. > > In this patch, however, just a function taking byte offsets is created, > > it doesn't align anything yet. > > > > Signed-off-b

Re: [Qemu-devel] [PATCH v2 1/1] genius: add genius serial mouse emulation

2014-01-16 Thread Romain Naour
Hi, Le 14/01/2014 23:46, Peter Maydell a écrit : It might be helpful to note why we should care, ie if there are any particularly interesting guests which can only deal with this and not the MS mouse protocol, or if there are mouse features you can only get support for with this protocol. I wor

Re: [Qemu-devel] troubleshooting live migration

2014-01-16 Thread Marcin Gibuła
> I tried -no-hpet, was still able to replicate the 'lapic' issue. I > find it interesting that I can only trigger it if the vm has been > running awhile. Hi, I've seen identical crashes with live migration in our environment. It looks identical - VM has to be idle for some time and after migra

[Qemu-devel] [Bug 1254828] Re: qemu-sparc64-static: Segmentation Fault during debootstrap second stage

2014-01-16 Thread Ken Sharp
Tried again with today's git and the result is a bit different: I: Running command: chroot debian-sparc64-sid /debootstrap/debootstrap --second-stage Unhandled trap: 0x34 pc: 001109a4 npc: 001109a8 %g0-3: 0001 0021b800 %g4-7:

Re: [Qemu-devel] [PATCH v2 12/14] spapr_events: re-use EPOW event infrastructure for hotplug events

2014-01-16 Thread Michael Roth
Quoting Alexey Kardashevskiy (2013-12-15 23:05:55) > On 12/06/2013 09:33 AM, Michael Roth wrote: > > From: Nathan Fontenot > > > > This extends the data structures currently used to report EPOW events to > > gets via the check-exception RTAS interfaces to also include event types > > for hotplug/

Re: [Qemu-devel] [PATCH v2 11/14] spapr_pci: enable basic hotplug operations

2014-01-16 Thread Michael Roth
Quoting Alexey Kardashevskiy (2013-12-15 22:36:32) > On 12/06/2013 09:33 AM, Michael Roth wrote: > > From: Mike Day > > > > This enables hotplug for PHB bridges. Upon hotplug we generate the > > OF-nodes required by PAPR specification and IEEE 1275-1994 > > "PCI Bus Binding to Open Firmware" for

[Qemu-devel] [Bug 1254672] Re: ps segfaults with qemu-{arm, armel, mips, powerpc}-static

2014-01-16 Thread Ken Sharp
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1254672 Title: ps segfaults with qemu-{arm,armel,mips,powerpc}-static Status in QEMU:

Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf.

2014-01-16 Thread Hervé Poussineau
Hi, Miki Mishael a écrit : Support for pci-serial-2x and pci-serial-4x added to inf file. Standard Windows driver mf.sys used to split single function device into per-port nodes. Signed-off-by: Miki Mishael Signed-off-by: Dmitry Fleytman --- docs/qemupciserial.i

Re: [Qemu-devel] [PATCH v2 05/14] spapr_pci: add get/set-power-level RTAS interfaces

2014-01-16 Thread Michael Roth
Quoting Alexey Kardashevskiy (2013-12-15 21:09:09) > On 12/06/2013 09:32 AM, Michael Roth wrote: > > From: Nathan Fontenot > > > > Signed-off-by: Nathan Fontenot > > Signed-off-by: Michael Roth > > --- > > hw/ppc/spapr_pci.c | 22 ++ > > 1 file changed, 22 insertions(+) >

Re: [Qemu-devel] [PATCH v2 04/14] spapr_pci: add set-indicator RTAS interface

2014-01-16 Thread Michael Roth
Quoting Alexey Kardashevskiy (2013-12-15 22:26:32) > On 12/06/2013 09:32 AM, Michael Roth wrote: > > From: Mike Day > > > > Signed-off-by: Mike Day > > Signed-off-by: Michael Roth > > --- > > hw/ppc/spapr_pci.c | 93 > > > > include/hw/pp

Re: [Qemu-devel] [PATCH v2 01/14] spapr: populate DRC entries for root dt node

2014-01-16 Thread Michael Roth
Quoting Alexey Kardashevskiy (2013-12-15 22:54:42) > On 12/16/2013 01:59 PM, Alexey Kardashevskiy wrote: > > On 12/06/2013 09:32 AM, Michael Roth wrote: > >> From: Nathan Fontenot > >> > >> This add entries to the root OF node to advertise our PHBs as being > >> DR-capable in according with PAPR s

Re: [Qemu-devel] [PATCH v2] target-ppc: gdbstub allow byte swapping for reading/writing registers

2014-01-16 Thread Thomas Falcon
On 01/16/2014 11:10 AM, Alexander Graf wrote: On 16.01.2014, at 17:59, Thomas Falcon wrote: This patch allows registers to be properly read from and written to when using the gdbstub to debug a ppc guest running in little endian mode. It accomplishes this goal by byte swapping the values of a

Re: [Qemu-devel] [PATCH] block: do not allow read-only=on and snapshot=on to be used together

2014-01-16 Thread Jeff Cody
On Thu, Jan 16, 2014 at 10:39:30AM +0100, Kevin Wolf wrote: > Am 14.01.2014 um 20:12 hat Jeff Cody geschrieben: > > Having both read-only=on and snapshot=on together does not make sense; > > currently, the read-only argument is effectively ignored for the > > temporary snapshot. To prevent confusi

Re: [Qemu-devel] [PATCH v2] target-ppc: gdbstub allow byte swapping for reading/writing registers

2014-01-16 Thread Peter Maydell
On 16 January 2014 17:51, Alexander Graf wrote: >> Am 16.01.2014 um 18:41 schrieb Peter Maydell : >> Also see my remarks on the previous patch series suggesting >> that we should look at this in a more holistic way than >> just randomly fixing small bits of things. A good place >> to start would b

[Qemu-devel] [PULL 06/11] ide: cmd_exec_dev_diagnostic() always set error register to 0x01

2014-01-16 Thread Michael Tokarev
From: David du Colombier <0in...@gmail.com> This notably fix IDE CD probing on the Plan 9 operating system, which rely on the error register set by the Execute Device Diagnostic command to detect drive configurations. Thanks to Rémi Pommarel for reporting this issue. Signed-off-by: David du Colo

Re: [Qemu-devel] [PATCH v2] target-ppc: gdbstub allow byte swapping for reading/writing registers

2014-01-16 Thread Alexander Graf
> Am 16.01.2014 um 18:41 schrieb Peter Maydell : > >> On 16 January 2014 16:59, Thomas Falcon wrote: >> This patch allows registers to be properly read from and written to >> when using the gdbstub to debug a ppc guest running in little >> endian mode. It accomplishes this goal by byte swappin

[Qemu-devel] [PULL 01/11] docs: Fix typo in QMP WAKEUP example

2014-01-16 Thread Michael Tokarev
From: Namhyung Kim Cc: qemu-triv...@nongnu.org Signed-off-by: Namhyung Kim Reviewed-by: Markus Armbruster Signed-off-by: Michael Tokarev --- docs/qmp/qmp-events.txt |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt index 6

[Qemu-devel] [PULL 09/11] linux-user: fixed recvfrom() addrlen

2014-01-16 Thread Michael Tokarev
From: Pavel Zbitskiy addrlen parameter of recvfrom() of type socklen_t* was read into variable of type socklen_t, that caused zeroing out of upper 4 bytes when running s390x on top of x86_64. This patch changes addrlen type to abi_ulong. Signed-off-by: Pavel Zbitskiy Signed-off-by: Michael Toka

[Qemu-devel] [PULL 05/11] virtio-balloon: don't hardcode config size value

2014-01-16 Thread Michael Tokarev
From: Luiz Capitulino Use sizeof(struct virtio_balloon_config) instead. Signed-off-by: Luiz capitulino Reviewed-by: Peter Crosthwaite Signed-off-by: Michael Tokarev --- hw/virtio/virtio-balloon.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/virtio/virtio-b

[Qemu-devel] [PULL 00/11] Trivial patches for 2014-01-16

2014-01-16 Thread Michael Tokarev
There's nothing exciting in there, but we have some small bugfixes here and there, and a few cosmetic changes too. This is my first signed pull request too, based on my regular GnuPG key which I use to sign Debian packages. Please pull. Thanks, /mjt The following changes since commit 1cf892ca2

[Qemu-devel] [PULL 04/11] exec: Exclude non portable function for MinGW

2014-01-16 Thread Michael Tokarev
From: Stefan Weil cpu_physical_memory_set_dirty_lebitmap calls getpageaddr and ffsl which are unavailable for MinGW. As the function is unused for MinGW, it can simply be excluded from compilation. Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- include/exec/ram_addr.h |2 ++

[Qemu-devel] [PULL 08/11] linux-user: fixed getsockopt() optlen

2014-01-16 Thread Michael Tokarev
From: Pavel Zbitskiy optlen parameter of getsockopt() of type socklen_t* was read into variable of type socklen_t, that caused zeroing out of upper 4 bytes when running s390x on top of x86_64. This patch changes optlen type to abi_ulong. Signed-off-by: Pavel Zbitskiy Signed-off-by: Michael Toka

Re: [Qemu-devel] [PATCH v2] target-ppc: gdbstub allow byte swapping for reading/writing registers

2014-01-16 Thread Peter Maydell
On 16 January 2014 16:59, Thomas Falcon wrote: > This patch allows registers to be properly read from and written to > when using the gdbstub to debug a ppc guest running in little > endian mode. It accomplishes this goal by byte swapping the values of > any registers if the MSR:LE value is set.

[Qemu-devel] [PULL 11/11] vl: Add a blank space between the variable and '='

2014-01-16 Thread Michael Tokarev
From: Kewei Yu Signed-off-by: Kewei Yu Signed-off-by: Michael Tokarev --- vl.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 7f4fe0d..2b47866 100644 --- a/vl.c +++ b/vl.c @@ -2925,7 +2925,7 @@ int main(int argc, char **argv, char **envp) bdrv_i

[Qemu-devel] [PULL 03/11] Add bios-256k.bin to BLOBS on Makefile

2014-01-16 Thread Michael Tokarev
From: Eduardo Habkost The default machine-type (pc-i440fx-2.0) now requires bios-256k.bin, but "make install" isn't installing it, so qemu-system-x86_64 won't run out of the box. Add it to BLOBS so it gets installed. Signed-off-by: Eduardo Habkost Reviewed-by: Gerd Hoffmann Tested-by: William

[Qemu-devel] [PULL 10/11] pc-bios: Remove execute flag from BIOS files

2014-01-16 Thread Michael Tokarev
From: Stefan Weil BIOS files are not directly executable, so they don't need this flag. All other BIOS files don't use the execute flag. Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- pc-bios/kvmvapic.bin | Bin 9216 -> 9216 bytes pc-bios/multiboot.bin | Bin 1024 -> 1024 byt

[Qemu-devel] [PULL 02/11] Fix typo of tiemr in timer.h

2014-01-16 Thread Michael Tokarev
From: Namhyung Kim Signed-off-by: Namhyung Kim Reviewed-by: Stefan Hajnoczi Signed-off-by: Michael Tokarev --- include/qemu/timer.h |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/qemu/timer.h b/include/qemu/timer.h index 5afcffc..7f9a074 100644 --- a/incl

[Qemu-devel] [PULL 07/11] linux-user: fixed s390x clone() argument order

2014-01-16 Thread Michael Tokarev
From: Pavel Zbitskiy It was broken by 4ce6243dc6216e35b5b691078ffa856463bfa8db, where TARGET_CLONE_BACKWARDS was specified instead of TARGET_CLONE_BACKWARDS2. Signed-off-by: Pavel Zbitskiy Reviewed-by: Peter Maydell Signed-off-by: Michael Tokarev --- linux-user/s390x/syscall.h |2 +- 1 f

Re: [Qemu-devel] [PATCH V5 0/7] Giving names to BlockDriverState graph nodes

2014-01-16 Thread Benoît Canet
Le Thursday 12 Dec 2013 à 16:33:53 (+0100), Benoît Canet a écrit : > v5: > block empty node names [Kevin] > factorize setting of node-name option [Kevin] > NULL terminate node_name on removal [Kevin] > make query-named-block-nodes return BlockDeviceInfo structure [Eric] > Change

Re: [Qemu-devel] [PATCH v2] target-ppc: gdbstub allow byte swapping for reading/writing registers

2014-01-16 Thread Alexander Graf
On 16.01.2014, at 17:59, Thomas Falcon wrote: > This patch allows registers to be properly read from and written to > when using the gdbstub to debug a ppc guest running in little > endian mode. It accomplishes this goal by byte swapping the values of > any registers if the MSR:LE value is set.

[Qemu-devel] [PATCH v2] target-ppc: gdbstub allow byte swapping for reading/writing registers

2014-01-16 Thread Thomas Falcon
This patch allows registers to be properly read from and written to when using the gdbstub to debug a ppc guest running in little endian mode. It accomplishes this goal by byte swapping the values of any registers if the MSR:LE value is set. Signed-off-by: Thomas Falcon --- Have created wrapper

[Qemu-devel] [PATCH 1/3] acpi unit-test: renamed ssdt_tables to tables

2014-01-16 Thread Marcel Apfelbaum
Just a refactoring, ssdt_tables name was confusing as it included other tables as well. Signed-off-by: Marcel Apfelbaum --- tests/acpi-test.c | 48 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/tests/acpi-test.c b/tests/acpi-test

[Qemu-devel] [PATCH 2/3] acpi unit-test: resolved iasl crash

2014-01-16 Thread Marcel Apfelbaum
It seems that iasl has an issue when disassembles some ACPI tables using the command line: iasl -e DSDT -e SSDT -d HPET Modified the iasl command line to "iasl -d HPET" until the problem is solved. The command line remained the same for DSDT and SSDT tables. Reported-by: Michael S. Tsirkin Signe

[Qemu-devel] [PATCH 3/3] acpi unit-test: do not fail on asl mismatch

2014-01-16 Thread Marcel Apfelbaum
The asl comparison will break every time the ACPI tables are updated. This may break the git bisect. Instead of failing print a warning on stderr including the retained asl files, so they can be compared offline. Signed-off-by: Marcel Apfelbaum --- tests/acpi-test.c | 13 +++-- 1 file ch

Re: [Qemu-devel] [PATCH v1 2/4] vl.c: -object: don't ingnore duplicate 'id'

2014-01-16 Thread Eric Blake
On 01/16/2014 09:34 AM, Igor Mammedov wrote: s/ingnore/ignore/ in subject > object_property_add_child() may fail if 'id' matches > an already existing object. Which meansi an incorrect s/meansi/means/ > command line. > So instead of silently ignoring error, report it and > terminate QEMU. > >

[Qemu-devel] [PATCH v1 2/4] vl.c: -object: don't ingnore duplicate 'id'

2014-01-16 Thread Igor Mammedov
object_property_add_child() may fail if 'id' matches an already existing object. Which meansi an incorrect command line. So instead of silently ignoring error, report it and terminate QEMU. Signed-off-by: Igor Mammedov --- vl.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-)

[Qemu-devel] [PATCH v1 4/4] virtio_rng: replace custom backend API with UserCreatable.complete() callback

2014-01-16 Thread Igor Mammedov
in addition fix default backend leak by releasing it if its initialization failed. Signed-off-by: Igor Mammedov --- backends/rng.c | 12 ++-- hw/virtio/virtio-rng.c | 15 +-- include/sysemu/rng.h | 11 --- 3 files changed, 19 insertions(+), 19 deletion

[Qemu-devel] [PATCH v1 0/4] -object/object-add add 2nd stage initialization

2014-01-16 Thread Igor Mammedov
Adds UserCreatable interface that objects must inherit from If they need to be created with help of -object/object-add commands. Interface also provides an optional complete() callback, that is called after object properties are set. Which allows * replace custom backend APIs to initialize them w

[Qemu-devel] [PATCH v1 1/4] object_add: consolidate error handling

2014-01-16 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- qmp.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/qmp.c b/qmp.c index 0f46171..a67e0c4 100644 --- a/qmp.c +++ b/qmp.c @@ -549,15 +549,17 @@ void object_add(const char *type, const char *id, const QDict *qdict, for (e

[Qemu-devel] [PATCH v1 3/4] add optional 2nd stage initialization to -object/object-add commands

2014-01-16 Thread Igor Mammedov
Introduces USER_CREATABLE interface that must be implemented by objects which are designed to created with -object CLI option or object-add QMP command. Interface provides an ability to do an optional second stage initialization of the object created with -object/object-add commands. By providing

[Qemu-devel] [RFC PATCH] balloon: add automatic ballooning support

2014-01-16 Thread Luiz Capitulino
The current balloon device has an important drawback: it's entirely manual. This largely limits the feature when used to manage memory on a memory over-committed host. In order to make the balloon device really useful for memory-overcommit setups, we have to make it automatic. This is what this pa

Re: [Qemu-devel] [PATCH 0/2] QEMU/seccomp fixes for PulseAudio

2014-01-16 Thread Paul Moore
On Thursday, January 16, 2014 01:52:30 PM Eduardo Otubo wrote: > On 01/15/2014 05:38 PM, Paul Moore wrote: > > It turns out we need to add some additional syscalls to QEMU to make > > PulseAudio happy. Two minor patches follow ... > > > > --- > > > > Paul Moore (2): > >seccomp: add mkdir

Re: [Qemu-devel] qemu-seccomp.c:228: error: '__NR_getcpu' undeclared here (not in a function)

2014-01-16 Thread Eduardo Otubo
On 01/03/2014 12:54 PM, lejeczek wrote: dear developers I was hoping someone could suggest what is missing or incompatible on my setup that causes a compilation to fail I'm trying to rpmbuild-compile qemu-1.2.2-1.fc18.src.rpm on rhel 6.5 I thought I have got all dependencies from rpm perspect

Re: [Qemu-devel] [PATCH 1/2] seccomp: add mkdir() and fchmod() to the whitelist

2014-01-16 Thread Eduardo Otubo
I have tested and reviewed both patches. And if nothing more comes up, I'll send a pull request by tomorrow EOD. On 01/15/2014 05:38 PM, Paul Moore wrote: The PulseAudio library attempts to do a mkdir(2) and fchmod(2) on "/run/user//pulse" which is currently blocked by the syscall filter; this

Re: [Qemu-devel] [PATCH 0/2] QEMU/seccomp fixes for PulseAudio

2014-01-16 Thread Eduardo Otubo
On 01/15/2014 05:38 PM, Paul Moore wrote: It turns out we need to add some additional syscalls to QEMU to make PulseAudio happy. Two minor patches follow ... --- Paul Moore (2): seccomp: add mkdir() and fchmod() to the whitelist seccomp: add some basic shared memory syscalls to

Re: [Qemu-devel] [PATCH 2/2] seccomp: add some basic shared memory syscalls to the whitelist

2014-01-16 Thread Eduardo Otubo
On 01/15/2014 05:38 PM, Paul Moore wrote: PulseAudio requires the use of shared memory so add shmget(), shmat(), and shmdt() to the syscall whitelist. Reported-by: xu...@redhat.com Signed-off-by: Paul Moore --- qemu-seccomp.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) di

[Qemu-devel] [PATCH 0/3] acpi unit-test: fixes and improvements

2014-01-16 Thread Marcel Apfelbaum
patch 1: refactoring Addressed Michael S. Tsirkin's prev comments: Renamed ssdt_tables to tables to avoid confusion. patch 2: resolved iasl crash Addressed Michael S. Tsirkin's prev comments: Do not assume the order of ssdt tables and single ssdt table. patch 3: do not fail on as

Re: [Qemu-devel] [PATCH 1/6] qemu-fd-exchange: provide common methods for exchange fd

2014-01-16 Thread Eric Blake
On 01/08/2014 02:12 AM, Lei Li wrote: > Signed-off-by: Lei Li > --- > include/qemu/fd-exchange.h | 25 +++ > util/Makefile.objs |1 + > util/qemu-fd-exchange.c| 97 > > 3 files changed, 123 insertions(+), 0 deletions(-) >

Re: [Qemu-devel] [PATCH 1/6] qemu-fd-exchange: provide common methods for exchange fd

2014-01-16 Thread Eric Blake
On 01/08/2014 02:12 AM, Lei Li wrote: > Signed-off-by: Lei Li > --- > include/qemu/fd-exchange.h | 25 +++ > util/Makefile.objs |1 + > util/qemu-fd-exchange.c| 97 > > 3 files changed, 123 insertions(+), 0 deletions(-) >

Re: [Qemu-devel] [PATCH v2 0/6] Add netmap backend offloadings support

2014-01-16 Thread Vincenzo Maffione
2014/1/16 Stefan Hajnoczi > On Tue, Jan 14, 2014 at 11:59:44AM +0100, Vincenzo Maffione wrote: > > (3) There is actually an important problem. In the previous patch > version, TCP/UDP traffic was > > supported between two guests attached to a VALE switch if and only > if both guests use (or >

Re: [Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf.

2014-01-16 Thread Gerd Hoffmann
On Do, 2014-01-16 at 07:18 -0500, Miki Mishael wrote: > Support for pci-serial-2x and pci-serial-4x > added to inf file. > Standard Windows driver mf.sys used to > split single function > device into per-port nodes. Patch looks good. Not that I understand everything

Re: [Qemu-devel] In "pci_fixup_video" check if this is or should be the primary video d

2014-01-16 Thread Bjorn Helgaas
[+cc Michael, Jesse, David, qemu-devel] On Wed, Jan 15, 2014 at 8:58 PM, wrote: > I suggest you should not break the PCI specification, as a developer of > proprietary > hypervisor, but I think your patch is no problem. > Your PCI structure is specialized structure for your virtual machine. > M

[Qemu-devel] [PATCH] char: udp chardev shouldn't require an explicit open.

2014-01-16 Thread Gal Hammer
A chardev with a UDP backend never send the CHR_EVENT_OPENED event. This cause the virtio-serial port not to work because data is dropped when no listner on the host side. Signed-off-by: Gal Hammer --- qemu-char.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c ind

Re: [Qemu-devel] [PATCH V7 3/6] qemu-iotests: add 058 internal snapshot export with qemu-nbd case

2014-01-16 Thread Kevin Wolf
Am 04.12.2013 um 10:10 hat Wenchao Xia geschrieben: > This case can't run when IMGPROTO=nbd, since it needs to create some > internal snapshot which would fail for EOF write request, even when > TEST_IMG is exported with "-f raw" in common.rc, so set _supported_proto > to file. > > _require_comman

Re: [Qemu-devel] [PATCH v2 1/2] hw/net: add support for Allwinner EMAC Fast Ethernet controller

2014-01-16 Thread Peter Crosthwaite
On Thu, Jan 16, 2014 at 12:45 PM, Stefan Hajnoczi wrote: > On Wed, Jan 15, 2014 at 06:24:24PM +1000, Peter Crosthwaite wrote: >> On Tue, Jan 14, 2014 at 3:19 PM, Stefan Hajnoczi wrote: >> > On Mon, Jan 13, 2014 at 11:16:37PM +1000, Peter Crosthwaite wrote: >> >> On Mon, Jan 13, 2014 at 11:15 PM,

Re: [Qemu-devel] [PATCH v16 2/9] rules.mak: allow per object cflags and libs

2014-01-16 Thread Paolo Bonzini
Il 16/01/2014 13:40, Fam Zheng ha scritto: > , compared to > > $(obj)/foo.mo-objs := $(obj)/bar.o $(obj)/biz.o $(obj)/qux.o > > or slightly better > > $(obj)/foo.mo-objs := $(addprefix $(obj), bar.o, biz.o, qux.o) > > I've already converted block/curl.o's cflags to this, later in this s

Re: [Qemu-devel] [PATCH v16 2/9] rules.mak: allow per object cflags and libs

2014-01-16 Thread Fam Zheng
On Thu, 01/16 11:04, Peter Maydell wrote: > On 15 January 2014 08:48, Fam Zheng wrote:.objs. > > Similarly, > > > > foo.o-cflags := $(FOO_CFLAGS) > > > > is also supported. > > I noticed that we already support per-object cflags via: > > $(obj)/adlib.o $(obj)/fmopl.o: QEMU_CFLAGS += -DBU

Re: [Qemu-devel] [PATCH v6 0/8] Vhost and vhost-net support for userspace based backends

2014-01-16 Thread Antonios Motakis
On Wed, Jan 15, 2014 at 3:49 PM, Michael S. Tsirkin wrote: > On Wed, Jan 15, 2014 at 01:50:47PM +0100, Antonios Motakis wrote: > > > > > > > > On Wed, Jan 15, 2014 at 10:07 AM, Michael S. Tsirkin > wrote: > > > > On Tue, Jan 14, 2014 at 07:13:43PM +0100, Antonios Motakis wrote: > > > > >

Re: [Qemu-devel] [PATCH v2 13/24] block: Introduce bdrv_co_do_pwritev()

2014-01-16 Thread Kevin Wolf
Am 13.12.2013 um 14:22 hat Kevin Wolf geschrieben: > This is going to become the bdrv_co_do_preadv() equivalent for writes. > In this patch, however, just a function taking byte offsets is created, > it doesn't align anything yet. > > Signed-off-by: Kevin Wolf > --- > block.c | 23 ++

[Qemu-devel] [PATCH] Docs: Introduce multiport serial support in qemupciserial.inf.

2014-01-16 Thread Miki Mishael
Support for pci-serial-2x and pci-serial-4x added to inf file. Standard Windows driver mf.sys used to split single function device into per-port nodes. Signed-off-by: Miki Mishael Signed-off-by: Dmitry Fleytman --- docs/qemupciserial.inf | 227 +

[Qemu-devel] [PATCH V2 00/01] Docs: Introduce multiport serial support in qemupciserial.inf.

2014-01-16 Thread Miki Mishael
Support for pci-serial-2x and pci-serial-4x added to inf file. Standard Windows driver mf.sys used to split single function device into per-port nodes. Changes since V1: * Removed subsystem & revision strings from the hardware ID string of pci-serial, pci-serial-2x

[Qemu-devel] [PATCH] scsi: Support TEST UNIT READY in the dummy LUN0

2014-01-16 Thread Paolo Bonzini
SeaBIOS waits for LUN0 to respond to the TEST UNIT READY command in order to decide whether it should part of the boot sequence. If LUN0 does not respond to the command, boot is delayed by up to 5 seconds. This currently happens when there is no LUN0 on a target. Fix that by adding a trivial impl

[Qemu-devel] [PATCH v2 1/5] rules.mak: Support .cc as a C++ source file suffix

2014-01-16 Thread Peter Maydell
The A64 disassembler libvixl uses .cc as its suffix for C++ source files, so add support for it (we already support .cpp). Signed-off-by: Peter Maydell --- rules.mak | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/rules.mak b/rules.mak index 49edb9b..cd9187e 100644 --- a

[Qemu-devel] [PATCH v2 4/5] disas/libvixl: Fix upstream libvixl compilation issues

2014-01-16 Thread Peter Maydell
Fix various minor issues with upstream libvixl so that it will compile successfully on the platforms QEMU cares about: * remove unused GBytes constant (it clashes with the glib headers) * fix suffixes on constants to use 'LL' for 64 bit constants so we can compile on 32 bit hosts Signed-off-b

[Qemu-devel] [PATCH v2 2/5] rules.mak: Link with C++ if we have a C++ compiler

2014-01-16 Thread Peter Maydell
If we have a C++ compiler available, link with it, because we might be linking some C++ files in. This allows us to include C++ object files in the QEMU binary proper. Signed-off-by: Peter Maydell --- rules.mak | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/rules.mak

[Qemu-devel] [PATCH v2 0/5] disas: add libvixl to support A64 disassembly

2014-01-16 Thread Peter Maydell
Hi. This is a rebased and mildly cleaned up version of Claudio's RFC patchset from last year to add libvixl to QEMU and use it for A64 disassembly. NOTE NOTE NOTE * we now link with g++, not gcc (even if the target doesn't happen to need the A64 disassembler, since it's a bit hard to tell w

[Qemu-devel] [PATCH v2 5/5] disas: Implement disassembly output for A64

2014-01-16 Thread Peter Maydell
From: Claudio Fontana Use libvixl to implement disassembly output in debug logs for A64, for use with both AArch64 hosts and targets. Signed-off-by: Claudio Fontana [PMM: * added support for target disassembly * switched to custom QEMUDisassembler so the output format matches what QEMU exp

[Qemu-devel] [PATCH] tests: require that acpi tests are enabled explicitly

2014-01-16 Thread Michael S. Tsirkin
ACPI code is changing as bit too fast to make it worth it to require everyone to check it against expected output. Make test run depend on an ACPI_TEST_EXPECTED_AML set in environment, so interested people can run it without affecting everyone. Signed-off-by: Michael S. Tsirkin --- I'd like to p

Re: [Qemu-devel] [PATCH RFC 2/3] qapi script: add support of event

2014-01-16 Thread Paolo Bonzini
Il 16/01/2014 03:50, Michael Roth ha scritto: > If we go to that effort, it may make sense to try to re-license to GPLv2+ > while we're at it, but either way I think this should be done as a separate > patchset, and shouldn't hold up Wenchao's series. I can send that out, since > it's my screw-up.

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/1] Add a blank space between the variable and '='

2014-01-16 Thread Peter Maydell
On 16 January 2014 10:50, Michael Tokarev wrote: > Thanks, applied. Can you fix the subject line in your tree to have a prefix indicating which area of the codebase it affects, please? thanks -- PMM

Re: [Qemu-devel] [PATCH v16 2/9] rules.mak: allow per object cflags and libs

2014-01-16 Thread Peter Maydell
On 15 January 2014 08:48, Fam Zheng wrote:.objs. > Similarly, > > foo.o-cflags := $(FOO_CFLAGS) > > is also supported. I noticed that we already support per-object cflags via: $(obj)/adlib.o $(obj)/fmopl.o: QEMU_CFLAGS += -DBUILD_Y8950=0 (this example from audio/Makefile.objs). Is your

Re: [Qemu-devel] [PATCH v16 2/9] rules.mak: allow per object cflags and libs

2014-01-16 Thread Fam Zheng
On Wed, 01/15 19:35, Peter Maydell wrote: > On 15 January 2014 08:48, Fam Zheng wrote: > > Adds extract-libs in LINK to expand any "per object libs", the syntax to > > define > > such a libs options is like: > > > > foo.o-libs := $(CURL_LIBS) > > > > in block/Makefile.objs. > > > > Simila

Re: [Qemu-devel] [Qemu-trivial] [PATCH] pc-bios: Remove execute flag from BIOS files

2014-01-16 Thread Michael Tokarev
28.12.2013 11:31, Stefan Weil wrote: > BIOS files are not directly executable, so they don't need this flag. > All other BIOS files don't use the execute flag. Thanks, applied. /mjt

  1   2   >