On Thu, 01/16 11:04, Peter Maydell wrote: > On 15 January 2014 08:48, Fam Zheng <f...@redhat.com> wrote:.objs. > > Similarly, > > > > foo.o-cflags := $(FOO_CFLAGS) > > > > is also supported. > > I noticed that we already support per-object cflags via: > > $(obj)/adlib.o $(obj)/fmopl.o: QEMU_CFLAGS += -DBUILD_Y8950=0 > > (this example from audio/Makefile.objs). Is your new > method better in some way? Are we going to convert > users of the old-style method? >
I added this new method as it's cleaner to use, especially when defining multiple-object module (implemented in this series): foo.mo-objs := bar.o biz.o qux.o , compared to $(obj)/foo.mo-objs := $(obj)/bar.o $(obj)/biz.o $(obj)/qux.o or slightly better $(obj)/foo.mo-objs := $(addprefix $(obj), bar.o, biz.o, qux.o) I've already converted block/curl.o's cflags to this, later in this series. So yes I think this is a better syntax. Thanks, Fam