Re: [Qemu-devel] [PATCH 05/11] qdev: add "hotpluggable" property to Device

2013-12-13 Thread Peter Crosthwaite
On Fri, Dec 13, 2013 at 10:44 PM, Igor Mammedov wrote: > Currently it's possible to make PCIDevice not hotpluggable by using > no_hotplug field of PCIDeviceClass. However it limits this > only to PCI devices and prevents from generalizing hotplug code. > > So add similar field to DeviceClass so it

Re: [Qemu-devel] [PATCH 04/11] qdev: add to BusState "hotplug-handler" link

2013-12-13 Thread Peter Crosthwaite
On Fri, Dec 13, 2013 at 10:44 PM, Igor Mammedov wrote: > It will allow to reuse field with different BUSes, reducing code duplication. > Field is intended fot replacing 'hotplug_qdev' field in PCIBus and also > will allow to avoid adding equivalent field to DimmBus with possiblitity > to refactor

Re: [Qemu-devel] [PATCH 03/11] define hotplug interface

2013-12-13 Thread Peter Crosthwaite
On Fri, Dec 13, 2013 at 10:44 PM, Igor Mammedov wrote: > Provide generic hotplug interface for devices. "Provide a". s/devices/hotplug handlers would be cleaner too, to match your v2 changes. > Intended for replacing hotplug mechanism used by > PCI/PCIE/SHPC code and will be used for memory hotp

Re: [Qemu-devel] [PATCH 02/11] qom: detect bad reentrance during object_class_foreach

2013-12-13 Thread Peter Crosthwaite
On Fri, Dec 13, 2013 at 10:44 PM, Igor Mammedov wrote: > From: Hervé Poussineau > > We should not modify the type hash table while it is being iterated on. > Assert that it does not happen. > > Signed-off-by: Hervé Poussineau > Signed-off-by: Paolo Bonzini > Signed-off-by: Igor Mammedov > ---

Re: [Qemu-devel] [PATCH v8 3/6] hw/arm/digic: add timer support

2013-12-13 Thread Peter Crosthwaite
On Sat, Dec 14, 2013 at 7:42 AM, Antony Pavlov wrote: > Signed-off-by: Antony Pavlov > --- > hw/arm/digic.c | 28 + > hw/timer/Makefile.objs | 1 + > hw/timer/digic-timer.c | 168 > + > hw/timer/digic-timer.h | 38 +++ >

Re: [Qemu-devel] [PATCH v3 1/7] Add -mem-share option

2013-12-13 Thread Eric Blake
On 12/13/2013 04:14 AM, Antonios Motakis wrote: > This option complements -mem-path. It implies -mem-prealloc. If specified, > the guest RAM is allocated as a shared memory object. If both -mem-path > and -mem-share are provided, the memory is allocated from the HugeTLBFS > supplied path, and then

Re: [Qemu-devel] [PATCH v6 4/6] commit: support commit active layer

2013-12-13 Thread Eric Blake
On 11/25/2013 10:45 PM, Fam Zheng wrote: > If active is top, it will be mirrored to base, (with block/mirror.c > code), then the image is switched when user completes the block job. > > QMP documentation is updated. > > Signed-off-by: Fam Zheng > --- > +++ b/qapi-schema.json > @@ -1967,9 +1967,

Re: [Qemu-devel] [PATCH v5 16/22] blkdebug: Make filename optional

2013-12-13 Thread Max Reitz
On 13.12.2013 21:43, Kevin Wolf wrote: Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: There is no problem in giving no filename; in this case, it has to be specified through the "image" option. Signed-off-by: Max Reitz --- block/blkdebug.c | 6 -- 1 file changed, 4 insertions(+), 2 d

Re: [Qemu-devel] [PATCH v5 17/22] blkverify: Allow command-line configuration

2013-12-13 Thread Max Reitz
On 13.12.2013 21:46, Kevin Wolf wrote: Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: Introduce the "test" and "raw" options for specifying images. Signed-off-by: Max Reitz --- block/blkverify.c | 59 --- 1 file changed, 39 insertions(+

Re: [Qemu-devel] [PATCH v5 20/22] qapi: QMP interface for blkdebug and blkverify

2013-12-13 Thread Max Reitz
On 13.12.2013 21:54, Kevin Wolf wrote: Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: Add structures to support blkdebug and blkverify in blockdev-add. Signed-off-by: Max Reitz --- qapi-schema.json | 94 +--- 1 file changed, 90 insertio

Re: [Qemu-devel] [PATCH v5 12/22] block: Allow recursive "file"s

2013-12-13 Thread Max Reitz
On 13.12.2013 21:19, Kevin Wolf wrote: Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: It should be possible to use a format as a driver for a file which in turn requires another file, i.e., nesting file formats. Signed-off-by: Max Reitz Hm, does this do what I think it does? $ ./qemu-img

Re: [Qemu-devel] [PATCH v5 11/22] block: Allow block devices without files

2013-12-13 Thread Max Reitz
On 13.12.2013 21:06, Kevin Wolf wrote: Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: blkdebug and blkverify will, in order to retain compatibility, not support the field "file" implicitly through bdrv_open(). In order to be able to use those drivers without giving a filename anyway, it is ne

Re: [Qemu-devel] [PATCH v5 05/22] qdict: Remove delete from qdict_flatten_qdict()

2013-12-13 Thread Max Reitz
On 13.12.2013 19:58, Kevin Wolf wrote: Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: delete is always set to true, therefore it can be removed. Signed-off-by: Max Reitz Nope, this can't be right. delete is always set, except for simple types in the top-level QDict. They get deleted now i

Re: [Qemu-devel] [PATCH v5 22/22] iotests: Test new blkdebug/blkverify interface

2013-12-13 Thread Max Reitz
On 13.12.2013 22:08, Kevin Wolf wrote: Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: Add a test for the new blkdebug/blkverify interface. This test is not written in Python, although it uses QMP. This is because it invokes the qemu-io HMP command, which outputs errors to stderr instead of r

Re: [Qemu-devel] [PATCH v5 19/22] blkdebug: Alias "errno" as "error"

2013-12-13 Thread Max Reitz
On 13.12.2013 22:00, Eric Blake wrote: On 12/13/2013 01:49 PM, Kevin Wolf wrote: Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: Introduce an alias "error" for "errno", since using the latter for QMP is sure to result in various syntax errors due to the name being used directly as an identifi

Re: [Qemu-devel] [PATCH v5 15/22] blkdebug: Allow command-line file configuration

2013-12-13 Thread Max Reitz
On 13.12.2013 21:36, Kevin Wolf wrote: Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: Introduce the "image" option as an alternative to specifying the image through the filename. Signed-off-by: Max Reitz One thing I'd like to see, either in the next version or in a follow-up series, is to

Re: [Qemu-devel] [PATCH V4 9/9] qapi script: do not add "_" for every capitalized char in enum

2013-12-13 Thread Eric Blake
On 12/10/2013 10:48 PM, Wenchao Xia wrote: > Now "enum AIOContext" will generate AIO_CONTEXT instead of A_I_O_CONTEXT, > "X86CPU" will generate X86_CPU instead of X86_C_P_U. > > Signed-off-by: Wenchao Xia > --- > include/qapi/qmp/qerror.h |2 +- > scripts/qapi.py | 26 +++

Re: [Qemu-devel] [PATCH V4 8/9] qapi: convert BlockdevOptions to use enum discriminator

2013-12-13 Thread Eric Blake
On 12/10/2013 10:48 PM, Wenchao Xia wrote: > After this patch, hidden enum type BlockdevOptionsKind will not > be generated, and other API can use enum BlockdevDriver. > > Signed-off-by: Wenchao Xia > Reviewed-by: Eric Blake > --- > qapi-schema.json | 14 +- > 1 files changed, 13

Re: [Qemu-devel] [PATCH V4 7/9] tests: add cases for inherited struct and union with discriminator

2013-12-13 Thread Eric Blake
On 12/10/2013 10:48 PM, Wenchao Xia wrote: > Test for inherit and complex union. > > Signed-off-by: Wenchao Xia > --- > tests/qapi-schema/qapi-schema-test.json | 27 ++ > tests/qapi-schema/qapi-schema-test.out | 11 +++ > tests/test-qmp-input-visitor.c | 120 ++

[Qemu-devel] [PATCH v8 0/6] hw/arm: add initial support for Canon DIGIC SoC

2013-12-13 Thread Antony Pavlov
S QEMU has incomplete ROM support; (this patch series uses conventional QEMU pflash). This initial DIGIC support can't be used to run the original camera firmware, but it can successfully run experimental version of barebox bootloader (see http://www.barebox.org). The last sources of barebox for

[Qemu-devel] [PATCH v8 5/6] hw/arm/digic: add NOR ROM support

2013-12-13 Thread Antony Pavlov
Signed-off-by: Antony Pavlov --- hw/arm/digic_boards.c | 70 +++ 1 file changed, 70 insertions(+) diff --git a/hw/arm/digic_boards.c b/hw/arm/digic_boards.c index 87a9c4b..217c506 100644 --- a/hw/arm/digic_boards.c +++ b/hw/arm/digic_boards.c @@ -2

[Qemu-devel] [PATCH v8 4/6] hw/arm/digic: add UART support

2013-12-13 Thread Antony Pavlov
Signed-off-by: Antony Pavlov Reviewed-by: Peter Maydell Reviewed-by: Peter Crosthwaite --- hw/arm/digic.c | 16 hw/char/Makefile.objs | 1 + hw/char/digic-uart.c | 195 + hw/char/digic-uart.h | 45 include/hw/arm

[Qemu-devel] [PATCH v8 3/6] hw/arm/digic: add timer support

2013-12-13 Thread Antony Pavlov
Signed-off-by: Antony Pavlov --- hw/arm/digic.c | 28 + hw/timer/Makefile.objs | 1 + hw/timer/digic-timer.c | 168 + hw/timer/digic-timer.h | 38 +++ include/hw/arm/digic.h | 6 ++ 5 files changed, 241 insertions(+) c

[Qemu-devel] [PATCH v8 1/6] hw/arm: add very initial support for Canon DIGIC SoC

2013-12-13 Thread Antony Pavlov
DIGIC is Canon Inc.'s name for a family of SoC for digital cameras and camcorders. There is no publicly available specification for DIGIC chips. All information about DIGIC chip internals is based on reverse engineering efforts made by CHDK (http://chdk.wikia.com) and Magic Lantern (http://www.mag

[Qemu-devel] [PATCH v8 2/6] hw/arm/digic: prepare DIGIC-based boards support

2013-12-13 Thread Antony Pavlov
Also this patch adds initial support for Canon PowerShot A1100 IS compact camera. Signed-off-by: Antony Pavlov --- hw/arm/Makefile.objs | 1 + hw/arm/digic_boards.c | 84 +++ 2 files changed, 85 insertions(+) create mode 100644 hw/arm/digic_boar

[Qemu-devel] [PATCH v8 6/6] MAINTAINERS: Document 'Canon DIGIC' machine

2013-12-13 Thread Antony Pavlov
Signed-off-by: Antony Pavlov --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7f45d1d..1fce9a5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -233,6 +233,12 @@ S: Supported F: hw/arm/highbank.c F: hw/net/xgmac.c +Canon DIGIC +M: Antony P

Re: [Qemu-devel] [PATCH v5 19/22] blkdebug: Alias "errno" as "error"

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 22:00 hat Eric Blake geschrieben: > On 12/13/2013 01:49 PM, Kevin Wolf wrote: > > Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: > >> Introduce an alias "error" for "errno", since using the latter for QMP > >> is sure to result in various syntax errors due to the name being used

Re: [Qemu-devel] [PATCH v5 12/22] block: Allow recursive "file"s

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 21:36 hat Eric Blake geschrieben: > On 12/13/2013 01:19 PM, Kevin Wolf wrote: > > Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: > >> It should be possible to use a format as a driver for a file which in > >> turn requires another file, i.e., nesting file formats. > >> > >> Sign

Re: [Qemu-devel] [PATCH v5 22/22] iotests: Test new blkdebug/blkverify interface

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: > Add a test for the new blkdebug/blkverify interface. > > This test is not written in Python, although it uses QMP. This is > because it invokes the qemu-io HMP command, which outputs errors to > stderr instead of returning them through QMP. Filte

Re: [Qemu-devel] [PATCH v5 20/22] qapi: QMP interface for blkdebug and blkverify

2013-12-13 Thread Eric Blake
On 12/13/2013 01:54 PM, Kevin Wolf wrote: > Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: >> +# @BlkdebugInjectErrorOptions >> +# >> +# Describes a single error injection for blkdebug. >> +# >> +# @event: trigger event name >> +# >> +## >> +{ 'type': 'BlkdebugInjectErrorOptions', >> +

Re: [Qemu-devel] [PATCH v5 19/22] blkdebug: Alias "errno" as "error"

2013-12-13 Thread Eric Blake
On 12/13/2013 01:49 PM, Kevin Wolf wrote: > Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: >> Introduce an alias "error" for "errno", since using the latter for QMP >> is sure to result in various syntax errors due to the name being used >> directly as an identifier. >> >> Signed-off-by: Max Rei

Re: [Qemu-devel] [PATCH v5 21/22] qemu-io: Make filename optional

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: > Giving a filename is actually not essential, since it can be specified > through the options as well - on the contrary: Sometimes a filename must > not be given. > > Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH v5 20/22] qapi: QMP interface for blkdebug and blkverify

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: > Add structures to support blkdebug and blkverify in blockdev-add. > > Signed-off-by: Max Reitz > --- > qapi-schema.json | 94 > +--- > 1 file changed, 90 insertions(+), 4 deletions(-) > > di

Re: [Qemu-devel] [PATCH v5 19/22] blkdebug: Alias "errno" as "error"

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: > Introduce an alias "error" for "errno", since using the latter for QMP > is sure to result in various syntax errors due to the name being used > directly as an identifier. > > Signed-off-by: Max Reitz I can't say I like this, but it seems we do

Re: [Qemu-devel] [PATCH v5 18/22] blkverify: Don't require protocol filename

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: > If the filename is not prefixed by "blkverify:" in > blkverify_parse_filename(), the blkverify driver was not selected > through that protocol prefix, but by an explicit command line (or QMP) > option (like driver=blkverify). Contrary to the curre

Re: [Qemu-devel] [PATCH v5 17/22] blkverify: Allow command-line configuration

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: > Introduce the "test" and "raw" options for specifying images. > > Signed-off-by: Max Reitz > --- > block/blkverify.c | 59 > --- > 1 file changed, 39 insertions(+), 20 deletions(-) > > diff

Re: [Qemu-devel] [PATCH v5 16/22] blkdebug: Make filename optional

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: > There is no problem in giving no filename; in this case, it has to be > specified through the "image" option. > > Signed-off-by: Max Reitz > --- > block/blkdebug.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/

Re: [Qemu-devel] [PATCH v5 15/22] blkdebug: Allow command-line file configuration

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: > Introduce the "image" option as an alternative to specifying the image > through the filename. > > Signed-off-by: Max Reitz One thing I'd like to see, either in the next version or in a follow-up series, is to generalise open_image() into a blo

Re: [Qemu-devel] [PATCH v5 12/22] block: Allow recursive "file"s

2013-12-13 Thread Eric Blake
On 12/13/2013 01:19 PM, Kevin Wolf wrote: > Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: >> It should be possible to use a format as a driver for a file which in >> turn requires another file, i.e., nesting file formats. >> >> Signed-off-by: Max Reitz > > Hm, does this do what I think it doe

Re: [Qemu-devel] [PATCH v5 14/22] blockdev: Move "file" to legacy_opts

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: > Specifying the image filename through the "file" option is a legacy > option and should not be supported by blockdev-add (in that case, giving > a string for "file" references an existing block device). > > Signed-off-by: Max Reitz This is a go

Re: [Qemu-devel] [PATCH v5 13/22] qemu-iotests: Fix output of test 051

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: > Allowing nested file formats now results in e.g. qcow2 BlockDriverStates > never being directly passed to bdrv_open_common() from bdrv_file_open(), > but instead being handed through bdrv_open(). This changes the error > message when trying to giv

Re: [Qemu-devel] [PATCH v5 13/22] qemu-iotests: Fix output of test 051

2013-12-13 Thread Eric Blake
On 12/13/2013 10:10 AM, Max Reitz wrote: > Allowing nested file formats now results in e.g. qcow2 BlockDriverStates > never being directly passed to bdrv_open_common() from bdrv_file_open(), > but instead being handed through bdrv_open(). This changes the error > message when trying to give a filen

Re: [Qemu-devel] [PATCH v5 12/22] block: Allow recursive "file"s

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: > It should be possible to use a format as a driver for a file which in > turn requires another file, i.e., nesting file formats. > > Signed-off-by: Max Reitz Hm, does this do what I think it does? $ ./qemu-img convert -O qcow2 /home/kwolf/image

[Qemu-devel] a QOM Coding Conventions question

2013-12-13 Thread Antony Pavlov
Hi, Andreas! Here is a quote from http://wiki.qemu.org/QOMConventions > a FooClass structure definition containing at least the parent class > field: > > typedef struct { > /*< private >*/ > MyParentClass parent_class; > /*< public >*/ > > [any fields

Re: [Qemu-devel] [PATCH 2/5] ui/cocoa: Correct typos in comments and variable names

2013-12-13 Thread Stefan Weil
Am 08.12.2013 23:59, schrieb Peter Maydell: > Fix various non-user-visible typos in comments and variable names. > > Signed-off-by: Peter Maydell > --- > ui/cocoa.m | 28 ++-- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/ui/cocoa.m b/ui/cocoa.m > in

Re: [Qemu-devel] [PATCH v12 2/5] hw/timer: add allwinner a10 timer

2013-12-13 Thread Antony Pavlov
On Fri, 13 Dec 2013 09:19:08 +0800 liguang wrote: > Signed-off-by: liguang > Reviewed-by: Peter Crosthwaite > --- > default-configs/arm-softmmu.mak |2 + > hw/timer/Makefile.objs |2 + > hw/timer/allwinner-a10-pit.c | 254 > +

Re: [Qemu-devel] [PATCH v5 11/22] block: Allow block devices without files

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: > blkdebug and blkverify will, in order to retain compatibility, not > support the field "file" implicitly through bdrv_open(). In order to be > able to use those drivers without giving a filename anyway, it is > necessary to be able to have block d

Re: [Qemu-devel] [PATCH v5 04/22] qapi: extend qdict_flatten() for QLists

2013-12-13 Thread Eric Blake
On 12/13/2013 10:10 AM, Max Reitz wrote: > Reversing qdict_array_split(), qdict_flatten() should flatten QLists as > well by interpreting them as QDicts where every entry's key is its > index. > > This allows bringing QDicts with QLists from QMP commands to the same > form as they would be given a

Re: [Qemu-devel] [PATCH] cocoa: Fix typo (aditional -> additional)

2013-12-13 Thread Peter Maydell
On 13 December 2013 19:49, Stefan Weil wrote: > Signed-off-by: Stefan Weil > --- > ui/cocoa.m |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ui/cocoa.m b/ui/cocoa.m > index be49179..6569326 100644 > --- a/ui/cocoa.m > +++ b/ui/cocoa.m > @@ -204,7 +204,7 @@ int keymap

Re: [Qemu-devel] [PATCH v5 10/22] block: Pass reference to bdrv_file_open()

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: > With that now being possible, bdrv_open() should try to extract a block > device reference from the options and pass it to bdrv_file_open(). > > Signed-off-by: Max Reitz Ah well, I see. Users do have a way to specify both options and a referenc

Re: [Qemu-devel] [PATCH v5 09/22] block: Allow reference for bdrv_file_open()

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: > Allow specifying a reference to an existing block device (by name) for > bdrv_file_open() instead of a filename and/or options. > > Signed-off-by: Max Reitz > @@ -872,6 +873,24 @@ int bdrv_file_open(BlockDriverState **pbs, const char > *filena

Re: [Qemu-devel] [PATCH] roms: Flush icache when writing roms to guest memory

2013-12-13 Thread Scott Wood
On Wed, 2013-12-11 at 13:56 +, Peter Maydell wrote: > On 11 December 2013 13:23, Alexander Graf wrote: > > The guest expects that its data and instruction cache view of the world > > is 100% consistent when it initially boots. This works just fine on > > initial rom population for the first bo

[Qemu-devel] [PATCH] cocoa: Fix typo (aditional -> additional)

2013-12-13 Thread Stefan Weil
Signed-off-by: Stefan Weil --- ui/cocoa.m |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index be49179..6569326 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -204,7 +204,7 @@ int keymap[] = 200,// 126 0x7E0xc8E0,48 U ARROW QZ_UP /

Re: [Qemu-devel] [PATCH v5 08/22] blkdebug: Use command-line in read_config()

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: > Use qemu_config_parse_qdict() to parse the command-line options in > addition to the config file. > > Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf

[Qemu-devel] [PATCH v3 5/8] target-arm: A64: add support for add, addi, sub, subi

2013-12-13 Thread Peter Maydell
From: Alex Bennée Implement the non-carry forms of addition and subtraction (immediate, extended register and shifted register). This includes the code to calculate NZCV if the instruction calls for setting the flags. Signed-off-by: Alex Bennée Signed-off-by: Peter Maydell Reviewed-by: Richard

[Qemu-devel] [PATCH v3 0/8] target-arm: A64 decoder set 3: loads, stores, misc integer

2013-12-13 Thread Peter Maydell
Version 3 of the third set of A64 decoder patches (loads, stores, misc integer). (Fourth set is very nearly ready to roll, I just need to review the load/store exclusive patch.) Changes v2->v3: * added the non-temporal forms of LDP/STP (fixing a miscoded unallocated_encoding() codepath) * up

[Qemu-devel] [PATCH v3 3/8] target-arm: A64: add support for ld/st with reg offset

2013-12-13 Thread Peter Maydell
From: Alex Bennée This adds support for the load/store forms using a register offset. Signed-off-by: Alex Bennée Signed-off-by: Peter Maydell --- target-arm/translate-a64.c | 144 - 1 file changed, 143 insertions(+), 1 deletion(-) diff --git a/targ

[Qemu-devel] [PATCH v3 4/8] target-arm: A64: add support for ld/st with index

2013-12-13 Thread Peter Maydell
From: Alex Bennée This adds support for the pre/post-index ld/st forms with immediate offsets as well as the un-scaled immediate form (which are all variations on the same 9-bit immediate instruction form). Signed-off-by: Alex Bennée Signed-off-by: Peter Maydell --- target-arm/translate-a64.c

[Qemu-devel] [PATCH v3 6/8] target-arm: A64: add support for move wide instructions

2013-12-13 Thread Peter Maydell
From: Alex Bennée This patch adds emulation for the mov wide instructions (MOVN, MOVZ, MOVK). Signed-off-by: Alex Bennée Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target-arm/translate-a64.c | 51 -- 1 file changed, 49 insertio

[Qemu-devel] [PATCH v3 1/8] target-arm: A64: add support for ld/st pair

2013-12-13 Thread Peter Maydell
From: Alex Bennée This patch support the basic load and store pair instructions and includes the generic helper functions: * do_gpr_st() * do_fp_st() * do_gpr_ld() * do_fp_ld() * read_cpu_reg_sp() * gen_check_sp_alignment() The last function gen_check_sp_alignment() is a NULL op cur

[Qemu-devel] [PATCH v3 2/8] target-arm: A64: add support for ld/st unsigned imm

2013-12-13 Thread Peter Maydell
From: Alex Bennée This adds support for the forms of ld/st with a 12 bit unsigned immediate offset. Signed-off-by: Alex Bennée Signed-off-by: Peter Maydell --- target-arm/translate-a64.c | 89 +- 1 file changed, 88 insertions(+), 1 deletion(-) diff

[Qemu-devel] [PATCH v3 7/8] target-arm: A64: add support for 3 src data proc insns

2013-12-13 Thread Peter Maydell
From: Alexander Graf This patch adds emulation for the "Data-processing (3 source)" family of instructions, namely MADD, MSUB, SMADDL, SMSUBL, SMULH, UMADDL, UMSUBL, UMULH. Signed-off-by: Alexander Graf Signed-off-by: Alex Bennée Signed-off-by: Peter Maydell --- target-arm/translate-a64.c |

[Qemu-devel] [PATCH v3 8/8] target-arm: A64: implement SVC, BRK

2013-12-13 Thread Peter Maydell
From: Alexander Graf Add decoding for the exception generating instructions, and implement SVC (syscalls) and BRK (software breakpoint). Signed-off-by: Alexander Graf Signed-off-by: Alex Bennée Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target-arm/translate-a64.c | 51 +

[Qemu-devel] [PATCH 10/11] ACPI: set CPU hotplug io base dynamically

2013-12-13 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 6 ++ hw/i386/ssdt-misc.dsl | 1 + 2 files changed, 7 insertions(+) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index befc39f..bfd34d7 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -68,6 +68,7 @@ typedef

Re: [Qemu-devel] [PATCH v5 07/22] blkdebug: Always call read_config()

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: > Move the check whether there actually is a config file into the > read_config() function. > > Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH v5 04/22] qapi: extend qdict_flatten() for QLists

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: > Reversing qdict_array_split(), qdict_flatten() should flatten QLists as > well by interpreting them as QDicts where every entry's key is its > index. > > This allows bringing QDicts with QLists from QMP commands to the same > form as they would b

Re: [Qemu-devel] [PATCH v5 03/22] qdict: Add qdict_array_split()

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: > This function splits a QDict consisting of entries prefixed by > incrementally enumerated indices into a QList of QDicts. > > Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH v5 02/22] blkdebug: Don't require sophisticated filename

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: > If the filename is not prefixed by "blkdebug:" in > blkdebug_parse_filename(), the blkdebug driver was not selected through > that protocol prefix, but by an explicit command line option > (file.driver=blkdebug or something similar). Contrary to t

Re: [Qemu-devel] [PATCH v5 01/22] blkdebug: Use errp for read_config()

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: > Use an Error variable in the read_config() function. > > Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH v5 05/22] qdict: Remove delete from qdict_flatten_qdict()

2013-12-13 Thread Kevin Wolf
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: > delete is always set to true, therefore it can be removed. > > Signed-off-by: Max Reitz Nope, this can't be right. delete is always set, except for simple types in the top-level QDict. They get deleted now instead of being left alone. But it

Re: [Qemu-devel] [PATCH] [PATCH RFC v4] qemu-monitor: HMP cpu-add wrapper

2013-12-13 Thread Igor Mammedov
On Wed, 11 Dec 2013 13:24:14 -0500 "Jason J. Herne" wrote: > From: "Jason J. Herne" > > Add HMP cpu-add wrapper to allow cpu hot plugging via monitor. > > Signed-off-by: Jason J. Herne > --- > hmp-commands.hx | 13 + > hmp.c | 10 ++ > hmp.h | 1 + >

[Qemu-devel] [PATCH 1/2] sun4m: Add Sun CG3 framebuffer and corresponding OpenBIOS FCode ROM

2013-12-13 Thread Mark Cave-Ayland
The CG3 framebuffer is a simple 8-bit framebuffer for use with operating systems such as early Solaris that do not have drivers for TCX. Signed-off-by: Mark Cave-Ayland CC: Blue Swirl CC: Anthony Liguori CC: Bob Breuer CC: Artyom Tarasenko --- Makefile |2 +- def

[Qemu-devel] [PATCH 2/2] sun4m: Add Sun CG3 framebuffer initialisation function

2013-12-13 Thread Mark Cave-Ayland
In order to allow the user to choose the framebuffer for sparc-softmmu, add -vga tcx and -vga cg3 options to the QEMU command line. If no option is specified, the default TCX framebuffer is used. Signed-off-by: Mark Cave-Ayland CC: Blue Swirl CC: Anthony Liguori CC: Bob Breuer CC: Artyom Taras

[Qemu-devel] [PATCH 0/2] sun4m: Implement Sun CG3 framebuffer for QEMU

2013-12-13 Thread Mark Cave-Ayland
This patchset provides QEMU with an implementation of the Sun CG3 8-bit framebuffer. It is based upon Bob Breuer's original work which has been rebased onto git master, and is now capable of running with an OpenBIOS CG3 FCode ROM instead of requiring copies of proprietary Sun ROMs. The motivation

Re: [Qemu-devel] [PATCH v6 0/6] block: allow commit active as top

2013-12-13 Thread Kevin Wolf
Am 26.11.2013 um 06:45 hat Fam Zheng geschrieben: > Previously live commit of active block device is not supported, this series > implements it and updates corresponding qemu-iotests cases. > > This series is based on BlockJobType enum QAPI series. > > v6: Address comments from Stefan: > > [

Re: [Qemu-devel] [PATCH v6 4/6] commit: support commit active layer

2013-12-13 Thread Kevin Wolf
Am 26.11.2013 um 06:45 hat Fam Zheng geschrieben: > If active is top, it will be mirrored to base, (with block/mirror.c > code), then the image is switched when user completes the block job. > > QMP documentation is updated. > > Signed-off-by: Fam Zheng > --- > block/mirror.c | 11 +++

[Qemu-devel] [PATCH v5 19/22] blkdebug: Alias "errno" as "error"

2013-12-13 Thread Max Reitz
Introduce an alias "error" for "errno", since using the latter for QMP is sure to result in various syntax errors due to the name being used directly as an identifier. Signed-off-by: Max Reitz --- block/blkdebug.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/block/bl

[Qemu-devel] [PATCH 05/11] acpi: ich9: allow guest to clear SCI rised by GPE

2013-12-13 Thread Igor Mammedov
it fixes IRQ storm since guest isn't able to lower SCI IRQ after it has been handled when it clears GPE event. Signed-off-by: Igor Mammedov --- hw/acpi/ich9.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index dcdef7c..30f0df8 100644 --- a/hw/acpi/ich9.c ++

[Qemu-devel] [PATCH 02/11] acpi: factor out common pm_update_sci() into acpi core

2013-12-13 Thread Igor Mammedov
... and rename it into acpi_update_sci() since it changes SCI on only on PM registers status. Signed-off-by: Igor Mammedov --- --- hw/acpi/core.c | 18 ++ hw/acpi/ich9.c | 23 ++- hw/acpi/piix4.c| 26 -- include/

[Qemu-devel] [PATCH v5 11/22] block: Allow block devices without files

2013-12-13 Thread Max Reitz
blkdebug and blkverify will, in order to retain compatibility, not support the field "file" implicitly through bdrv_open(). In order to be able to use those drivers without giving a filename anyway, it is necessary to be able to have block devices without files implicitly opened by bdrv_open(). Thi

[Qemu-devel] [PATCH v5 09/22] block: Allow reference for bdrv_file_open()

2013-12-13 Thread Max Reitz
Allow specifying a reference to an existing block device (by name) for bdrv_file_open() instead of a filename and/or options. Signed-off-by: Max Reitz --- block.c | 25 ++--- block/blkdebug.c | 2 +- block/blkverify.c | 2 +- block/cow.c |

[Qemu-devel] [PULL 6/6] blkdebug: Use QLIST_FOREACH_SAFE to resume IO

2013-12-13 Thread Kevin Wolf
From: Fam Zheng Qemu-iotest 030 was broken. When the coroutine runs and finishes, it will remove itself from the req list, so let's use safe version of foreach to avoid use after free. Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- block/blkdebug.c | 8 1 file changed, 4 ins

[Qemu-devel] [PULL 4/6] block: expect get_block_status errors in bdrv_make_zero

2013-12-13 Thread Kevin Wolf
From: Peter Lieven during testing around with 4k LUNs a bad target implementation triggert an -EIO in iscsi_get_block_status, but it got never caught resulting in an infinite loop. CC: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --

[Qemu-devel] [PULL 2/6] qapi-schema.json: Change 1.8 reference to 2.0

2013-12-13 Thread Kevin Wolf
Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- qapi-schema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index d6f8615..c3c939c 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -949,7 +949,7 @@ # (only pres

[Qemu-devel] [Bug 1259499] Re: QEmu 1.7.0 cannot restore a 1.6.0 live snapshot made in qemu-system-x86_64

2013-12-13 Thread Dr. David Alan Gilbert
Hi Francois, I've done some more digging. It looks like the problem you've hit is related to the same one that's fixed by: http://lists.gnu.org/archive/html/qemu-devel/2013-11/msg00513.html however that only fixes older restores ; there is a work around which is to pass to QEMU: -global i440FX

[Qemu-devel] [PULL 0/6] Block patches

2013-12-13 Thread Kevin Wolf
The following changes since commit 47acdd63a33a5966bf4fc94a6ac835d72a70c555: target-microblaze: Use the new qemu_ld/st opcodes (2013-12-13 10:00:42 +1000) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-anthony for you to fetch changes up to c547e5640d5b0993

[Qemu-devel] [PATCH v5 08/22] blkdebug: Use command-line in read_config()

2013-12-13 Thread Max Reitz
Use qemu_config_parse_qdict() to parse the command-line options in addition to the config file. Signed-off-by: Max Reitz --- block/blkdebug.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index 5647467..08ea88c 100644 ---

[Qemu-devel] [PULL 5/6] qemu-img: make progress output more accurate during convert

2013-12-13 Thread Kevin Wolf
From: Peter Lieven the progress output is very bumpy if the input images contains a significant portion of unallocated sectors. This patch checks how much sectors are allocated a priori if progress output is selected. Signed-off-by: Peter Lieven Signed-off-by: Kevin Wolf --- qemu-img.c | 26 +

[Qemu-devel] [PULL 1/6] sheepdog: check if '-o redundancy' is passed from user

2013-12-13 Thread Kevin Wolf
From: Liu Yuan This fix a segfault (that is caused by b3af018f3) of following command: $ qemu-img convert some_img sheepdog:some_img Cc: qemu-devel@nongnu.org Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan Signed-off-by: Kevin Wolf --- block/sheepdog.c | 8 +--- 1 file chan

[Qemu-devel] [PULL 3/6] block/vvfat: Fix compiler warnings for OpenBSD

2013-12-13 Thread Kevin Wolf
From: Stefan Weil The buildbot shows these compiler warnings: block/vvfat.c: In function 'create_short_and_long_name': block/vvfat.c:620: warning: array size (8) smaller than bound length (11) block/vvfat.c:620: warning: array size (8) smaller than bound length (11) block/vvfat.c:635: warning: a

[Qemu-devel] [PATCH v5 12/22] block: Allow recursive "file"s

2013-12-13 Thread Max Reitz
It should be possible to use a format as a driver for a file which in turn requires another file, i.e., nesting file formats. Signed-off-by: Max Reitz --- block.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c index 9659eb5..9222669 10064

[Qemu-devel] [PATCH] sheepdog: fix dynamic grow for running qcow2 format

2013-12-13 Thread Liu Yuan
When running qcow2 over sheepdog, we might meet following problem qemu-system-x86_64: shrinking is not supported And cause IO errors to Guest. This is because we abuse bs->total_sectors, which is manipulated by generic block layer and race with sheepdog code. We should directly check if offset

[Qemu-devel] [PATCH v5 07/22] blkdebug: Always call read_config()

2013-12-13 Thread Max Reitz
Move the check whether there actually is a config file into the read_config() function. Signed-off-by: Max Reitz --- block/blkdebug.c | 36 +++- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index a2301d7..5647

Re: [Qemu-devel] [PATCH v3 00/21] blkdebug/blkverify: Allow QMP configuration

2013-12-13 Thread Max Reitz
Sorry, the subject should say "v5", obviously (but since the patches itself are fine, I hope it is okay not to resend the series). Max

[Qemu-devel] [PATCH 00/11] pc: CPU hotplug support for Q35

2013-12-13 Thread Igor Mammedov
Tested with RHEL6 & WS2012R2 git tree for testing: https://github.com/imammedo/qemu/commits/q35_cpu_hp_v1 Igor Mammedov (11): acpi: piix4: remove not needed GPE0 mask acpi: factor out common pm_update_sci() into acpi core acpi: factor out common cpu hotplug code for PIIX4/Q35 acpi/piix4

[Qemu-devel] [PATCH v5 22/22] iotests: Test new blkdebug/blkverify interface

2013-12-13 Thread Max Reitz
Add a test for the new blkdebug/blkverify interface. This test is not written in Python, although it uses QMP. This is because it invokes the qemu-io HMP command, which outputs errors to stderr instead of returning them through QMP. Filtering and testing that output is easier in a shell script tha

[Qemu-devel] [PATCH v5 20/22] qapi: QMP interface for blkdebug and blkverify

2013-12-13 Thread Max Reitz
Add structures to support blkdebug and blkverify in blockdev-add. Signed-off-by: Max Reitz --- qapi-schema.json | 94 +--- 1 file changed, 90 insertions(+), 4 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index c3c939c..6ce016c

[Qemu-devel] [PATCH v5 05/22] qdict: Remove delete from qdict_flatten_qdict()

2013-12-13 Thread Max Reitz
delete is always set to true, therefore it can be removed. Signed-off-by: Max Reitz --- qobject/qdict.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/qobject/qdict.c b/qobject/qdict.c index 1d0e66c..ec42b1c 100644 --- a/qobject/qdict.c +++ b/qobject/qdi

[Qemu-devel] [PATCH v5 21/22] qemu-io: Make filename optional

2013-12-13 Thread Max Reitz
Giving a filename is actually not essential, since it can be specified through the options as well - on the contrary: Sometimes a filename must not be given. Signed-off-by: Max Reitz --- qemu-io.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/qemu-io.c b/qemu-io.c i

[Qemu-devel] [PATCH v5 17/22] blkverify: Allow command-line configuration

2013-12-13 Thread Max Reitz
Introduce the "test" and "raw" options for specifying images. Signed-off-by: Max Reitz --- block/blkverify.c | 59 --- 1 file changed, 39 insertions(+), 20 deletions(-) diff --git a/block/blkverify.c b/block/blkverify.c index c6eb287..8bf81b5

  1   2   3   >