Am 13.12.2013 um 22:00 hat Eric Blake geschrieben: > On 12/13/2013 01:49 PM, Kevin Wolf wrote: > > Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: > >> Introduce an alias "error" for "errno", since using the latter for QMP > >> is sure to result in various syntax errors due to the name being used > >> directly as an identifier. > >> > >> Signed-off-by: Max Reitz <mre...@redhat.com> > > > > I can't say I like this, but it seems we don't have an option. > > Don't we already have a way to use QMP keys that collide with C keywords > (for example, "unix" in qapi's SocketAddress becomes "q_unix" in C)? > Why can't we reuse that mechanism, and just add "errno" to the polluted > words list so that the generated C code uses "q_errno" rather than > having to invent an "error" alias?
Oh, I didn't know that this exists. Sounds better then, because it makes the external interfaces uniform, even though internally we'd still have aliases (errno/q_errno instead of errno/error then). Kevin
pgp1x1RU6YMuE.pgp
Description: PGP signature
