On 12/13/2013 01:54 PM, Kevin Wolf wrote: > Am 13.12.2013 um 18:10 hat Max Reitz geschrieben:
>> +# @BlkdebugInjectErrorOptions
>> +#
>> +# Describes a single error injection for blkdebug.
>> +#
>> +# @event: trigger event name
>> +#
>> +##
>> +{ 'type': 'BlkdebugInjectErrorOptions',
>> + 'data': { 'event': 'str',
>
> I bet Eric will tell you that an enum for event would be much nicer. ;-)
Am I that predictable? :)
And see my comments on 19; I think with a minor tweak to qapi.py's
polluted_words, that you could use @errno instead of @error.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
