Re: [Qemu-devel] [uq/master PATCH] kvmvapic: add ioport read accessor

2013-05-05 Thread Jan Kiszka
On 2013-05-05 22:51, Marcelo Tosatti wrote: > > Necessary since memory region accessor assumes read and write > methods are registered. Otherwise reading I/O port 0x7e segfaults. > > https://bugzilla.redhat.com/show_bug.cgi?id=954306 > > Signed-off-by: Marcelo Tosatti > > diff --git a/hw/i386/

Re: [Qemu-devel] [PATCH v3 2/4] Add i.MX I2C controller emulator

2013-05-05 Thread Jean-Christophe DUBOIS
On 05/06/2013 04:19 AM, Peter Crosthwaite wrote: Hi JC, On Mon, May 6, 2013 at 12:28 AM, Jean-Christophe DUBOIS wrote: The slave mode is not implemented. Changes since v1: * use QOM cast * run checkpatch on code * added restrictin on MemoryRegionOps * use DeviceClass::real

Re: [Qemu-devel] [PATCH v2 0/6] proposal to make hostmem listener RAM unplug safe

2013-05-05 Thread Paolo Bonzini
Il 06/05/2013 03:42, liu ping fan ha scritto: > On Sat, May 4, 2013 at 5:53 PM, Paolo Bonzini wrote: >> Il 03/05/2013 04:45, Liu Ping Fan ha scritto: >>> v1->v2: >>> 1.split RCU prepared style update and monitor the RAM-Device refcnt into >>> two patches (patch 2,4) >>> 2.introduce AddrSpaceM

[Qemu-devel] [PATCH v2 1/2] target-i386/seg_helper: refactor 4 helper functions

2013-05-05 Thread liguang
for helper_{lsl, lar, verr, verw}, there are common parts, so move them outside, and then call this new helper-helper function. Signed-off-by: liguang --- v2: change misc_check_helper to privilege_check --- target-i386/seg_helper.c | 179 ++--- 1 files ch

[Qemu-devel] [PATCH v2 2/2] target-i386/seg_helper: define names for code/data segment types

2013-05-05 Thread liguang
Signed-off-by: liguang --- target-i386/seg_helper.c | 71 + 1 files changed, 52 insertions(+), 19 deletions(-) diff --git a/target-i386/seg_helper.c b/target-i386/seg_helper.c index eb9dc04..2e6ee7c 100644 --- a/target-i386/seg_helper.c +++ b/target-

Re: [Qemu-devel] [RFC 0/9] QContext: QOM class to support multiple event loops

2013-05-05 Thread liu ping fan
On Sat, May 4, 2013 at 12:03 AM, Michael Roth wrote: > These patches apply on top of qemu.git master, and can also be obtained from: > git://github.com/mdroth/qemu.git qcontext > > OVERVIEW > > This series introduces a set of QOM classes/interfaces for event > registration/handling: QContext and Q

Re: [Qemu-devel] [PATCH 1/3] virtio-pci: properly validate address before accessing config

2013-05-05 Thread Jason Wang
On 05/02/2013 10:35 PM, Andreas Färber wrote: > Am 28.04.2013 10:35, schrieb Michael S. Tsirkin: >> On Sun, Apr 28, 2013 at 03:54:20PM +0800, Jason Wang wrote: >>> On 04/28/2013 03:26 AM, Michael S. Tsirkin wrote: On Fri, Apr 26, 2013 at 04:34:02PM +0800, Jason Wang wrote: > There are seve

Re: [Qemu-devel] [PATCH] [KVM] Needless to update msi route when only msi-x entry "control" section changed

2013-05-05 Thread Zhanghaoyu (A)
>> With regard to old version linux guest(e.g., rhel-5.5), in ISR processing, >> mask and unmask msi-x vector every time, which result in VMEXIT, then QEMU >> will invoke kvm_irqchip_update_msi_route() to ask KVM hypervisor to update >> the VM irq routing table. In KVM hypervisor, synchronizing

Re: [Qemu-devel] [PATCH v2 6/6] virtio-blk: release reference to RAM's memoryRegion

2013-05-05 Thread liu ping fan
On Fri, May 3, 2013 at 6:09 PM, Stefan Hajnoczi wrote: > On Fri, May 03, 2013 at 10:45:22AM +0800, Liu Ping Fan wrote: >> From: Liu Ping Fan >> >> virtio-blk will unref RAM's memoryRegion when the io-req has been >> done. So we can avoid to call bdrv_drain_all() when RAM hot unplug. >> >> Signed-

Re: [Qemu-devel] [PATCH v4 0/2] i2c: Add AT24Cxx EEPROM model

2013-05-05 Thread Peter Crosthwaite
HI Jan, On Mon, Apr 29, 2013 at 11:09 PM, Jan Kiszka wrote: > Changes in v4: > - instead of provide size property, register at24c1..1024 types to >allow specifying the size via the device name > > Jan Kiszka (2): > i2c: Introduce device address mask > Add AT24Cxx I2C EEPROM device model

Re: [Qemu-devel] [PATCH v3 2/4] Add i.MX I2C controller emulator

2013-05-05 Thread Peter Crosthwaite
Hi JC, On Mon, May 6, 2013 at 12:28 AM, Jean-Christophe DUBOIS wrote: > The slave mode is not implemented. > > Changes since v1: > * use QOM cast > * run checkpatch on code > * added restrictin on MemoryRegionOps > * use DeviceClass::realise as init function > > Changes since v2:

Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump()

2013-05-05 Thread Wenchao Xia
于 2013-5-3 10:51, Wenchao Xia 写道: 于 2013-5-2 20:02, Luiz Capitulino 写道: On Thu, 02 May 2013 10:05:08 +0800 Wenchao Xia wrote: 于 2013-4-30 3:05, Luiz Capitulino 写道: On Fri, 26 Apr 2013 16:46:57 +0200 Stefan Hajnoczi wrote: On Fri, Apr 26, 2013 at 05:31:15PM +0800, Wenchao Xia wrote: @@ -2

Re: [Qemu-devel] [PATCH V4 5/5] block: make all steps in qmp_transaction() as callback

2013-05-05 Thread Wenchao Xia
于 2013-5-3 22:46, Eric Blake 写道: On 05/01/2013 08:26 PM, Wenchao Xia wrote: Make it easier to add other operations to qmp_transaction() by using callbacks, with external snapshots serving as an example implementation of the callbacks. Signed-off-by: Wenchao Xia --- blockdev.c | 92

Re: [Qemu-devel] [PATCH v7 0/7] push mmio dispatch out of big lock

2013-05-05 Thread liu ping fan
On Fri, May 3, 2013 at 4:04 PM, Jan Kiszka wrote: > On 2013-05-03 09:37, liu ping fan wrote: >> On Fri, May 3, 2013 at 12:58 AM, Jan Kiszka wrote: >>> Hi Pingfan, >>> >>> On 2012-12-06 08:28, liu ping fan wrote: Any suggestion? Or new design idea for this? >>> >>> Finally... I'm getting back

Re: [Qemu-devel] [PATCH v7 0/7] push mmio dispatch out of big lock

2013-05-05 Thread liu ping fan
On Sat, May 4, 2013 at 5:47 PM, Paolo Bonzini wrote: > Il 03/05/2013 10:04, Jan Kiszka ha scritto: >> We can't change the semantics of opaque as long as old_mmio / old_portio >> are around. But we need a flag anyway to indicate if a region is >> depending on BQL or not. Adding a separate "Object *

Re: [Qemu-devel] [PATCH v2 5/6] Vring: use hostmem's RAM safe api

2013-05-05 Thread liu ping fan
On Fri, May 3, 2013 at 6:02 PM, Stefan Hajnoczi wrote: > On Fri, May 03, 2013 at 10:45:21AM +0800, Liu Ping Fan wrote: >> @@ -109,11 +110,14 @@ bool vring_should_notify(VirtIODevice *vdev, Vring >> *vring) >> static int get_indirect(Vring *vring, >> struct iovec iov[], s

Re: [Qemu-devel] [PATCH v2 4/6] hostmem: hostmem listener pin RAM-Device by refcnt

2013-05-05 Thread liu ping fan
On Fri, May 3, 2013 at 5:35 PM, Stefan Hajnoczi wrote: > On Fri, May 03, 2013 at 10:45:20AM +0800, Liu Ping Fan wrote: >> From: Liu Ping Fan >> >> With ref()/unref() interface of MemoryRegion, we can pin RAM-Device >> when using its memory, and release it when done. >> >> Signed-off-by: Liu Ping

Re: [Qemu-devel] [PATCH v2 2/6] hostmem: AddressSpace has its own map and maintained by RCU prepared style

2013-05-05 Thread liu ping fan
On Fri, May 3, 2013 at 5:10 PM, Stefan Hajnoczi wrote: > On Fri, May 03, 2013 at 10:45:18AM +0800, Liu Ping Fan wrote: >> +/** >> + * Install new regions list >> + */ >> +static void hostmem_listener_commit(MemoryListener *listener) >> +{ >> +HostMem *tmp; >> +AddrSpaceMem *as_mem = contai

Re: [Qemu-devel] [PATCH] po/hu.po: Hungarian translation for the GTK+ interface

2013-05-05 Thread Ákos Kovács
On Sun, May 05, 2013 at 08:47:25PM +0200, Laszlo Ersek wrote: > On 05/04/13 17:22, akoskov...@gmx.com wrote: > > From: Ákos Kovács > > > > Cc: Laszlo Ersek > > Signed-off-by: Ákos Kovács > > --- > > po/hu.po | 63 > > ++ > > 1 file

Re: [Qemu-devel] [PATCH v2 0/6] proposal to make hostmem listener RAM unplug safe

2013-05-05 Thread liu ping fan
On Sat, May 4, 2013 at 5:53 PM, Paolo Bonzini wrote: > Il 03/05/2013 04:45, Liu Ping Fan ha scritto: >> v1->v2: >> 1.split RCU prepared style update and monitor the RAM-Device refcnt into >> two patches (patch 2,4) >> 2.introduce AddrSpaceMem, which is similar to HostMem, but based on >> add

[Qemu-devel] [PULL 2/3] prep: Add ELF support for -bios

2013-05-05 Thread Andreas Färber
This prepares for switching from OpenHack'Ware to OpenBIOS. While touching the error handling code, switch from aborting hw_error() to fprintf()+exit() and suppress failing without -bios for qtest. Acked-by: Alexander Graf Signed-off-by: Andreas Färber --- hw/ppc/prep.c | 31 ++

[Qemu-devel] [PULL 3/3] prep: Make System I/O port 0092 read/write

2013-05-05 Thread Andreas Färber
From: Julio Guerra Port 0x0092 is documented as read/write, so for now return the endianness state instead of hardcoded 0x00. Signed-off-by: Julio Guerra [AF: Extracted from larger port 0092 patch] Signed-off-by: Andreas Färber --- hw/ppc/prep.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[Qemu-devel] [PULL 1/3] prep: Fix NIP reset value

2013-05-05 Thread Andreas Färber
From: Fabien Chouteau The value was changed by commit 09d9828ace37ead29d510a7e24e63c2f15cd4b1c "PPC: fix hreset_vector for 60x, ...". Change it back for prep machine to unbreak OpenHack'Ware. Signed-off-by: Fabien Chouteau Signed-off-by: Andreas Färber --- hw/ppc/prep.c | 3 +++ 1 file chang

[Qemu-devel] [PULL for-1.5 0/3] PReP patch queue 2013-05-05

2013-05-05 Thread Andreas Färber
Hello, Please pull the PowerPC Reference Platform (PReP) queue into qemu.git master. It includes: * ppc NIP reset workaround for OpenHack'Ware, * ELF -bios support. * port 0092 read fix. The following changes since commit 467b34689d277fa56c09ad07ca0f08d7d7539f6d: Update OpenBIOS images (2013-

Re: [Qemu-devel] [PATCH] prep: Fix software reset

2013-05-05 Thread Andreas Färber
Am 16.02.2013 16:08, schrieb Julio Guerra: > The software reset of a PReP machine should reset the entire system > and not only the processor. It occurs when changing the 7th bit of > port 0092 from 0 to 1. > > Adding a new variable in PReP's sysctrl_t to store the soft reset bit > makes possible

Re: [Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-05 Thread Peter Maydell
On 5 May 2013 22:15, Michael S. Tsirkin wrote: > On Sun, May 05, 2013 at 07:01:34PM +0100, Peter Maydell wrote: >> Sorry, you can't say this until we've sorted out the mess >> that is new-style networking options in a machine which >> creates embedded network controllers. > What is missing exactl

Re: [Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-05 Thread Michael S. Tsirkin
On Sun, May 05, 2013 at 07:01:34PM +0100, Peter Maydell wrote: > On 5 May 2013 18:49, Michael S. Tsirkin wrote: > > Let's not bother with legacy -net support > > for new devices. > > > > Anyone who wants it can create it with the new style > > -device flag. > > Sorry, you can't say this until we'

Re: [Qemu-devel] [PATCH] [KVM] Needless to update msi route when only msi-x entry "control" section changed

2013-05-05 Thread Michael S. Tsirkin
On Sat, May 04, 2013 at 09:12:30AM +, Zhanghaoyu (A) wrote: > With regard to old version linux guest(e.g., rhel-5.5), in ISR processing, > mask and unmask msi-x vector every time, which result in VMEXIT, then QEMU > will invoke kvm_irqchip_update_msi_route() to ask KVM hypervisor to update >

Re: [Qemu-devel] [Patch] v2 fix /proc/self/maps output

2013-05-05 Thread Peter Maydell
On 2 April 2013 13:03, Christophe Lyon wrote: > Add a space at end of line when there is no filename to print, to > conform to linux kernel format (see show_map_vma() in > fs/proc/task_mmu.c). > > Signed-off-by: Christophe Lyon Reviewed-by: Peter Maydell (CCing Riku and/or trivial might have h

Re: [Qemu-devel] [Patch] v2 fix /proc/self/maps output

2013-05-05 Thread Christophe Lyon
Ping? On 2 April 2013 14:03, Christophe Lyon wrote: > Add a space at end of line when there is no filename to print, to > conform to linux kernel format (see show_map_vma() in > fs/proc/task_mmu.c). > > Signed-off-by: Christophe Lyon > --- > > Changes v1-v2: > Additional space is now part of the

[Qemu-devel] [uq/master PATCH] kvmvapic: add ioport read accessor

2013-05-05 Thread Marcelo Tosatti
Necessary since memory region accessor assumes read and write methods are registered. Otherwise reading I/O port 0x7e segfaults. https://bugzilla.redhat.com/show_bug.cgi?id=954306 Signed-off-by: Marcelo Tosatti diff --git a/hw/i386/kvmvapic.c b/hw/i386/kvmvapic.c index 5b558aa..655483b 100644

Re: [Qemu-devel] 1.4.1 won't build with --enable-debug-tcg (or --enable-debug)

2013-05-05 Thread Juergen Lock
On Sat, May 04, 2013 at 03:23:28PM +0100, Richard Sandiford wrote: > Juergen Lock writes: > > Hi! > > > > The failure is in the mips64-softmmu target: (at least) > > > > [...] > > CCmips64-softmmu/target-mips/translate.o > > ..qemu-1.4.1/target-mips/translate.c::2780:35 : error: > >

Re: [Qemu-devel] [PATCH] po/hu.po: Hungarian translation for the GTK+ interface

2013-05-05 Thread BALATON Zoltan
On Sun, 5 May 2013, Laszlo Ersek wrote: On 05/04/13 17:22, akoskov...@gmx.com wrote: +#: ../ui/gtk.c:217 +msgid " [Paused]" +msgstr " [Leállítva]" Hrmph. Yet another overloaded word. "Leállítva" can just as well mean "shut down" (adverb or adjective, not the verb). I'm tempted to recommend "fe

Re: [Qemu-devel] [PATCH] po/hu.po: Hungarian translation for the GTK+ interface

2013-05-05 Thread Laszlo Ersek
On 05/05/13 22:11, BALATON Zoltan wrote: > On Sun, 5 May 2013, Laszlo Ersek wrote: >> On 05/04/13 17:22, akoskov...@gmx.com wrote: >>> +#: ../ui/gtk.c:217 >>> +msgid " [Paused]" >>> +msgstr " [Leállítva]" >> >> Hrmph. Yet another overloaded word. "Leállítva" can just as well mean >> "shut down" (ad

Re: [Qemu-devel] [PATCH] po/hu.po: Hungarian translation for the GTK+ interface

2013-05-05 Thread Laszlo Ersek
On 05/05/13 21:29, Paolo Bonzini wrote: > Il 05/05/2013 20:47, Laszlo Ersek ha scritto: >>> + >>> +#: ../ui/gtk.c:1252 >>> +msgid "_Pause" >>> +msgstr "_Megállítva" >> >> I think the word is used here as a verb, ie. "pause the virtual >> machine". You could say "Felfüggesztés" (noun) or "Felfüggesz

Re: [Qemu-devel] [PATCH] po/hu.po: Hungarian translation for the GTK+ interface

2013-05-05 Thread Paolo Bonzini
Il 05/05/2013 20:47, Laszlo Ersek ha scritto: >> + >> +#: ../ui/gtk.c:1252 >> +msgid "_Pause" >> +msgstr "_Megállítva" > > I think the word is used here as a verb, ie. "pause the virtual > machine". You could say "Felfüggesztés" (noun) or "Felfüggeszt" (verb, > present tense, singular, third perso

Re: [Qemu-devel] [PATCH prep for-1.5 v2] prep: Add ELF support for -bios

2013-05-05 Thread Andreas Färber
Am 05.05.2013 20:40, schrieb Alexander Graf: > > > Am 05.05.2013 um 19:45 schrieb Andreas Färber : > >> This prepares for switching from OpenHack'Ware to OpenBIOS. >> >> While touching the error handling code, switch from aborting hw_error() >> to fprintf()+exit() and suppress failing without -b

Re: [Qemu-devel] [PATCH] po/hu.po: Hungarian translation for the GTK+ interface

2013-05-05 Thread Laszlo Ersek
On 05/04/13 17:22, akoskov...@gmx.com wrote: > From: Ákos Kovács > > Cc: Laszlo Ersek > Signed-off-by: Ákos Kovács > --- > po/hu.po | 63 > ++ > 1 files changed, 63 insertions(+), 0 deletions(-) > create mode 100644 po/hu.po Heh

Re: [Qemu-devel] [PATCH prep for-1.5 v2] prep: Add ELF support for -bios

2013-05-05 Thread Alexander Graf
Am 05.05.2013 um 19:45 schrieb Andreas Färber : > This prepares for switching from OpenHack'Ware to OpenBIOS. > > While touching the error handling code, switch from aborting hw_error() > to fprintf()+exit() and suppress failing without -bios for qtest. > > Signed-off-by: Andreas Färber Acke

Re: [Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-05 Thread Peter Maydell
On 5 May 2013 18:49, Michael S. Tsirkin wrote: > Let's not bother with legacy -net support > for new devices. > > Anyone who wants it can create it with the new style > -device flag. Sorry, you can't say this until we've sorted out the mess that is new-style networking options in a machine which

Re: [Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-05 Thread Michael S. Tsirkin
On Sat, May 04, 2013 at 04:09:11PM +0200, Jean-Christophe DUBOIS wrote: > This is based on the mcf_fec.c FEC implementation for ColdFire. > > * a generic phy was added (borrowed from lan9118). > * The buffer management is also modified as buffers are > slightly different between cold

[Qemu-devel] [PATCH prep for-1.5 v2] prep: Add ELF support for -bios

2013-05-05 Thread Andreas Färber
This prepares for switching from OpenHack'Ware to OpenBIOS. While touching the error handling code, switch from aborting hw_error() to fprintf()+exit() and suppress failing without -bios for qtest. Signed-off-by: Andreas Färber --- hw/ppc/prep.c | 31 ++- 1 file chan

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Fix recent compile breakage

2013-05-05 Thread Andreas Färber
Am 05.05.2013 18:47, schrieb Peter Maydell: > On 5 May 2013 17:29, Andreas Färber wrote: >> That works fine, but one error remains: >> >> LINK i386-softmmu/qemu-system-i386 >> Undefined symbols: >> "___sync_val_compare_and_swap", referenced from: >> _migrate_finish_set_state in migratio

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Fix recent compile breakage

2013-05-05 Thread Peter Maydell
On 5 May 2013 17:29, Andreas Färber wrote: > That works fine, but one error remains: > > LINK i386-softmmu/qemu-system-i386 > Undefined symbols: > "___sync_val_compare_and_swap", referenced from: > _migrate_finish_set_state in migration.o > ld: symbol(s) not found > collect2: ld returne

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Fix recent compile breakage

2013-05-05 Thread Andreas Färber
Am 22.04.2013 14:32, schrieb Paolo Bonzini: > Il 22/04/2013 13:51, Peter Maydell ha scritto: >> On 22 April 2013 00:03, Andreas Färber wrote: >>> Even after this has been applied, things are still not building for me. >>> >>> I'm seeing CC trace/generated-events.o failing with "error: parameter >>

[Qemu-devel] [PATCH v3 4/4] Add qtest support for i.MX I2C device emulation.

2013-05-05 Thread Jean-Christophe DUBOIS
This is using a ds1338 RTC chip on the i2c bus. This RTC chip is not present on the real board. Changes since v1: * not present on v1 Changes since v2: * use a common header file for I2C regs definition Signed-off-by: Jean-Christophe DUBOIS --- tests/Makefile | 3 + tests/ds1

[Qemu-devel] [PATCH v3 2/4] Add i.MX I2C controller emulator

2013-05-05 Thread Jean-Christophe DUBOIS
The slave mode is not implemented. Changes since v1: * use QOM cast * run checkpatch on code * added restrictin on MemoryRegionOps * use DeviceClass::realise as init function Changes since v2: * use CamelCase for state type * use extrac32() for bit manipilation. * impr

[Qemu-devel] [PATCH v3 1/4] Add i.MX FEC Ethernet emulator

2013-05-05 Thread Jean-Christophe DUBOIS
This is based on the mcf_fec.c FEC implementation for ColdFire. * a generic phy was added (borrowed from lan9118). * The buffer management is also modified as buffers are slightly different between coldfire and i.MX. Changes since V1: * none Changes since v2: * use QOM cast

[Qemu-devel] [PATCH v3 3/4] Add i.MX25 3DS evaluation board support.

2013-05-05 Thread Jean-Christophe DUBOIS
For now we support: * timers (GPT and EPIT) * serial ports (only 2 out of 5 possible) * ethernet (through the newly added FEC driver) * I2C (through the newly added I2C driver) A ds1338 I2C RTC chip was added on the first i2c bus to allow automatic test through qtest. This RTC is n

[Qemu-devel] [PATCH v3 0/4] Add i.MX25 support through the 3DS evaluation board

2013-05-05 Thread Jean-Christophe DUBOIS
This series of patches add the support for the i.MX25 processor through the Freescale 3DS evaluation board. For now a limited set of devices are supported. * GPT timers (from i.MX31) * EPIT timers (from i.MX31) * Serial ports (from i.MX31) * Ethernet FEC port * I2C controller

Re: [Qemu-devel] [PATCH for-1.5] audio: update documentation after removing --audio-card-list option

2013-05-05 Thread Andreas Färber
Am 04.05.2013 16:17, schrieb Hervé Poussineau: > Commit 98af93fde2e37b5b0c8cee9036e028fe6df6446c removed the > --audio-card-list option in configure, and commit > 8f3b664f6cc4153cc73941c941d54c4e499b7537 always compiled in > the adlib, gus and cs4231a audio cards. > > Signed-off-by: Hervé Poussine

Re: [Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-05 Thread Jean-Christophe DUBOIS
On 05/05/2013 03:31 PM, Andreas Färber wrote: Am 05.05.2013 15:14, schrieb Jean-Christophe DUBOIS: On 05/05/2013 05:11 AM, Peter Crosthwaite wrote: Hi JC, On Sun, May 5, 2013 at 12:09 AM, Jean-Christophe DUBOIS wrote: This is based on the mcf_fec.c FEC implementation for ColdFire. Note tha

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-1.5] audio: update documentation after removing --audio-card-list option

2013-05-05 Thread Michael Tokarev
04.05.2013 18:17, Hervé Poussineau wrote: > Commit 98af93fde2e37b5b0c8cee9036e028fe6df6446c removed the > --audio-card-list option in configure, and commit > 8f3b664f6cc4153cc73941c941d54c4e499b7537 always compiled in > the adlib, gus and cs4231a audio cards. Added to the trivial patches queue (ba

Re: [Qemu-devel] [Qemu-trivial] [PATCH] m25p80.c: Sync Flash chip list with Linux

2013-05-05 Thread Michael Tokarev
01.05.2013 18:40, Ed Maste wrote: > Add new devices for various manufacturers, and re-sort Spansion list to > match the order in Linux, which requires chips with a non-zero extended ID > to come first. > > With this commit the outstanding differences to Linux rev 55bf75b are: > > - Erase size fla

[Qemu-devel] [Bug 1175513] Re: Qemu 1.5-git gpu clock control doesn`t work after guest reboot

2013-05-05 Thread commiethebeastie
** Also affects: linux Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1175513 Title: Qemu 1.5-git gpu clock control doesn`t work after guest reboot Statu

Re: [Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-05 Thread Andreas Färber
Am 05.05.2013 15:14, schrieb Jean-Christophe DUBOIS: > On 05/05/2013 05:11 AM, Peter Crosthwaite wrote: >> Hi JC, >> >> On Sun, May 5, 2013 at 12:09 AM, Jean-Christophe DUBOIS >> wrote: >>> This is based on the mcf_fec.c FEC implementation for ColdFire. Note that ColdFire is one of the least mai

Re: [Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-05 Thread Jean-Christophe DUBOIS
On 05/05/2013 05:11 AM, Peter Crosthwaite wrote: Hi JC, On Sun, May 5, 2013 at 12:09 AM, Jean-Christophe DUBOIS wrote: This is based on the mcf_fec.c FEC implementation for ColdFire. * a generic phy was added (borrowed from lan9118). * The buffer management is also modified as buff

Re: [Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-05 Thread Peter Maydell
On 5 May 2013 12:59, Peter Crosthwaite wrote: > While your here I have an on topic question, do we want creation > helpers like this? I notice that we progressively moving towards the > state where machine models talk to QOM directly without wrapper init > fns such as this.. Are functions like thi

Re: [Qemu-devel] [PATCH v2 2/4] Add i.MX I2C controller driver.

2013-05-05 Thread Jean-Christophe DUBOIS
On 05/05/2013 01:34 PM, Andreas Färber wrote: Am 05.05.2013 05:14, schrieb Peter Crosthwaite: On Sun, May 5, 2013 at 12:09 AM, Jean-Christophe DUBOIS wrote: diff --git a/hw/i2c/imx_i2c.c b/hw/i2c/imx_i2c.c new file mode 100644 index 000..5b0d046 --- /dev/null +++ b/hw/i2c/imx_i2c.c [...]

Re: [Qemu-devel] Git head build problem (popcountl vs. system headers)

2013-05-05 Thread Blue Swirl
On Sat, Apr 27, 2013 at 6:50 PM, Martin Husemann wrote: > On Thu, Apr 25, 2013 at 08:36:55PM +0200, Martin Husemann wrote: >> Ok, I can fix the namespace issue (which is real) easily. > > Turns out to be a bit harder: qemu does not define (as far as I can tell) > any restricting macro (_POSIX_C_SO

Re: [Qemu-devel] [PATCH v2 2/4] Add i.MX I2C controller driver.

2013-05-05 Thread Jean-Christophe DUBOIS
On 05/05/2013 01:53 PM, Peter Crosthwaite wrote: Hi Peter, On Sun, May 5, 2013 at 9:41 PM, Peter Maydell wrote: On 5 May 2013 11:53, Peter Crosthwaite wrote: On Sun, May 5, 2013 at 8:47 PM, Peter Maydell wrote: On 5 May 2013 04:58, Jean-Christophe DUBOIS wrote: no extract16() macro spott

Re: [Qemu-devel] [PULL 0/1] target-arm queue

2013-05-05 Thread Blue Swirl
Thanks, pulled. On Fri, May 3, 2013 at 5:58 PM, Peter Maydell wrote: > Last target-arm pullreq before the hardfreeze; just a > single patch. (Actually it's a bugfix patch so strictly > it could go in post-freeze, but anyway.) > > Please pull. > > thanks > -- PMM > > > The following changes since

Re: [Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-05 Thread Peter Crosthwaite
Hi Andreas, On Sun, May 5, 2013 at 9:46 PM, Andreas Färber wrote: > Am 05.05.2013 05:11, schrieb Peter Crosthwaite: >> On Sun, May 5, 2013 at 12:09 AM, Jean-Christophe DUBOIS >> wrote: >>> +void imx_fec_create(int nic, const hwaddr base, qemu_irq irq) >> >> does this compile with Werror? I thoug

Re: [Qemu-devel] [PATCH v2 2/4] Add i.MX I2C controller driver.

2013-05-05 Thread Peter Crosthwaite
Hi Peter, On Sun, May 5, 2013 at 9:41 PM, Peter Maydell wrote: > On 5 May 2013 11:53, Peter Crosthwaite wrote: >> On Sun, May 5, 2013 at 8:47 PM, Peter Maydell >> wrote: >>> On 5 May 2013 04:58, Jean-Christophe DUBOIS wrote: no extract16() macro spotted. Should one be added? >>> >>>

Re: [Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-05 Thread Andreas Färber
Am 05.05.2013 05:11, schrieb Peter Crosthwaite: > On Sun, May 5, 2013 at 12:09 AM, Jean-Christophe DUBOIS > wrote: >> +void imx_fec_create(int nic, const hwaddr base, qemu_irq irq) > > does this compile with Werror? I thought there was a requirement that > all non-static functions must have a fn

Re: [Qemu-devel] [PATCH v2 2/4] Add i.MX I2C controller driver.

2013-05-05 Thread Peter Maydell
On 5 May 2013 11:53, Peter Crosthwaite wrote: > On Sun, May 5, 2013 at 8:47 PM, Peter Maydell > wrote: >> On 5 May 2013 04:58, Jean-Christophe DUBOIS wrote: >>> no extract16() macro spotted. >>> Should one be added? >> >> There's no need for one -- just use extract32. The only >> reason for hav

Re: [Qemu-devel] [PATCH v2 2/4] Add i.MX I2C controller driver.

2013-05-05 Thread Andreas Färber
Am 05.05.2013 05:14, schrieb Peter Crosthwaite: > On Sun, May 5, 2013 at 12:09 AM, Jean-Christophe DUBOIS > wrote: >> diff --git a/hw/i2c/imx_i2c.c b/hw/i2c/imx_i2c.c >> new file mode 100644 >> index 000..5b0d046 >> --- /dev/null >> +++ b/hw/i2c/imx_i2c.c [...] >> +typedef struct imx_i2c_state

Re: [Qemu-devel] [PATCH v2 2/4] Add i.MX I2C controller driver.

2013-05-05 Thread Peter Crosthwaite
Hi Peter, On Sun, May 5, 2013 at 8:47 PM, Peter Maydell wrote: > On 5 May 2013 04:58, Jean-Christophe DUBOIS wrote: >> On 05/05/2013 05:14 AM, Peter Crosthwaite wrote: >>> You could use an extract macro. extract32 is generally considered >>> better than shift and & logicvfor multi-bit fields. Il

Re: [Qemu-devel] [PATCH v2 2/4] Add i.MX I2C controller driver.

2013-05-05 Thread Peter Maydell
On 5 May 2013 04:58, Jean-Christophe DUBOIS wrote: > On 05/05/2013 05:14 AM, Peter Crosthwaite wrote: >> You could use an extract macro. extract32 is generally considered >> better than shift and & logicvfor multi-bit fields. Ill have to look >> up if extract16 exists (im away from tree for this r

Re: [Qemu-devel] [PATCH 2/7] qom: handle registration of new types when initializing the first ones

2013-05-05 Thread Hervé Poussineau
Andreas Färber a écrit : Am 02.05.2013 22:08, schrieb Hervé Poussineau: When initializing all types in object_class_foreach, called by object_class_get_list, some new types may be registered. Those will change the type internal hashtable which is currently enumerated, and may crash QEMU. Fix