Re: [Qemu-devel] [PATCH 1/2] virtio-pci: reset all qbuses too when writing to the status field

2012-12-12 Thread Paolo Bonzini
Il 12/12/2012 22:32, Michael S. Tsirkin ha scritto: > > i.e. just implement a method on the bus to do the hard-reset, and let > > generic infrastructure call it. > > I dislike this approach. > A specific function call is easier to follow. "I dislike reading documentation, so I prefer to have ugly

Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed

2012-12-12 Thread Paolo Bonzini
Il 12/12/2012 22:19, Michael S. Tsirkin ha scritto: > On Wed, Dec 12, 2012 at 10:00:37PM +0100, Paolo Bonzini wrote: >> Il 12/12/2012 20:23, Michael S. Tsirkin ha scritto: > Saving inuse counter is useless. We need to know which requests > are outstanding if we want to retry them on remote.

Re: [Qemu-devel] [PATCH v2 2/2] ivshmem: use irqfd to interrupt among VMs

2012-12-12 Thread liu ping fan
Hi Jan and Cam, It has been tested with uio driver. And other opinion for the code? Regards, Pingfan On Thu, Dec 6, 2012 at 2:37 PM, Liu Ping Fan wrote: > From: Liu Ping Fan > > Using irqfd, so we can avoid switch between kernel and user when > VMs interrupts each other. > > Signed-off-by: Liu

[Qemu-devel] [PULL] pci,net,misc infrastructure

2012-12-12 Thread Michael S. Tsirkin
The following changes since commit 1c97e303d4ea80a2691334b0febe87a50660f99d: Merge remote-tracking branch 'afaerber/qom-cpu' into staging (2012-12-10 08:35:15 -0600) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_anthony for you to fetc

Re: [Qemu-devel] [RFC PATCH] Allow building without graphics support

2012-12-12 Thread Gerd Hoffmann
On 12/13/12 01:57, Scott Wood wrote: > On 12/12/2012 01:52:29 AM, Gerd Hoffmann wrote: >> On 12/12/12 04:18, Scott Wood wrote: >> > QEMU is sometimes used in embedded contexts, where graphical support >> > is unnecessary. The ability to turn off graphics support not only >> > saves some space, but

Re: [Qemu-devel] [PATCH 1/3] Fix my email address

2012-12-12 Thread Wei-Ren Chen
On Wed, Dec 12, 2012 at 11:02:59PM +0100, Stefan Weil wrote: > Am 12.12.2012 08:24, schrieb Dongxue Zhang: > > > Sorry I don't really catch your idea. This email address is wrong and i > just > want to correct it. I just want to do something to qemu. When I add > target-mips/dsp_h

Re: [Qemu-devel] [RFC PATCH] Allow building without graphics support

2012-12-12 Thread Stefan Weil
Am 13.12.2012 01:48, schrieb Scott Wood: On 12/12/2012 12:46:44 AM, Stefan Weil wrote: Am 12.12.2012 04:18, schrieb Scott Wood: QEMU is sometimes used in embedded contexts, where graphical support is unnecessary. The ability to turn off graphics support not only saves some space, but it elimin

Re: [Qemu-devel] [PATCH] kvm: do not flush after deleting gsi

2012-12-12 Thread Asias He
Hello Michael, On 12/12/2012 06:48 PM, Michael S. Tsirkin wrote: > Deleting a GSI isn't necessary: it is enough > to stop using it. Delay flush until an entry is used. > > Signed-off-by: Michael S. Tsirkin > --- > kvm-all.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/kvm-all.c b/

[Qemu-devel] Guest OS cannot get the host timer

2012-12-12 Thread tran dung
After booting Arm Linux on QEMU 0.12.5, I checked the time by command "date". However, the displayed time was weird. Its year is 1970. Why cannot QEMU get timer of the host? -- Thanks and Best regards --- Tran Van Dung 1-1-1 Noji-higashi, Kusatsu, Shiga 525-8577 JAPAN Phone:

Re: [Qemu-devel] [BUG] QEMU crashes when 64bit BAR is present

2012-12-12 Thread Alexey Korolev
On 10/12/12 20:22, Gerd Hoffmann wrote: > On 12/10/12 03:05, Alexey Korolev wrote: >> Hi, It is a 64bit guest OS. I've upgraded to RHEL 5.8 and still have the same problem. >>> My rhel5 is 32bit. >>> Could you please send me a qemu command line you are running? >>> qemu-default -m 51

Re: [Qemu-devel] [RFC PATCH] Allow building without graphics support

2012-12-12 Thread Scott Wood
On 12/12/2012 01:52:29 AM, Gerd Hoffmann wrote: On 12/12/12 04:18, Scott Wood wrote: > QEMU is sometimes used in embedded contexts, where graphical support > is unnecessary. The ability to turn off graphics support not only > saves some space, but it eliminates the dependency on pixman. We have

Re: [Qemu-devel] [RFC PATCH] Allow building without graphics support

2012-12-12 Thread Scott Wood
On 12/12/2012 10:54:04 AM, Andreas Färber wrote: Am 12.12.2012 17:28, schrieb John Spencer: > On 12/12/2012 04:18 AM, Scott Wood wrote: >> QEMU is sometimes used in embedded contexts, where graphical support >> is unnecessary. The ability to turn off graphics support not only >> saves some sp

Re: [Qemu-devel] [RFC PATCH] Allow building without graphics support

2012-12-12 Thread Scott Wood
On 12/12/2012 10:47:04 AM, Peter Maydell wrote: On 12 December 2012 03:18, Scott Wood wrote: > QEMU is sometimes used in embedded contexts, where graphical support > is unnecessary. The ability to turn off graphics support not only > saves some space, but it eliminates the dependency on pixman.

Re: [Qemu-devel] [RFC PATCH] Allow building without graphics support

2012-12-12 Thread Scott Wood
On 12/12/2012 12:46:44 AM, Stefan Weil wrote: Am 12.12.2012 04:18, schrieb Scott Wood: QEMU is sometimes used in embedded contexts, where graphical support is unnecessary. The ability to turn off graphics support not only saves some space, but it eliminates the dependency on pixman. Signed-off

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/5] PPC: E500: Generate dt pci irq map dynamically

2012-12-12 Thread Alexander Graf
On 13.12.2012, at 01:33, Scott Wood wrote: > On 12/12/2012 06:28:02 PM, Alexander Graf wrote: >> On 13.12.2012, at 01:20, Scott Wood wrote: >> > On 12/12/2012 06:04:11 PM, Alexander Graf wrote: >> >> We could call bus->map_irq(...) with an artificially created PCIDevice >> >> struct ;). But that

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/5] PPC: E500: Generate dt pci irq map dynamically

2012-12-12 Thread Scott Wood
On 12/12/2012 06:28:02 PM, Alexander Graf wrote: On 13.12.2012, at 01:20, Scott Wood wrote: > On 12/12/2012 06:04:11 PM, Alexander Graf wrote: >> We could call bus->map_irq(...) with an artificially created PCIDevice struct ;). But that's pretty hacky. > > If we do anything like that, it sho

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/5] PPC: E500: Generate dt pci irq map dynamically

2012-12-12 Thread Alexander Graf
On 13.12.2012, at 01:20, Scott Wood wrote: > On 12/12/2012 06:04:11 PM, Alexander Graf wrote: >> On 13.12.2012, at 00:43, Scott Wood wrote: >> > On 12/12/2012 05:38:32 PM, Alexander Graf wrote: >> >> On 12.12.2012, at 19:40, Scott Wood wrote: >> >> > On 12/12/2012 08:09:56 AM, Alexander Graf wrot

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/5] PPC: E500: Generate dt pci irq map dynamically

2012-12-12 Thread Scott Wood
On 12/12/2012 06:04:11 PM, Alexander Graf wrote: On 13.12.2012, at 00:43, Scott Wood wrote: > On 12/12/2012 05:38:32 PM, Alexander Graf wrote: >> On 12.12.2012, at 19:40, Scott Wood wrote: >> > On 12/12/2012 08:09:56 AM, Alexander Graf wrote: >> >> +for (slot = first_slot; slot < last_slot;

[Qemu-devel] [PATCH] target-xtensa: fix ITLB/DTLB page protection flags

2012-12-12 Thread Max Filippov
With MMU option xtensa architecture has two TLBs: ITLB and DTLB. ITLB is only used for code access, DTLB is only for data. However TLB entries in both TLBs have attribute field controlling write and exec access. These bits need to be properly masked off depending on TLB type before being used as tl

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-12 Thread Busch, Keith
On Mon, Dec 10, 2012 at 7:11 AM, Stefan Hajnoczi wrote: > Quick pointers to get started on Kevin's suggestion: > > bdrv_aio_readv(), bdrv_aio_writev(), bdrv_aio_flush(), and > bdrv_aio_discard() provide the block device operations that emulated > storage controllers use. There seems to be an issu

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/5] PPC: E500: Generate dt pci irq map dynamically

2012-12-12 Thread Alexander Graf
On 13.12.2012, at 00:43, Scott Wood wrote: > On 12/12/2012 05:38:32 PM, Alexander Graf wrote: >> On 12.12.2012, at 19:40, Scott Wood wrote: >> > On 12/12/2012 08:09:56 AM, Alexander Graf wrote: >> >> +for (slot = first_slot; slot < last_slot; slot++) { >> >> +for (pci_irq = 0; pci_irq

Re: [Qemu-devel] new pc-bios/bios.bin breaks freebsd booting

2012-12-12 Thread Luigi Rizzo
On Wed, Dec 12, 2012 at 06:47:58PM +0100, Paolo Bonzini wrote: > Il 12/12/2012 17:04, Luigi Rizzo ha scritto: > > I am not sure if it has been reported already but this commit > > > > http://git.qemu.org/?p=qemu.git;a=commitdiff;h=d7a51dbbaa70677846453f8c961590913052dd86 > > > > (replacing pc-bio

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/5] PPC: E500: Generate dt pci irq map dynamically

2012-12-12 Thread Scott Wood
On 12/12/2012 05:38:32 PM, Alexander Graf wrote: On 12.12.2012, at 19:40, Scott Wood wrote: > On 12/12/2012 08:09:56 AM, Alexander Graf wrote: >> +for (slot = first_slot; slot < last_slot; slot++) { >> +for (pci_irq = 0; pci_irq < 4; pci_irq++) { >> +pci_map[i++] = cpu_t

Re: [Qemu-devel] [PATCH 01/20] host-utils: add ffsl

2012-12-12 Thread Eric Blake
On 12/12/2012 06:46 AM, Paolo Bonzini wrote: > We can provide fast versions based on the other functions defined > by host-utils.h. Some care is required on glibc, which provides > ffsl already. > > Signed-off-by: Paolo Bonzini > --- > host-utils.h | 26 ++ > 1 file chan

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/5] PPC: E500: Generate dt pci irq map dynamically

2012-12-12 Thread Alexander Graf
On 12.12.2012, at 19:40, Scott Wood wrote: > On 12/12/2012 08:09:56 AM, Alexander Graf wrote: >> Today we're hardcoding the PCI interrupt map in the e500 machine file. >> Instead, let's write it dynamically so that different machine types >> can have different slot properties. >> Signed-off-by: A

Re: [Qemu-devel] [PATCH 2/3] target-i386/cpu.c: coding style fix

2012-12-12 Thread Igor Mammedov
On Wed, 12 Dec 2012 20:22:25 -0200 Eduardo Habkost wrote: While at it, could you remove the last as well? > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index a2ee

Re: [Qemu-devel] [PATCH 2/3] Make-repl_ph-to-sign-extended-to-target_long

2012-12-12 Thread Jovanovic, Petar
What does it mean you do not have gcc that can compile repl.ph instruction? How do you test your patches? If you want to append the repl_ph.c, you may want to add something like this: diff --git a/tests/tcg/mips/mips32-dsp/repl_ph.c b/tests/tcg/mips/mips32-dsp/repl_ph.c index 2107495..07d137d --

Re: [Qemu-devel] [PATCH 2/2] tests: Add tmp105 unit test

2012-12-12 Thread Andreas Färber
Am 12.12.2012 20:43, schrieb Blue Swirl: > On Wed, Dec 12, 2012 at 6:29 AM, Andreas Färber > wrote: >> +static void omap_i2c_send(uint8_t addr, const void *buf, uint16_t len) > > With const uint8_t *buf you could avoid a few casts below. Good idea, thanks. I was working with other data types be

[Qemu-devel] [PATCH v4 5/6] hw/ds1338.c: Implement support for the control register.

2012-12-12 Thread Antoine Mathys
Signed-off-by: Antoine Mathys --- hw/ds1338.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/hw/ds1338.c b/hw/ds1338.c index d2f52fc..94a2f54 100644 --- a/hw/ds1338.c +++ b/hw/ds1338.c @@ -125,7 +125,8 @@ static int ds1338_send(I2CSlave *i2c, uint8_t da

[Qemu-devel] [PATCH v4 6/6] hw/ds1338.c: Fix handling of DAY (wday) register.

2012-12-12 Thread Antoine Mathys
Per the datasheet, the DAY (wday) register is user defined. Implement this. Signed-off-by: Antoine Mathys --- hw/ds1338.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/hw/ds1338.c b/hw/ds1338.c index 94a2f54..1aefa3b 100644 --- a/hw/ds1338.c +++ b/hw/ds1

[Qemu-devel] [PATCH v4 4/6] hw/ds1338.c: Ensure state is properly initialized.

2012-12-12 Thread Antoine Mathys
Signed-off-by: Antoine Mathys --- hw/ds1338.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/ds1338.c b/hw/ds1338.c index 0f88720..d2f52fc 100644 --- a/hw/ds1338.c +++ b/hw/ds1338.c @@ -179,6 +179,17 @@ static int ds1338_init(I2CSlave *i2c) return 0; } +static voi

[Qemu-devel] [PATCH v4 3/6] hw/ds1338.c: Fix handling of HOURS register.

2012-12-12 Thread Antoine Mathys
Per the datasheet, the mapping between 12 and 24 hours modes is: 0 <-> 12 PM 1-12 <-> 1-12 AM 13-23 <-> 1-11 PM Signed-off-by: Antoine Mathys --- hw/ds1338.c | 29 ++--- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/hw/d

[Qemu-devel] [PATCH v4 2/6] hw/ds1338.c: Add definitions for various flags in the RTC registers.

2012-12-12 Thread Antoine Mathys
Signed-off-by: Antoine Mathys --- hw/ds1338.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/ds1338.c b/hw/ds1338.c index faaa4a0..69018bc 100644 --- a/hw/ds1338.c +++ b/hw/ds1338.c @@ -17,6 +17,12 @@ */ #define NVRAM_SIZE 64 +/* Flags definitions */ +#define SECONDS_CH 0x8

[Qemu-devel] [PATCH v4 1/6] hw/ds1338.c: Correct bug in conversion to BCD.

2012-12-12 Thread Antoine Mathys
Signed-off-by: Antoine Mathys --- hw/ds1338.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ds1338.c b/hw/ds1338.c index b576d56..faaa4a0 100644 --- a/hw/ds1338.c +++ b/hw/ds1338.c @@ -57,9 +57,9 @@ static void capture_current_time(DS1338State *s) } else {

[Qemu-devel] [PATCH v4 0/6] hw/ds1338.c

2012-12-12 Thread Antoine Mathys

Re: [Qemu-devel] [PATCH v3 4/6] hw/ds1338.c: Ensure state is properly initialized.

2012-12-12 Thread Antoine Mathys
Oops. There was a problem in the patch. Resending the series.

[Qemu-devel] [PATCH] define qemukvm-1.2 machine type

2012-12-12 Thread Marcelo Tosatti
To allow migration from qemu-kvm-1.2, where cirrus device has 16 megabytes of RAM. Signed-off-by: Marcelo Tosatti diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 19e342a..ead4b6b 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -347,6 +347,26 @@ static QEMUMachine pc_machine_v1_2 = { }, };

Re: [Qemu-devel] [PATCH v3 4/6] hw/ds1338.c: Ensure state is properly initialized.

2012-12-12 Thread Antoine Mathys
Signed-off-by: Antoine Mathys --- hw/ds1338.c | 51 ++- 1 file changed, 38 insertions(+), 13 deletions(-) diff --git a/hw/ds1338.c b/hw/ds1338.c index b576d56..d2f52fc 100644 --- a/hw/ds1338.c +++ b/hw/ds1338.c @@ -17,6 +17,12 @@ */ #define

Re: [Qemu-devel] [PATCH v3 6/6] hw/ds1338.c: Fix handling of DAY (wday) register.

2012-12-12 Thread Antoine Mathys
Per the datasheet, the DAY (wday) register is user defined. Implement this. Signed-off-by: Antoine Mathys --- hw/ds1338.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/hw/ds1338.c b/hw/ds1338.c index 94a2f54..1aefa3b 100644 --- a/hw/ds1338.c +++ b/hw/ds1

Re: [Qemu-devel] [PATCH v3 3/6] hw/ds1338.c: Fix handling of HOURS register.

2012-12-12 Thread Antoine Mathys
Per the datasheet, the mapping between 12 and 24 hours modes is: 0 <-> 12 PM 1-12 <-> 1-12 AM 13-23 <-> 1-11 PM Signed-off-by: Antoine Mathys --- hw/ds1338.c | 29 ++--- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/hw/

Re: [Qemu-devel] [PATCH v3 5/6] hw/ds1338.c: Implement support for the control register.

2012-12-12 Thread Antoine Mathys
Signed-off-by: Antoine Mathys --- hw/ds1338.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/hw/ds1338.c b/hw/ds1338.c index d2f52fc..94a2f54 100644 --- a/hw/ds1338.c +++ b/hw/ds1338.c @@ -125,7 +125,8 @@ static int ds1338_send(I2CSlave *i2c, uint8_t da

[Qemu-devel] [PATCH 0/3] replace cpuid_*features fields with a featue word array (v2)

2012-12-12 Thread Eduardo Habkost
Changes in v2: - Rebased on top of: Subject: [PATCH 0/2] target-i386: move CPU object creation to cpu.c (v2) - Wrote a sed script that can be used to reproduce exactly the same changes from patch 3: https://gist.github.com/4271991 Git tree for testing: git://github.com/ehabkost/qemu-h

Re: [Qemu-devel] [PATCH v3 1/6] hw/ds1338.c: Correct bug in conversion to BCD.

2012-12-12 Thread Antoine Mathys
Signed-off-by: Antoine Mathys --- hw/ds1338.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ds1338.c b/hw/ds1338.c index b576d56..faaa4a0 100644 --- a/hw/ds1338.c +++ b/hw/ds1338.c @@ -57,9 +57,9 @@ static void capture_current_time(DS1338State *s) } else {

Re: [Qemu-devel] [PATCH v3 2/6] hw/ds1338.c: Add definitions for various flags in, the RTC registers.

2012-12-12 Thread Antoine Mathys
Signed-off-by: Antoine Mathys --- hw/ds1338.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/ds1338.c b/hw/ds1338.c index faaa4a0..69018bc 100644 --- a/hw/ds1338.c +++ b/hw/ds1338.c @@ -17,6 +17,12 @@ */ #define NVRAM_SIZE 64 +/* Flags definitions */ +#define SECONDS_CH 0x8

[Qemu-devel] [PATCH v3 0/6] hw/ds1338.c

2012-12-12 Thread Antoine Mathys

[Qemu-devel] [PATCH 3/3] target-i386: replace cpuid_*features fields with a feature word array

2012-12-12 Thread Eduardo Habkost
This replaces the feature-bit fields on both X86CPU and x86_def_t structs with an array. With this, we will be able to simplify code that simply does the same operation on all feature words (e.g. kvm_check_features_against_host(), filter_features_for_kvm(), add_flagname_to_bitmaps(), and CPU featu

[Qemu-devel] [PATCH 2/3] target-i386/cpu.c: coding style fix

2012-12-12 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index a2ee8bb..25f7500 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1865,10 +1865,11 @@ void cpu_x86_cpuid(CPUX86State

[Qemu-devel] [PATCH 1/3] target-i386: add EXT2_PPRO_FEATURES #define

2012-12-12 Thread Eduardo Habkost
Instead of repeating the (PPRO_FEATURES & CPUID_EXT2_AMD_ALIASES) expression everywhere, use EXT2_PPRO_FEATURES. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 546c

Re: [Qemu-devel] [PATCH 1/3] Fix my email address

2012-12-12 Thread Stefan Weil
Am 12.12.2012 08:24, schrieb Dongxue Zhang: Sorry I don't really catch your idea. This email address is wrong and i just want to correct it. I just want to do something to qemu. When I add target-mips/dsp_helper.c I got lots of help from other people, so I also want to help others who need he

Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed

2012-12-12 Thread Michael S. Tsirkin
On Wed, Dec 12, 2012 at 03:33:32PM -0600, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Wed, Dec 12, 2012 at 10:00:37PM +0100, Paolo Bonzini wrote: > >> Il 12/12/2012 20:23, Michael S. Tsirkin ha scritto: > >> >>> Saving inuse counter is useless. We need to know which requests >

[Qemu-devel] [PATCH] RTC: enable lost_tick_policy=slew as default (v2)

2012-12-12 Thread Marcelo Tosatti
RTC interrupt reinjection has no known negative effect. Lack of RTC interrupt reinjection, though, has negative effects: time drift for Windows guests which use it as a timer source. Based on that, enable lost_tick_policy=slew option as default. Signed-off-by: Marcelo Tosatti v2: do not change

Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed

2012-12-12 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Wed, Dec 12, 2012 at 10:00:37PM +0100, Paolo Bonzini wrote: >> Il 12/12/2012 20:23, Michael S. Tsirkin ha scritto: >> >>> Saving inuse counter is useless. We need to know which requests >> >>> are outstanding if we want to retry them on remote. >> >> >> >> And th

Re: [Qemu-devel] [PATCH 1/2] virtio-pci: reset all qbuses too when writing to the status field

2012-12-12 Thread Michael S. Tsirkin
On Wed, Dec 12, 2012 at 06:29:54PM +0100, Paolo Bonzini wrote: > > >> No, it's a generic thing. Other virtio devices may have a bus, and they > >> should reset it just as well. virtio-serial's guest_reset function > >> closes each port from its own reset callback manually (since commit > >> 4399

Re: [Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API.

2012-12-12 Thread Michael S. Tsirkin
On Wed, Dec 12, 2012 at 07:03:21PM +0100, Paolo Bonzini wrote: > Il 12/12/2012 18:58, Peter Maydell ha scritto: > > It should be equally > > valid to just use the PCI transport plugged into a VirtioDevice, > > both of which were created by the user with -device [and for > > new transports, separate

Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed

2012-12-12 Thread Michael S. Tsirkin
On Wed, Dec 12, 2012 at 10:00:37PM +0100, Paolo Bonzini wrote: > Il 12/12/2012 20:23, Michael S. Tsirkin ha scritto: > >>> Saving inuse counter is useless. We need to know which requests > >>> are outstanding if we want to retry them on remote. > >> > >> And that's what virtio-blk and virtio-scsi h

Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed

2012-12-12 Thread Paolo Bonzini
Il 12/12/2012 20:23, Michael S. Tsirkin ha scritto: >>> Saving inuse counter is useless. We need to know which requests >>> are outstanding if we want to retry them on remote. >> >> And that's what virtio-blk and virtio-scsi have been doing for years. > > I don't see it - all I see in save is virt

Re: [Qemu-devel] [PATCH 7/8] pci: rename pci_internals.h pci_bus.h

2012-12-12 Thread Michael S. Tsirkin
On Wed, Dec 12, 2012 at 07:56:50PM +, Blue Swirl wrote: > On Wed, Dec 12, 2012 at 1:14 PM, Michael S. Tsirkin wrote: > > There are lots of external users of pci_internals.h, > > apparently making it an internal interface only didn't > > work out. Let's stop pretending it's an internal header.

Re: [Qemu-devel] [PATCH 0/8] pci core reorg

2012-12-12 Thread Michael S. Tsirkin
On Wed, Dec 12, 2012 at 08:00:58PM +, Blue Swirl wrote: > On Wed, Dec 12, 2012 at 1:13 PM, Michael S. Tsirkin wrote: > > This patchset starts some cleanups of the pci core > > by rearranging the code: pci core is split out > > from devices into its own directory, pci internals.h > > is renamed

Re: [Qemu-devel] [PATCH 5/8] pci: make external dependencies explicit

2012-12-12 Thread Michael S. Tsirkin
On Wed, Dec 12, 2012 at 07:49:35PM +, Blue Swirl wrote: > On Wed, Dec 12, 2012 at 1:14 PM, Michael S. Tsirkin wrote: > > Include dependencies from pci core using <> and > > Nack, the usual convention is to use <> for system headers like > and "" for local headers. > > For example with MSVC

Re: [Qemu-devel] cpu hotplug roadmap ?

2012-12-12 Thread Igor Mammedov
On Wed, 12 Dec 2012 17:55:38 +0100 (CET) Alexandre DERUMIER wrote: > Hi, > this wiki talked about cpu hotplug for qemu 1.3. > > http://wiki.qemu.org/Features/CPUHotplug > > Is it planned for qemu 1.4 ? or later release ? WiKi is not complete yet and shows only foreseeable steps that hopefully w

[Qemu-devel] [Bug 1089006] Re: Qemu scrambles order of eth devices in vm

2012-12-12 Thread john fisher
Thank you Daniel. I understand what you say and agree. However when presented with a mapping and an order by libvirt, shouldn't the order be preserved by default? If the OS scrambles it, then fine, not your problem... Are we on the right track here, is there some way to control the order as pres

Re: [Qemu-devel] [PATCH 0/8] pci core reorg

2012-12-12 Thread Blue Swirl
On Wed, Dec 12, 2012 at 1:13 PM, Michael S. Tsirkin wrote: > This patchset starts some cleanups of the pci core > by rearranging the code: pci core is split out > from devices into its own directory, pci internals.h > is renamed as it's used externally a lot. > > I'd like to merge this quickly to

Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/19] openpic: rename openpic_t to OpenPICState

2012-12-12 Thread Blue Swirl
On Wed, Dec 12, 2012 at 2:12 PM, Alexander Graf wrote: > Rename the openpic_t struct to OpenPICState, so it adheres better to > the current coding style rules. > > Signed-off-by: Alexander Graf > --- > hw/openpic.c | 68 > +- > 1 files c

Re: [Qemu-devel] [PATCH 7/8] pci: rename pci_internals.h pci_bus.h

2012-12-12 Thread Blue Swirl
On Wed, Dec 12, 2012 at 1:14 PM, Michael S. Tsirkin wrote: > There are lots of external users of pci_internals.h, > apparently making it an internal interface only didn't > work out. Let's stop pretending it's an internal header. > > Signed-off-by: Michael S. Tsirkin > --- > hw/apb_pci.c

Re: [Qemu-devel] [PATCH 1/3] s390: Move IPL code into a separate device

2012-12-12 Thread Christian Borntraeger
On 12/12/12 14:31, Alexander Graf wrote: >> +void s390_ipl_cpu(uint64_t pswaddr) > > Any reason this isn't inlined inside the reset handler? And why is this > public? Well, the former patch version had the disk bootmap parsing in a separate file, but we can certainly unexport that and make it i

Re: [Qemu-devel] [PATCH 5/8] pci: make external dependencies explicit

2012-12-12 Thread Blue Swirl
On Wed, Dec 12, 2012 at 1:14 PM, Michael S. Tsirkin wrote: > Include dependencies from pci core using <> and Nack, the usual convention is to use <> for system headers like and "" for local headers. For example with MSVC the search path for angle brackets does not even include the local directo

Re: [Qemu-devel] [PATCH 2/2] tests: Add tmp105 unit test

2012-12-12 Thread Blue Swirl
On Wed, Dec 12, 2012 at 6:29 AM, Andreas Färber wrote: > Exercise all four commands of the TMP105, testing for an issue in the > I2C TX path. The test case is specific to the n800's OMAP I2C for now > and is the first test case for arm. > > Signed-off-by: Andreas Färber > --- > tests/Makefile

Re: [Qemu-devel] [PATCH v2 3/6] add backup related monitor commands

2012-12-12 Thread Dietmar Maurer
> I'm coming into this review late, so I'm not sure what your series is adding > that cannot already be done with external snapshots and migration to file. This series try to do backup more efficient (see docu in [PATCH v2 1/6]). > But any time someone proposes new QMP commands that libvirt might

Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed

2012-12-12 Thread Michael S. Tsirkin
On Wed, Dec 12, 2012 at 06:39:15PM +0100, Paolo Bonzini wrote: > Il 12/12/2012 18:14, Michael S. Tsirkin ha scritto: > > On Wed, Dec 12, 2012 at 05:51:51PM +0100, Paolo Bonzini wrote: > >> Il 12/12/2012 17:37, Michael S. Tsirkin ha scritto: > You wrote "the only way to know head 1 is outstandi

Re: [Qemu-devel] [RFC 04/34] qdev: Prepare "realized" property

2012-12-12 Thread Eduardo Habkost
On Wed, Dec 12, 2012 at 07:25:01PM +0100, Andreas Färber wrote: > Am 12.12.2012 19:16, schrieb Eduardo Habkost: > > So, just to check if I understood all correctly: > > > > DeviceClass.init() is just the old and deprecated version of > > DeviceClass.realize() (just because the former has no Error

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/5] PPC: E500: Generate dt pci irq map dynamically

2012-12-12 Thread Scott Wood
On 12/12/2012 08:09:56 AM, Alexander Graf wrote: Today we're hardcoding the PCI interrupt map in the e500 machine file. Instead, let's write it dynamically so that different machine types can have different slot properties. Signed-off-by: Alexander Graf --- hw/ppc/e500.c | 51 +

Re: [Qemu-devel] [PATCH 1/2] add visitor for parsing int[KMGT] input string

2012-12-12 Thread Eduardo Habkost
On Mon, Dec 10, 2012 at 10:33:06PM +0100, Igor Mammedov wrote: > Caller of visit_type_suffixed_int() have to specify > value of 'K' suffix using suffix_factor argument. > Example of selecting suffix_factor value: > * Kbytes: 1024 > * Khz: 1000 > > Signed-off-by: Igor Mammedov Reviewed-by: Edua

[Qemu-devel] [Bug 1089281] Re: kvm crash when writing on disk

2012-12-12 Thread xavy
** Attachment added: "libvirtd-qemu-machine.log" https://bugs.launchpad.net/qemu/+bug/1089281/+attachment/3458117/+files/libvirtd-qemu-machine.log -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/108

Re: [Qemu-devel] [PATCH 3/3] S390: Enable -cpu help and QMP query-cpu-definitions

2012-12-12 Thread Alexander Graf
On 12/12/2012 06:52 PM, Richard Henderson wrote: On 12/12/2012 06:03 AM, Alexander Graf wrote: The TCG model is a "z900". We can just have a "z900" model and a "host" model with tcg_enabled() vs kvm_enabled() checks on each. My target-s390x tcg rewrite targets something just shy of z196. The m

Re: [Qemu-devel] [RFC 04/34] qdev: Prepare "realized" property

2012-12-12 Thread Andreas Färber
Am 12.12.2012 19:16, schrieb Eduardo Habkost: > So, just to check if I understood all correctly: > > DeviceClass.init() is just the old and deprecated version of > DeviceClass.realize() (just because the former has no Error parameter), > but both have exactly the same semantics/purpose, and device

[Qemu-devel] [Bug 1089281] [NEW] kvm crash when writing on disk

2012-12-12 Thread xavy
Public bug reported: When running the following command: /usr/bin/kvm -S -M pc-1.0 -cpu qemu32 -enable-kvm -m 1024 -smp 1,sockets=1,cores=1,threads=1 -name winxp -uuid f86ef88f-b90e-699a- 74b8-9675063fc26e -nodefconfig -nodefaults -chardev socket,id=charmonitor,path=/var/lib/libvirt/qemu/winxp.mo

[Qemu-devel] [Bug 1087114] Re: assertion "QLIST_EMPTY(&bs->tracked_requests)" failed

2012-12-12 Thread Brad Smith
qemu-system-x86_64 -cdrom [image] -boot -d -hda virtual.img is the command line I was using. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1087114 Title: assertion "QLIST_EMPTY(&bs->tracked_reques

Re: [Qemu-devel] [PATCH 3/3] S390: Enable -cpu help and QMP query-cpu-definitions

2012-12-12 Thread Alexander Graf
On 12/12/2012 05:28 PM, Andreas Färber wrote: Am 12.12.2012 16:05, schrieb Viktor Mihajlovski: On 12/12/2012 02:51 PM, Andreas Färber wrote: +(*cpu_fprintf)(f, "s390 %16s\n", "[host]"); Note that the square-bracket notation was specific to x86 when it distinguished between built-in and con

Re: [Qemu-devel] [RFC qom-cpu v2 2/2] target-i386: Turn Haswell into subclass of SandyBridge

2012-12-12 Thread Alexander Graf
On 12/12/2012 06:29 PM, Andreas Färber wrote: Am 12.12.2012 16:05, schrieb Eduardo Habkost: On Wed, Dec 12, 2012 at 03:47:49PM +0100, Andreas Färber wrote: Am 12.12.2012 13:45, schrieb Eduardo Habkost: On Mon, Dec 10, 2012 at 11:59:32PM +0100, Andreas Färber wrote: ehabkost: "When adding t

Re: [Qemu-devel] [PATCH v2 4/6] hw/ds1338.c: Ensure state is properly initialized.

2012-12-12 Thread Peter Maydell
On 12 December 2012 12:46, Antoine Mathys wrote: > On 12/12/2012 01:05 PM, Peter Maydell wrote: >> I think we need to reset ptr and addr_byte too... > > The initial value of the register pointer is unspecified. > > addr_byte is only used when receiving user data. It is written in > ds1338_event()

Re: [Qemu-devel] [PATCH 2/2] target-i386: use visit_type_suffixed_int() to parse tsc_freq property value

2012-12-12 Thread Eduardo Habkost
On Mon, Dec 10, 2012 at 10:33:07PM +0100, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Like I said in the previous patch, maybe it would be nice to have a visit_type_frequency() helper, to hide the specific details/parameters required to parse frequency value

Re: [Qemu-devel] [RFC 04/34] qdev: Prepare "realized" property

2012-12-12 Thread Eduardo Habkost
On Wed, Dec 12, 2012 at 05:51:18PM +0100, Andreas Färber wrote: > Am 12.12.2012 15:29, schrieb Eduardo Habkost: > > On Mon, Nov 26, 2012 at 01:12:16AM +0100, Andreas Färber wrote: > >> Based on earlier patches by Paolo and me, introduce the QOM realizefn at > >> device level only, as requested by A

Re: [Qemu-devel] [PATCH 1/2] virtio-pci: reset all qbuses too when writing to the status field

2012-12-12 Thread Paolo Bonzini
>> No, it's a generic thing. Other virtio devices may have a bus, and they >> should reset it just as well. virtio-serial's guest_reset function >> closes each port from its own reset callback manually (since commit >> 4399722, virtio-serial-bus: Unset guest_connected at reset and driver >> rese

[Qemu-devel] [PATCH 0/2] target-i386: move CPU object creation to cpu.c (v2)

2012-12-12 Thread Eduardo Habkost
This small series moves the X86CPU object creation to the cpu.c code, as the object creation will depend on the CPU class lookup, that will be done inside cpu.c. I expect this to make the x86 CPU subclass work simpler. Maybe it will help simplify some of the CPU properties work, too. This version

[Qemu-devel] [PATCH 1/2] target-i386: move CPU object creation to cpu.c

2012-12-12 Thread Eduardo Habkost
As we will need to create the CPU object after splitting the CPU model string (because we're going to use different subclasses for each CPU model), move the CPU object creation to cpu_x86_register(), and at the same time rename cpu_x86_register() to cpu_x86_create(). This will also simplify the CP

[Qemu-devel] [PATCH 2/2] target-i386: make cpu_x86_create() get Error argument

2012-12-12 Thread Eduardo Habkost
Instead of forcing the caller to guess what went wrong while creating the CPU object, return error information in a Error argument. Also, as cpu_x86_create() won't print error messages itself anymore, change cpu_x86_init() to print any error returned by cpu_x86_create() or cpu_x86_realize(). Sign

Re: [Qemu-devel] [BUG] qemu-1.1.2 [FIXED-BY] qcow2: Fix avail_sectors in cluster allocation code

2012-12-12 Thread Philipp Hahn
Hello Kevin, Am Mittwoch 12 Dezember 2012 17:54:58 schrieb Kevin Wolf: > Am 12.12.2012 15:09, schrieb Philipp Hahn: > > Am Mittwoch 12 Dezember 2012 14:41:49 schrieb Kevin Wolf: > >> As you can see in the commit message of that patch I was convinced that > >> no bug did exist in practice and this

Re: [Qemu-devel] [ [PATCH 1/2] cutils:change strtosz_suffix_unit function

2012-12-12 Thread Igor Mammedov
On Fri, 7 Dec 2012 11:49:49 +0800 liguang wrote: > if value to be translated is larger than INT64_MAX, > this function will not be convenient for caller to > be aware of it, so change a little for this. > > Signed-off-by: liguang > --- > cutils.c |5 +++-- > 1 files changed, 3 insertions(+

Re: [Qemu-devel] [PATCH 3/3] S390: Enable -cpu help and QMP query-cpu-definitions

2012-12-12 Thread Viktor Mihajlovski
On 12/12/2012 03:03 PM, Alexander Graf wrote: The TCG model is a "z900". We can just have a "z900" model and a "host" model with tcg_enabled() vs kvm_enabled() checks on each. Alex I would advise to not define 'artificial' names, i.e. such that cannot be retrieved via a user-space interf

Re: [Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API.

2012-12-12 Thread Paolo Bonzini
Il 12/12/2012 18:58, Peter Maydell ha scritto: > It should be equally > valid to just use the PCI transport plugged into a VirtioDevice, > both of which were created by the user with -device [and for > new transports, separate transport and backend should be the > standard]. That means the virtio-b

Re: [Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API.

2012-12-12 Thread Peter Maydell
On 12 December 2012 17:53, Andreas Färber wrote: > Am 12.12.2012 15:25, schrieb Peter Maydell: >> How will the PCI transport's PCI vendor/device/class IDs be >> set (a) when a virtio-blk backend is created and separately >> plugged into a virtio-pci transport (b) for the legacy >> virtio-pci-blk?

Re: [Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API.

2012-12-12 Thread Paolo Bonzini
Il 12/12/2012 18:53, Andreas Färber ha scritto: > Am 12.12.2012 15:25, schrieb Peter Maydell: >> How will the PCI transport's PCI vendor/device/class IDs be >> set (a) when a virtio-blk backend is created and separately >> plugged into a virtio-pci transport (b) for the legacy >> virtio-pci-blk? [i

Re: [Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API.

2012-12-12 Thread Andreas Färber
Am 12.12.2012 15:25, schrieb Peter Maydell: > How will the PCI transport's PCI vendor/device/class IDs be > set (a) when a virtio-blk backend is created and separately > plugged into a virtio-pci transport (b) for the legacy > virtio-pci-blk? [ideally the answer to (b) should be "in the > same way

Re: [Qemu-devel] [PATCH 3/3] S390: Enable -cpu help and QMP query-cpu-definitions

2012-12-12 Thread Richard Henderson
On 12/12/2012 06:03 AM, Alexander Graf wrote: > The TCG model is a "z900". We can just have a "z900" model and a > "host" model with tcg_enabled() vs kvm_enabled() checks on each. My target-s390x tcg rewrite targets something just shy of z196. The main thing that's missing is actually STORE FACIL

Re: [Qemu-devel] [PATCH v2 3/6] add backup related monitor commands

2012-12-12 Thread Eric Blake
On 11/30/2012 02:22 AM, Dietmar Maurer wrote: > We use a generic BackupDriver struct to encaplulated all archive format s/encaplulated/encapsulated/ > related function. > > Another option would be to simply dump to > the output fh (pipe), and an external binary saves the data. That way we > cou

Re: [Qemu-devel] [PATCH 3/3] S390: Enable -cpu help and QMP query-cpu-definitions

2012-12-12 Thread Viktor Mihajlovski
On 12/12/2012 02:51 PM, Andreas Färber wrote: +(*cpu_fprintf)(f, "s390 %16s\n", "[host]"); Note that the square-bracket notation was specific to x86 when it distinguished between built-in and config-based models. OK, since libvirt capable of dealing with s390 cpu models will never see thi

Re: [Qemu-devel] [RFC PATCH] Allow building without graphics support

2012-12-12 Thread Paolo Bonzini
Il 12/12/2012 18:09, Andreas Färber ha scritto: >> > Problems with cross compilation should be reported as bugs >> > so we can fix them -- we need to fix them anyway for the more >> > common case where there is host graphics support. > I already reported that the submodule does not configure on OSX

Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed

2012-12-12 Thread Paolo Bonzini
Il 12/12/2012 18:14, Michael S. Tsirkin ha scritto: > On Wed, Dec 12, 2012 at 05:51:51PM +0100, Paolo Bonzini wrote: >> Il 12/12/2012 17:37, Michael S. Tsirkin ha scritto: You wrote "the only way to know head 1 is outstanding is because backend has stored this info somewhere". But the ba

Re: [Qemu-devel] [RFC PATCH] Allow building without graphics support

2012-12-12 Thread Peter Maydell
On 12 December 2012 17:09, Andreas Färber wrote: > I already reported that the submodule does not configure on OSX/ppc > v10.5.8 - apparently due to some PKG_ macros not getting resolved. I > suspected aclocal not picking up pkg.m4 file but setting ACLOCAL_FLAGS > did not help. Do we need a more m

[Qemu-devel] [Bug 1089496] [NEW] qemu doesn't set vnc port correctly

2012-12-12 Thread Michael Mair-Keimberger
Public bug reported: Qemu Version: 1.1.1 In the past it was possible to set the port for vnc with: -vnc :1 That would mean the port would be 5901, Starting from 5900 plus the given number. However, it was also possible to set the port directly with a custom given port. Usually i set the port to

  1   2   3   4   >