What does it mean you do not have gcc that can compile repl.ph instruction?
How do you test your patches?
If you want to append the repl_ph.c, you may want to add something like this:
diff --git a/tests/tcg/mips/mips32-dsp/repl_ph.c
b/tests/tcg/mips/mips32-dsp/repl_ph.c
index 2107495..07d137d
--- a/tests/tcg/mips/mips32-dsp/repl_ph.c
+++ b/tests/tcg/mips/mips32-dsp/repl_ph.c
@@ -19,5 +19,12 @@ int main()
);
assert(rd == result);
+ result = 0xFFFFFFFF;
+ __asm
+ ("repl.ph %0, -1\n\t"
+ : "=r"(rd)
+ );
+ assert(rd == result);
+
return 0;
}
Petar
p.s. +cc Aurelien J.
________________________________
From: Dongxue Zhang [elta....@gmail.com]
Sent: Wednesday, December 12, 2012 7:43 AM
To: Andreas Färber
Cc: Markus Armbruster; Jovanovic, Petar; qemu-devel@nongnu.org; 陳韋任;
r...@twiddle.net
Subject: Re: [Qemu-devel] [PATCH 2/3]
Make-repl_ph-to-sign-extended-to-target_long
Thanks for your review, now I know this problem but don't have gcc can compile
repl_ph instruction. I will build a gcc and resend this patch later.
2012/12/12 Andreas Färber <afaer...@suse.de<mailto:afaer...@suse.de>>
Am 11.12.2012 16:13, schrieb Markus Armbruster:
> Please-separate-words-with-spaces-in-your-subject-line-thank-you-:)
Also all three patches should have a "target-mips: " prefix in the
subject to make clear what they touch and who must review and later
commit these.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
