[Qemu-devel] [PATCH 2/5] pseries: Instantiate USB if requested

2012-07-30 Thread David Gibson
The pseries machine currently ignores the -usb command line option. This patch corrects the problem by having it instantiate a PCI OHCI USB host controller when -usb is specified. Signed-off-by: David Gibson --- hw/spapr.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/spapr.c

Re: [Qemu-devel] [PATCH] configure: fix libcap detection

2012-07-30 Thread Aneesh Kumar K.V
Avi Kivity writes: > - avoid assigned-but-not-used error > - avoid missing return error > > Signed-off-by: Avi Kivity Acked-by: Aneesh Kumar K.V > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 7767aca..5fb449d 100755

Re: [Qemu-devel] 9p broken?

2012-07-30 Thread Aneesh Kumar K.V
Avi Kivity writes: > Having an annoying bug on i386 kvm I decided to debug it buy running an > i386 guest on my x86_64 host, use 9p to access a guest image, and run it > using nested kvm. > > However, 9p appears to be broken: first, the configure test fails (patch > sent). Second, while mount wo

[Qemu-devel] [PATCH] configure: Fix configure error with --enable-virtfs

2012-07-30 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" This fix the below error on ubuntu 12.04 a.c: In function ‘main’: a.c:3:24: error: variable ‘caps’ set but not used [-Werror=unused-but-set-variable] a.c:3:1: error: control reaches end of non-void function [-Werror=return-type] Signed-off-by: Aneesh Kumar K.V --- co

[Qemu-devel] [PATCH 4/5] pseries: Remove extraneous prints

2012-07-30 Thread David Gibson
The pseries machine prints several messages to stderr whenever it starts up and another whenever the vm is reset. It's not normal for qemu machines to do this though, so this patch removes them. We can put them back conditional on a DEBUG symbol if we really need them in future. Signed-off-by: D

[Qemu-devel] [PATCH 5/5] pseries: Add support for new KVM hash table control call

2012-07-30 Thread David Gibson
From: Ben Herrenschmidt This adds support for then new "reset htab" ioctl which allows qemu to properly cleanup the MMU hash table when the guest is reset. With the corresponding kernel support, reset of a guest now works properly. This also paves the way for indicating a different size hash tab

Re: [Qemu-devel] 9p broken?

2012-07-30 Thread Aneesh Kumar K.V
"Richard W.M. Jones" writes: > On Mon, Jul 30, 2012 at 03:35:39PM +0300, Avi Kivity wrote: >> Having an annoying bug on i386 kvm I decided to debug it buy running an >> i386 guest on my x86_64 host, use 9p to access a guest image, and run it >> using nested kvm. >> >> However, 9p appears to be b

[Qemu-devel] Compile errors on latest checkout

2012-07-30 Thread Gerhard Wiesinger
Hello, I'm getting the following compile errors: /root/download/qemu/git/qemu/hw/megasas.c: In function ‘megasas_class_init’: /root/download/qemu/git/qemu/hw/megasas.c:2155:14: error: assignment from incompatible pointer type [-Werror] pc->exit = megasas_scsi_uninit; With #define DEBUG_SCSI h

[Qemu-devel] [PATCH 3/5] pseries: Add support for -vga option

2012-07-30 Thread David Gibson
From: Ben Herrenschmidt Also instantiate the USB keyboard and mouse when that option is used (you can still use -device to create individual devices without all the defaults) Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David Gibson --- hw/spapr.c | 50 ++

[Qemu-devel] [0/5] Assorted pseries fixes and updates

2012-07-30 Thread David Gibson
Hi Alex, I'm now back from vacation, and have more or less got back on top of my qemu tree. Here's my first batch of new patches, an assortment of fairly simple fixes and cleanups for the pseries code. Please apply.

[Qemu-devel] buildbot failure in qemu on xen41

2012-07-30 Thread qemu
The Buildbot has detected a new failure on builder xen41 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/xen41/builds/79 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: anthony_xen Build Reason: The Nightly scheduler n

[Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit

2012-07-30 Thread Stefan Weil
Commit f90c2bcdbc69e41e575f868b984c3e2de8f51bac changed PCIUnregisterFunc, therefore the function prototype needs an update. megasas.o is currently not linked, so this bug was not detected by the buildbots. Signed-off-by: Stefan Weil --- hw/megasas.c |3 +-- 1 file changed, 1 insertion(+),

[Qemu-devel] [RFC PATCH 3/4] qerror: new errors for live block commit, QERR_TOP_NOT_FOUND

2012-07-30 Thread Jeff Cody
Signed-off-by: Jeff Cody --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+) diff --git a/qerror.c b/qerror.c index 25c2733..69a59ab 100644 --- a/qerror.c +++ b/qerror.c @@ -307,6 +307,10 @@ static const QErrorStringTable qerror_table[] = { .desc = "Too

[Qemu-devel] [RFC PATCH 2/4] block: add live block commit functionality

2012-07-30 Thread Jeff Cody
This adds the live commit coroutine. This iteration focuses on the commit only below the active layer, and not the active layer itself. The behaviour is similar to block streaming; the sectors are walked through, and anything that exists above 'base' is committed back down into base. At the end,

[Qemu-devel] [RFC PATCH 4/4] QAPI: add command for live block commit, 'block-commit'

2012-07-30 Thread Jeff Cody
The command for live block commit is added, which has the following arguments: device: the block device to perform the commit on (mandatory) base: the base image to commit into; optional (if not specified, it is the underlying original image) top:the top image of the commit - all dat

[Qemu-devel] [RFC PATCH 1/4] block: add support functions for live commit, to find and delete images.

2012-07-30 Thread Jeff Cody
Add bdrv_find_image(), bdrv_find_base(), and bdrv_delete_intermediate(). bdrv_find_image(): given a filename and a BDS, find the image in the chain that matches the passed filename. bdrv_find_base(): given a BDS, find the base image (parent-most image) bdrv_delete_intermed

[Qemu-devel] [RFC PATCH 0/4] Live block commit

2012-07-30 Thread Jeff Cody
These are proposed changes, to add live block commit functionality. I originally had intended for this RFC series to include the more complicated case of a live commit of the active layer, but removed it for this commit in the hopes of making it into the soft feature freeze for 1.2, so this series

[Qemu-devel] buildbot failure in qemu on xen_unstable

2012-07-30 Thread qemu
The Buildbot has detected a new failure on builder xen_unstable while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/xen_unstable/builds/79 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: anthony_xen Build Reason: The Nigh

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-07-30 Thread Benjamin Herrenschmidt
On Mon, 2012-07-30 at 19:17 -0500, Anthony Liguori wrote: > This is a detail of how Spice/QXL works. It is not a framebuffer > protocol. > > Spice sends a series of rendering commands. It not rendering to a flat > framebuffer but rather to window-like objects. It maintains a list of > these co

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-07-30 Thread Benjamin Herrenschmidt
On Tue, 2012-07-31 at 09:17 +0930, Rusty Russell wrote: > > Shared memory is an efficiency thing, not a requirement. If the > virtio > side-channel tells the device about the location of framebuffer > changes, it could still be quite efficient. But potentially tricky to get things like BIOSes wo

Re: [Qemu-devel] [GIT PULL (PATCH 0/4)] VFIO driver for v3.6

2012-07-30 Thread Alex Williamson
On Fri, 2012-07-27 at 15:32 +1000, Paul Mackerras wrote: > On Wed, Jul 25, 2012 at 08:53:06AM -0600, Alex Williamson wrote: > > Hi Linus, > > > > This series includes the VFIO userspace driver interface for the > > 3.6 kernel merge window. This driver is intended to provide a > > secure interface

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-07-30 Thread Rusty Russell
On Mon, 30 Jul 2012 11:01:20 -0500, Anthony Liguori wrote: > Avi Kivity writes: > > It doesn't seem to be such a huge problem, though it does turn virtio > > into a respec'ed PCI. > > Virtio was originally designed to be a DMA API (although not ABI). From > a virtio-pci perspective, adding a l

Re: [Qemu-devel] [PATCH v2 00/16] net: Move legacy QEMU VLAN code into net/hub.c

2012-07-30 Thread Zhi Yong Wu
On Mon, Jul 30, 2012 at 11:49 PM, Stefan Hajnoczi wrote: > On Tue, Jul 24, 2012 at 4:35 PM, Stefan Hajnoczi > wrote: >> [These patches are based on the net tree at git://github.com/stefanha/net] >> >> The QEMU net subsystem has the concept of separate network segments, called >> "VLANs". Each VL

[Qemu-devel] [PATCH] ATAPI: Add support for ASCQ in sense codes

2012-07-30 Thread Ronnie Sahlberg
Add support for setting the ASCQ for SCSI sense codes in the ATAPI driver. Use this to set ASCQ==2 for the medium removal prevention that is recommended in MMC for this condition. asc:0x53 ascq:0x02 is the recommended error for MEDIUM_REMOVAL_PREVENTED and is listed in Annex F in MMC Signed-off

[Qemu-devel] [PATCH] ATAPI: Add support for ASCQ and improve a medium removal sense code

2012-07-30 Thread Ronnie Sahlberg
Kevin, Paolo, List Please find a patch that adds support for setting the ASCQ in sense data for the ATAPI driver. This mechanism is then used to generate the correct MEDIUM_REMOVAL_PREVENTED error when a disk can not be ejected. regards ronnie sahlberg

[Qemu-devel] [PATCH] ATAPI: STARTSTOPUNIT only eject/load media if powercondition is 0

2012-07-30 Thread Ronnie Sahlberg
The START STOP UNIT command will only eject/load media if power condition is zero. If power condition is !0 then LOEJ and START will be ignored. >From MMC (sbc contains similar wordings too) The Power Conditions field requests the block device to be placed in the power condition defined in

[Qemu-devel] [PATCH] ATAPI: STARTSTOPUNIT only eject/load when pwrcnd is 0

2012-07-30 Thread Ronnie Sahlberg
Kevin, Paolo, List Please find a trivial patch for ATAPI. It adds a similar check to STARTSTOPUNIT for powercondition as was recently added to the SCSI emulation. regards ronnie sahlberg

[Qemu-devel] [GIT PULL] tcm_vhost: Initial merge of vhost level target fabric driver

2012-07-30 Thread Nicholas A. Bellinger
Hi Linus, Here is the PULL request for the initial merge of tcm_vhost based on RFC-v5 code with MST's ACK appended to the initial merge commit. As promised, the commit is available from two different branches for you to consider merging as for-3.6 code. The 'for-next-merge' branch based on mainli

Re: [Qemu-devel] [RFC PATCH 0/6] virtio-trace: Support virtio-trace

2012-07-30 Thread Yoshihiro YUNOMAE
Hi Amit, Sorry for the late reply. (2012/07/27 18:43), Amit Shah wrote: On (Fri) 27 Jul 2012 [17:55:11], Yoshihiro YUNOMAE wrote: Hi Amit, Thank you for commenting on our work. (2012/07/26 20:35), Amit Shah wrote: On (Tue) 24 Jul 2012 [11:36:57], Yoshihiro YUNOMAE wrote: [...] ***Jus

Re: [Qemu-devel] [PATCH] hw/armv7m_nvic: Fix incorrect default for num-irqs property

2012-07-30 Thread Peter Crosthwaite
Thanks Peter, All good now. Regards, Peter On Tue, Jul 24, 2012 at 8:39 PM, Peter Maydell wrote: > Fix an incorrect default value for the num-irqs property (we were > attempting to override it from the default set by the parent class > but not succeeding, which meant that the lm3s6965evb model

Re: [Qemu-devel] [PATCHv2] qemu: add .exrc

2012-07-30 Thread Michael S. Tsirkin
On Mon, Jul 30, 2012 at 03:03:56PM +, Blue Swirl wrote: > On Sun, Jul 29, 2012 at 2:08 PM, Michael S. Tsirkin wrote: > > On Thu, Jul 19, 2012 at 05:48:32PM +0300, Michael S. Tsirkin wrote: > >> I've been using this to get correct indenting with vim > >> in qemu for a while, but it's a bit easi

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-07-30 Thread Anthony Liguori
Benjamin Herrenschmidt writes: > On Mon, 2012-07-30 at 16:55 +0300, Avi Kivity wrote: >> > The trouble is predicting which guests have drivers and which guests >> > don't. Having a VGA model that could be enabled universally with good >> > VBE support for guests without drivers would be a very n

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO PCI driver for Qemu

2012-07-30 Thread Alex Williamson
On Sun, 2012-07-29 at 16:47 +0300, Avi Kivity wrote: > On 07/26/2012 08:40 PM, Alex Williamson wrote: > > On Thu, 2012-07-26 at 19:34 +0300, Avi Kivity wrote: > >> On 07/25/2012 08:03 PM, Alex Williamson wrote: > >> > >> > +/* > >> > + * Resource setup > >> > + */ > >> > +static void vfio_unmap_ba

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-07-30 Thread Benjamin Herrenschmidt
On Mon, 2012-07-30 at 18:24 +0200, Alon Levy wrote: > On Mon, Jul 30, 2012 at 10:08:07PM +1000, Benjamin Herrenschmidt wrote: > > On Mon, 2012-07-30 at 14:58 +0300, Avi Kivity wrote: > > > Let's balkanize some more then? > > > > > > No, qxl is our paravirt vga, we should improve it instead of spaw

Re: [Qemu-devel] [RFC PATCH 4/6] ftrace: Allow stealing pages from pipe buffer

2012-07-30 Thread Steven Rostedt
On Tue, 2012-07-24 at 11:37 +0900, Yoshihiro YUNOMAE wrote: > From: Masami Hiramatsu > > Use generic steal operation on pipe buffer to allow stealing > ring buffer's read page from pipe buffer. > > Note that this could reduce the performance of splice on the > splice_write side operation without

[Qemu-devel] [PATCH] tcm_vhost: Post-merge review changes requested by MST

2012-07-30 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch contains the post RFC-v5 (post-merge) changes, this includes: - Add locking comment - Move vhost_scsi_complete_cmd ahead of TFO callbacks in order to drop forward declarations - Drop extra '!= NULL' usage in vhost_scsi_complete_cmd_work() - Change vhost_scsi

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-07-30 Thread Benjamin Herrenschmidt
On Mon, 2012-07-30 at 16:55 +0300, Avi Kivity wrote: > > The trouble is predicting which guests have drivers and which guests > > don't. Having a VGA model that could be enabled universally with good > > VBE support for guests without drivers would be a very nice default > > model. > > I agree.

Re: [Qemu-devel] [PATCH 00/11] Migration next v7

2012-07-30 Thread Juan Quintela
Luiz Capitulino wrote: > On Sun, 29 Jul 2012 12:42:52 +0300 > Orit Wasserman wrote: > >> Those are the latest XBZRLE patches (part of the migration next branch). > > I've concentrated my review on the QMP part, which looks good in general, but > has some details to be fixed. > > I'd like to give

Re: [Qemu-devel] [PATCH] configure: fix libcap detection

2012-07-30 Thread Richard W.M. Jones
On Mon, Jul 30, 2012 at 02:41:33PM +0300, Avi Kivity wrote: > - avoid assigned-but-not-used error > - avoid missing return error > > Signed-off-by: Avi Kivity > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 7767aca..5fb4

Re: [Qemu-devel] 9p broken?

2012-07-30 Thread Richard W.M. Jones
On Mon, Jul 30, 2012 at 03:35:39PM +0300, Avi Kivity wrote: > Having an annoying bug on i386 kvm I decided to debug it buy running an > i386 guest on my x86_64 host, use 9p to access a guest image, and run it > using nested kvm. > > However, 9p appears to be broken: first, the configure test fails

Re: [Qemu-devel] [PATCH] Use siginfo_t instead of struct siginfo.

2012-07-30 Thread Alexander Graf
On 30.07.2012, at 23:38, Peter Maydell wrote: > On 30 July 2012 22:33, Andreas Färber wrote: >> Am 30.07.2012 23:30, schrieb Alexander Graf: >>> On 30.07.2012, at 09:21, Andreas Jaeger wrote: glibc 2.16 does not export the undocumented struct siginfo anymore. qemu uses already in most

[Qemu-devel] [v2 Patch 7/9]block: qed image file reopen

2012-07-30 Thread Supriya Kannery
qed driver changes for bdrv_reopen_xx functions to safely reopen image files. Reopening of image files while changing hostcache dynamically is handled here. Signed-off-by: Supriya Kannery --- Index: qemu/block/qed.c === --- qemu.ori

Re: [Qemu-devel] [PATCH] Use siginfo_t instead of struct siginfo.

2012-07-30 Thread Peter Maydell
On 30 July 2012 22:33, Andreas Färber wrote: > Am 30.07.2012 23:30, schrieb Alexander Graf: >> On 30.07.2012, at 09:21, Andreas Jaeger wrote: >>> glibc 2.16 does not export the undocumented struct siginfo anymore. >>> qemu uses already in most cases siginfo_t, this patch fixes the last >>> three o

[Qemu-devel] [v2 Patch 9/9]block: Enhance "info block" to display host cache setting

2012-07-30 Thread Supriya Kannery
Enhance "info block" to display hostcache setting for each block device. Example: (qemu) info block ide0-hd0: removable=0 file=../rhel6-32.raw ro=0 drv=raw encrypted=0 Enhanced to display "hostcache" setting: (qemu) info block ide0-hd0: removable=0 hostcache=1 file=../rhel6-32.raw ro=0 drv=raw en

[Qemu-devel] [v2 Patch 0/9]block: Image file reopen and dynamic host pagecache change

2012-07-30 Thread Supriya Kannery
For changing host pagecache setting of a running VM, it is important to have a safe way of reopening its image file. V1 introduced: * a generic way to reopen image files safely. In this approach, before reopening an image, for each block driver, its state will be stashed. Incase pre

[Qemu-devel] [v2 Patch 5/9]block: qcow2 image file reopen

2012-07-30 Thread Supriya Kannery
qcow2 driver changes for bdrv_reopen_xx functions to safely reopen image files. Reopening of image files while changing hostcache dynamically is handled here. Signed-off-by: Supriya Kannery --- Index: qemu/block/qcow2.c === --- qemu

[Qemu-devel] [v2 Patch 2/9]block: raw-posix image file reopen

2012-07-30 Thread Supriya Kannery
raw-posix driver changes for bdrv_reopen_xx functions to safely reopen image files. Reopening of image files while changing hostcache dynamically is handled here. Signed-off-by: Supriya Kannery --- Index: qemu/block/raw.c === --- q

[Qemu-devel] [v2 Patch 3/9]block: raw-win32 image file reopen

2012-07-30 Thread Supriya Kannery
raw-win32 driver changes for bdrv_reopen_xx functions to safely reopen image files. Reopening of image files while changing hostcache dynamically is handled here. Signed-off-by: Supriya Kannery Signed-off-by: Shrinidhi Joshi --- Index: qemu/block/raw-win32.c

[Qemu-devel] [v2 Patch 4/9]block: vmdk image file reopen

2012-07-30 Thread Supriya Kannery
vmdk driver changes for bdrv_reopen_xx functions to safely reopen image files. Reopening of image files while changing hostcache dynamically is handled here. Signed-off-by: Supriya Kannery --- Index: qemu/block/vmdk.c === --- qemu.o

[Qemu-devel] [v2 Patch 1/9]block: Framework for reopening image files safely

2012-07-30 Thread Supriya Kannery
Struct BDRVReopenState along with three reopen related functions introduced for handling reopening of images safely. This can be extended by each of the block drivers to reopen respective image files. Signed-off-by: Supriya Kannery --- Index: qemu/block.c

Re: [Qemu-devel] [PATCH] Use siginfo_t instead of struct siginfo.

2012-07-30 Thread Andreas Färber
Am 30.07.2012 23:30, schrieb Alexander Graf: > > On 30.07.2012, at 09:21, Andreas Jaeger wrote: > >> >> glibc 2.16 does not export the undocumented struct siginfo anymore. >> qemu uses already in most cases siginfo_t, this patch fixes the last >> three occurences. >> >> Signed-off-by: Andreas Jae

Re: [Qemu-devel] [PATCH] Use siginfo_t instead of struct siginfo.

2012-07-30 Thread Alexander Graf
On 30.07.2012, at 09:21, Andreas Jaeger wrote: > > glibc 2.16 does not export the undocumented struct siginfo anymore. > qemu uses already in most cases siginfo_t, this patch fixes the last > three occurences. > > Signed-off-by: Andreas Jaeger That email address doesn't look valid :). So I t

[Qemu-devel] [Bug 897750] Re: libvirt/kvm problem with disk attach/detach/reattach on running virt

2012-07-30 Thread Stefan Bader
I am quite confused. Looking at my Precise system, pci-hotplug is built- in, and the configs for Oneiric and Quantal are the same. Could you tell me the exact kernel version for which you see this as a module? -- You received this bug notification because you are a member of qemu- devel-ml, which

[Qemu-devel] [PATCH] Use siginfo_t instead of struct siginfo.

2012-07-30 Thread Andreas Jaeger
glibc 2.16 does not export the undocumented struct siginfo anymore. qemu uses already in most cases siginfo_t, this patch fixes the last three occurences. Signed-off-by: Andreas Jaeger --- linux-user/signal.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/linux-use

[Qemu-devel] [Bug 1030807] Re: PCI host bridge should ignore 1- and 2-byte I/O accesses

2012-07-30 Thread Henning Schild
I tried the following quick fix but the BIOS does not seem to like that. ** Attachment added: "pci" https://bugs.launchpad.net/qemu/+bug/1030807/+attachment/3242137/+files/pci -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https

[Qemu-devel] [Bug 1030807] [NEW] PCI host bridge should ignore 1- and 2-byte I/O accesses

2012-07-30 Thread Henning Schild
Public bug reported: In PCI there are two IO modes. Deprecated Mode2 that uses single byte IO and Mode1 that uses 4byte IO. According to the spec a host bridge that supports Mode1 should ignore all IO that is not 4bytes. > Anytime a host bridge sees a full DWORD I/O write from the host to > CON

[Qemu-devel] [Bug 966316] Re: Can't load Android VBOX image or even linux test image as well

2012-07-30 Thread Joel Jensen
I'm getting this same error with qemu v1.1.1 on a RAW formatted disk image of windows XP that used to work. > qemu -m 1024 -hda xp.img -localtime -net user qemu: PC system firmware (pflash) must be a multiple of 0x1000 I've no idea what this error could mean =) -- You received this bug notifica

Re: [Qemu-devel] [PATCH 00/11] Migration next v7

2012-07-30 Thread Orit Wasserman
On 07/30/2012 10:38 PM, Luiz Capitulino wrote: > On Sun, 29 Jul 2012 12:42:52 +0300 > Orit Wasserman wrote: > >> Those are the latest XBZRLE patches (part of the migration next branch). > > I've concentrated my review on the QMP part, which looks good in general, but > has some details to be fix

Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migrate-parameters

2012-07-30 Thread Juan Quintela
Juan Quintela wrote: > Orit Wasserman wrote: >> The management can enable/disable a capability for the next migration by >> using >> migrate_set_parameter command. >> The management can query the current migration capabilities using >> query-migrate-parameters >> >> Signed-off-by: Orit Wasserman

Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migrate-parameters

2012-07-30 Thread Luiz Capitulino
On Mon, 30 Jul 2012 15:04:57 -0500 Anthony Liguori wrote: > Luiz Capitulino writes: > > > On Mon, 30 Jul 2012 14:45:04 -0500 > > Anthony Liguori wrote: > > > >> Orit Wasserman writes: > >> > >> > The management can enable/disable a capability for the next migration by > >> > using > >> > mi

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-07-30 Thread Anthony Liguori
Alon Levy writes: > On Mon, Jul 30, 2012 at 10:08:07PM +1000, Benjamin Herrenschmidt wrote: >> On Mon, 2012-07-30 at 14:58 +0300, Avi Kivity wrote: >> > Let's balkanize some more then? >> > >> > No, qxl is our paravirt vga, we should improve it instead of spawning >> > new ones (which will be ho

Re: [Qemu-devel] [PATCH 09/11] Add migration accounting for normal and duplicate pages

2012-07-30 Thread Luiz Capitulino
On Sun, 29 Jul 2012 12:43:01 +0300 Orit Wasserman wrote: > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > Signed-off-by: Juan Quintela > --- > arch_init.c | 38 ++ > migr

Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migrate-parameters

2012-07-30 Thread Anthony Liguori
Luiz Capitulino writes: > On Mon, 30 Jul 2012 14:45:04 -0500 > Anthony Liguori wrote: > >> Orit Wasserman writes: >> >> > The management can enable/disable a capability for the next migration by >> > using >> > migrate_set_parameter command. >> > The management can query the current migration

Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migrate-parameters

2012-07-30 Thread Luiz Capitulino
On Mon, 30 Jul 2012 14:45:04 -0500 Anthony Liguori wrote: > Orit Wasserman writes: > > > The management can enable/disable a capability for the next migration by > > using > > migrate_set_parameter command. > > The management can query the current migration capabilities using > > query-migrate

Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migrate-parameters

2012-07-30 Thread Anthony Liguori
Orit Wasserman writes: > The management can enable/disable a capability for the next migration by using > migrate_set_parameter command. > The management can query the current migration capabilities using > query-migrate-parameters > > Signed-off-by: Orit Wasserman > Signed-off-by: Juan Quintela

Re: [Qemu-devel] [PATCH 00/11] Migration next v7

2012-07-30 Thread Luiz Capitulino
On Sun, 29 Jul 2012 12:42:52 +0300 Orit Wasserman wrote: > Those are the latest XBZRLE patches (part of the migration next branch). I've concentrated my review on the QMP part, which looks good in general, but has some details to be fixed. I'd like to give this a try btw, but it doesn't apply o

Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migrate-parameters

2012-07-30 Thread Anthony Liguori
Juan Quintela writes: > Orit Wasserman wrote: >> The management can enable/disable a capability for the next migration by >> using >> migrate_set_parameter command. >> The management can query the current migration capabilities using >> query-migrate-parameters >> >> Signed-off-by: Orit Wasserm

Re: [Qemu-devel] [PATCH 10/11] Add XBZRLE statistics

2012-07-30 Thread Luiz Capitulino
On Sun, 29 Jul 2012 12:43:02 +0300 Orit Wasserman wrote: > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > Signed-off-by: Juan Quintela > --- > arch_init.c | 28 > hmp.c

Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migrate-parameters

2012-07-30 Thread Eric Blake
On 07/30/2012 01:12 PM, Juan Quintela wrote: > Orit Wasserman wrote: >> The management can enable/disable a capability for the next migration by >> using >> migrate_set_parameter command. >> The management can query the current migration capabilities using >> query-migrate-parameters >> >> Signed

Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migrate-parameters

2012-07-30 Thread Juan Quintela
Orit Wasserman wrote: > The management can enable/disable a capability for the next migration by using > migrate_set_parameter command. > The management can query the current migration capabilities using > query-migrate-parameters > > Signed-off-by: Orit Wasserman > Signed-off-by: Juan Quintela

[Qemu-devel] [PATCH] kvm: Check if smp_cpus exceeds max cpus supported by kvm

2012-07-30 Thread riegamaths
From: Dunrong Huang Add a helper function for fetching max cpus supported by kvm. Make QEMU exit with an error message if smp_cpus exceeds limit of VCPU count retrieved by invoking this helper function. Signed-off-by: Dunrong Huang --- kvm-all.c | 25 + 1 files chang

Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migrate-parameters

2012-07-30 Thread Luiz Capitulino
On Mon, 30 Jul 2012 12:11:52 -0600 Eric Blake wrote: > On 07/29/2012 03:42 AM, Orit Wasserman wrote: > > The management can enable/disable a capability for the next migration by > > using > > migrate_set_parameter command. > > The management can query the current migration capabilities using > >

Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migrate-parameters

2012-07-30 Thread Eric Blake
On 07/29/2012 03:42 AM, Orit Wasserman wrote: > The management can enable/disable a capability for the next migration by using > migrate_set_parameter command. > The management can query the current migration capabilities using > query-migrate-parameters In addition to Luiz' nitpicks: Here in the

Re: [Qemu-devel] [PATCH 2/5] sparc: fix expression with uninitialized initial value

2012-07-30 Thread Peter Maydell
On 30 July 2012 18:20, Blue Swirl wrote: > On Mon, Jul 30, 2012 at 5:09 PM, Peter Maydell > wrote: >> Not really, things would still need changing later. Really the >> problem is that most of the function is #if 0'd out (and never >> called from anywhere); it's just unused stub code so anything

Re: [Qemu-devel] [PATCH 01/11] Add migration capabilities

2012-07-30 Thread Eric Blake
On 07/29/2012 03:42 AM, Orit Wasserman wrote: > Add migration capabilities that can be queried by the management. > The management can query the source QEMU and the destination QEMU in order to > verify both support some migration capability (currently only XBZRLE). > > Signed-off-by: Orit Wasserm

Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migrate-parameters

2012-07-30 Thread Luiz Capitulino
On Sun, 29 Jul 2012 12:42:54 +0300 Orit Wasserman wrote: > The management can enable/disable a capability for the next migration by using > migrate_set_parameter command. > The management can query the current migration capabilities using > query-migrate-parameters In general looks good to me, I

Re: [Qemu-devel] [PATCH 01/18] smbios: Add a function to directly add an entry

2012-07-30 Thread Corey Minyard
On 07/30/2012 12:25 PM, Anthony Liguori wrote: Corey Minyard writes: On 07/30/2012 10:37 AM, Anthony Liguori wrote: miny...@acm.org writes: From: Corey Minyard There was no way to directly add a table entry to the SMBIOS table, even though the BIOS supports this. So add a function to do

Re: [Qemu-devel] [PATCH 01/11] Add migration capabilities

2012-07-30 Thread Luiz Capitulino
On Mon, 30 Jul 2012 14:24:18 -0300 Luiz Capitulino wrote: > On Sun, 29 Jul 2012 12:42:53 +0300 > Orit Wasserman wrote: > > > Add migration capabilities that can be queried by the management. > > The management can query the source QEMU and the destination QEMU in order > > to > > verify both s

Re: [Qemu-devel] [PATCH 01/11] Add migration capabilities

2012-07-30 Thread Luiz Capitulino
On Sun, 29 Jul 2012 12:42:53 +0300 Orit Wasserman wrote: > Add migration capabilities that can be queried by the management. > The management can query the source QEMU and the destination QEMU in order to > verify both support some migration capability (currently only XBZRLE). > > Signed-off-by:

Re: [Qemu-devel] [PATCH 01/18] smbios: Add a function to directly add an entry

2012-07-30 Thread Anthony Liguori
Corey Minyard writes: > On 07/30/2012 10:37 AM, Anthony Liguori wrote: >> miny...@acm.org writes: >> >>> From: Corey Minyard >>> >>> There was no way to directly add a table entry to the SMBIOS table, >>> even though the BIOS supports this. So add a function to do this. >>> This is in preparati

Re: [Qemu-devel] [PATCH 5/5] configure: disable a few Clang compiler warnings

2012-07-30 Thread Blue Swirl
On Mon, Jul 30, 2012 at 4:56 PM, Stefan Weil wrote: > Am 30.07.2012 18:04, schrieb blauwir...@gmail.com: > >> From: Blue Swirl >> >> Clang compiler warns about a few constructs in QEMU code. It's possible >> to avoid those but that needs more work. >> >> Suppress some warnings for Clang compiler.

Re: [Qemu-devel] [PATCH 2/5] sparc: fix expression with uninitialized initial value

2012-07-30 Thread Blue Swirl
On Mon, Jul 30, 2012 at 5:09 PM, Peter Maydell wrote: > On 30 July 2012 17:59, Andreas Färber wrote: >> Am 30.07.2012 18:13, schrieb Peter Maydell: >>> This will need changing again if we ever fix the #if 0-d out >>> code in this function, but I guess that will be obvious to whoever >>> does that

Re: [Qemu-devel] [PATCH 2/5] sparc: fix expression with uninitialized initial value

2012-07-30 Thread Peter Maydell
On 30 July 2012 17:59, Andreas Färber wrote: > Am 30.07.2012 18:13, schrieb Peter Maydell: >> This will need changing again if we ever fix the #if 0-d out >> code in this function, but I guess that will be obvious to whoever >> does that. > > You mean the #endif part? Would an explicit err = 0 mak

Re: [Qemu-devel] [PATCH 12/18] IPMI: Add a PC ISA type structure

2012-07-30 Thread Corey Minyard
On 07/30/2012 08:45 AM, Andreas Färber wrote: Am 19.07.2012 20:53, schrieb miny...@acm.org: From: Corey Minyard + +static Property ipmi_isa_properties[] = { +DEFINE_PROP_STRING("interface", ISAIPMIDevice, interface), +DEFINE_PROP_HEX32("iobase", ISAIPMIDevice, iobase, 0), +DEFINE

Re: [Qemu-devel] [PATCH V5 2/4] block: Use bdrv_get_backing_file_depth()

2012-07-30 Thread Luiz Capitulino
On Mon, 30 Jul 2012 10:48:49 -0600 Eric Blake wrote: > On 07/30/2012 10:32 AM, Luiz Capitulino wrote: > > On Thu, 26 Jul 2012 15:18:19 +0200 > > benoit.ca...@gmail.com wrote: > > > >> From: Benoît Canet > >> > >> Use the dedicated counting function in qmp_query_block in order to > >> propagate

Re: [Qemu-devel] [PATCH 2/5] sparc: fix expression with uninitialized initial value

2012-07-30 Thread Andreas Färber
Am 30.07.2012 18:13, schrieb Peter Maydell: > On 30 July 2012 17:04, wrote: >> From: Blue Swirl >> >> err was uninitalized, it's not OK to use |=. Spotted by Clang > > "uninitialized" (feel free to just fix typo on commit). > >> compiler. >> >> Fix by replacing |= by =. >> >> Signed-off-by: Bl

Re: [Qemu-devel] [PATCH 5/5] configure: disable a few Clang compiler warnings

2012-07-30 Thread Stefan Weil
Am 30.07.2012 18:04, schrieb blauwir...@gmail.com: From: Blue Swirl Clang compiler warns about a few constructs in QEMU code. It's possible to avoid those but that needs more work. Suppress some warnings for Clang compiler. -Wno-unused-value would conflict with GCC. Signed-off-by: Blue Swirl

Re: [Qemu-devel] [PATCH v2] vl.c: Fix max_cpus

2012-07-30 Thread Dunrong Huang
2012/7/31 Stefan Hajnoczi : > On Wed, Jul 25, 2012 at 12:11 PM, wrote: >> From: Dunrong Huang >> >> The VCPU count limit in kernel now is 254, defined by KVM_MAX_VCPUS >> in kernel's header files. But the count limit in QEMU is 255, >> so QEMU will failed to start if user passes "-enable-kvm" an

Re: [Qemu-devel] [PATCH V5 2/4] block: Use bdrv_get_backing_file_depth()

2012-07-30 Thread Eric Blake
On 07/30/2012 10:32 AM, Luiz Capitulino wrote: > On Thu, 26 Jul 2012 15:18:19 +0200 > benoit.ca...@gmail.com wrote: > >> From: Benoît Canet >> >> Use the dedicated counting function in qmp_query_block in order to >> propagate the backing file depth to HMP. >> >> Signed-off-by: Benoit Canet >> +

Re: [Qemu-devel] [PATCH] Makefile: Remove generated hw/usb files in 'clean' target

2012-07-30 Thread Peter Maydell
On 30 July 2012 17:42, Stefan Hajnoczi wrote: > On Sun, Jul 29, 2012 at 03:48:49PM +0200, Stefan Weil wrote: >> Commit f1ae32a1ecda8aaff7a355c9030c0d8c363f3a70 moved the >> usb directory to hw, so the files which should be removed >> are now hw/usb/*.{d,o}. >> >> The new code removes these files a

Re: [Qemu-devel] [PATCH 01/18] smbios: Add a function to directly add an entry

2012-07-30 Thread Corey Minyard
On 07/30/2012 10:37 AM, Anthony Liguori wrote: miny...@acm.org writes: From: Corey Minyard There was no way to directly add a table entry to the SMBIOS table, even though the BIOS supports this. So add a function to do this. This is in preparation for the IPMI handler adding it's SMBIOS tabl

Re: [Qemu-devel] [PATCH v2] vl.c: Fix max_cpus

2012-07-30 Thread Stefan Hajnoczi
On Wed, Jul 25, 2012 at 12:11 PM, wrote: > From: Dunrong Huang > > The VCPU count limit in kernel now is 254, defined by KVM_MAX_VCPUS > in kernel's header files. But the count limit in QEMU is 255, > so QEMU will failed to start if user passes "-enable-kvm" and "-smp 255" > to it. > > Exit QEMU

Re: [Qemu-devel] [PATCH] Makefile: Remove generated hw/usb files in 'clean' target

2012-07-30 Thread Stefan Hajnoczi
On Sun, Jul 29, 2012 at 03:48:49PM +0200, Stefan Weil wrote: > Commit f1ae32a1ecda8aaff7a355c9030c0d8c363f3a70 moved the > usb directory to hw, so the files which should be removed > are now hw/usb/*.{d,o}. > > The new code removes these files and also any other generated > *.o and *.d files in di

[Qemu-devel] [PATCH 1/5] sparc: fix floppy TC line setup

2012-07-30 Thread blauwirbel
From: Blue Swirl The qemu_irq for Terminal Count (TC) line between FDC and Slavio misc device was created only after use, spotted by Clang compiler. Also, it was not created if the FDC didn't exist. Rearrange code to fix order. Always create the TC line. Signed-off-by: Blue Swirl --- hw/sun4m

[Qemu-devel] Adding a parameter to a helper

2012-07-30 Thread Jose Cano Reyes
Hi all, I am trying to add a new integer parameter to an existing helper and call this helper in "targeti386/translate.c". I have several problems: 1) I cannot add an integer parameter to the helper, the compiler says that it must be "TCGv_i32", despite I declare this new parameter as "int"

Re: [Qemu-devel] [PATCH v2] vl.c: Fix max_cpus

2012-07-30 Thread Peter Maydell
On 25 July 2012 12:11, wrote: > From: Dunrong Huang > > The VCPU count limit in kernel now is 254, defined by KVM_MAX_VCPUS > in kernel's header files. But the count limit in QEMU is 255, > so QEMU will failed to start if user passes "-enable-kvm" and "-smp 255" > to it. > > Exit QEMU with an er

[Qemu-devel] [PATCH 5/5] configure: disable a few Clang compiler warnings

2012-07-30 Thread blauwirbel
From: Blue Swirl Clang compiler warns about a few constructs in QEMU code. It's possible to avoid those but that needs more work. Suppress some warnings for Clang compiler. -Wno-unused-value would conflict with GCC. Signed-off-by: Blue Swirl --- configure |5 - 1 files changed, 4 inse

[Qemu-devel] [PATCH 2/5] sparc: fix expression with uninitialized initial value

2012-07-30 Thread blauwirbel
From: Blue Swirl err was uninitalized, it's not OK to use |=. Spotted by Clang compiler. Fix by replacing |= by =. Signed-off-by: Blue Swirl --- linux-user/signal.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 97f30d

Re: [Qemu-devel] QEMU hacking session/day at KVM Forum 2012?

2012-07-30 Thread Chris Wright
* Anthony Liguori (aligu...@us.ibm.com) wrote: > Peter Maydell writes: > > Last year at KVM Forum, in addition to the scheduled talks we also > > had an informal hacking session on one of the following days, since > > we were colocated with LinuxCon NA and most people were still around > > afterwa

Re: [Qemu-devel] [PATCH V5 2/4] block: Use bdrv_get_backing_file_depth()

2012-07-30 Thread Luiz Capitulino
On Thu, 26 Jul 2012 15:18:19 +0200 benoit.ca...@gmail.com wrote: > From: Benoît Canet > > Use the dedicated counting function in qmp_query_block in order to > propagate the backing file depth to HMP. > > Signed-off-by: Benoit Canet > --- > block.c |3 +++ > qapi-schema.json |

  1   2   >