On 07/30/2012 08:45 AM, Andreas Färber wrote:
Am 19.07.2012 20:53, schrieb miny...@acm.org:
From: Corey Minyard <cminy...@mvista.com>
+
+static Property ipmi_isa_properties[] = {
+ DEFINE_PROP_STRING("interface", ISAIPMIDevice, interface),
+ DEFINE_PROP_HEX32("iobase", ISAIPMIDevice, iobase, 0),
+ DEFINE_PROP_UINT32("irq", ISAIPMIDevice, isairq, 5),
+ DEFINE_PROP_UINT8("slave_addr", ISAIPMIDevice, slave_addr, 0),
+ DEFINE_PROP_CHR("chardev", ISAIPMIDevice, chr),
+ DEFINE_PROP_END_OF_LIST(),
+};
+
+#if 0 /* FIXME */
Fix this? x86 machines should definitely remain migratable.
Yeah, I need to fix that so it works. I'll definitely get that in
before the next iteration.
+static const VMStateDescription vmstate_isa_ipmi = {
+ .name = "isa-ipmi",
+ .version_id = 3,
+ .minimum_version_id = 3,
+ .fields = (VMStateField[]) {
+ /* FIXME - fill this in */
+ VMSTATE_END_OF_LIST()
+ }
+};
+#endif
+
+static void ipmi_isa_class_initfn(ObjectClass *klass, void *data)
+{
+ DeviceClass *dc = DEVICE_CLASS(klass);
+ ISADeviceClass *ic = ISA_DEVICE_CLASS(klass);
+ ic->init = ipmi_isa_initfn;
+ dc->reset = ipmi_isa_reset;
+ /* dc->vmsd = &vmstate_isa_ipmi; FIXME */
+ dc->props = ipmi_isa_properties;
+}
+
+static TypeInfo ipmi_isa_info = {
static const please.
+ .name = "isa-ipmi",
Where is this used? Should probably be TYPE_..., too.
That's what the user specified on the -device line. Does it need to be
referenced someplace else?
Thanks,
-corey