Juan Quintela <quint...@redhat.com> writes: > Orit Wasserman <owass...@redhat.com> wrote: >> The management can enable/disable a capability for the next migration by >> using >> migrate_set_parameter command. >> The management can query the current migration capabilities using >> query-migrate-parameters >> >> Signed-off-by: Orit Wasserman <owass...@redhat.com> >> Signed-off-by: Juan Quintela <quint...@redhat.com> > > I just noticed .... shouldn't we use > > migrate_set_parameter cache_size 256M > ??? > > I think that even the old migration parameters could be added to this > one? > > migrate_set_parameter downtime 30ms > migrate_set_parameter bandwidth 1G > > This way everything would be more regular, and easier on libvirt, as new > parameters would be trivial to ask for? > > Notice that I can understand that we have to maintain the old commands > for compability, but we can do "regularly" for new ones?
I think this is worse. How does libvirt determine which parameters are valid? Let's do migrate_set_cache_size. Please don't introduce commands that multiplex multiple behavior. They do more harm than good. Regards, Anthony Liguori > > Later, Juan.
