On 30 July 2012 17:59, Andreas Färber <afaer...@suse.de> wrote: > Am 30.07.2012 18:13, schrieb Peter Maydell: >> This will need changing again if we ever fix the #if 0-d out >> code in this function, but I guess that will be obvious to whoever >> does that. > > You mean the #endif part? Would an explicit err = 0 make things better?
Not really, things would still need changing later. Really the problem is that most of the function is #if 0'd out (and never called from anywhere); it's just unused stub code so anything that shuts the compiler up will do, really. -- PMM