Re: [Qemu-devel] [PATCH 1/5] i8259: qdev-ify creation

2012-01-11 Thread Alexander Graf
On 12.01.2012, at 08:35, Jan Kiszka wrote: > On 2012-01-12 01:04, Andreas Färber wrote: >> Alex, >> >> I have this in my mailbox, but I'm still waiting for an SoB. Hervé? >> >> Regards, >> Andreas >> >> Original-Nachricht >> Betreff: [PATCH 1/5] i8259: qdev-ify creation >> Da

Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

2012-01-11 Thread Gerd Hoffmann
Hi, > I'm not sure about the consequences (hotplugging feature, etc.) when > changing it to romfile as in other PCI devices. There should be no noticable difference. > Also the patch is more > generic and supports static and dynamic devices (hotplugable and > possible future devices). Hotplug

Re: [Qemu-devel] Fwd: [PATCH 1/5] i8259: qdev-ify creation

2012-01-11 Thread Jan Kiszka
On 2012-01-12 01:04, Andreas Färber wrote: > Alex, > > I have this in my mailbox, but I'm still waiting for an SoB. Hervé? > > Regards, > Andreas > > Original-Nachricht > Betreff: [PATCH 1/5] i8259: qdev-ify creation > Datum: Sun, 26 Jun 2011 14:47:09 +0200 > Von: Hervé Poussin

[Qemu-devel] [PATCH 7/9] pseries: Use correct dispatcher for PCI config space accesses

2012-01-11 Thread David Gibson
The pseries machine expects a para-virtualized guest and so supplies RTAS functions (via a hypercall) for performing PCI config space access. Currently the implementation of these calls into pci_default_{read,write}_config(). However this would be incorrect for any PCI device which overrides the d

[Qemu-devel] [PATCH 1/9] load_image_targphys() should enforce the max size

2012-01-11 Thread David Gibson
From: Benjamin Herrenschmidt load_image_targphys() gets passed a max size for the file, but doesn't enforce it at all. Add a check and return -1 (error) if the file is too big, without loading it. Fix the bracing style in the function while we're at it. Signed-off-by: Benjamin Herrenschmidt Si

[Qemu-devel] [PATCH 2/9] Fix dirty logging with 32-bit qemu & 64-bit guests

2012-01-11 Thread David Gibson
From: Benjamin Herrenschmidt The kvm_get_dirty_pages_log_range() function uses two address variables to step through the monitored memory region to update the dirty log. However, these variables have type unsigned long, which can overflow if running a 64-bit guest with a 32-bit qemu binary. Thi

[Qemu-devel] [PATCH 1/2] target-xtensa: define TLB_TEMPLATE for MMU-less cores

2012-01-11 Thread Max Filippov
TLB_TEMPLATE macro specifies TLB geometry in the core configuration. Make TLB_TEMPLATE available for region protection core variants, defining 1 way ITLB and DTLB with 8 entries each. Signed-off-by: Max Filippov --- target-xtensa/overlay_tool.h | 18 -- 1 files changed, 16 inse

[Qemu-devel] [PATCH 2/2] target-xtensa: implement info tlb monitor command

2012-01-11 Thread Max Filippov
Command dumps valid ITLB and DTLB entries. Signed-off-by: Max Filippov --- hmp-commands.hx|2 +- monitor.c |4 +- target-xtensa/cpu.h|1 + target-xtensa/helper.c | 67 4 files changed, 71 insertions(+), 3 del

[Qemu-devel] [PATCH 4/9] Update gitignore file

2012-01-11 Thread David Gibson
This patch adds several auto-generated files to .gitignore which were previously missing. Signed-off-by: David Gibson --- .gitignore |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 406f75f..f5aab2c 100644 --- a/.gitignore +++ b/.gitignore

[Qemu-devel] [PATCH 5/9] Correct types in bmdma_addr_{read,write}

2012-01-11 Thread David Gibson
Back when I made patches introducing dma_addr_t and various PCI DMA wrapper functions, I made a mistake. The bmdma_addr_{read,write} functions need to take target_phys_addr_t not dma_addr_t, since they are assigned to MemoryRegionOps callbacks. This patch corrects my error. Signed-off-by: David

[Qemu-devel] [PATCH 8/9] pseries: Don't try to munmap() a malloc()ed TCE table

2012-01-11 Thread David Gibson
For the pseries machine, TCE (IOMMU) tables can either be directly malloc()ed in qemu or, when running on a KVM which supports it, mmap()ed from a KVM ioctl. The latter option is used when available, because it allows the (frequent bottlenext) H_PUT_TCE hypercall to be KVM accelerated. However, ev

Re: [Qemu-devel] [PATCH 3/4] pci: Make bounds checks on config space accesses actually work

2012-01-11 Thread Stefan Weil
Am 12.01.2012 04:27, schrieb David Gibson: On Wed, Jan 11, 2012 at 07:25:52AM +0100, Stefan Weil wrote: Am 11.01.2012 06:44, schrieb David Gibson: The pci_host_config_{read,write}_common() functions perform PCI config accesses. They take a limit parameter which they appear to be supposed to b

[Qemu-devel] [PATCH 6/9] pseries: Support PCI extended config space in RTAS calls

2012-01-11 Thread David Gibson
From: Benjamin Herrenschmidt On the pseries machine (which expexts a paravirtualized guest), guest access to PCI config space is via host-provided RTAS functions. This patch extends these RTAS functions to permit access to PCI extended config space, as specified in PAPR. Signed-off-by: Benjamin

[Qemu-devel] [PATCH 3/9] pci: Make bounds checks on config space accesses actually work

2012-01-11 Thread David Gibson
The pci_host_config_{read,write}_common() functions perform PCI config accesses. They take a limit parameter which they appear to be supposed to bounds check against, however the bounds checking logic, such as it is, is completely broken. Currently, it takes the minimum of the supplied length and

[Qemu-devel] [0/9] Bugfixes and pseries enhancements

2012-01-11 Thread David Gibson
This series has two parts. THe first has a few bugfixes for generic qemu code. The second has a number of pseries machine specific enhancements and bugfixes. They are included in the one series because some of the pseries specific patches rely on the generic bugfixes (in the sense that they expo

[Qemu-devel] [PATCH v2] qemu-ga: add guest-set-support-level command

2012-01-11 Thread Michael Roth
Recently commands where introduced on the mailing that involved adding commands to the guest agent that could potentially break older versions of QEMU. While it's okay to expect that qemu-ga can be updated to support newer host features, it's unrealistic to require a host to be updated to support q

Re: [Qemu-devel] [PATCH 4/4] target-i386: fix SSE rounding and flush to zero

2012-01-11 Thread Dong Xu Wang
After applied this patch, while I was compiling on my lap, there will be an error: ./configure --enable-kvm --target-list=x86_64-softmmu && make CCx86_64-softmmu/translate.o /qemu/target-i386/translate.c: In function ‘disas_insn’: /qemu/target-i386/translate.c:7547:17: error: incompatible typ

[Qemu-devel] [PATCH] hmp: Fix freeing of PciInfoList

2012-01-11 Thread Stefan Berger
Remember the original PciInfoList in info_list and use the info variable to traverse the list. Signed-off-by: Stefan Berger --- hmp.c |8 1 file changed, 4 insertions(+), 4 deletions(-) Index: qemu-git.pt/hmp.c === -

[Qemu-devel] [PATCH] qemu-ga: add guest-set-support-level command

2012-01-11 Thread Michael Roth
Recently commands where introduced on the mailing that involved adding commands to the guest agent that could potentially break older versions of QEMU. While it's okay to expect that qemu-ga can be updated to support newer host features, it's unrealistic to require a host to be updated to support q

Re: [Qemu-devel] [PATCH] hw/lan9118: Add save/load support

2012-01-11 Thread Andreas Färber
Am 19.12.2011 23:01, schrieb Peter Maydell: > Implement save/load for the LAN9118. > > Signed-off-by: Peter Maydell Reviewed-by: Andreas Färber The type conversions are okay. The VMState fields look sane on a short look, didn't check for completeness though. Andreas > --- > Does anybody have

Re: [Qemu-devel] [PATCH 1/4] load_image_targphys() should enforce the max size

2012-01-11 Thread David Gibson
On Wed, Jan 11, 2012 at 07:19:00AM +0100, Stefan Weil wrote: > Am 11.01.2012 06:44, schrieb David Gibson: > >From: Benjamin Herrenschmidt > > > >load_image_targphys() gets passed a max size for the file, but > >doesn't enforce it at all. Add a check and return -1 (error) if > >the file is too big,

Re: [Qemu-devel] [PATCH 3/4] pci: Make bounds checks on config space accesses actually work

2012-01-11 Thread David Gibson
On Wed, Jan 11, 2012 at 07:25:52AM +0100, Stefan Weil wrote: > Am 11.01.2012 06:44, schrieb David Gibson: > >The pci_host_config_{read,write}_common() functions perform PCI config > >accesses. They take a limit parameter which they appear to be supposed > >to bounds check against, however the bound

Re: [Qemu-devel] [PATCH 3/3] stop the periodic RTC update timer

2012-01-11 Thread Zhang, Yang Z
> -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Because it's not in the spec because some engineer thought it was cool. It not cool. We need to do some optimizations to get Better Performance. > It's in the spec because it gives y

[Qemu-devel] Fwd: [PATCH 1/5] i8259: qdev-ify creation

2012-01-11 Thread Andreas Färber
Alex, I have this in my mailbox, but I'm still waiting for an SoB. Hervé? Regards, Andreas Original-Nachricht Betreff: [PATCH 1/5] i8259: qdev-ify creation Datum: Sun, 26 Jun 2011 14:47:09 +0200 Von: Hervé Poussineau An: andreas.faer...@web.de Kopie (CC): Hervé Poussineau --

Re: [Qemu-devel] [PATCH 3/3] stop the periodic RTC update timer

2012-01-11 Thread Zhang, Yang Z
> -Original Message- > From: Marcelo Tosatti [mailto:mtosa...@redhat.com] > > Regarding the UIP bit, a guest could read it in a loop and wait for the value > to > change. But you can emulate it in cmos_ioport_read by reading the host time, > that is, return 1 during 244us, 0 for remaining

[Qemu-devel] [PATCH] PREP: Finish qdev conversion

2012-01-11 Thread Alexander Graf
In your previous 2 patches you start off with a really nice qdev conversion, don't finish it unfortunately though. This patch goes the final mile and does what's necessary to address the comments I had. Signed-off-by: Alexander Graf --- hw/ppc_prep.c | 14 ++- hw/prep_pci.c | 72

Re: [Qemu-devel] [PATCH] hw/lan9118: Add save/load support

2012-01-11 Thread Peter Maydell
On consideration, unless somebody wishes to: (a) commit this (b) object I'm going to put it in the next arm-devs pullreq I do. This is reasonably justifiable since the only boards using lan9118 are the ARM realview and vexpress devboard models. -- PMM On 10 January 2012 16:55, Peter Maydell w

Re: [Qemu-devel] [PATCH v9 2/6] arm: make the number of GIC interrupts configurable

2012-01-11 Thread Peter Maydell
On 11 January 2012 16:31, Mark Langsdorf wrote: > +static SysBusDeviceInfo armv7m_nvic_priv_info = { > +    .init = armv7m_nvic_init, > +    .qdev.name  = "armv7m_nvic", > +    .qdev.size  = sizeof(nvic_state), > +    .qdev.vmsd = &vmstate_nvic, So Andreas pointed out the inconsistent spacing her

Re: [Qemu-devel] [PATCH v9 0/6] arm: add support for Calxeda Highbank SoC

2012-01-11 Thread Peter Maydell
On 11 January 2012 16:31, Mark Langsdorf wrote: > This patch series adds support for the Calxeda Highbank SoC. > It depends on my previous patch series "various ARM fixes for > Calxeda Highbank" and "ahci: convert ahci_reset to use AHCIState". > Some of the patches are carried over from "Various A

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 2/3] prep: Add Raven PCI host SysBus device

2012-01-11 Thread Andreas Färber
Am 11.01.2012 23:12, schrieb Alexander Graf: > > On 07.01.2012, at 01:06, Andreas Färber wrote: > >> For now, focus on qdev'ification and leave PIC IRQs unchanged. >> >> Signed-off-by: Andreas Färber >> Cc: Hervé Poussineau >> Cc: Michael S. Tsirkin >> Cc: Anthony Liguori >> --- >> hw/prep_pc

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 2/3] prep: Add Raven PCI host SysBus device

2012-01-11 Thread Alexander Graf
On 07.01.2012, at 01:06, Andreas Färber wrote: > For now, focus on qdev'ification and leave PIC IRQs unchanged. > > Signed-off-by: Andreas Färber > Cc: Hervé Poussineau > Cc: Michael S. Tsirkin > Cc: Anthony Liguori > --- > hw/prep_pci.c | 41 +++-- > 1 f

Re: [Qemu-devel] [PATCH] prep: Fix offset of BIOS MemoryRegion

2012-01-11 Thread Anthony Liguori
On 01/11/2012 03:49 PM, Alexander Graf wrote: On 11.01.2012, at 22:46, Anthony Liguori wrote: On 01/11/2012 03:43 PM, Andreas Färber wrote: Am 05.01.2012 18:13, schrieb Andreas Färber: Since 0c90c52fab5ea92d7f12b29bfe26a7cd75d9efcb (ppc_prep: convert to memory API) OHW was "Trying to execute

Re: [Qemu-devel] [PATCH v2 2/3] prep: Add Raven PCI host SysBus device

2012-01-11 Thread Anthony Liguori
On 01/06/2012 06:06 PM, Andreas Färber wrote: For now, focus on qdev'ification and leave PIC IRQs unchanged. Signed-off-by: Andreas Färber Cc: Hervé Poussineau Cc: Michael S. Tsirkin Cc: Anthony Liguori --- hw/prep_pci.c | 41 +++-- 1 files changed, 31 in

Re: [Qemu-devel] [PATCH v2 1/3] prep: qdev'ify Raven host bridge

2012-01-11 Thread Anthony Liguori
On 01/06/2012 06:06 PM, Andreas Färber wrote: Move initialization of vendor ID, etc. to PCIDeviceInfo. Add VMState. Signed-off-by: Andreas Färber Cc: Hervé Poussineau Cc: Michael S. Tsirkin Cc: Anthony Liguori --- hw/prep_pci.c | 55 ++- 1

Re: [Qemu-devel] [Qemu-ppc] [PATCH] prep: Fix offset of BIOS MemoryRegion

2012-01-11 Thread Alexander Graf
On 11.01.2012, at 22:55, Andreas Färber wrote: > Am 11.01.2012 22:51, schrieb Alexander Graf: >> >> On 11.01.2012, at 22:49, Alexander Graf wrote: >> >>> >>> On 11.01.2012, at 22:46, Anthony Liguori wrote: >>> On 01/11/2012 03:43 PM, Andreas Färber wrote: > Am 05.01.2012 18:13, schri

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 3/3] MAINTAINERS: Add PCI host bridge files to PReP machine

2012-01-11 Thread Alexander Graf
On 07.01.2012, at 01:06, Andreas Färber wrote: > Signed-off-by: Andreas Färber Acked-by: Alexander Graf Alex > --- > MAINTAINERS |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 764c92d..6e9cd33 100644 > --- a/MAINTAINERS > +++

Re: [Qemu-devel] [Qemu-ppc] [PATCH] prep: Fix offset of BIOS MemoryRegion

2012-01-11 Thread Andreas Färber
Am 11.01.2012 22:51, schrieb Alexander Graf: > > On 11.01.2012, at 22:49, Alexander Graf wrote: > >> >> On 11.01.2012, at 22:46, Anthony Liguori wrote: >> >>> On 01/11/2012 03:43 PM, Andreas Färber wrote: Am 05.01.2012 18:13, schrieb Andreas Färber: > Since 0c90c52fab5ea92d7f12b29bfe26a7

Re: [Qemu-devel] [Qemu-ppc] [PATCH] prep: Fix offset of BIOS MemoryRegion

2012-01-11 Thread Alexander Graf
On 11.01.2012, at 22:49, Alexander Graf wrote: > > On 11.01.2012, at 22:46, Anthony Liguori wrote: > >> On 01/11/2012 03:43 PM, Andreas Färber wrote: >>> Am 05.01.2012 18:13, schrieb Andreas Färber: Since 0c90c52fab5ea92d7f12b29bfe26a7cd75d9efcb (ppc_prep: convert to memory API) OHW w

Re: [Qemu-devel] [PATCH] prep: Fix offset of BIOS MemoryRegion

2012-01-11 Thread Alexander Graf
On 11.01.2012, at 22:46, Anthony Liguori wrote: > On 01/11/2012 03:43 PM, Andreas Färber wrote: >> Am 05.01.2012 18:13, schrieb Andreas Färber: >>> Since 0c90c52fab5ea92d7f12b29bfe26a7cd75d9efcb (ppc_prep: convert to memory >>> API) OHW was "Trying to execute code outside RAM or ROM at 0xfff00700

Re: [Qemu-devel] State of KVM bits in linux-headers

2012-01-11 Thread Alexander Graf
On 11.01.2012, at 21:16, Anthony Liguori wrote: > On 01/11/2012 02:05 PM, Alexander Graf wrote: >> >> On 11.01.2012, at 20:59, Anthony Liguori wrote: >> >>> On 01/11/2012 01:53 PM, Alexander Graf wrote: On 11.01.2012, at 20:52, Anthony Liguori wrote: >> IIRC, we never had t

Re: [Qemu-devel] [PATCH] prep: Fix offset of BIOS MemoryRegion

2012-01-11 Thread Anthony Liguori
On 01/11/2012 03:43 PM, Andreas Färber wrote: Am 05.01.2012 18:13, schrieb Andreas Färber: Since 0c90c52fab5ea92d7f12b29bfe26a7cd75d9efcb (ppc_prep: convert to memory API) OHW was "Trying to execute code outside RAM or ROM at 0xfff00700". The BIOS MemoryRegion is created with a fixed size of 1

Re: [Qemu-devel] [PATCH] prep: Fix offset of BIOS MemoryRegion

2012-01-11 Thread Andreas Färber
Am 05.01.2012 18:13, schrieb Andreas Färber: > Since 0c90c52fab5ea92d7f12b29bfe26a7cd75d9efcb (ppc_prep: convert to memory > API) OHW was "Trying to execute code outside RAM or ROM at 0xfff00700". > > The BIOS MemoryRegion is created with a fixed size of 1 MiB. > Ensure that the full size can be a

Re: [Qemu-devel] [PATCH 07/10] fdc: check if media rate is correct before doing any transfer

2012-01-11 Thread Andreas Färber
Am 08.01.2012 21:27, schrieb Hervé Poussineau: > > Signed-off-by: Hervé Poussineau > --- > hw/fdc.c | 24 +++- > 1 files changed, 23 insertions(+), 1 deletions(-) > > diff --git a/hw/fdc.c b/hw/fdc.c > index aec1e5e..ddfa91f 100644 > --- a/hw/fdc.c > +++ b/hw/fdc.c > @@ -8

Re: [Qemu-devel] [PATCH 10/10] fdc: DIR (Digital Input Register) should return status of current drive...

2012-01-11 Thread Andreas Färber
Am 08.01.2012 21:27, schrieb Hervé Poussineau: > > Signed-off-by: Hervé Poussineau > --- > hw/fdc.c |9 ++--- > 1 files changed, 2 insertions(+), 7 deletions(-) > > diff --git a/hw/fdc.c b/hw/fdc.c > index 7af0f7e..a23fb1e 100644 > --- a/hw/fdc.c > +++ b/hw/fdc.c > @@ -932,13 +933,7 @@

Re: [Qemu-devel] [PATCH 08/10] fdc: add CCR (Configuration Control Register) write register

2012-01-11 Thread Andreas Färber
Am 08.01.2012 21:27, schrieb Hervé Poussineau: > > Signed-off-by: Hervé Poussineau > --- > hw/fdc.c | 21 + > 1 files changed, 21 insertions(+), 0 deletions(-) > > diff --git a/hw/fdc.c b/hw/fdc.c > index ddfa91f..67cd14f 100644 > --- a/hw/fdc.c > +++ b/hw/fdc.c > @@ -227,

Re: [Qemu-devel] State of KVM bits in linux-headers

2012-01-11 Thread Anthony Liguori
On 01/11/2012 02:05 PM, Alexander Graf wrote: On 11.01.2012, at 20:59, Anthony Liguori wrote: On 01/11/2012 01:53 PM, Alexander Graf wrote: On 11.01.2012, at 20:52, Anthony Liguori wrote: IIRC, we never had this problem with qemu-kvm - as the merges were coordinated with the kernel (subsys

Re: [Qemu-devel] State of KVM bits in linux-headers

2012-01-11 Thread Alexander Graf
On 11.01.2012, at 20:41, Anthony Liguori wrote: > On 01/11/2012 01:38 PM, Jan Kiszka wrote: >>> I would like to see us avoiding this in the future. Headers update patches should mention the source and should not be merged until the ABI changes actually made it at least into kvm.gi

Re: [Qemu-devel] State of KVM bits in linux-headers

2012-01-11 Thread Jan Kiszka
On 2012-01-11 20:38, Anthony Liguori wrote: > On 01/11/2012 01:32 PM, Alexander Graf wrote: >> >> On 11.01.2012, at 20:16, Jan Kiszka wrote: >> >>> Hi, >>> >>> I'm a bit unhappy about the current state of our supposed to be >>> automatically sync'ed linux-headers directory in qemu. It has been >>>

Re: [Qemu-devel] State of KVM bits in linux-headers

2012-01-11 Thread Alexander Graf
On 11.01.2012, at 20:59, Anthony Liguori wrote: > On 01/11/2012 01:53 PM, Alexander Graf wrote: >> >> On 11.01.2012, at 20:52, Anthony Liguori wrote: >> IIRC, we never had this problem with qemu-kvm - as the merges were coordinated with the kernel (subsystem) tree. >>> >>> Are you su

Re: [Qemu-devel] State of KVM bits in linux-headers

2012-01-11 Thread Anthony Liguori
On 01/11/2012 01:53 PM, Alexander Graf wrote: On 11.01.2012, at 20:52, Anthony Liguori wrote: IIRC, we never had this problem with qemu-kvm - as the merges were coordinated with the kernel (subsystem) tree. Are you suggesting that kvm header updates go through uq/master? That seems reasona

Re: [Qemu-devel] State of KVM bits in linux-headers

2012-01-11 Thread Jan Kiszka
On 2012-01-11 20:52, Anthony Liguori wrote: > On 01/11/2012 01:48 PM, Jan Kiszka wrote: >> On 2012-01-11 20:46, Alexander Graf wrote: >>> >>> On 11.01.2012, at 20:41, Anthony Liguori wrote: >>> On 01/11/2012 01:38 PM, Jan Kiszka wrote: >> >>> I would like to see us avoiding this in the

[Qemu-devel] [PATCH v2] rbd: wire up snapshot removal and rollback functionality

2012-01-11 Thread Gregory Farnum
Signed-off-by: Greg Farnum --- Remove redundant warnings and add Kevin to the CC. block/rbd.c | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index 7a2384c..475e362 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -787,6 +787,

Re: [Qemu-devel] State of KVM bits in linux-headers

2012-01-11 Thread Alexander Graf
On 11.01.2012, at 20:52, Anthony Liguori wrote: > On 01/11/2012 01:48 PM, Jan Kiszka wrote: >> On 2012-01-11 20:46, Alexander Graf wrote: >>> >>> On 11.01.2012, at 20:41, Anthony Liguori wrote: >>> On 01/11/2012 01:38 PM, Jan Kiszka wrote: >> >>> I would like to see us avoiding th

Re: [Qemu-devel] State of KVM bits in linux-headers

2012-01-11 Thread Anthony Liguori
On 01/11/2012 01:48 PM, Jan Kiszka wrote: On 2012-01-11 20:46, Alexander Graf wrote: On 11.01.2012, at 20:41, Anthony Liguori wrote: On 01/11/2012 01:38 PM, Jan Kiszka wrote: I would like to see us avoiding this in the future. Headers update patches should mention the source and should not

Re: [Qemu-devel] [PATCH]: set up rbd snapshot handling

2012-01-11 Thread Gregory Farnum
On Wed, Jan 11, 2012 at 1:58 AM, Stefan Hajnoczi wrote: > On Tue, Jan 10, 2012 at 8:01 PM, Gregory Farnum > wrote: >> +static int qemu_rbd_snap_remove(BlockDriverState *bs, >> +                                const char *snapshot_name) >> +{ >> +    BDRVRBDState *s = bs->opaque; >> +    int r; >>

Re: [Qemu-devel] State of KVM bits in linux-headers

2012-01-11 Thread Jan Kiszka
On 2012-01-11 20:46, Alexander Graf wrote: > > On 11.01.2012, at 20:41, Anthony Liguori wrote: > >> On 01/11/2012 01:38 PM, Jan Kiszka wrote: > I would like to see us avoiding this in the future. Headers update > patches should mention the source and should not be merged until the AB

Re: [Qemu-devel] State of KVM bits in linux-headers

2012-01-11 Thread Alexander Graf
On 11.01.2012, at 20:46, Jan Kiszka wrote: > On 2012-01-11 20:38, Anthony Liguori wrote: >> On 01/11/2012 01:32 PM, Alexander Graf wrote: >>> >>> On 11.01.2012, at 20:16, Jan Kiszka wrote: >>> Hi, I'm a bit unhappy about the current state of our supposed to be automatically

Re: [Qemu-devel] State of KVM bits in linux-headers

2012-01-11 Thread Alexander Graf
On 11.01.2012, at 20:38, Anthony Liguori wrote: > On 01/11/2012 01:32 PM, Alexander Graf wrote: >> >> On 11.01.2012, at 20:16, Jan Kiszka wrote: >> >>> Hi, >>> >>> I'm a bit unhappy about the current state of our supposed to be >>> automatically sync'ed linux-headers directory in qemu. It has

Re: [Qemu-devel] [PATCH 12/15] qtest: add support for target-i386 -M pc

2012-01-11 Thread Anthony Liguori
On 01/10/2012 01:56 PM, Paolo Bonzini wrote: On 01/10/2012 08:10 PM, Anthony Liguori wrote: This involves forcing the CPU into the halted state if qtest is enabled and replacing the local APIC with the qtest interrupt controller. It should be pretty straight forward to do the same for other mac

Re: [Qemu-devel] State of KVM bits in linux-headers

2012-01-11 Thread Anthony Liguori
On 01/11/2012 01:38 PM, Jan Kiszka wrote: I would like to see us avoiding this in the future. Headers update patches should mention the source and should not be merged until the ABI changes actually made it at least into kvm.git. Same applies, of course, to the functional changes related to tha

Re: [Qemu-devel] State of KVM bits in linux-headers

2012-01-11 Thread Jan Kiszka
On 2012-01-11 20:32, Alexander Graf wrote: > > On 11.01.2012, at 20:16, Jan Kiszka wrote: > >> Hi, >> >> I'm a bit unhappy about the current state of our supposed to be >> automatically sync'ed linux-headers directory in qemu. It has been >> updated several times against undefined kernel trees, m

Re: [Qemu-devel] State of KVM bits in linux-headers

2012-01-11 Thread Anthony Liguori
On 01/11/2012 01:32 PM, Alexander Graf wrote: On 11.01.2012, at 20:16, Jan Kiszka wrote: Hi, I'm a bit unhappy about the current state of our supposed to be automatically sync'ed linux-headers directory in qemu. It has been updated several times against undefined kernel trees, means against n

Re: [Qemu-devel] [PATCH 15/15] qtest: add rtc-test test-case

2012-01-11 Thread Paolo Bonzini
On 01/11/2012 06:06 PM, Anthony Liguori wrote: The right thing to do would be to run the test with vm_clock for the rtc_clock, add a way for the qtest machine to bump the vm_clock to the next event, I actually was looking at this yesterday. Just bumping to the next event is not enough, you w

[Qemu-devel] [RFC][PATCH] Update linux headers against kvm.git

2012-01-11 Thread Jan Kiszka
On 2012-01-11 20:16, Jan Kiszka wrote: > Hi, > > I'm a bit unhappy about the current state of our supposed to be > automatically sync'ed linux-headers directory in qemu. It has been > updated several times against undefined kernel trees, means against > neither a released version nor kvm.git. Now,

Re: [Qemu-devel] State of KVM bits in linux-headers

2012-01-11 Thread Alexander Graf
On 11.01.2012, at 20:16, Jan Kiszka wrote: > Hi, > > I'm a bit unhappy about the current state of our supposed to be > automatically sync'ed linux-headers directory in qemu. It has been > updated several times against undefined kernel trees, means against > neither a released version nor kvm.git

Re: [Qemu-devel] [PATCH v4 00/15] block: generic image streaming

2012-01-11 Thread Luiz Capitulino
On Fri, 6 Jan 2012 14:01:26 + Stefan Hajnoczi wrote: > This series adds the 'block_stream' command which copies the contents of a > backing file into the image file while the VM is running. The series builds > on > the zero detection features which I sent out before Christmas. I suggest >

Re: [Qemu-devel] LLVM builds on Lion (Xcode 4.2.1)?

2012-01-11 Thread Peter Maydell
On 10 January 2012 11:18, Rui Carmo wrote: > For the record, the way I got it to build was patching fpu/softfloat.h (see > below, I think this has been submitted as a formal patch by someone else, but > can't find it either) and setting --cc=gcc-4.2 --host-cc=gcc-4.2. [uint16/int16 typename cla

[Qemu-devel] [PATH 7/6] trace: [tracetool] Make format-specific code optional and with access to event information

2012-01-11 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool.py | 35 ++- 1 files changed, 10 insertions(+), 25 deletions(-) diff --git a/scripts/tracetool.py b/scripts/tracetool.py index a9020de..ddf4c31 100755 --- a/scripts/tracetool.py +++ b/scripts/tracetool.py @@ -3

[Qemu-devel] LLVM builds on Lion (Xcode 4.2.1)?

2012-01-11 Thread Rui Carmo
Hello, I posted this to the list a couple of days ago but I still don't see it in the archives, so here goes again... I've been trying to get a working build of QEMU 1.0 (or HEAD) that would build or run on Mac OS X Lion without segfaulting or spinlocking, and so far the only way I've been ab

[Qemu-devel] State of KVM bits in linux-headers

2012-01-11 Thread Jan Kiszka
Hi, I'm a bit unhappy about the current state of our supposed to be automatically sync'ed linux-headers directory in qemu. It has been updated several times against undefined kernel trees, means against neither a released version nor kvm.git. Now, if I run an update against kvm.git + some local ch

[Qemu-devel] [PATCH] virtfs-proxy-helper: Add missing printf format attribute

2012-01-11 Thread Stefan Weil
Every function with printf like arguments must have it (see file HACKING), so add it. Signed-off-by: Stefan Weil --- fsdev/virtfs-proxy-helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c index 21e9b16..4a50

[Qemu-devel] Does iotlb have anything to do with IOMMU?

2012-01-11 Thread 陳韋任
Hi all, I am wondering if iotlb (cpu-defs.h) has anything to do with IOMMU [1]. I think iotlb is used in MMIO (memory mapped IO), right? Thanks for clarification. [1] http://en.wikipedia.org/wiki/IOMMU Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information

[Qemu-devel] [PATCH v7 4/6] arm: Add dummy support for co-processor 15's secure config register

2012-01-11 Thread Mark Langsdorf
From: Rob Herring Signed-off-by: Rob Herring Signed-off-by: Mark Langsdorf Reviewed-by: Peter Maydell --- Changes from v1, v2, v3, v4, v5, v6 Skipped target-arm/cpu.h |3 ++- target-arm/helper.c |9 + target-arm/machine.c |2 ++ 3 files changed, 13 insertions

Re: [Qemu-devel] [RFC][PATCT 0/14 v4] dump memory when host pci device is used by guest

2012-01-11 Thread Jan Kiszka
On 2012-01-10 08:44, Wen Congyang wrote: > Hi, Jan Kiszka > Do you have any time to review this patchset? Will try to find some. BTW, the title of this cover letter is a bit misleading. This series is about introducing a new, dedicated memory dump mechanism. Jan > > Thanks > Wen Congyang > >

[Qemu-devel] [PATCH v7 0/6] arm: add support for Calxeda Highbank SoC

2012-01-11 Thread Mark Langsdorf
This patch series adds support for the Calxeda Highbank SoC. It depends on my previous patch series "various ARM fixes for Calxeda Highbank" and "ahci: convert ahci_reset to use AHCIState". Some of the patches are carried voer from "Various ARM fixes for Calxeda Highbank" and were reviewed but not

Re: [Qemu-devel] [kvm-devel] [PATCH v2] kvm-ppc: halt secondary cpus when guest reset

2012-01-11 Thread Jan Kiszka
On 2012-01-10 00:17, Scott Wood wrote: > On 01/09/2012 04:39 PM, Alexander Graf wrote: >> >> On 09.01.2012, at 22:23, Scott Wood wrote: >> >>> On 01/09/2012 01:41 AM, Liu Yu wrote: When guest reset, we need to halt secondary cpus until guest kick them. This already works for tcg. The patc

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Add 'fall through' comments to case statements without break

2012-01-11 Thread Stefan Hajnoczi
On Mon, Jan 09, 2012 at 06:29:51PM +0100, Stefan Weil wrote: > These comments are used by static code analysis tools and in code reviews > to avoid false warnings because of missing break statements. > > The case statements handled here were reported by coverity. > > Signed-off-by: Stefan Weil >

Re: [Qemu-devel] [PATCH V5] Guest stop notification

2012-01-11 Thread Jan Kiszka
On 2012-01-11 19:17, Eric B Munson wrote: > Often when a guest is stopped from the qemu console, it will report spurious > soft lockup warnings on resume. There are kernel patches being discussed that > will give the host the ability to tell the guest that it is being stopped and > should ignore t

[Qemu-devel] [PATCH v3 0/5] arm: add support for Calxeda Highbank SoC

2012-01-11 Thread Mark Langsdorf
This patch series adds support for the Calxeda Highbank SoC. It depends on my previous patch series "various ARM fixes for Calxeda Highbank" and "ahci: convert ahci_reset to use AHCIState". Some of the patches are carried voer from "Various ARM fixes for Calxeda Highbank" and were reviewed but not

[Qemu-devel] [PATCH 2/2] virtfs-proxy-helper: Clean include files

2012-01-11 Thread Stefan Weil
The common standard include files are already included via qemu-common.h, and for the socket related include files there is qemu_socket.h, so the code can be reduced by some lines. Signed-off-by: Stefan Weil --- fsdev/virtfs-proxy-helper.c | 15 ++- 1 files changed, 2 insertions(+)

[Qemu-devel] [PATCH 1/2] virtfs-proxy-helper: Fix compilation on newer systems

2012-01-11 Thread Stefan Weil
Include file attr/xattr.h is not available on "newer" systems (for example Fedora 12 or Debian Squeeze). See comments in qemu-xattr.h for more information. This file handles the system dependencies automatically. Signed-off-by: Stefan Weil --- fsdev/virtfs-proxy-helper.c |2 +- 1 files chan

[Qemu-devel] [PATCH 0/2] virtfs-proxy-helper: Fix and clean include statements

2012-01-11 Thread Stefan Weil
Obviously most Linux host systems don't have a libcap-dev package. If this package is available, make tries to build virtfs-proxy-helper and fails on recent Linux distributions because of a missing attr/xattr.h. The first patch fixes this. As I noticed that several include statements were redunda

[Qemu-devel] [PATCH 4/5] usb-redir: Try to keep our buffer size near the target size

2012-01-11 Thread Hans de Goede
Before this patch we would allow the (iso) buffer to grow unlimited (and it would under certain circumstances) leading to way too high latencies for iso data streams. Signed-off-by: Hans de Goede --- usb-redir.c | 30 +++--- 1 files changed, 27 insertions(+), 3 deletion

[Qemu-devel] [PATCH 3/5] usb-redir: Pre-fill our isoc input buffer before sending pkts to the host

2012-01-11 Thread Hans de Goede
This is something which should have been done from the first version of usb-redir, but wasn't. Signed-off-by: Hans de Goede --- usb-redir.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/usb-redir.c b/usb-redir.c index 76cae16..9970b85 100644 --- a/usb-r

Re: [Qemu-devel] [PATCH 1/2] block: add dirty flag status to qemu-img

2012-01-11 Thread Kevin Wolf
Am 11.01.2012 15:35, schrieb Stefan Hajnoczi: > On Sat, Dec 31, 2011 at 9:06 AM, Dong Xu Wang > wrote: >> +int bdrv_is_dirty(BlockDriverState *bs) > > bool would be nicer instead of int. Traditionally we used int but C99 > has been around for a long time now and it's more appropriate. > >> diff

Re: [Qemu-devel] [RFC PATCH v3 1/3] Converting tracetool.sh to tracetool.py

2012-01-11 Thread Stefan Hajnoczi
On Tue, Jan 10, 2012 at 10:59 AM, Harsh Prateek Bora wrote: > diff --git a/scripts/tracetool.py b/scripts/tracetool.py > new file mode 100755 > index 000..6874f66 > --- /dev/null > +++ b/scripts/tracetool.py > @@ -0,0 +1,585 @@ > +#!/usr/bin/env python > +# Python based tracetool script (Code

[Qemu-devel] [PATCH v2 6/6] arm: Remove incorrect comment in arm_timer

2012-01-11 Thread Mark Langsdorf
The current comment says that the arm_timers are restricted to between 32 KHz and 1 MHz, but sp804 TRM does not specify those limits. Signed-off-by: Mark Langsdorf --- Changes from v1 Clarified the commit message hw/arm_timer.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-

Re: [Qemu-devel] [libvirt] QMP: Supporting off tree APIs

2012-01-11 Thread Luiz Capitulino
On Tue, 10 Jan 2012 15:02:48 -0600 Anthony Liguori wrote: > On 01/10/2012 02:55 PM, Luiz Capitulino wrote: > > On Tue, 10 Jan 2012 13:18:41 -0600 > > Anthony Liguori wrote: > > > >> On 01/06/2012 01:42 PM, Luiz Capitulino wrote: > >>> On Fri, 06 Jan 2012 09:08:19 -0600 > We also need to loo

Re: [Qemu-devel] [PATCH] (dont commit) virtio-gl-fixes for build on F17

2012-01-11 Thread andrzej zaborowski
On 10 January 2012 09:44, Alon Levy wrote: > All but the last are assigned but unused variables, > and an always true comparison, but the last looks like a logic > error - decode not returning the actual return value for the last call > in the buffer (vmgl-exec.c). > --- >  gl/gloffscreen-xcomposi

Re: [Qemu-devel] [PATCH 1/3]use int64 when compare two time

2012-01-11 Thread Marcelo Tosatti
On Fri, Jan 06, 2012 at 01:20:55PM +, Peter Maydell wrote: > On 6 January 2012 07:37, Zhang, Yang Z wrote: > > use int64 when compare two time > > > > int32 only represent only 136 years when comparing two times based on > > second. It would be better to use int64. > > "int32", "int32_t" and

Re: [Qemu-devel] [RFC 00/10]: QMP/HMP: Introduce tray handling commands

2012-01-11 Thread Osier Yang
On 2012年01月04日 03:28, Luiz Capitulino wrote: On Tue, 20 Dec 2011 14:49:47 +0800 Osier Yang wrote: On 2011年06月04日 03:03, Luiz Capitulino wrote: In a recent discussion on the mailing list regarding the introduction of the BLOCK_TRAY_OPEN and BLOCK_TRAY_CLOSE events[1], it was mentioned that we

Re: [Qemu-devel] [RFC PATCH v3 1/3] Converting tracetool.sh to tracetool.py

2012-01-11 Thread Lluís Vilanova
Harsh Prateek Bora writes: > Signed-off-by: Harsh Prateek Bora > --- > Makefile.objs|6 +- > Makefile.target | 10 +- > configure|7 +- > scripts/tracetool| 643 > -- > scripts/tracetool.py | 585 ++

Re: [Qemu-devel] [libvirt] QMP: Supporting off tree APIs

2012-01-11 Thread Anthony Liguori
On 01/06/2012 01:42 PM, Luiz Capitulino wrote: On Fri, 06 Jan 2012 09:08:19 -0600 We also need to look at this interface as a public interface whether we technically committed it to or not. The fact is, an important user is relying upon so that makes it a supported interface. Even though I abs

Re: [Qemu-devel] [PATCH 1/2] virtio-pci: Fix endianness of virtio config

2012-01-11 Thread Benjamin Herrenschmidt
On Wed, 2012-01-11 at 01:08 +0100, Alexander Graf wrote: > On 11.01.2012, at 01:07, Anthony Liguori wrote: > > > On 01/10/2012 06:07 PM, Alexander Graf wrote: > >> From: Benjamin Herrenschmidt > >> > >> The virtio config area in PIO space is a bit special. The initial > >> header is little endian

[Qemu-devel] [RFC PATCH 0/5] initial suspend support

2012-01-11 Thread Gerd Hoffmann
Hi, This patch series makes suspend support in qemu alot more useful. Right now the guest can put itself into s3, but qemu will wakeup the guest instantly. With this patch series applied the guest will stay suspended instead and there are a few events which can kick the guest out of suspend st

Re: [Qemu-devel] Please read: make check framework

2012-01-11 Thread Kevin Wolf
Am 10.01.2012 00:56, schrieb Anthony Liguori: > On 01/09/2012 05:22 PM, Andreas Färber wrote: >> Am 09.01.2012 22:42, schrieb Anthony Liguori: >>> If there's some piece of QEMU you care about, start writing tests and >>> tie it into make check. It's that simple :-) >> >> Not quite. It would be eas

[Qemu-devel] [PATCH V5] Guest stop notification

2012-01-11 Thread Eric B Munson
Often when a guest is stopped from the qemu console, it will report spurious soft lockup warnings on resume. There are kernel patches being discussed that will give the host the ability to tell the guest that it is being stopped and should ignore the soft lockup warning that generates. This patch

Re: [Qemu-devel] [PATCH] virtio-pci: Fix endianness of virtio config

2012-01-11 Thread Benjamin Herrenschmidt
On Tue, 2012-01-10 at 22:45 +0100, Alexander Graf wrote: > Here's the thing that I don't understand. What exactly is breaking for > you? I tried -M pseries on a ppc box and on an x86 box and both times > was able to see /dev/vda. And mount it and use it ? Here I get the capacity wrong if I don't h

Re: [Qemu-devel] [PATCH 3/3] stop the periodic RTC update timer

2012-01-11 Thread Paolo Bonzini
On 01/10/2012 07:37 AM, Zhang, Yang Z wrote: Also, I'm not sure if the update in progress flag still works. Clients are supposed to wait for UIP=0 before reading the RTC, and an update is supposed to be at least 220 microseconds away when UIP=0. Hardware need a period time to update clock and i

[Qemu-devel] [PATCH v9 1/6] Add xgmac ethernet model

2012-01-11 Thread Mark Langsdorf
This adds very basic support for the xgmac ethernet core. Missing things include: - statistics counters - WoL support - rx checksum offload - chained descriptors (only linear descriptor ring) - broadcast and multicast handling Signed-off-by: Rob Herring Signed-off-by: Mark Langsdorf Reviewed-by

  1   2   3   >