Hi, > I'm not sure about the consequences (hotplugging feature, etc.) when > changing it to romfile as in other PCI devices.
There should be no noticable difference. > Also the patch is more > generic and supports static and dynamic devices (hotplugable and > possible future devices). Hotplug works just fine for the other pci devices. > Patch supports without hotplugging both > options to disable the romfile: > ,romfile= > ,romfile=disabled That should be a separate patch. And it should update pci_add_option_rom() so it works equally for all pci devices. > And the patch has already been tested ... Well, it adds a bunch of code which would not be needed in the first place if you would simply make use of the romfile support of the pci layer. cheers, Gerd
