[issue22079] Ensure in PyType_Ready() that base class of static type is static

Xiang Zhang added the comment: In the mro list I think the first is always the type itself which has already been checked to be a statically allocated type if we can touch the loop. Starting from 0 checks it twice and it's not a base either. BTW, I don't receive an email from the tracker. :(

[issue24364] Not all defects pass through email policy

Martin Panter added the comment: I see that “compat32” and “default” are actually different things (Compat32 vs EmailPolicy classes). IMO “default” was a bad choice of name, but I guess that ship has already sailed. This patch adds a test_defect_handling.TestCompat32 subclass, so the test met

[issue20825] containment test for "ip_network in ip_network"

Michel Albert added the comment: I just realised that the latest patch on this no longer applies properly. I have fixed the issue and I am currently in the process of running the unit-tests which takes a while. Once those pass, I'll update some metadata and resubmit. -- _

[issue20825] containment test for "ip_network in ip_network"

Michel Albert added the comment: Test pass properly. Is there anything else left to do? Here's the fixed patch (net-in-net-r4.patch) -- Added file: http://bugs.python.org/file43534/net-in-net-r4.patch ___ Python tracker

[issue20842] pkgutil docs should reference glossary terms not PEP 302

Jaysinh shukla added the comment: Dear Martin, I observed your comment. I can see, issue mentioned by you http://bugs.python.org/issue26896 contains patch of clarifying the reference of Importer, Finder. The issue-26896 is still under review phase. It will be good step to update doc in thi

[issue20825] containment test for "ip_network in ip_network"

SilentGhost added the comment: Have you seen my comments on rietveld re you previous patch? -- ___ Python tracker ___ ___ Python-bugs-

[issue20825] containment test for "ip_network in ip_network"

Michel Albert added the comment: Updated patch, taking into account notes from the previous patch-reviews -- Added file: http://bugs.python.org/file43535/net-in-net-r5.patch ___ Python tracker _

[issue27353] Add nroot function to math

Steven D'Aprano added the comment: On Mon, Jun 20, 2016 at 09:02:09PM +, Tim Peters wrote: > Note that the very popular TI graphics calculators have had a distinct > nth-root function at least since the TI-83. It's a minor convenience > there. Likewise HP calculators ("xroot") and at leas

[issue20825] containment test for "ip_network in ip_network"

Berker Peksag added the comment: Thanks for the updated patch. Some comments from a quick review: * We need tests for the TypeError branches in both methods * +'of type %s' % type(other) type(other) -> type(other).__name__ * You can drop the XXX part in +XXX I

[issue20674] Update comments in dictobject.c

Jaysinh shukla added the comment: Agreeing with "SilentGhost". Demonstrating `hash()` example for type int using list comprehension. Review issue20674_patch_v5.diff Thanks! -- Added file: http://bugs.python.org/file43536/issue20674_patch_v5.diff ___

[issue27363] Complex with negative zero imaginary part

Vedran Čačić added the comment: Mark, I think it would be a great idea. It would be consistent with both "str is straightforward, repr is reproducible", and with the idea that (evalable) repr is almost always of the form `typename(arguments)`. It would also get rid of that "supefluous-looking"

[issue26896] mix-up with the terms 'importer', 'finder', 'loader' in the import system and related code

Martin Panter added the comment: Oren: If you have extra changes to make on the same topic, it is probably best to make a new patch that combines both the original changes plus the new changes. Brett: Since you were responsible for the two dead assignments, your input would be helpful. Perhap

[issue20842] pkgutil docs should reference glossary terms not PEP 302

Martin Panter added the comment: I’m not sure what the best solution is. I am just pointing out the problem. It seems an “importer” as mentioned in PEP 302 is more general than the current glossary definition. E.g. ImpImporter() returns an object that has a find_module() method (which partiall

[issue26865] Meta-issue: support of the android platform

Xavier de Gaye added the comment: issue #23968: rename the platform directory from plat-$(MACHDEP) to plat-$(PLATFORM_TRIPLET) -- ___ Python tracker ___

[issue26865] Meta-issue: support of the android platform

Changes by Xavier de Gaye : -- dependencies: +rename the platform directory from plat-$(MACHDEP) to plat-$(PLATFORM_TRIPLET) ___ Python tracker ___ _

[issue23968] rename the platform directory from plat-$(MACHDEP) to plat-$(PLATFORM_TRIPLET)

Xavier de Gaye added the comment: The same problem occurs when cross-compiling for Android and running test_sysconfig and test_distutils. Some other points: * The generation of the platform directory breaks the support of read only source trees. The files of this directory are not tracked by

[issue20825] containment test for "ip_network in ip_network"

Michel Albert added the comment: I don't quite see how the operator module could help. I don't have much experience with it though, so I might be missing something... I don't see how I can relate one check to the other. The example I gave in the patch review was the following: With the existi

[issue20825] containment test for "ip_network in ip_network"

Michel Albert added the comment: New patch with proposed changes. -- Added file: http://bugs.python.org/file43537/net-in-net-r6.patch ___ Python tracker ___ _

[issue23968] rename the platform directory from plat-$(MACHDEP) to plat-$(PLATFORM_TRIPLET)

Xavier de Gaye added the comment: > The same problem occurs when cross-compiling for Android and running > test_sysconfig and test_distutils. This is misleading. Actually, test_sysconfig and test_distutils do not fail when run from the source tree, but fail on an installed python, whatever the

[issue26896] mix-up with the terms 'importer', 'finder', 'loader' in the import system and related code

Oren Milman added the comment: Except for some trailing spaces I have just found in my original proposed patches, I don't have any extra changes to add. So as soon as Brett answers about those two assignments, I would update and upload the patches diff file. With regard to terminology, I belie

[issue27363] Complex with negative zero imaginary part

Mark Dickinson added the comment: > People usually say it's because we don't have separate imaginary type, but we > don't need it. I think we do. Consider the case of something like -0 + 1j (the `repr` of complex(-0.0, 1.0)). That currently evaluates to `complex(0.0, 1.0)`, because the `-0.0`

[issue26896] mix-up with the terms 'importer', 'finder', 'loader' in the import system and related code

Oren Milman added the comment: Also, Brett was the one who added the three terms to the glossary in https://hg.python.org/cpython/rev/ea5767ebd903, and a clarification of 'finder' in https://hg.python.org/cpython/rev/88cee7d16ccb, so I guess his input in this matter also would be helpful. (If

[issue26186] LazyLoader rejecting use of SourceFileLoader

Roundup Robot added the comment: New changeset 7af4b3ad75b7 by Brett Cannon in branch 'default': Issue #26186: Remove the restriction that built-in and extension https://hg.python.org/cpython/rev/7af4b3ad75b7 -- ___ Python tracker

[issue26186] LazyLoader rejecting use of SourceFileLoader

Brett Cannon added the comment: The restriction of lazily loading built-ins and extensions is now lifted! -- status: open -> closed ___ Python tracker ___ ___

[issue26896] mix-up with the terms 'importer', 'finder', 'loader' in the import system and related code

Changes by Brett Cannon : -- assignee: -> brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue27130] zlib: OverflowError while trying to compress 2^32 bytes or more

Xiang Zhang added the comment: Add the newest version applying Martin's comments. -- Added file: http://bugs.python.org/file43538/64bit_support_for_zlib_v7.patch ___ Python tracker _

[issue22079] Ensure in PyType_Ready() that base class of static type is static

Serhiy Storchaka added the comment: __bases__ != mro() -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue22928] HTTP header injection in urrlib2/urllib/httplib/http.client

Changes by Serhiy Storchaka : -- nosy: +georg.brandl ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue26243] zlib.compress level as keyword argument

Roundup Robot added the comment: New changeset 01f82a7a1250 by Serhiy Storchaka in branch 'default': Issue #26243: Only the level argument to zlib.compress() is keyword argument https://hg.python.org/cpython/rev/01f82a7a1250 -- ___ Python tracker

[issue27051] Create PIP gui

Terry J. Reedy added the comment: Raymond, since you are the one who proposed making a pip-gui accessible from IDLE, you might want to comment on where and how it should be installed. Ned Deily and Nick Coughlin are dubious about putting it anywhere in the stdlib, including idlelib. One alte

[issue26243] zlib.compress level as keyword argument

Roundup Robot added the comment: New changeset ab2e7e51869d by Serhiy Storchaka in branch 'default': Issue #26243: Correct a wording in docs. https://hg.python.org/cpython/rev/ab2e7e51869d -- ___ Python tracker ___

[issue26243] zlib.compress level as keyword argument

Serhiy Storchaka added the comment: Thanks Berker and Martin. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue23551] IDLE to provide menu link to PIP gui.

Terry J. Reedy added the comment: Starting with June 20 msg268947 of #27051, Ned Deily raised the issue of adding something to the stdlib that depends on an external interface. Nick Coughlin agreed that this is problematical. Pipgui might have to be installed into site-packages from PyPI. O

[issue22115] Add new methods to trace Tkinter variables

Serhiy Storchaka added the comment: Thank you for your review Terry. Here is updated patch. IDLE now uses new API. -- Added file: http://bugs.python.org/file43539/tkinter_trace_variable_6.patch ___ Python tracker _

[issue24137] Force not using _default_root in IDLE

Roundup Robot added the comment: New changeset a8d611eb6173 by Serhiy Storchaka in branch 'default': Issue #24137: Fixed IDLE on Linux with tkinter default root disabled. https://hg.python.org/cpython/rev/a8d611eb6173 -- ___ Python tracker

[issue24137] Force not using _default_root in IDLE

Serhiy Storchaka added the comment: You have missed my changes in nodefaultroot2.diff. -- ___ Python tracker ___ ___ Python-bugs-list

[issue27386] Asyncio server hang when clients connect and immediately disconnect

New submission from Jim Fulton: I recently ported ZEO to asyncio. We'd had a bug in our old asyncore-based server where the server would hang if several connections were made and then immediately disconnected on Mac OS X. This was due to an error-handling bug in our code that we fixed. We ha

[issue24364] Not all defects pass through email policy

R. David Murray added the comment: The name default is future proofing. It will be the default...eventually :) And it is the default now if you use EmailMessage to construct your messages. -- ___ Python tracker

[issue27051] Create PIP gui

Nick Coghlan added the comment: Terry, would you be open to overseeing the merge of a version that bootstrapped itself as follows: - IDLE gained a pip GUI launcher that, if the pip GUI was not importable, offered to install it from PyPI (always using a "--user" install if it doesn't detect an

[issue27365] Allow non-ascii chars in IDLE NEWS.txt (for contributor names)

Larry Hastings added the comment: If this is fixed, and resolved, why is it still open? Closing. -- status: open -> closed ___ Python tracker ___ ___

[issue20350] Replace tkapp.split() to tkapp.splitlist()

Roundup Robot added the comment: New changeset 8d78cd7c4a9e by Serhiy Storchaka in branch 'default': Issue #20350. tkapp.splitlist() is now always used instead of unreliable https://hg.python.org/cpython/rev/8d78cd7c4a9e -- nosy: +python-dev ___ Pytho

[issue20350] Replace tkapp.split() to tkapp.splitlist()

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 2.7, Python 3.5 ___ Python tracker ___ __

[issue26867] test_ssl test_options fails on ubuntu 16.04

Larry Hastings added the comment: Well, as Donald Rumsfeld said in 2008: "As you know, you go to war with the army you have, not the army you might want or wish to have at a later time." 3.5.2 final and 3.4.5 final will ship with Matthias's patch as proposed. FWIW I'd accept an improved patch

[issue27387] Thread hangs on str.encode() when locale is not set

New submission from Josh Purvis: This bug manifest itself in at least one very specific situation: 1. No locale is set on the machine 2. A file (test1.py) imports a second (test2.py) 3. The second file (test2.py) calls str.encode() from inside a thread 4. Running Python 2.7 [Env

[issue23551] IDLE to provide menu link to PIP gui.

Terry J. Reedy added the comment: It is possible that some institution might block or remove a pip install. IDLE should check for the presence of pip itself before adding the menu entry. -- ___ Python tracker ___

[issue27051] Create PIP gui

Terry J. Reedy added the comment: Upendra: you own the code you are writing. Are you willing to create and maintain for some time a PyPI project? If so, Nick, Donald, or someone should be willing and able to help. If you do so, please make someone a backup co-owner, to make it less likely th

[issue24137] Force not using _default_root in IDLE

Terry J. Reedy added the comment: Using Rietveld to make a 1-2 diff for each file, it appears you made 3 changes. I incorporated 2, and missed 1 (which you just pushed). I believe I incorporated your changes by hand because I had already made additional changes myself. I suspect that at that

[issue27051] Create PIP gui

Terry J. Reedy added the comment: Our messages crossed. See msg269266 for fuller response. -- ___ Python tracker ___ ___ Python-bugs-

[issue23551] IDLE to provide menu link to PIP gui.

Terry J. Reedy added the comment: Nick, in answer to msg269259, see last two messages above. The commit would be here and I would want your review before committing. > always using a "--user" install if it doesn't detect an active virtual > environment) I will look up what --user does. You w

[issue27051] Create PIP gui

Nick Coghlan added the comment: Right, I think we need to separate two questions here: 1. Making a GUI for pip available *at all*. At the moment, there isn't really one, so even if instructors want to offer one, they can't without writing it first. That's a reported PyPA issue here: https://g

[issue27051] Create PIP gui

Nick Coghlan added the comment: As far as the security questions go, yes, this is one of the benefits of education focused stributions like the Raspbian used on the Raspberry Pi - they can make extra packages available without introducing kids to the idea of downloading and running arbitrary c

[issue27363] Complex with negative zero imaginary part

Vedran Čačić added the comment: Yes, but IMO that's a separate issue. And if complex analysis has taught me anything, it's that the sign of zero of .imag is much more important than the sign of zero of .real part (most elementary functions have branch cuts along real axis, where sign of .imag

[issue27388] IDLE configdialog: reduce multiple references to Var names

New submission from Terry J. Reedy: ConfigDialog uses nearl 20 tkinter Vars, and I expect to add more. The name of each appears in at least 6 places. In one of 'create tab frame' methods: 1. create the Var 2. use the Var with at least 1 tk widget In AttachVarCallbacks method: 3, 4. attach trac

[issue22115] Add new methods to trace Tkinter variables

Terry J. Reedy added the comment: What's New: patchcheck found trailing whitespace to remove; it contains some additions that appear to belong to another issue. configdialog change looks good and dialog still works. I am expecting to add more Vars sometime soon, though probably not in the next

[issue23551] IDLE to provide menu link to PIP gui.

Nick Coghlan added the comment: Virtual environments don't provide any sandboxing, they just let you isolate different dependency sets from each other when switching between working on different applications. If you're inside a venv, you'll see either: sys.prefix != sys.base_prefix (venv

[issue27389] When a TypeError is raised due to invalid arguments to a method, it should use __qualname__ to identify the class the method is in

New submission from Steven Barker: When a method is called with incorrect arguments (too many or too few, for instance), a TypeError is raised. The message in the TypeError generally of the form: foo() takes 2 positional arguments but 3 were given I think the message should include the cl

[issue22079] Ensure in PyType_Ready() that base class of static type is static

Xiang Zhang added the comment: Of course, I know it. But doesn't the local variable `bases` refer to mro[1]? [1] https://hg.python.org/cpython/file/tip/Objects/typeobject.c#l4900 -- ___ Python tracker

[issue22115] Add new methods to trace Tkinter variables

Serhiy Storchaka added the comment: Maybe omit the mention of the array mode since it can't be used with variables created with Tkinter wrapper? -- ___ Python tracker ___ __

[issue27387] Thread hangs on str.encode() when locale is not set

Changes by Serhiy Storchaka : -- nosy: +brett.cannon, eric.snow, ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue22115] Add new methods to trace Tkinter variables

Terry J. Reedy added the comment: Good idea. Anyone who knows enough to create one by calling into tcl, assuming that is possible, should know that the methods apply. Everyone else, like me, will just be confused. -- ___ Python tracker

[issue22079] Ensure in PyType_Ready() that base class of static type is static

Serhiy Storchaka added the comment: Good point! tp_bases should be iterated instead of tp_mro in this check. -- resolution: fixed -> stage: resolved -> patch review status: closed -> open Added file: http://bugs.python.org/file43541/issue22079-tp_bases.patch ___

[issue22079] Ensure in PyType_Ready() that base class of static type is static

Xiang Zhang added the comment: I thought that too at first. But if we use __bases__, can we still guarantee that 'all bases of statically allocated type should be statically allocated'? How about its grand bases? Is it possible that a statically allocated type inherit a dynamic type but does n

[issue22115] Add new methods to trace Tkinter variables

Roundup Robot added the comment: New changeset a201180c0f77 by Serhiy Storchaka in branch 'default': Issue #22115: Added methods trace_add, trace_remove and trace_info in the https://hg.python.org/cpython/rev/a201180c0f77 -- nosy: +python-dev ___ Pyth