Berker Peksag added the comment: Thanks for the updated patch. Some comments from a quick review:
* We need tests for the TypeError branches in both methods * + 'of type %s' % type(other) type(other) -> type(other).__name__ * You can drop the XXX part in +XXX Instances of * Perhaps code duplication mentioned by SilentGhost can be eliminated by using the operator module ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue20825> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
