, the storage
will be added without error.
Signed-off-by: Philipp Hufnagl
---
src/PVE/Storage/PBSPlugin.pm | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Storage/PBSPlugin.pm b/src/PVE/Storage/PBSPlugin.pm
index 4320974..aceb2c4 100644
--- a/src
On 11/15/23 09:31, Fiona Ebner wrote:
> Am 14.11.23 um 15:27 schrieb Philipp Hufnagl:
>> Currently, when adding a PBS storage with a namespace that does not
>> exist, the storage gets added normally, but browsing/using it only
>> returns a cryptic error message.
>>
&
On 11/15/23 10:52, Thomas Lamprecht wrote:
> Am 15/11/2023 um 10:37 schrieb Philipp Hufnagl:
>> On 11/15/23 09:31, Fiona Ebner wrote:
>>> Am 14.11.23 um 15:27 schrieb Philipp Hufnagl:
>>>> diff --git a/src/PVE/Storage/PBSPlugin.pm b/src/PVE/Storage/PBSPlugin.
On 11/15/23 11:09, Thomas Lamprecht wrote:
> Am 15/11/2023 um 11:05 schrieb Philipp Hufnagl:
>>
>>
>> On 11/15/23 10:52, Thomas Lamprecht wrote:
>>> Am 15/11/2023 um 10:37 schrieb Philipp Hufnagl:
>>>> On 11/15/23 09:31, Fiona Ebner wrote:
>>
Because it is needed later in this patch series, the method
pbs_api_connect is moved earlyer in the code
Signed-off-by: Philipp Hufnagl
---
src/PVE/Storage/PBSPlugin.pm | 63 ++--
1 file changed, 32 insertions(+), 31 deletions(-)
diff --git a/src/PVE/Storage
not, it will create a new
one.
Signed-off-by: Philipp Hufnagl
---
src/PVE/Storage/PBSPlugin.pm | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/PVE/Storage/PBSPlugin.pm b/src/PVE/Storage/PBSPlugin.pm
index 96373a4..81df21e 100644
--- a/src/PVE/Storage/PBSPlugin.pm
+++ b
Parts contained in activate_storage are needed to be run to fix #5008,
however, implementing a namespace check there would cause unneded
overhead.
Therfore, this patch extracts the method check_datastore_exists from
activate storage.
Signed-off-by: Philipp Hufnagl
---
src/PVE/Storage
functionallity to check namespaces is added with this commit. For
checking the datastore, existing code that has previously been
refactored will be reused
Signed-off-by: Philipp Hufnagl
---
src/PVE/Storage/PBSPlugin.pm | 43 +++-
1 file changed, 42 insertions(+), 1
, the storage
will be added without error.
This is done by adding code to check if the namespace exists and call it
as well as existing code to check if a datastore exists on the add and
update hooks of the PBS datastore.
Signed-off-by: Philipp Hufnagl
---
Changes since v1:
* do not add any
not, it will create a new
one.
Signed-off-by: Philipp Hufnagl
---
src/PVE/Storage/PBSPlugin.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/PVE/Storage/PBSPlugin.pm b/src/PVE/Storage/PBSPlugin.pm
index 96373a4..b4d7914 100644
--- a/src/PVE/Storage/PBSPlugin.pm
+++ b
, the storage
will be added without error.
This is done by adding code to check if the namespace exists and call it
as well as existing code to check if a datastore exists on the add and
update hooks of the PBS datastore.
Signed-off-by: Philipp Hufnagl
---
Changes since v2:
* Typos
* reuse
Parts contained in activate_storage are needed to be run to fix #5008,
however, implementing a namespace check there would cause unneeded
overhead.
Therefore, this patch extracts the method check_datastore_exists from
activate storage.
Signed-off-by: Philipp Hufnagl
---
src/PVE/Storage
Because it is needed later in this patch series, the method
pbs_api_connect is moved earlyer in the code
Signed-off-by: Philipp Hufnagl
---
src/PVE/Storage/PBSPlugin.pm | 63 ++--
1 file changed, 32 insertions(+), 31 deletions(-)
diff --git a/src/PVE/Storage
functionallity to check namespaces is added with this commit. For
checking the datastore, existing code that has previously been
refactored will be reused
Signed-off-by: Philipp Hufnagl
---
src/PVE/Storage/PBSPlugin.pm | 41
1 file changed, 41 insertions(+)
diff
On 11/16/23 10:57, Fiona Ebner wrote:
> Am 15.11.23 um 17:00 schrieb Philipp Hufnagl:
>> @@ -831,10 +855,27 @@ sub check_datastore_exists {
>> return 1;
>> }
>> }
>> -
>> die "$storeid: Cannot find datastore '$d
On 11/16/23 14:55, Dominik Csapak wrote:
> to compare nested hashes/lists and scalar values recursively.
> Also includes some tests
>
> Signed-off-by: Dominik Csapak
> ---
> new in v3, split out from section config
> changes to the is_deeply function:
> * incorporate thomas suggestions
> * fix
I think you made a mistake when sending this patch.
There are only one 3 out of 4 files attached and
[pve-devel] [PATCH access-control 2/2] pools: record parent/subpool
information
appears to be double.
___
pve-devel mailing list
pve-devel@lists.prox
e,
> + renderer: function(record) {
> + return Proxmox.Utils.render_size_usage(record.used,
> record.total, true);
> + },
> },
> {
> iconCls: 'fa fa-fw fa-refresh',
LGTM
Tested-by: Philipp Hufnagl
Reviewed-by: Phi
7; + gettext('HD space'),
> valueField: 'rootfs',
> maxField: 'rootfs',
> - renderer: Proxmox.Utils.render_node_size_usage,
> + renderer: ({ used, total }) =>
> Proxmox.Utils.render_size_usage(used, total
The build in mail-to-root target can be disabled but not be deleted.
Is this on purpose?
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
On 11/21/23 13:23, Lukas Wagner wrote:
> This selector allows one to selected between the 'old' (send email
> directly via sendmail) or the 'new' notification system.
>
> The default is 'auto', which sends and email if one is configured,
> and uses the notification system if no email address is
On 11/21/23 13:16, Christian Ebner wrote:
>> On 16.11.2023 11:35 CET Philipp Hufnagl wrote:
>>
>>
>> Currently, when adding a PBS storage with a namespace that does not
>> exist, the storage gets added normally, but browsing/using it only
>> returns a cryp
On 11/21/23 13:52, Lukas Wagner wrote:
> This patch series adds the 'notification-mode' setting for backup jobs.
> It allows users to choose between the 'old-style' notifications
> (mail to configured address, directly via a call to sendmail) or
> the 'new-style' notification system.
>
> noti
On 11/21/23 14:40, Christian Ebner wrote:
>
>> On 21.11.2023 14:12 CET Philipp Hufnagl wrote:
>>
>>
>> Hmmm... thats very curios. I tried that on my end and it worked fine.
>>
>> What datastore did you try to delete? Did you have a valid
>> config
Because it is needed later in this patch series, the method
pbs_api_connect is moved earlyer in the code
Signed-off-by: Philipp Hufnagl
---
src/PVE/Storage/PBSPlugin.pm | 63 ++--
1 file changed, 32 insertions(+), 31 deletions(-)
diff --git a/src/PVE/Storage
pretty sure that this modification does not break anything, however
a second look would be appreciated!
Signed-off-by: Philipp Hufnagl
---
Changes since v3:
* Modify src/PVE/API2/Storage/Config.pm to add server address
Changes since v2:
* Typos
* reuse connecton on one more place previously
Parts contained in activate_storage are needed to be run to fix #5008,
however, implementing a namespace check there would cause unneeded
overhead.
Therefore, this patch extracts the method check_datastore_exists from
activate storage.
Signed-off-by: Philipp Hufnagl
---
src/PVE/Storage
: Philipp Hufnagl
---
src/PVE/API2/Storage/Config.pm | 4 ++--
src/PVE/Storage/PBSPlugin.pm | 41 ++
2 files changed, 43 insertions(+), 2 deletions(-)
diff --git a/src/PVE/API2/Storage/Config.pm b/src/PVE/API2/Storage/Config.pm
index e04b6ab..651d4bc 100755
--- a
not, it will create a new
one.
Signed-off-by: Philipp Hufnagl
---
src/PVE/Storage/PBSPlugin.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/PVE/Storage/PBSPlugin.pm b/src/PVE/Storage/PBSPlugin.pm
index 96373a4..b4d7914 100644
--- a/src/PVE/Storage/PBSPlugin.pm
+++ b
Signed-off-by: Philipp Hufnagl
---
pvesm.adoc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pvesm.adoc b/pvesm.adoc
index 49eb972..d6da5f4 100644
--- a/pvesm.adoc
+++ b/pvesm.adoc
@@ -370,11 +370,11 @@ List volumes allocated by VMID
List iso images
- pvesm list
Currently there is a bug that you only can install < 8gb when you NOT
accept the warning. This is wrong. A user should have to accept the
warning to install on small systems
Signed-off-by: Philipp Hufnagl
---
Proxmox/Sys/Block.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
There is an error in this example. The .conf has to be moved in the
quemu-server folder of the new node for the migration to work.
Signed-off-by: Philipp Hufnagl
---
pmxcfs.adoc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pmxcfs.adoc b/pmxcfs.adoc
index ca4e327..f4aa847
-off-by: Philipp Hufnagl
---
src/PVE/CLI/pct.pm | 4 ++--
src/PVE/LXC.pm | 32 +---
2 files changed, 31 insertions(+), 5 deletions(-)
diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm
index ff75d33..e531b27 100755
--- a/src/PVE/CLI/pct.pm
+++ b/src/PVE/CLI/pct.pm
#4765
Signed-off-by: Philipp Hufnagl
---
src/PVE/CLI/pct.pm | 4 ++--
src/PVE/LXC.pm | 32 +---
2 files changed, 31 insertions(+), 5 deletions(-)
diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm
index ff75d33..e531b27 100755
--- a/src/PVE/CLI/pct.pm
+++ b/src
Sorry forgott to tag as v2
On 7/18/23 13:58, Philipp Hufnagl wrote:
When called from the command line, it was not possible to calculate
cpu load because there was no 2nd data point available for the
calculation. Now (when called) from the command line, cpu stats will
be fetched twice
Hello
On 7/18/23 15:02, Thomas Lamprecht wrote:
Am 18/07/2023 um 14:00 schrieb Philipp Hufnagl:
Sorry forgott to tag as v2
and also forgot to document the patch changelog like asked yesterday..
Sorry. I did not know that. I will add a changelog
On 7/18/23 13:58, Philipp Hufnagl wrote
Many web pages offer the download of the disk images compressed. This
patch allows the download of archives (like .gz), automatically detects
the format and decompresses it
pve-storage:
Philipp Hufnagl (2):
fix #4849: download-url: allow download and decompression of
compressed ISOs
clean
Signed-off-by: Philipp Hufnagl
---
src/PVE/API2/Storage/Status.pm | 20 ++--
src/PVE/Storage.pm | 22 ++
2 files changed, 40 insertions(+), 2 deletions(-)
diff --git a/src/PVE/API2/Storage/Status.pm b/src/PVE/API2/Storage/Status.pm
index e4ce698
Signed-off-by: Philipp Hufnagl
---
PVE/API2/Nodes.pm | 21 -
www/manager6/Makefile | 1 +
www/manager6/form/DecompressionSelector.js | 14 +++
www/manager6/window/DownloadUrlToStorage.js | 26 +++--
4 files
removed Data::Dumper and a newline
Signed-off-by: Philipp Hufnagl
---
src/PVE/API2/Storage/Status.pm | 18 +--
src/PVE/Storage.pm | 55 +-
src/PVE/Storage/Plugin.pm | 3 +-
3 files changed, 37 insertions(+), 39 deletions(-)
diff --git a
Signed-off-by: Philipp Hufnagl
---
src/PVE/Tools.pm | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
index 9ffac12..d9869e8 100644
--- a/src/PVE/Tools.pm
+++ b/src/PVE/Tools.pm
@@ -2059,6 +2059,15 @@ sub download_file_from_url {
}
print
Many web pages offer the download of the disk images compressed. This
patch allows the download of archives (like .gz), automatically detects
the format and decompresses it
Philipp Hufnagl (1):
fix #4849: download-url: allow download and decompression of
compressed ISOs
src/PVE/API2
Signed-off-by: Philipp Hufnagl
---
src/PVE/API2/Storage/Status.pm | 22 +++---
src/PVE/Storage.pm | 6 ++
2 files changed, 25 insertions(+), 3 deletions(-)
diff --git a/src/PVE/API2/Storage/Status.pm b/src/PVE/API2/Storage/Status.pm
index 2aaeff6..a087c53 100644
Signed-off-by: Philipp Hufnagl
---
PVE/API2/Nodes.pm | 21 -
www/manager6/Makefile | 1 +
www/manager6/form/DecompressionSelector.js | 14 ++
www/manager6/window/DownloadUrlToStorage.js | 21
v1:
* Improve code quality as suggested by feedback
Philipp Hufnagl (1):
fix #4849: download-url: allow download and decompression of
compressed ISOs
src/PVE/API2/Storage/Status.pm | 17 +++--
src/PVE/Storage.pm | 6 ++
2 files changed, 21 insertions(+), 2
Signed-off-by: Philipp Hufnagl
---
src/PVE/Tools.pm | 59 +++-
1 file changed, 38 insertions(+), 21 deletions(-)
diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
index 9ffac12..ab97129 100644
--- a/src/PVE/Tools.pm
+++ b/src/PVE/Tools.pm
@@ -92,23
Signed-off-by: Philipp Hufnagl
---
PVE/API2/Nodes.pm | 21 -
www/manager6/Makefile | 1 +
www/manager6/form/DecompressionSelector.js | 14 ++
www/manager6/window/DownloadUrlToStorage.js | 21
Signed-off-by: Philipp Hufnagl
---
src/PVE/API2/Storage/Status.pm | 17 +++--
src/PVE/Storage.pm | 6 ++
2 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/src/PVE/API2/Storage/Status.pm b/src/PVE/API2/Storage/Status.pm
index 2aaeff6..1d73c96 100644
Signed-off-by: Philipp Hufnagl
---
src/PVE/API2/Storage/Status.pm | 14 +-
src/PVE/Storage.pm | 6 ++
src/PVE/Storage/Plugin.pm | 3 ++-
3 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/src/PVE/API2/Storage/Status.pm b/src/PVE/API2/Storage
Signed-off-by: Philipp Hufnagl
---
PVE/API2/Nodes.pm | 16
www/manager6/window/DownloadUrlToStorage.js | 4 ++--
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
index 2bae4e6f..6fa138fb 100644
Signed-off-by: Philipp Hufnagl
---
PVE/API2/Nodes.pm | 21 -
www/manager6/Makefile | 1 +
www/manager6/form/DecompressionSelector.js | 13 +
www/manager6/window/DownloadUrlToStorage.js | 17 +
4
Signed-off-by: Philipp Hufnagl
---
src/PVE/Tools.pm | 31 +--
1 file changed, 25 insertions(+), 6 deletions(-)
diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
index 9ffac12..159ec82 100644
--- a/src/PVE/Tools.pm
+++ b/src/PVE/Tools.pm
@@ -2013,10 +2013,13 @@ sub
Signed-off-by: Philipp Hufnagl
---
src/PVE/Storage/Plugin.pm | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
index 18cb5d5..1795ae3 100644
--- a/src/PVE/Storage/Plugin.pm
+++ b/src/PVE/Storage
Changes since v3:
* generate compression regex from compression list
* fix logic errors
Changes since v2:
* move compression code to the download function in common
* minor code improvements
Changes since v1:
* Improve code quality as suggested by feedback
Philipp Hufnagl (2):
fix
Signed-off-by: Philipp Hufnagl
---
src/PVE/Tools.pm | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
index 159ec82..28e70f0 100644
--- a/src/PVE/Tools.pm
+++ b/src/PVE/Tools.pm
@@ -92,23 +92,23 @@ our
between pools, guarded by a checkbox from accidental
transfers
Signed-off-by: Philipp Hufnagl
---
PVE/API2/Pool.pm | 19 +--
www/manager6/grid/PoolMembers.js | 17 ++---
2 files changed, 31 insertions(+), 5 deletions(-)
diff --git a/PVE/API2/Pool.pm b/PVE
extend the download_url function with the capabillity to handle
compression
add decopressor info for images
build compression algorithm regex dynamically to avoid duplication
Signed-off-by: Philipp Hufnagl
---
src/PVE/API2/Storage/Status.pm | 14 +-
src/PVE/Storage.pm
list
* fix logic errors
Changes since v2:
* move compression code to the download function in common
* minor code improvements
Changes since v1:
* Improve code quality as suggested by feedback
Philipp Hufnagl (1):
fix #4849: download-url: allow download and decompression of
compressed
ically set in
the UI
Signed-off-by: Philipp Hufnagl
---
PVE/API2/Nodes.pm | 21 -
www/manager6/Makefile | 1 +
www/manager6/form/DecompressionSelector.js | 13 +
www/manager6/window/DownloadUrlToStora
On 8/9/23 13:32, Fiona Ebner wrote:
The permission for the original pool should be checked here?! Or is
that already done somewhere?
The permission of the original pool does not matter. The permission of
the VM is important
(maybe the original pool granting the user permission on the VM).
H
between pools, guarded by a checkbox from accidental
transfers
This is the patch for the backend changes
Signed-off-by: Philipp Hufnagl
---
PVE/API2/Pool.pm | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/PVE/API2/Pool.pm b/PVE/API2/Pool.pm
index 007fc815
between pools, guarded by a checkbox from accidental
transfers
Philipp Hufnagl (2):
fix #474: backend allow transfer from container/vms
fix #474: backend allow transfer from container/vms
PVE/API2/Pool.pm | 15 +--
www/manager6/grid/PoolMembers.js | 17
between pools, guarded by a checkbox from accidental
transfers
This is the patch for the frontend changes
Signed-off-by: Philipp Hufnagl
---
www/manager6/grid/PoolMembers.js | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/www/manager6/grid/PoolMembers.js b
between pools, guarded by a checkbox from accidental
transfers
This is the patch for the backend changes
Signed-off-by: Philipp Hufnagl
---
PVE/API2/Pool.pm | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/PVE/API2/Pool.pm b/PVE/API2/Pool.pm
index 007fc815
between pools, guarded by a checkbox from accidental
transfers
This is the patch for the frontend changes
Signed-off-by: Philipp Hufnagl
---
www/manager6/grid/PoolMembers.js | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/www/manager6/grid/PoolMembers.js b
privileges of the pool member for this vm/contianer. This feature introduces
a way to transfer a vm between pools, guarded by a checkbox from accidental
transfers
Philipp Hufnagl (2):
fix #474: backend allow transfer from container/vms
fix #474: backend allow transfer from container/vms
PVE/API2
On 8/10/23 09:16, Fiona Ebner wrote:
But it should. After all, the operation is modifying the original pool,
so the user better have an appropriate permission to do so.
Currently, Permissions.Modify|VM.Allocate on the VM and Pool.Allocate on
the target pool would be enough to "steal" the gue
When the newly introduced optional parameter "transfer" is set, the user
add a vm/container to a pool even if it is already in one. If so it will
be removed from the old pool
Signed-off-by: Philipp Hufnagl
---
PVE/API2/Pool.pm | 16 ++--
1 file changed, 14 insertions(+), 2
between pools, guarded by a checkbox from accidental
transfers
changes to v4:
* check for allocate permissions of the originating pool
changes to v3:
* fix subject typo
* at version log
changes to v2:
* split patch in front and backend
Philipp Hufnagl (2):
fix #474: api: allow transfer from
A user can no see all vms/containers, even the ones that are already a
member of a pool. They can be transfered now after checking the newly
introduced "allow transfer" checkbox.
Signed-off-by: Philipp Hufnagl
---
www/manager6/grid/PoolMembers.js | 17 ++---
1 file c
extends the query_url_metadata callback with the functionallity to
detect used compressions. If a compression is used it tells the ui which
one
Signed-off-by: Philipp Hufnagl
---
PVE/API2/Nodes.pm | 20
1 file changed, 20 insertions(+)
diff --git a/PVE/API2/Nodes.pm b/PVE
Philipp Hufnagl (2):
fix #4849: api: download to storage: automatically dectect and
configure compression
fix #4849: ui: download to storage: automatically dectect and
configure compression
PVE/API2/Nodes.pm | 20
www/manager6/Makefile
extends the download iso prompt with a "compression algorithm" drop down
under advanced. User can configure there if a decompression algorithm
should be used from the storage backend. The compression algorithm will
be automatically guessed when calling query_url_metadata
Signed-off-b
adds information for how to decompress isos.
generates the compressor regex from a list of comression formats (to
avoid redundancy)
extends the download_url wtih the functionality to handley compression
for images
Signed-off-by: Philipp Hufnagl
---
src/PVE/API2/Storage/Status.pm | 14
On 8/14/23 12:42, Dominik Csapak wrote:
On 8/14/23 12:36, Wolfgang Bumiller wrote:
applied, thanks
@Dominik: does extjs have an 'enableFn' for rows in a grid?
IMO we should either disable the ones with pools when the transfer
checkbox is not checked, or hide them (but when hiding them after
al
On 8/24/23 16:46, Thomas Lamprecht wrote:
Am 14/08/2023 um 12:42 schrieb Dominik Csapak:
On 8/14/23 12:36, Wolfgang Bumiller wrote:
applied, thanks
@Dominik: does extjs have an 'enableFn' for rows in a grid?
IMO we should either disable the ones with pools when the transfer
checkbox is not che
On 8/30/23 16:29, Dominik Csapak wrote:
On 8/30/23 14:43, Philipp Hufnagl wrote:
On 8/14/23 12:42, Dominik Csapak wrote:
On 8/14/23 12:36, Wolfgang Bumiller wrote:
applied, thanks
@Dominik: does extjs have an 'enableFn' for rows in a grid?
IMO we should either disable the ones
grate". However and API change would break already implemented usage
and so it has been decided to call it (for now) transfer everywhere to
avoid confusion
Signed-off-by: Philipp Hufnagl
---
www/manager6/grid/PoolMembers.js | 29 ++---
1 file changed, 22 insert
On 9/6/23 11:18, Thomas Lamprecht wrote:
subject is quite confusing, this isn't for what's commonly understood
w.r.t. the "VM/CT migration", i.e., live migration to another host.
You at least need to use the word "pool" somewhere..
Am 05/09/2023 um 15:51 schri
grate". However and API change would break already implemented usage
and so it has been decided to call it (for now) transfer everywhere to
Signed-off-by: Philipp Hufnagl
modified: www/manager6/grid/PoolMembers.js
---
www/manager6/grid/PoolMembers.js | 26 +++---
Please dont merge. It appers i made an error at testing
On 9/8/23 13:56, Philipp Hufnagl wrote:
After the implementation of fix #474, it has been suggested that
instead of requiring the user to click a checkbox allowing migration,
it should be allowed automatically and and a warning should be
grate". However and API change would break already implemented usage
and so it has been decided to call it (for now) transfer everywhere to
Signed-off-by: Philipp Hufnagl
---
www/manager6/grid/PoolMembers.js | 26 +++---
1 file changed, 19 insertions(+), 7 deletions(
extends the query_url_metadata callback with the functionallity to
detect used compressions. If a compression is used it tells the ui which
one
Signed-off-by: Philipp Hufnagl
---
PVE/API2/Nodes.pm | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/PVE/API2
extends the download iso prompt with a "compression algorithm" drop down
under advanced. User can configure there if a decompression algorithm
should be used from the storage backend. The compression algorithm will
be automatically guessed when calling query_url_metadata
Signed-off-b
common
* minor code improvements
Changes since v1:
* Improve code quality as suggested by feedback
Philipp Hufnagl (2):
fix #4849: api: download to storage: automatically dectect and
configure compression
fix #4849: ui: download to storage: automatically dectect and
configure
On 9/20/23 14:09, Fabian Grünbichler wrote:
On September 20, 2023 1:50 pm, Dominik Csapak wrote:
On 9/20/23 13:46, Fabian Grünbichler wrote:
On September 20, 2023 1:07 pm, Dominik Csapak wrote:
LGTM and works as advertised.
it breaks downloading container templates that are compressed with on
extends the query_url_metadata callback with the functionallity to
detect used compressions. If a compression is used it tells the ui which
one
Signed-off-by: Philipp Hufnagl
---
PVE/API2/Nodes.pm | 22 +-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/PVE
improvements
Changes since v1:
* Improve code quality as suggested by feedback
Philipp Hufnagl (2):
fix #4849: api: download to storage: automatically dectect and
configure compression
fix #4849: ui: download to storage: automatically dectect and
configure compression
PVE/API2
extends the download iso prompt with a "compression algorithm" drop down
under advanced. User can configure there if a decompression algorithm
should be used from the storage backend. The compression algorithm will
be automatically guessed when calling query_url_metadata
Signed-off-b
-off-by: Philipp Hufnagl
---
www/manager6/Workspace.js | 28
1 file changed, 28 insertions(+)
diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js
index 18d574b7..9d166493 100644
--- a/www/manager6/Workspace.js
+++ b/www/manager6/Workspace.js
@@ -42,6
Adds a new css class to underlay information urgency in table columns
for dark and light mode. This underlay color then is used to notifiy
user administrators about user accounts that will expire soon
Signed-off-by: Philipp Hufnagl
---
src/Utils.js| 6
When an user experation date is send with the /accesss/tickets POST API
call, it will be stored in a global variable like the username
Signed-off-by: Philipp Hufnagl
---
src/Utils.js| 3 +++
src/proxmox-dark/scss/abstracts/_variables.scss | 1 +
src/proxmox
Adds an additional, optional parameter to the access/tickets api call
which tells when the currently used user account will expire. If it will
not expire, the parameter will not be added.
Signed-off-by: Philipp Hufnagl
---
src/PVE/API2/AccessControl.pm | 8
src/PVE/AccessControl.pm
adds in this case a new entry briefly saing that the account
expires. When this entry is clicked it states this in more detail
including the experation date.
Sending this for PVE only now to get feedback before implementing this
for PMG and PBS
Philipp Hufnagl (1):
fix #4546: ui: notify user if
ple
> string regex match to the backend seems rather odd to me..
The problem with that is that the point where the iso is stored might
not be accessible for the client. If it is done by the PVE, it might
resolve the url differently.
>
> Am 21/09/2023 um 15:09 schrieb Philipp Hu
On 9/26/23 12:59, Thomas Lamprecht wrote:
> Am 21/09/2023 um 15:09 schrieb Philipp Hufnagl:
>> extends the download iso prompt with a "compression algorithm" drop down
>> under advanced. User can configure there if a decompression algorithm
>> should be use
On 9/26/23 16:23, Thomas Lamprecht wrote:
> Am 26/09/2023 um 14:25 schrieb Philipp Hufnagl:
>> On 9/26/23 12:56, Thomas Lamprecht wrote:
>>> while this is already applied, some comments inline, for a possible next
>>> time, and also the big
>>> question if th
> There are code paths where $filename is not yet defined here, resulting
> in a rather ugly warning – so this needs upfront checking too – always
> check where the value code path is coming in (yeah, Rust would do that for
> you, but most API endpoints are small enough to be able to do so quickly
On 9/27/23 10:33, Thomas Lamprecht wrote:
> Am 27/09/2023 um 10:03 schrieb Philipp Hufnagl:
>>> There are code paths where $filename is not yet defined here, resulting
>>> in a rather ugly warning – so this needs upfront checking too – always
>>> check where the valu
When there is no comment for a backup group, the comment of the last
snapshot in this group will be shown slightly grayed out as long as
the group is collapsed.
Signed-off-by: Philipp Hufnagl
---
www/css/ext6-pbs.css | 3 +++
www/datastore/Content.js | 17 ++---
2 files changed
1 - 100 of 110 matches
Mail list logo
