On 9/20/23 14:09, Fabian Grünbichler wrote:
On September 20, 2023 1:50 pm, Dominik Csapak wrote:
On 9/20/23 13:46, Fabian Grünbichler wrote:
On September 20, 2023 1:07 pm, Dominik Csapak wrote:
LGTM and works as advertised.
it breaks downloading container templates that are compressed with one
of the "known" compression algorithms (such as gz).
probably the detect-compression parameter and handling needs to go back
in (that was the reason it was there in the first place!), or some other
solution needs to be found..
ah yes ofc, sorry for the oversight
couldn't we simply check in the backend for the download for the content type?
as we only really need to unpack isos?
the "query url" part doesn't know about (storage) content types. and it
returns the file name, so we can't let it detect compression but throw
that part away, else we get the uncompressed filename instead of the
compressed one (exactly what happens with v7 now).
that's why we originally made the client/GUI make the choice:
iso download dialogue:
- query url with compression support
- allow overriding (de)compression
- pass (de)compression to download if set
other download dialogues (currently only templates):
- query url without compression support
- don't offer (de)compression choice
- (de)compression is never set, thus never passed to download
in addition, the download backend (which knows about content types) also
only allows decompression for isos (at least for the time being, if we
ever revisit and allow plain container template archives then all of
this is moot anyway ;))
Thank you for reviewing this! I will make a v8 very soon featuring
detect_compression again!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
