Is there anything else missing on my end? The patch still applies.
Maximiliano Sandoval writes:
> Continuation of ab70343982f36a5343d3fcf4a1a6489bd3f52a66. Discussion at
> https://lists.proxmox.com/pipermail/pve-devel/2023-September/059013.html.
>
--
Ma
Tested on a new Proxmox VE 8 cluster. The mclock scheduler settings do
not appear in `ceph config dump` after removing the OSD using the web
UI. Removing a OSD without this setting being set does not cause any
issue either.
Tested-by: Maximiliano Sandoval
Aaron Lauterer writes:
> Ceph d
config set X value`. The values in ceph.conf indeed take
priority as per the commit message. When the values are not present in
ceph.conf, the values from the config DB take preference over the 3/2
default as expected.
Tested-by: Maximiliano Sandoval
Aaron Lauterer writes:
> The main goal of t
master
Maximiliano Sandoval (7):
gui: move create_basic_grid subroutine definition up
gui: expand ip address Gtk3::Entry
gui: use basic grid in password panel
gui: use basic grid in country/timezone panel
gui: change margins in create_basic_grid
gui: use basic grid in the network panel
d to use a grid.
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/proxinstall b/proxinstall
index bdff22d..87e81fd 100755
--- a/proxinstall
+++ b/proxinstall
@@ -332,10 +332,10 @@ my $create_basic_grid = sub {
This will be used in future commits to create grids so we need it to be defined.
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/proxinstall b/proxinstall
index 01d4cfe..8f40234 100755
--- a
Using boxes causes the labels to not align correctly in certain
circumstances. In the following commits we replace the use of boxes with
grids and set the margins and spacing directly on the respective grid.
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 52
This accounts for the different layout set in the previous commit.
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxinstall b/proxinstall
index 8f40234..a5de06c 100755
--- a/proxinstall
+++ b/proxinstall
@@ -308,7 +308,7
The extra 10px margin on the email row was added to account for the
removed line:
$vbox->pack_start($hbox3, 0, 0, 15);
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 29 +++--
1 file changed, 11 insertions(+), 18 deletions(-)
diff --git a/proxinstal
For consistency sake, all colons and trailing spaces in labels that were
followed with an entry were removed, this matches other panels such as
the password and country/timezone panels.
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 12 ++--
1 file changed, 6 insertions(+), 6
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 34 --
1 file changed, 12 insertions(+), 22 deletions(-)
diff --git a/proxinstall b/proxinstall
index 69c48b4..bdff22d 100755
--- a/proxinstall
+++ b/proxinstall
@@ -648,12 +648,12 @@ sub update_layout {
my
Signed-off-by: Maximiliano Sandoval
---
www/manager6/ceph/CephInstallWizard.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/ceph/CephInstallWizard.js
b/www/manager6/ceph/CephInstallWizard.js
index f33ae868..3342a80f 100644
--- a/www/manager6/ceph
Signed-off-by: Maximiliano Sandoval
---
www/manager6/ceph/CephInstallWizard.js | 6 +++---
www/manager6/storage/RBDEdit.js| 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/www/manager6/ceph/CephInstallWizard.js
b/www/manager6/ceph/CephInstallWizard.js
index f33ae868
The autoscaler is well-known Ceph concept. A translation might prefer to
use "Autoscaler" as-is in a translation.
Signed-off-by: Maximiliano Sandoval
---
www/manager6/ceph/Pool.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/ceph/Pool.js b/www/man
Signed-off-by: Maximiliano Sandoval
---
www/manager6/ceph/Pool.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js
index c61d4f71..e514518c 100644
--- a/www/manager6/ceph/Pool.js
+++ b/www/manager6/ceph/Pool.js
@@ -88,7
The autoscaler is well-known Ceph concept. A translation might prefer to use
"Autoscaler" as-is in a translation, which in turn lends itself better to a
search online.
The patch series is split into three commits since each one can be a bit more
controvertial than the last one.
M
The autoscaler is well-known Ceph concept. A translation might prefer to
use "Autoscaler" as-is in a translation.
Signed-off-by: Maximiliano Sandoval
---
www/manager6/ceph/Pool.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/ceph/Pool.js b/www/man
It would be preferable to use "won't" but I would rather err on the safe
side when it comes to escapes in gettext.
Signed-off-by: Maximiliano Sandoval
---
src/node/APTRepositories.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/node/APTRepositorie
The string `proxmox.Utils.defaultText + ' (free)'` was inlined as
`Default (Free)` cutting translatable strings makes them harder or even
impossible to translate in certain languages.
Signed-off-by: Maximiliano Sandoval
---
www/manager6/dc/UserTagAccessEdit.js | 10 +-
ww
Maximiliano Sandoval writes:
> + { flag: 'ssbd', desc: gettext('Protection for "Speculative Store
> Bypass" for Intel models') },
> + { flag: 'ibpb', desc: gettext('Allows improved Spectre mitigation
> with AMD CPUs&#
> btw. @Maximiliano: "Free" is rather a bad original text for the
Noted. Will send a v2 in a bit.
>> If its only right-to-left languages, we could just add another helper
>> to assemble lists in the correct order?
The GNOME l10n guidelines at least have an entry about not splitting
strings.
W
The string `proxmox.Utils.defaultText + ' (free)'` was inlined as `Default
(Unrestricted)` cutting translatable strings makes them harder or even
impossible to translate in certain languages. Additionally the extra context
makes the work of translators easier.
Signed-off-by: Maximilian
Note that ACME is already in 3 translatable strings, a similar remark
applies to N/A which is already translated in many languages.
Signed-off-by: Maximiliano Sandoval
---
src/node/DNSView.js | 2 +-
src/panel/ACMEDomains.js | 2 +-
src/panel/DiskList.js
Signed-off-by: Maximiliano Sandoval
---
Improvements made after going through the three web UIs.
es.po | 62 +--
sl.po | 2 +-
2 files changed, 32 insertions(+), 32 deletions(-)
diff --git a/es.po b/es.po
index 262e86c..132f82a 100644
:30 2023\n"
+"POT-Creation-Date: 2023-12-01 11:25+0100\n"
"PO-Revision-Date: 2023-11-27 16:43+0100\n"
"Last-Translator: Maximiliano Sandoval \n"
"Language-Team: Spanish\n"
```
- Extraction of strings using ngettext, pgettext, etc. Even if w
Dominik Csapak writes:
> translating ACME does not make sense to me since it's
> the name of the protocol and stands for
> Automatic Certificate Management Environment
>
> i don't think/believe this should be translated
> into other languages as a standalone word
"ACME" appears in four transla
Dominik Csapak writes:
> the translator must make sure the terms are consistent anyway...
This is the heart of the issue. The translator cannot know there are
more uses of the string if it is not marked as translatable.
--
Maximiliano
___
pve-deve
Dominik Csapak writes:
> it's more like DHCP, SLAAC or IPv4. those are names of protocols (like ACME)
> that shouldn't change across translations
>
> and we removed those gettexts (mostly) a while ago
> e.g. see lxc/Network.js in pve-manager:
>
> ---8<---
> boxLabel: 'DHCP', // do not localize
>
Note that N/A is already translatable in other places.
Signed-off-by: Maximiliano Sandoval
---
Differences from v2:
- Translate the invalid subscription key message, this string is also in two
more places in pve-manager. This will be the content of a following patch.
- Do not translate
:30 2023\n"
+"POT-Creation-Date: 2023-12-01 11:25+0100\n"
"PO-Revision-Date: 2023-11-27 16:43+0100\n"
"Last-Translator: Maximiliano Sandoval \n"
"Language-Team: Spanish\n"
```
- Extraction of strings using ngettext, pgettext, etc. Even if w
The strings were hard to translate and required some tricks like passing
'Ceph ' as an argument. The `/main` part was also removed to simplify
the flow and UX.
Suggested-by: Dietmar Maurer
Signed-off-by: Maximiliano Sandoval
---
src/node/APTRepositories.js | 20 +-
Lukas Wagner writes:
> This patch series attempts to improve the user experience when creating
> notification matchers.
I gave the web UI side of things a test, it substantially improves the
UX when setting Match Rules.
In my brief testing everything worked correctly.
Tested-by: Maxim
the old values instead of removing the corresponding line:
sendmail: test
mailto Y
mailto-user X
Tested setting both mailto and mailto-user to `` from non-nil values and
switching their values around. The patch fixes this as far as my testing
went.
Tested-by:
Tweak some string, improve others.
Signed-off-by: Maximiliano Sandoval
---
es.po | 52 +---
1 file changed, 25 insertions(+), 27 deletions(-)
diff --git a/es.po b/es.po
index 132f82a..98eb007 100644
--- a/es.po
+++ b/es.po
@@ -8,7 +8,7 @@ msgstr
int',
> + hidden: true,
> + value: gettext('No email configured, the notification system will
> be used'),
> + viewModel,
> + bind: {
> + hidden: '{!hintTextVisible}',
I think the `pmx-hint` being displayed as
Bump :)
--
Maximiliano
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
This is useful to test multipath devices which need a wwid.
We use 'e.g.' rather than 'Example', otherwise the 18 characters of the
example do not fit in the field.
Suggested-by: Friedrich Weber
Signed-off-by: Maximiliano Sandoval
---
www/manager6/qemu/HDEdit.js | 18 +
This is useful to test multipath devices which need a wwn.
We use 'e.g.' rather than 'Example', otherwise the 18 characters of the
example do not fit in the field.
Suggested-by: Friedrich Weber
Signed-off-by: Maximiliano Sandoval
---
Differences from v1:
- Use WWN rather t
Christoph Heiss writes:
> On Tue, Nov 21, 2023 at 04:10:20PM +0100, Maximiliano Sandoval wrote:
>>
>> This accounts for the different layout set in the previous commit.
>
> What commit is meant here exactly? The previous patch in this series
> (aka. the first) does
se if we reach the
branch where `operation.error.statusText` matches:
binary not installed: /usr/bin/ceph-mon
This allow us to configure this node and run `init` in the API.
Suggested-by: Mira Limbeck
Signed-off-by: Maximiliano Sandoval
---
This was found on a ticker from the support portal.
Hello Eneko Lacunza,
You are right, I found that [1] contains a document with guidelines for
translating to Spanish, capitalization is specifically mentioned at
section 8.4.1.1.
I will study the document for more venues for improvement and submit a
patch.
Thanks.
[1] https://wiki.gnome.org/Tr
Fiona Ebner writes:
> Is there a user request for this feature or other common use cases? If
> it's just for testing multipath, it's a rather niche use case and fine
> to be CLI only.
Yeah, its mostly for debugging. Probably it is niche enough to not have
it in the web UI.
--
Maximiliano
ping
Maximiliano Sandoval writes:
> We replace the use of nested boxes with grids when possible to ensure correct
> margins and alignment of widgets.
>
> At the end we also remove trailing spaces and colons from labels preceding an
> input widget, e.g. we replace `DNS Server: ` w
The default certificate does not have a name.
Reported-by: Dietmar Maurer
Signed-off-by: Maximiliano Sandoval
---
src/panel/Certificates.js | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/src/panel/Certificates.js b/src/panel/Certificates.js
index a522ab6
Signed-off-by: Maximiliano Sandoval
---
es.po | 48 +++-
1 file changed, 19 insertions(+), 29 deletions(-)
diff --git a/es.po b/es.po
index 806f2a6..1b2d7d2 100644
--- a/es.po
+++ b/es.po
@@ -8,7 +8,7 @@ msgstr ""
"Project-Id-V
ping 👻
Maximiliano Sandoval writes:
> ping
>
> Maximiliano Sandoval writes:
--
Maximiliano
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Signed-off-by: Maximiliano Sandoval
---
js/LoginView.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/js/LoginView.js b/js/LoginView.js
index 63f4099..b5da19a 100644
--- a/js/LoginView.js
+++ b/js/LoginView.js
@@ -249,6 +249,7 @@ Ext.define('PMG.Logi
_autocomplete_attribute_and_login_fields
Signed-off-by: Maximiliano Sandoval
---
www/manager6/window/LoginWindow.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/www/manager6/window/LoginWindow.js
b/www/manager6/window/LoginWindow.js
index a79f5a2a..aaeca355 100644
--- a/www/manager6/
Signed-off-by: Maximiliano Sandoval
---
src/window/TfaWindow.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/window/TfaWindow.js b/src/window/TfaWindow.js
index 3646e0e..7c6f2ee 100644
--- a/src/window/TfaWindow.js
+++ b/src/window/TfaWindow.js
@@ -374,6 +374,7 @@ Ext.define
Signed-off-by: Maximiliano Sandoval
---
www/LoginView.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/www/LoginView.js b/www/LoginView.js
index 33734f6c..d4d8e73e 100644
--- a/www/LoginView.js
+++ b/www/LoginView.js
@@ -274,6 +274,7 @@ Ext.define('PBS.Logi
I sent this twice by mistake and the commit titles are wrong. Will send
a v2.
Maximiliano Sandoval writes:
> By default they have 'autocomplete=off'. From [1]:
>
> > In most modern browsers, setting autocomplete to "off" will not
> > prevent a passwor
Signed-off-by: Maximiliano Sandoval
---
src/window/TfaWindow.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/window/TfaWindow.js b/src/window/TfaWindow.js
index 3646e0e..7c6f2ee 100644
--- a/src/window/TfaWindow.js
+++ b/src/window/TfaWindow.js
@@ -374,6 +374,7 @@ Ext.define
Signed-off-by: Maximiliano Sandoval
---
www/LoginView.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/www/LoginView.js b/www/LoginView.js
index 33734f6c..d4d8e73e 100644
--- a/www/LoginView.js
+++ b/www/LoginView.js
@@ -274,6 +274,7 @@ Ext.define('PBS.Logi
Signed-off-by: Maximiliano Sandoval
---
js/LoginView.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/js/LoginView.js b/js/LoginView.js
index 63f4099..b5da19a 100644
--- a/js/LoginView.js
+++ b/js/LoginView.js
@@ -249,6 +249,7 @@ Ext.define('PMG.Logi
_autocomplete_attribute_and_login_fields
Signed-off-by: Maximiliano Sandoval
---
Differences from v1:
- Learn how to send emails
- Fix 'fix #5251' prefix in commit titles
www/manager6/window/LoginWindow.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/www/manager6/window/Lo
ping, still applies.
Maximiliano Sandoval writes:
> ping 👻
>
> Maximiliano Sandoval writes:
>
>> ping
>>
>> Maximiliano Sandoval writes:
--
Maximiliano
___
pve-devel mailing list
pve-devel@lists.proxmox.com
htt
Some comments bellow.
Christoph Heiss writes:
> For non-PVE products, simply use the ZFS defaults (aka. 50%) and leave
> unset, if the user never touches that setting.
>
> Signed-off-by: Christoph Heiss
> ---
> ...
> ...
> +
> +# GTKs SpinButton does not support a placeholder value, unfor
Signed-off-by: Maximiliano Sandoval
---
es.po | 36 ++--
1 file changed, 14 insertions(+), 22 deletions(-)
diff --git a/es.po b/es.po
index e874206..52f47e9 100644
--- a/es.po
+++ b/es.po
@@ -8,7 +8,7 @@ msgstr ""
"Project-Id-Version: proxmox
e set using
$ ceph osd pool get target_size_ratio
after setting the valut to 0 through the API it will output
Error ENOENT: option 'target_size_ratio' is not set on pool
'cephfs-test_data'
Signed-off-by: Maximiliano Sandoval
---
www/manager6/ceph/Pool.js | 6
Fiona Ebner writes:
> It might be cleaner to just use
> emptyValue: 0,
> in the field declaration like is already done for the "Target Size"
> field. And the same issue is also present for the "Min. # of PGs" field,
> right?
Thanks for the emptyValue tip, I didn't know about it. Unfortunately, I
Fiona Ebner writes:
> IMHO, it's still succinct enough. But you could also go for "avoid
> consumer grade SSDs, whose use is discouraged."
Neither consumer or enterprise grade disks are super well defined, why
not just discourage disks without PLP.
--
Maximiliano
_
ill used at the time the snapshot was taken. Thus, and because
some exotic third party plugin might be using it for whatever reason,
it's necessary to keep passing the same value as before.
Signed-off-by: Fiona Ebner
Signed-off-by: Maximiliano Sandoval
---
This is a backport for Proxm
Lukas Wagner writes:
> - Switch order of 'mailto' and 'mailnotification' field
> - When mode is 'auto', disable 'mailtnotification' field
> - When mode is 'auto' and 'mailto' is empty, show
> hint that the notification system will be used
>
> Signed-off-by: Lukas Wagner
> ---
ping 👻
Max Carrara writes:
> Fix #4759: Configure Permissions for ceph-crash.service - Version 5
> ===
I tested this patch series on a testing cluster updated to
no-subscription with ceph-base 18.2.2-pve1. For the purposes of testing
I r
Maximiliano Sandoval writes:
> Max Carrara writes:
>
>> Fix #4759: Configure Permissions for ceph-crash.service - Version 5
>> ===
>
> I tested this patch series on a testing cluster updated to
> no-
://www.rfc-editor.org/rfc/rfc1950
Signed-off-by: Maximiliano Sandoval
---
src/PVE/APIServer/AnyEvent.pm | 23 +--
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/src/PVE/APIServer/AnyEvent.pm b/src/PVE/APIServer/AnyEvent.pm
index b60b825..a43d6bb 100644
--- a/src/PVE
listed as one of the encodings in the
`Accept-Encoding` header and the data should be compressed.
[RFC9110] https://www.rfc-editor.org/rfc/rfc9110#name-deflate-coding
[RFC1950] https://www.rfc-editor.org/rfc/rfc1950
Suggested-by: Lukas Wagner
Signed-off-by: Maximiliano Sandoval
---
Differenc
listed as one of the encodings in the
`Accept-Encoding` header and the data should be compressed.
[RFC9110] https://www.rfc-editor.org/rfc/rfc9110#name-deflate-coding
[RFC1950] https://www.rfc-editor.org/rfc/rfc1950
Suggested-by: Lukas Wagner
Tested-by: Folke Gleumes
Signed-off-by: Maximilian
It is recommended that the quiet zone has the width of 4 blocks, since
each block is around 4 pixels each, we need a margin of 16 pixels and a
size of 256 + 2 * 16 pixels.
Signed-off-by: Maximiliano Sandoval
---
src/window/AddTotp.js | 8
1 file changed, 4 insertions(+), 4 deletions
Small series of patches to drop the use of properties and methods that were
deprecated in GTK 3.
Maximiliano Sandoval (4):
stop using Gtk3::Misc->set_alignment
stop using Gtk3::HBox and Gtk3::VBox
stop using Gtk3::HSeparator
stop using Gtk3::Window->set_has_resize_grip
proxinstal
via present.
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/proxinstall b/proxinstall
index d2f3d26..154703a 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1489,7 +1489,7 @@ sub create_main_window {
$window
This was deprecated in GTK 3.2, the replacement Gtk3::Separator was
added in GTK 3.0.
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/proxinstall b/proxinstall
index 105904f..d2f3d26 100755
--- a/proxinstall
+++ b
These widgets were deprecated in GTK 3.2 and replaced by Gtk3::Box which
was introduced in 3.0.
The packing changes require to horizontally expand the WebKit2::WebView
widget.
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 49 +
1 file
This was deprecated in GTK 3.14, instead we use
GtkLabel:{xalign,yalign}. Note that by default they are both set to 0.5.
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/proxinstall b/proxinstall
We make sure that all exit calls quit the Glib main loop and child
processes.
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 31 +++
1 file changed, 19 insertions(+), 12 deletions(-)
diff --git a/proxinstall b/proxinstall
index 2f63679..701133b 100755
--- a
Without this change closing the main window does not exit the main loop.
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 1 +
1 file changed, 1 insertion(+)
diff --git a/proxinstall b/proxinstall
index 701133b..4f3c85b 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1501,6 +1501,7 @@ sub
s a side note, gtk_main() and related functions were removed for GTK 4.
Maximiliano Sandoval (2):
exit process gracefully
stop main loop when closing the main window
proxinstall | 32
1 file changed, 20 insertions(+), 12 deletions(-)
--
2.3
Signed-off-by: Maximiliano Sandoval
---
Proxmox/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/Proxmox/Makefile b/Proxmox/Makefile
index d49da80..6360064 100644
--- a/Proxmox/Makefile
+++ b/Proxmox/Makefile
@@ -6,7 +6,6 @@ PERL5DIR=$(DESTDIR)/usr/share/perl5/Proxmox
#PERL_MODULES
Note that unlike the rest of the file, we connect to the response signal
instead of using Gtk3::Dialog->run, the reason is that run blocks the
main loop used by GTK and this undesirable to the point where
Gtk3::Dialog->run was removed for GTK 4.
Signed-off-by: Maximiliano Sa
This will be used in future commits to create grids so we need it to be defined.
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/proxinstall b/proxinstall
index fb365d4..fbd260b 100755
--- a
We replace the use of nested boxes with grids when possible to ensure correct
margins and alignment of widgets.
At the end we also remove trailing spaces and colons from labels preceding an
input widget, e.g. `DNS Server: `.
Maximiliano Sandoval (7):
move create_basic_grid subroutine
d to use a grid.
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/proxinstall b/proxinstall
index 29ed8dc..86922e2 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1484,10 +1484,10 @@ my $create_basic_grid = sub {
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 34 --
1 file changed, 12 insertions(+), 22 deletions(-)
diff --git a/proxinstall b/proxinstall
index faebdec..29ed8dc 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1781,12 +1781,12 @@ sub update_layout
Using boxes causes the labels to not align correctly in certain
circumstances. In the following commits we replace the use of boxes with
grids and set the margins and spacing directly on the respective grid.
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 56
This accounts for the different layout set in the previous commit.
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxinstall b/proxinstall
index 72802c0..7e1bcd4 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1460,7
For consistency sake, all colons and trailing spaces in labels were
removed, this matches other panels such as the password and
country/timezone panels.
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a
The extra 10px margin on the email row was added to account for the
removed line:
$vbox->pack_start($hbox3, 0, 0, 15);
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 32 ++--
1 file changed, 14 insertions(+), 18 deletions(-)
diff --git a/proxinstal
-off-by: Maximiliano Sandoval
---
proxinstall | 2 ++
1 file changed, 2 insertions(+)
diff --git a/proxinstall b/proxinstall
index fe0239f..f32abd2 100755
--- a/proxinstall
+++ b/proxinstall
@@ -2291,6 +2291,8 @@ sub create_hdoption_view {
my $dialog = Gtk3::Dialog->new();
$dia
When running `pct status VMID` the variable
$last_proc_vmid_stat->{$vmid} is not set and pct reports no cpu usage.
We address this by computing the used cpu time over the total uptime of
the container.
Signed-off-by: Maximiliano Sandoval
---
src/PVE/LXC.pm | 5 -
1 file changed
le of a GTK message dialog.
Maximiliano Sandoval (1):
fix #4643: show a confirmation dialog when clicking abort
proxinstall | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
--
2.39.2
___
pve-devel mailing list
pve-
Note that unlike the rest of the file, we connect to the response signal
instead of using Gtk3::Dialog->run, the reason is that run blocks the
main loop used by GTK and this undesirable to the point where
Gtk3::Dialog->run was removed for GTK 4.
Signed-off-by: Maximiliano Sa
This matches the GUI installer which counts with a close (x) button.
Signed-off-by: Maximiliano Sandoval
---
proxmox-tui-installer/src/views/bootdisk.rs | 1 +
1 file changed, 1 insertion(+)
diff --git a/proxmox-tui-installer/src/views/bootdisk.rs
b/proxmox-tui-installer/src/views/bootdisk.rs
It makes no sense from a UX point of view to abort an install that's
already finished.
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 5 +
1 file changed, 5 insertions(+)
diff --git a/proxinstall b/proxinstall
index 6d13892..bf88b31 100755
--- a/proxinstall
+++ b/proxin
GtkWiget:can-focus=false means that the user cannot use tab or key
navigation to interact with this button.
Signed-off-by: Maximiliano Sandoval
---
proxinstall | 1 -
1 file changed, 1 deletion(-)
diff --git a/proxinstall b/proxinstall
index 6d13892..f260a95 100755
--- a/proxinstall
+++ b
homas Lamprecht wrote:
Am 21/06/2023 um 11:16 schrieb Maximiliano Sandoval:
This matches the GUI installer which counts with a close (x) button.
Signed-off-by: Maximiliano Sandoval
---
proxmox-tui-installer/src/views/bootdisk.rs | 1 +
1 file changed, 1 insertion(+)
diff --git a/proxmox-tui
Note that the HTML5 standard [1] suggests
/^[a-zA-Z0-9.!#$%&'*+\/=?^_`{|}~-]+@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)*$/
as a regex, I am not sure whats the difference but it might be worth it to
check if there is any relevant differ
Otherwise the user only has 5 seconds to see the error message before
the machine reboots.
Signed-off-by: Maximiliano Sandoval
---
proxmox-tui-installer/src/main.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxmox-tui-installer/src/main.rs
b/proxmox-tui-installer/src
> On 27.06.2023 14:54 CEST Stefan Sterz wrote:
>
>
> previously the disk selection was reset if the advanced options
> dialogue was re-opened. this commit adapts the behavior to restore
> the previous selection.
>
> Signed-off-by: Stefan Sterz
> ---
> proxmox-tui-installer/src/options.rs
When running `pct status VMID` the variable
$last_proc_vmid_stat->{$vmid} is not set and pct reports no cpu usage.
For consistency with the qt command we do not print the cpu usage.
Signed-off-by: Maximiliano Sandoval
---
This is a different approach that the one tried at
ht
Lukas Wagner writes:
> Signed-off-by: Lukas Wagner
> ---
> Cargo.toml | 1 +
> proxmox-notify/Cargo.toml | 9 +
> proxmox-notify/src/config.rs| 51 +
> proxmox-notify/src/endpoints/mod.rs | 0
> proxmox-notify/src/lib.rs | 311 +++
1 - 100 of 274 matches
Mail list logo
