by adding them to their own list, saving the nodes where
they are not allowed, and return those on 'wantarray'
Signed-off-by: Dominik Csapak
---
PVE/QemuServer.pm | 36 ++--
1 file changed, 34 insertions(+), 2 deletions(-)
diff --git a/PVE/QemuServe
similar to the pciselector, make it accept a plain nodename,
or no node at all and provide a setNodename function
to keep backwards compatibility, also check pveSelNode for the nodename
Signed-off-by: Dominik Csapak
---
www/manager6/form/USBSelector.js | 32
1
akin to the PCISelector, but uses the api for mapped devices
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile | 1 +
www/manager6/form/PCIMapSelector.js | 95 +
2 files changed, 96 insertions(+)
create mode 100644 www/manager6/form
d permissions better
* added a 'comment' field for mappings
dependencies are ofc:
manager depends on qemu-server,pve-access-control,pve-common
qemu-server depends on pve-access-control,pve-common
pve-common depends on pve-cluster
pve-cluster:
Dominik Csapak (1):
add nodes/ha
to be able to select 'mapped' usb devices
Signed-off-by: Dominik Csapak
---
www/manager6/qemu/USBEdit.js | 34 +-
1 file changed, 33 insertions(+), 1 deletion(-)
diff --git a/www/manager6/qemu/USBEdit.js b/www/manager6/qemu/USBEdit.js
index a2204584
* same as above */
},
digest => ""
}
it also adds some helpers for the api schema & asserting that the
device mappings are valid (by checking the saved properties
against the ones found on the current available devices)
Signed-off-by: Dominik Csapak
---
src/Makefile
api call for each node
Signed-off-by: Dominik Csapak
---
PVE/API2/Cluster.pm | 8 +++
PVE/API2/Cluster/Hardware.pm | 117 +++
PVE/API2/Cluster/Makefile| 1 +
3 files changed, 126 insertions(+)
create mode 100644 PVE/API2/Cluster/Hardware.pm
diff
it's possible to add/edit/remove mappings here, with a cluster
wide view on the mappings and validity.
to do that, we have to to an api call for each node, since
we don't have the pci status synced across them.
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile |
: Dominik Csapak
---
PVE/API2/Hardware.pm | 6 +
PVE/API2/Hardware/Makefile | 1 +
PVE/API2/Hardware/Mapping.pm | 708 +++
3 files changed, 715 insertions(+)
create mode 100644 PVE/API2/Hardware/Mapping.pm
diff --git a/PVE/API2/Hardware.pm b/PVE/API2
if the migration is an offline migration and when the mapping on
the target node exists, otherwise not
this does not change the behaviour for 'raw' devices in the config
those can still be forced to be migrated, like before
Signed-off-by: Dominik Csapak
---
www/manager6/window/Migra
enough permissions.
data/PermPathStore:
add '/hardware' to the list of acl paths
Signed-off-by: Dominik Csapak
---
www/manager6/data/PermPathStore.js | 1 +
www/manager6/form/PCISelector.js | 1 +
www/manager6/form/USBSelector.js | 1 +
www/manager6/qemu/HardwareVie
reworks the panel to use a controller, so that we can easily
add the selector for mapped pci devices
shows now a selection between 'raw' and 'mapped' devices, where
'raw' ones work like before, and 'mapped' ones take the values
form the hardware map config
just a quick note, aaron noticed some small things immediately,
root@pam did not see the hardware panel:
access control needs this diff:
8<
diff --git a/src/PVE/RPCEnvironment.pm b/src/PVE/RPCEnvironment.pm
index c1b712d..b686c6b 100644
--- a/src/PVE/RPCEnvironment.pm
+++ b/src/PVE/RPCE
On 7/21/22 14:29, Gilberto Ferreira via pve-devel wrote:
It's nice to hear about this patch.
For now, as a workaround, when I need a usb device (like a stick for
instance), I am using USB Over IP, like you can read in this article
https://www.linux-magazine.com/Issues/2018/208/Tutorial-USB-IP#:~
in pbs we get an array here, so the renderer is fine, but in pve it's
just a long string, so add a space after commas to achieve the same
effect.
without this, the second column is not visible in pve because of an error
in the renderer (no 'join' function on a string)
Signed-
by
* showing the (optional) name in front of the type
* making the 'availble' column a bit narrower
* enabling 'cellWrap' for the description
* making the dropdown a bit wider (so all the information can fit)
Signed-off-by: Dominik Csapak
---
www/manager6/form/
Some vendors also provide a 'name' file here for the type, which, in case of
NVIDIA, is the official name for the vGPU type in their documentation,
so extract and return it too (if it exists).
Signed-off-by: Dominik Csapak
---
src/PVE/SysFSTools.pm | 6 +-
1 file changed, 5 insert
with QEMU anyway, i'd say we can ignore that.
Signed-off-by: Dominik Csapak
---
PVE/QemuServer.pm | 8 +++-
PVE/QemuServer/PCI.pm | 4 +++-
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 7d9cf22..c4eb031 100644
--- a/PV
nd give some feedback?
my idea there would be to allow multiple device mappings per node
(instead of one only) and the qemu code would select one automatically
0: https://bugzilla.proxmox.com/show_bug.cgi?id=3574
1: https://lists.proxmox.com/pipermail/pve-devel/2022-July/053565.html
pve-common:
Do
o it's own function, and call that instead of only 'remove_pci_reservation'
also print the errors of the cleanup steps with 'warn', otherwise we
might discard important errors
Signed-off-by: Dominik Csapak
---
PVE/QemuServer.pm | 40
applied
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
On 8/1/22 14:01, Fabian Grünbichler wrote:
On July 19, 2022 1:46 pm, Dominik Csapak wrote:
like check_vm_perm, etc.
Signed-off-by: Dominik Csapak
---
src/PVE/RPCEnvironment.pm | 8
1 file changed, 8 insertions(+)
diff --git a/src/PVE/RPCEnvironment.pm b/src/PVE/RPCEnvironment.pm
On 8/1/22 14:58, Fabian Grünbichler wrote:
On July 19, 2022 1:46 pm, Dominik Csapak wrote:
this adds functionality for the hardwaremap config (as json)
the format of the config is like this:
{
usb => {
name => {
nodename1 => { /* mappi
On 8/1/22 15:01, Fabian Grünbichler wrote:
On July 19, 2022 1:46 pm, Dominik Csapak wrote:
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm | 39 ---
1 file changed, 36 insertions(+), 3 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
On 8/9/22 09:59, DERUMIER, Alexandre wrote:
Le 26/07/22 à 08:55, Dominik Csapak a écrit :
so maybe someone can look at that and give some feedback?
my idea there would be to allow multiple device mappings per node
(instead of one only) and the qemu code would select one automatically
Hi
by
* showing the (optional) name in front of the type
* making the 'availble' column a bit narrower
* enabling 'cellWrap' for the description
* making the dropdown a bit wider (so all the information can fit)
Signed-off-by: Dominik Csapak
---
www/manager6/form/
Some vendors also provide a 'name' file here for the type, which, in case of
NVIDIA, is the official name for the vGPU type in their documentation,
so extract and return it too (if it exists).
Signed-off-by: Dominik Csapak
---
src/PVE/SysFSTools.pm | 7 ++-
1 file changed, 6
o it's own function, and call that instead of only 'remove_pci_reservation'
Signed-off-by: Dominik Csapak
---
PVE/QemuServer.pm | 40
1 file changed, 24 insertions(+), 16 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
inde
info.
changes from v1:
* use read_firstline instead of get_contents (to avoid the newline at the end)
* make sure only one '-uuid' parameter is given
* add patch 'cleanup pci device in more situations' (was seperate before)
pve-common:
Dominik Csapak (1):
SysFSTools: ge
with QEMU anyway, i'd say we can ignore that.
Signed-off-by: Dominik Csapak
---
PVE/QemuServer.pm | 9 -
PVE/QemuServer/PCI.pm | 4 +++-
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 7d9cf22..c706653 100644
--- a/PVE
On 8/17/22 01:15, DERUMIER, Alexandre wrote:
Le 9/08/22 à 10:39, Dominik Csapak a écrit :
On 8/9/22 09:59, DERUMIER, Alexandre wrote:
Le 26/07/22 à 08:55, Dominik Csapak a écrit :
so maybe someone can look at that and give some feedback?
my idea there would be to allow multiple device
On 8/22/22 15:39, DERUMIER, Alexandre wrote:
Le 22/08/22 à 12:16, Dominik Csapak a écrit :
On 8/17/22 01:15, DERUMIER, Alexandre wrote:
Le 9/08/22 à 10:39, Dominik Csapak a écrit :
On 8/9/22 09:59, DERUMIER, Alexandre wrote:
Le 26/07/22 à 08:55, Dominik Csapak a écrit :
so maybe someone can
On 8/22/22 16:07, Dominik Csapak wrote:
On 8/22/22 15:39, DERUMIER, Alexandre wrote:
Le 22/08/22 à 12:16, Dominik Csapak a écrit :
On 8/17/22 01:15, DERUMIER, Alexandre wrote:
Le 9/08/22 à 10:39, Dominik Csapak a écrit :
On 8/9/22 09:59, DERUMIER, Alexandre wrote:
Le 26/07/22 à 08:55
so that we can assign privileges on hardware level
this will generate a new role (PVEHardwareAdmin)
Signed-off-by: Dominik Csapak
---
src/PVE/AccessControl.pm | 13 +
src/PVE/RPCEnvironment.pm | 3 ++-
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/src/PVE
mdevs must have a host-unique uuid, and they appear in
/sys/bus/mdev/devices/, so there is no need to reference the pciid
with it
Signed-off-by: Dominik Csapak
---
PVE/QemuServer/PCI.pm | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/PVE/QemuServer/PCI.pm b/PVE/QemuServer
and get the correct pci device during parsing
Signed-off-by: Dominik Csapak
---
PVE/QemuServer/PCI.pm | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/PVE/QemuServer/PCI.pm b/PVE/QemuServer/PCI.pm
index b5284ef..8c171f3 100644
--- a/PVE/QemuServer/PCI.pm
into a private sub. This makes the 'print_hostpci_devices' function more
easier to read
Signed-off-by: Dominik Csapak
---
PVE/QemuServer/PCI.pm | 57 +--
1 file changed, 33 insertions(+), 24 deletions(-)
diff --git a/PVE/QemuServer/PC
restrict the nodes also for mapped devices, and return them in their
own property
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index f22c601..f570fc2 100644
--- a/PVE
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm | 40 +---
PVE/QemuServer.pm | 2 ++
2 files changed, 39 insertions(+), 3 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 99b426e..08e5104 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2
r (5-11) depends on qemu-server(<5),
pve-access-control,pve-common (2)
qemu-server (12,13) depends on qemu-server(<12), pve-common (3)
manager depends on qemu-server,pve-access-control,pve-common
pve-cluster:
Dominik Csapak (1):
add nodes/hardware-map.conf
data/PVE/Cluster.pm | 1 +
if the migration is an offline migration and when the mapping on
the target node exists, otherwise not
this does not change the behaviour for 'raw' devices in the config
those can still be forced to be migrated, like before
Signed-off-by: Dominik Csapak
---
www/manager6/window/Migra
api call for each node
Signed-off-by: Dominik Csapak
---
PVE/API2/Cluster.pm | 8 +++
PVE/API2/Cluster/Hardware.pm | 117 +++
PVE/API2/Cluster/Makefile| 1 +
3 files changed, 126 insertions(+)
create mode 100644 PVE/API2/Cluster/Hardware.pm
diff
the saved properties
against the ones found on the current available devices)
we use a single cluster wide json here, because section config is too
limited to properly represent the data we need and easily access the
config of all nodes when we need it (e.g. in api calls regarding
migration and config
allows to add a single host mapping for pci entries
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile| 1 +
www/manager6/form/PCISelector.js | 17 +-
www/manager6/window/PCIEdit.js | 287 +++
3 files changed, 304 insertions(+), 1 deletion
: Dominik Csapak
---
PVE/API2/Hardware.pm | 6 +
PVE/API2/Hardware/Makefile | 1 +
PVE/API2/Hardware/Mapping.pm | 708 +++
3 files changed, 715 insertions(+)
create mode 100644 PVE/API2/Hardware/Mapping.pm
diff --git a/PVE/API2/Hardware.pm b/PVE/API2
. we can also not select multiple
devices with different properties (e.g. vendor) so that the user
cannot select a set of pci devices which are not similar
Signed-off-by: Dominik Csapak
---
www/css/ext6-pve.css | 4 +
www/manager6/Makefile | 1 +
www/manager6
mediated devices also appear under /sys/bus/mdev/devices with their
uuid, independent of the pci device, so we can use that instead
Signed-off-by: Dominik Csapak
---
src/PVE/SysFSTools.pm | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/PVE/SysFSTools.pm b/src/PVE
to PVE/Cluster.pm
and status.c
Signed-off-by: Dominik Csapak
---
data/PVE/Cluster.pm | 1 +
data/src/status.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm
index abcc46d..5dfc6b2 100644
--- a/data/PVE/Cluster.pm
+++ b/data/PVE/Cluster.pm
Signed-off-by: Dominik Csapak
---
PVE/QemuServer.pm | 2 ++
PVE/QemuServer/USB.pm | 21 -
2 files changed, 22 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 050e5c2..68e1366 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
o it's own function, and call that instead of only 'remove_pci_reservation'
Signed-off-by: Dominik Csapak
---
PVE/QemuServer.pm | 34 ++
PVE/QemuServer/PCI.pm | 12 +++-
2 files changed, 25 insertions(+), 21 deletions(-)
diff --git
n the any has a different
group, the first one will too
Signed-off-by: Dominik Csapak
---
src/PVE/HardwareMap.pm | 68 +-
1 file changed, 40 insertions(+), 28 deletions(-)
diff --git a/src/PVE/HardwareMap.pm b/src/PVE/HardwareMap.pm
index 7a90220..4a322ff 1
they can only be migrated to nodes where there exists a mapping and if
the migration is done offline
Signed-off-by: Dominik Csapak
---
PVE/QemuMigrate.pm | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
index d52dc8d
by adding them to their own list, saving the nodes where
they are not allowed, and return those on 'wantarray'
Signed-off-by: Dominik Csapak
---
PVE/QemuServer.pm| 36 ++--
test/MigrationTest/Shared.pm | 7 +++
2 files changed, 41
similar to the pciselector, make it accept a plain nodename,
or no node at all and provide a setNodename function
to keep backwards compatibility, also check pveSelNode for the nodename
Signed-off-by: Dominik Csapak
---
www/manager6/form/USBSelector.js | 32
1
instead of parsing the config again when trying to reserver/prepare the
pci devices. also split the preparing into non-mdev devices and mdev
devices, this will come in handy later.
Signed-off-by: Dominik Csapak
---
PVE/QemuServer.pm | 20 +---
PVE/QemuServer/PCI.pm | 8
similar to PCIMapSelector
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile | 1 +
www/manager6/form/USBMapSelector.js | 73 +
2 files changed, 74 insertions(+)
create mode 100644 www/manager6/form/USBMapSelector.js
diff --git a/www/manager6
to be able to select 'mapped' usb devices
Signed-off-by: Dominik Csapak
---
www/manager6/qemu/USBEdit.js | 36 +++-
1 file changed, 35 insertions(+), 1 deletion(-)
diff --git a/www/manager6/qemu/USBEdit.js b/www/manager6/qemu/USBEdit.js
index a2204584
allows to add a single host mapping for usb entries
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile | 1 +
www/manager6/window/USBEdit.js | 248 +
2 files changed, 249 insertions(+)
create mode 100644 www/manager6/window/USBEdit.js
diff --git
_pci_usage) so that a 'qm showcmd' does not actually
reserve any pci id (this would break when using that on running vms).
Additionally this also prevents the migration tests from failing
(they use vm_commandline which in turn uses config_to_command)
Signed-off-by: Dominik Csapak
--
enough permissions.
data/PermPathStore:
add '/hardware' to the list of acl paths
Signed-off-by: Dominik Csapak
---
www/manager6/data/PermPathStore.js | 1 +
www/manager6/form/PCISelector.js | 1 +
www/manager6/form/USBSelector.js | 1 +
www/manager6/qemu/HardwareVie
Signed-off-by: Dominik Csapak
---
test/cfg2cmd/q35-linux-hostpci-mapping.conf | 17 +
.../q35-linux-hostpci-mapping.conf.cmd| 36 +
test/run_config2command_tests.pl | 76 +++
3 files changed, 129 insertions(+)
create mode 100644 test/cfg2cmd
it's possible to add/edit/remove mappings here, with a cluster
wide view on the mappings and validity.
to do that, we have to to an api call for each node, since
we don't have the pci status synced across them.
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile |
reworks the panel to use a controller, so that we can easily
add the selector for mapped pci devices
shows now a selection between 'raw' and 'mapped' devices, where
'raw' ones work like before, and 'mapped' ones take the values
form the hardware map config
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm | 54 ++--
1 file changed, 52 insertions(+), 2 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 08e5104..f22c601 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -26,6 +26,7
akin to the PCISelector, but uses the api for mapped devices
Signed-off-by: Dominik Csapak
---
www/manager6/Makefile | 1 +
www/manager6/form/PCIMapSelector.js | 102
2 files changed, 103 insertions(+)
create mode 100644 www/manager6/form
On 8/25/22 20:00, DERUMIER, Alexandre wrote:
Le 25/08/22 à 11:24, Dominik Csapak a écrit :
they can only be migrated to nodes where there exists a mapping and if
the migration is done offline
Signed-off-by: Dominik Csapak
---
PVE/QemuMigrate.pm | 13 -
1 file changed, 12
On 8/25/22 16:53, DERUMIER, Alexandre wrote:
> root@pve2:~# qm start 101
> ignoring mediated device with multifunction device
ok, it's simply that indeed I have specify a multifunction path ":02".
I think it should better/safe to die here, instead to simply warn and
continue.
i agree d
On 8/25/22 17:37, DERUMIER, Alexandre wrote:
I don't known if it's a bug in the gui, or the api.
But, if you update an existing mapping,with currently,a simple function
pci with mdev=1, and you change it to a pci multifunction with mdev=0,
the mdev value is not updated.
(This occur in the othe
On 8/27/22 18:09, DERUMIER, Alexandre wrote:
Le 26/08/22 à 08:39, Dominik Csapak a écrit :
On 8/25/22 16:53, DERUMIER, Alexandre wrote:
> root@pve2:~# qm start 101
> ignoring mediated device with multifunction device
ok, it's simply that indeed I have specify a multifunction
Code LGTM and tested fine
consider the series:
Reviewed-by: Dominik Csapak
Tested-by: Dominik Csapak
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
current version of webview_flutter_android (2.10.0) needs it
Signed-off-by: Dominik Csapak
---
android/app/build.gradle | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/android/app/build.gradle b/android/app/build.gradle
index d287d5b..27e8d55 100644
--- a/android/app
ProxmoxProgressOverlay, so
that the text appears now white instead of some shade of cyan.
Signed-off-by: Dominik Csapak
---
lib/proxmox_login_form.dart | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/proxmox_login_form.dart b/lib/proxmox_login_form.dart
index 5e9198f..706315f 100644
--- a/lib
flutter 3.0 removed RaisedButton
Signed-off-by: Dominik Csapak
---
lib/widgets/firstWelcomeScreen/pve_welcome_last.dart | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/lib/widgets/firstWelcomeScreen/pve_welcome_last.dart
b/lib/widgets/firstWelcomeScreen
e we get a Future, which cannot be converted
to FutureOr, we got an exception (that we never saw because
of the Missing ScaffoldMessenger)
same is true for the 'remove' button
despite that the backup always actually ran, but the user did not get
any visual feedback
Signed-off-by: Domi
flutter 3.0 removed OutlineButton in favor of OutlinedButton.
also change the default text color to white, and drop an unnecessary
padding in one case
Signed-off-by: Dominik Csapak
---
lib/main.dart | 10 ++
.../firstWelcomeScreen/pve_welcome_faq.dart
since flutter 3 removed FlatButton. For this we have to do the colors a
little different, so i moved the color/disabledColor into the
textButtonTheme, which does not modify anything else here.
Signed-off-by: Dominik Csapak
---
lib/proxmox_login_form.dart | 33
use them)
since then we could better use 'flutter analyze'
(now these widgets/files make much noise to the point where it's hard
to see which warnings/infos are even relevant for the app)
proxmox-login-manager:
Aaron Lauterer (1):
login_form: keep Continue button above Android sof
in newer flutter versions, call.arguments() can return null, so handle that
Signed-off-by: Dominik Csapak
---
.../kotlin/com/proxmox/app/pve_flutter_frontend/MainActivity.kt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/android/app/src/main/kotlin/com/proxmox/app
can happen when no ostype is set in the config (defaults to 'other')
Signed-off-by: Dominik Csapak
---
lib/widgets/pve_qemu_options_widget.dart | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/widgets/pve_qemu_options_widget.dart
b/l
so that it fits better with our color schemes instead of using the
flutter defaults (which are especially bad in dark mode for our scheme)
Signed-off-by: Dominik Csapak
---
lib/main.dart | 4
1 file changed, 4 insertions(+)
diff --git a/lib/main.dart b/lib/main.dart
index d467626..c9b862e
Signed-off-by: Dominik Csapak
---
lib/widgets/firstWelcomeScreen/pve_welcome_faq.dart | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/widgets/firstWelcomeScreen/pve_welcome_faq.dart
b/lib/widgets/firstWelcomeScreen/pve_welcome_faq.dart
index 470d118..f2be574 100644
--- a
From: Aaron Lauterer
By placing the items in a SafeArea we avoid having the "Continue" button
behind the Android soft navigation buttons.
Signed-off-by: Aaron Lauterer
Signed-off-by: Dominik Csapak
---
lib/proxmox_login_form.dart | 265 ++--
1 fi
flutter 3.0 removed FlatButton
Signed-off-by: Dominik Csapak
---
lib/pages/main_layout_slim.dart | 2 +-
lib/widgets/pve_console_menu_widget.dart | 4 +--
lib/widgets/pve_first_welcome_screen.dart | 32 ---
lib/widgets/pve_guest_backup_widget.dart
: Dominik Csapak
---
lib/widgets/pve_lxc_options_widget.dart | 140
lib/widgets/pve_qemu_options_widget.dart | 256 +++---
lib/widgets/pve_qemu_overview.dart| 319 +-
.../pve_qemu_power_settings_widget.dart | 178 +-
4 files changed
background, making them invisible.
Fix it by creating a manual textSelectionTheme with colors that properly
contrast the background. (The color works well for both light and dark mode)
The selectionHandleColor is modifed with an opacity of 0.4 like flutter
does by default.
Signed-off-by: Dominik
[snip]
# non systemd based containers work with pure cgroupv2
sub unified_cgroupv2_support {
-my ($self) = @_;
+my ($self, $conf) = @_;
why pass the whole config if you just need the arch? Please avoid overly generic
parameter in signatures if only one specific thing is required.
On 9/12/22 11:30, Dominik Csapak wrote:
[snip]
# non systemd based containers work with pure cgroupv2
sub unified_cgroupv2_support {
- my ($self) = @_;
+ my ($self, $conf) = @_;
why pass the whole config if you just need the arch? Please avoid overly generic
parameter in signatures
On 9/12/22 11:30, Dominik Csapak wrote:
[snip]
# non systemd based containers work with pure cgroupv2
sub unified_cgroupv2_support {
- my ($self) = @_;
+ my ($self, $conf) = @_;
why pass the whole config if you just need the arch? Please avoid overly generic
parameter in signatures
in at all because of a not quorate server (when
there is not a good technical reason for it) seems bad
It's still not possible to login when tfa is enabled though, but at
least for simple setups it should be a bit better
Signed-off-by: Dominik Csapak
---
src/PVE/AccessControl.pm | 6
'typeof' cannot return 'undefined' only the string '"undefined"', newer
eslint versions detect that as error
to fix it, directly check it for undefined instead of using typeof
Signed-off-by: Dominik Csapak
---
www/manager6/storage/PBSEdit.js | 2 +-
1
different enough?
On 6/21/22 11:19, Dominik Csapak wrote:
normal tags require 'VM.Config.Options' on the VM, admin tags require
'Sys.Modify' on '/'
a user can set/delete/reorder tags, as long as no admin tags get
added/removed
Signed-off-by: Dominik Csapak
[...]
re
but since we want the tags to be shown differently there (to be able to
add/edit them)
we cannot use that anymore
On 6/21/22 11:20, Dominik Csapak wrote:
[snip]
node: {
@@ -114,6 +116,8 @@ Ext.define('PVE.tree.ResourceTree', {
}
}
+ info.tex
On 9/14/22 16:15, Aaron Lauterer wrote:
On 6/21/22 11:20, Dominik Csapak wrote:
Signed-off-by: Dominik Csapak
---
www/manager6/form/Tag.js | 22 +++--
www/manager6/form/TagEdit.js | 96 +++-
2 files changed, 114 insertions(+), 4 deletions(-)
diff
On 9/15/22 12:43, Thomas Lamprecht wrote:
Am 14/09/2022 um 15:42 schrieb Dominik Csapak:
The downside is that we cannot authenticate users anymore without quorum
(since locking requires write access to pmxcfs), even for users without
tfa configured (and also for clusters without any tfa
On 9/15/22 14:53, Thomas Lamprecht wrote:
Am 15/09/2022 um 14:40 schrieb Dominik Csapak:
On 9/15/22 12:43, Thomas Lamprecht wrote:
Am 14/09/2022 um 15:42 schrieb Dominik Csapak:
The downside is that we cannot authenticate users anymore without quorum
(since locking requires write access to
On 9/16/22 09:19, Thomas Lamprecht wrote:
Am 21/06/2022 um 11:19 schrieb Dominik Csapak:
this series brings the already existing 'tags' for ct/vms to the gui:
* tags can be edited in the status toolbar of the guest
* existing tags will be shown in the tree/global search/resource gr
so that we can assign privileges on hardware level
this will generate a new role (PVEHardwareAdmin)
Signed-off-by: Dominik Csapak
---
src/PVE/AccessControl.pm | 13 +
src/PVE/RPCEnvironment.pm | 3 ++-
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/src/PVE
restrict the nodes also for mapped devices, and return them in their
own property
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index d6d393f..cc726bd 100644
--- a/PVE
mdevs must have a host-unique uuid, and they appear in
/sys/bus/mdev/devices/, so there is no need to reference the pciid
with it
Signed-off-by: Dominik Csapak
---
PVE/QemuServer/PCI.pm | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/PVE/QemuServer/PCI.pm b/PVE/QemuServer
_pci_usage) so that a 'qm showcmd' does not actually
reserve any pci id (this would break when using that on running vms).
Additionally this also prevents the migration tests from failing
(they use vm_commandline which in turn uses config_to_command)
Signed-off-by: Dominik Csapak
--
601 - 700 of 2437 matches
Mail list logo
