when we changed from ScaffoldState to ScaffoldMessengerState, we missed
that we have to wrap the scaffold in a ScaffoldMessenger, otherwise
there is no current state and we never could show a snack
we also have to do the null safety of the 'nodesVZDumpCreateBackup'
differently, since we get a Future<String?>, which cannot be converted
to FutureOr<String>, we got an exception (that we never saw because
of the Missing ScaffoldMessenger)
same is true for the 'remove' button
despite that the backup always actually ran, but the user did not get
any visual feedback
Signed-off-by: Dominik Csapak <d.csa...@proxmox.com>
---
lib/widgets/pve_guest_backup_widget.dart | 144 ++++++++++++-----------
1 file changed, 73 insertions(+), 71 deletions(-)
diff --git a/lib/widgets/pve_guest_backup_widget.dart
b/lib/widgets/pve_guest_backup_widget.dart
index e6aebde..05cd725 100644
--- a/lib/widgets/pve_guest_backup_widget.dart
+++ b/lib/widgets/pve_guest_backup_widget.dart
@@ -265,11 +265,11 @@ class PveGuestBackupContent extends StatelessWidget {
),
OutlinedButton.icon(
onPressed: () async {
- final guard = await (_showConfirmDialog(
+ final guard = (await _showConfirmDialog(
context,
'Attention',
'Do you really want to delete this backup?')
- as FutureOr<bool>);
+ )!;
if (guard) {
fBloc.events.add(DeleteFile(volid));
Navigator.of(context).pop();
@@ -417,77 +417,79 @@ class _PveBackupFormState extends State<PveBackupForm> {
@override
Widget build(BuildContext context) {
- return Scaffold(
+ return ScaffoldMessenger(
key: _scaffoldKey,
- appBar: AppBar(
- iconTheme: IconThemeData(color: Colors.black),
- backgroundColor: Colors.transparent,
- elevation: 0,
- title: Text(
- "Schedule backup",
- style: TextStyle(color: Colors.black),
+ child: Scaffold(
+ appBar: AppBar(
+ iconTheme: IconThemeData(color: Colors.black),
+ backgroundColor: Colors.transparent,
+ elevation: 0,
+ title: Text(
+ "Schedule backup",
+ style: TextStyle(color: Colors.black),
+ ),
),
- ),
- body: SingleChildScrollView(
- padding: EdgeInsets.all(8),
- child: Form(
- key: _formKey,
- onChanged: () {
- final isValid = _formKey.currentState!.validate();
- setState(() {
- enableSubmitButton = isValid;
- });
- },
- child: Column(
- children: [
- PveStorageSelectorDropdown(
- labelText: 'Storage',
- sBloc: widget.sBloc,
- allowBlank: false,
- ),
- _createModeDropdown(),
- _createCompressionDropdown(),
- TextFormField(
- decoration: InputDecoration(
- labelText: 'Email to',
- helperText: ' ',
+ body: SingleChildScrollView(
+ padding: EdgeInsets.all(8),
+ child: Form(
+ key: _formKey,
+ onChanged: () {
+ final isValid = _formKey.currentState!.validate();
+ setState(() {
+ enableSubmitButton = isValid;
+ });
+ },
+ child: Column(
+ children: [
+ PveStorageSelectorDropdown(
+ labelText: 'Storage',
+ sBloc: widget.sBloc,
+ allowBlank: false,
),
- controller: emailToController,
- autovalidateMode: AutovalidateMode.onUserInteraction,
- validator: (value) {
- if (value!.isNotEmpty && !Validators.isValidEmail(value)) {
- return 'Please enter valid email address';
- }
- return null;
- },
- ),
- OutlinedButton.icon(
- onPressed: enableSubmitButton
- ? () {
- //TODO remove when async validation is implemented
- if (!_formKey.currentState!.validate()) {
- setState(() {
- enableSubmitButton = false;
- });
- return;
- }
+ _createModeDropdown(),
+ _createCompressionDropdown(),
+ TextFormField(
+ decoration: InputDecoration(
+ labelText: 'Email to',
+ helperText: ' ',
+ ),
+ controller: emailToController,
+ autovalidateMode: AutovalidateMode.onUserInteraction,
+ validator: (value) {
+ if (value!.isNotEmpty &&
!Validators.isValidEmail(value)) {
+ return 'Please enter valid email address';
+ }
+ return null;
+ },
+ ),
+ OutlinedButton.icon(
+ onPressed: enableSubmitButton
+ ? () {
+ //TODO remove when async validation is
implemented
+ if (!_formKey.currentState!.validate()) {
+ setState(() {
+ enableSubmitButton = false;
+ });
+ return;
+ }
- startBackup(
- widget.sBloc.apiClient,
- widget.sBloc.latestState.nodeID,
- widget.sBloc.latestState.selected!.id,
- widget.guestID,
- compression,
- mode!,
- mailTo: emailToController!.text,
- );
- }
- : null,
- icon: Icon(Icons.save),
- label: Text('Start backup now'))
- ],
- ),
- )),
+ startBackup(
+ widget.sBloc.apiClient,
+ widget.sBloc.latestState.nodeID,
+ widget.sBloc.latestState.selected!.id,
+ widget.guestID,
+ compression,
+ mode!,
+ mailTo: emailToController!.text,
+ );
+ }
+ : null,
+ icon: Icon(Icons.save),
+ label: Text('Start backup now'))
+ ],
+ ),
+ )),
+ )
);
}
@@ -501,11 +503,11 @@ class _PveBackupFormState extends State<PveBackupForm> {
String? mailTo,
}) async {
try {
- final jobId = await (apiClient.nodesVZDumpCreateBackup(
+ final jobId = (await apiClient.nodesVZDumpCreateBackup(
node, storage, guestId,
compressionType: compression,
mode: mode,
- mailTo: mailTo) as FutureOr<String>);
+ mailTo: mailTo))!;
await showTaskLogBottomSheet(context, apiClient, node, jobId,
icon: Icon(Icons.save), jobTitle: Text('Backup $guestId'));
--
2.30.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
