if the migration is an offline migration and when the mapping on
the target node exists, otherwise not

this does not change the behaviour for 'raw' devices in the config
those can still be forced to be migrated, like before

Signed-off-by: Dominik Csapak <d.csa...@proxmox.com>
---
 www/manager6/window/Migrate.js | 37 +++++++++++++++++++++++++++-------
 1 file changed, 30 insertions(+), 7 deletions(-)

diff --git a/www/manager6/window/Migrate.js b/www/manager6/window/Migrate.js
index 1c23abb3..5465702e 100644
--- a/www/manager6/window/Migrate.js
+++ b/www/manager6/window/Migrate.js
@@ -219,14 +219,26 @@ Ext.define('PVE.window.Migrate', {
                let target = me.lookup('pveNodeSelector').value;
                if (target.length && 
!migrateStats.allowed_nodes.includes(target)) {
                    let disallowed = migrateStats.not_allowed_nodes[target];
-                   let missingStorages = 
disallowed.unavailable_storages.join(', ');
+                   if (disallowed.unavailable_storages !== undefined) {
+                       let missingStorages = 
disallowed.unavailable_storages.join(', ');
 
-                   migration.possible = false;
-                   migration.preconditions.push({
-                       text: 'Storage (' + missingStorages + ') not available 
on selected target. ' +
-                         'Start VM to use live storage migration or select 
other target node',
-                       severity: 'error',
-                   });
+                       migration.possible = false;
+                       migration.preconditions.push({
+                           text: 'Storage (' + missingStorages + ') not 
available on selected target. ' +
+                             'Start VM to use live storage migration or select 
other target node',
+                           severity: 'error',
+                       });
+                   }
+
+                   if (disallowed.unavailable_resources !== undefined) {
+                       let missingResources = 
disallowed.unavailable_resources.join(', ');
+
+                       migration.possible = false;
+                       migration.preconditions.push({
+                           text: 'Mapped Resources (' + missingResources + ') 
not available on selected target. ',
+                           severity: 'error',
+                       });
+                   }
                }
            }
 
@@ -249,6 +261,17 @@ Ext.define('PVE.window.Migrate', {
                }
            }
 
+           if (migrateStats.mapped_resources && 
migrateStats.mapped_resources.length) {
+               if (vm.get('running')) {
+                   migration.possible = false;
+                   migration.preconditions.push({
+                       text: Ext.String.format('Can\'t migrate running VM with 
mapped resources: {0}',
+                       migrateStats.mapped_resources.join(', ')),
+                       severity: 'error',
+                   });
+               }
+           }
+
            if (migrateStats.local_disks.length) {
                migrateStats.local_disks.forEach(function(disk) {
                    if (disk.cdrom && disk.cdrom === 1) {
-- 
2.30.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to