applied, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
one comment inline
On 11/11/24 12:35, Timothy Nicholson wrote:
Several strings that should probably also be translated now use
the gettext function to be translated.
Signed-off-by: Timothy Nicholson
---
[0]: https://bugzilla.proxmox.com/show_bug.cgi?id=5847
www/manager6/Workspace.js
Signed-off-by: Aaron Lauterer
Tested-By: Stefan Hanreich
Reviewed-by: Shannon Sterz
---
changes since
v5: none
v4: none
v3: none
v2: none
www/manager6/node/Config.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js
index d27592ce..7b
On November 7, 2024 5:51 pm, Fiona Ebner wrote:
> TPM drives are already detached there and it's better to group
> these things together.
>
> Signed-off-by: Fiona Ebner
> ---
>
> No changes in v3.
>
> PVE/VZDump/QemuServer.pm | 25 +
> 1 file changed, 9 insertions(+), 1
Reviewed-by: Fabian Grünbichler
but possibly needs a rebase in case the changes from patch #19 are
adapted based on my feedback ;)
On November 7, 2024 5:51 pm, Fiona Ebner wrote:
> For the external backup API, it will be necessary to add a fleecing
> image even for small disks like EFI and TPM,
On November 7, 2024 5:51 pm, Fiona Ebner wrote:
> When the VM is only started for backup, the VM will be stopped at that
> point again. While the detach helpers do not warn about errors
> currently, that might change in the future. This is also in
> preparation for other cleanup QMP helpers that ar
On November 7, 2024 5:51 pm, Fiona Ebner wrote:
> Makes it a clean error for buggy (external) backup providers where the
> size might not be set at all.
>
> Signed-off-by: Fiona Ebner
> ---
>
> No changes in v3.
>
> PVE/QemuServer.pm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/PV
On November 11, 2024 6:44 pm, Thomas Lamprecht wrote:
> Am 05.11.24 um 12:43 schrieb Fabian Grünbichler:
>> to avoid the need to mark every package shipping PVE-related perl code as
>> activating the explicit trigger. the explicit trigger can still be used for
>> packages that need to reload the AP
The API itself allows several list separators. The network configuration
for bridge_vids expects a space separated list. We therefore convert it
initially to a space separated list.
Signed-off-by: Aaron Lauterer
---
I opted for a comment before the step where we split and reassemble the
list with
Make clear that it affects only out-/inbound traffic and can be used if
the underlying physical NICs support only a limited number of VLANs when
offloading is possible.
Signed-off-by: Aaron Lauterer
Reviewed-by: Shannon Sterz
---
v5: shorten description and put into gettext
v4: none
v3-follow-up
The new optional bridge_vids field allows to set that property via the
GUI. Since the backend needs to support it, the field needs to be
explicitly enabled.
For now, Proxmox VE (PVE) is the use case.
Signed-off-by: Aaron Lauterer
Tested-By: Stefan Hanreich
Reviewed-by: Shannon Sterz
---
change
On November 7, 2024 5:51 pm, Fiona Ebner wrote:
> In preparation for allowing multiple backup providers. Each backup
> target can then have its own dirty bitmap and there can be additional
> checks that the current backup state is actually associated to the
> expected target.
>
> Signed-off-by: Fi
Am 07.11.24 um 17:51 schrieb Fiona Ebner:
> In preparation to re-use it for restore from backup providers.
>
> Signed-off-by: Fiona Ebner
> ---
>
> New in v3.
>
> src/PVE/LXC/Create.pm | 42 +-
> 1 file changed, 25 insertions(+), 17 deletions(-)
>
>
ap
Am 24.11.23 um 14:03 schrieb Maximiliano Sandoval:
> The autoscaler is well-known Ceph concept. A translation might prefer to use
> "Autoscaler" as-is in a translation, which in turn lends itself better to a
> search online.
>
> The patch series is split into three commits since each one can be a
Am 30.04.24 um 13:17 schrieb Filip Schauer:
> The pmxACMEAccountView & pmxACMEPluginView in proxmox-widget-toolkit
> were copied from pve-manager in commits 5df894de and 658bfdff. This
> makes pveACMEAccountView & pveACMEPluginView redundant, hence remove
> them and use pmxACMEAccountView & pmxACME
Reviewed-by: Fabian Grünbichler
IMHO this would also be a candidate for applying now - but held off
because of the RFC prefix ;)
On November 7, 2024 5:51 pm, Fiona Ebner wrote:
> In preparation to re-use it for restore from backup providers.
>
> Signed-off-by: Fiona Ebner
> ---
>
> New in v3.
Am 31.05.24 um 10:07 schrieb Dominik Csapak:
> we already have the information parsed, so it's cheap, and we already
> have a mechanism in place that adds 'ha-' as a css class, so
> let's reuse that.
>
> I chose a yellow wrench, as wrenches are associated with 'maintenance',
> and because the stat
Am 12.11.24 um 15:41 schrieb Dominik Csapak:
> by implementing Thomas suggestions from here:
> https://lore.proxmox.com/pve-devel/f592fea7-e0a5-4858-af48-b0b2ed57b...@proxmox.com/
>
> Dominik Csapak (5):
> webhook edit: improve layout and component hierarchy
> webhook edit: make items config n
Am 13.05.24 um 11:49 schrieb Christoph Heiss:
> No functional changes.
>
> Signed-off-by: Christoph Heiss
> ---
> Changes v1 -> v2:
> * no changes
>
> proxmox-auto-install-assistant/src/main.rs | 18 +-
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
>
applied this one w
Am 12.11.24 um 15:06 schrieb Christoph Heiss:
> On Tue, Nov 12, 2024 at 02:44:48PM +0100, Thomas Lamprecht wrote:
>> maybe still use $format-version or $hook-version or the like for the
>> serialized key? I.e., to even better convey that this is, e.g., not some
>> version from the installer or prod
Am 12.11.24 um 13:25 schrieb Stefan Hanreich:
> Signed-off-by: Stefan Hanreich
> ---
> proxmox-ve-config/tests/sdn/main.rs | 45 +++
> proxmox-ve-config/tests/sdn/resources/ipam.db | 26 +++
> 2 files changed, 71 insertions(+)
> create mode 100644 proxmox-ve-con
--- Begin Message ---
Prepare for debian trixie. Upstream has not yet made a new release since
Dec 2023, backporting this commit to make ifupdown2 work on trixie. Also
fixes an RC bug on debian (#1074250). Also fixed a typo in the commit msg.
upstream:
https://github.com/CumulusNetworks/ifupdown2
On 11.11.24 3:22 PM, Fabian Grünbichler wrote:
> On November 7, 2024 5:51 pm, Fiona Ebner wrote:
>> @@ -1042,6 +1044,31 @@ sub qga_fs_thaw {
>> $self->logerr($@) if $@;
>> }
>>
>> +# The size for fleecing images needs to be exactly the same size as QEMU
>> sees. E.g. EFI disk can bex
>> +#
Signed-off-by: Dominik Csapak
---
changes from v1:
* rebased on master
.../0001-add-PVE-specific-JS-code.patch | 4 ++--
...002-add-custom-fbresize-event-on-rfb.patch | 10 +-
...nge-scaling-when-toggling-fullscreen.patch | 6 +++---
...rectory-for-fetching-images-js-files.patch
On November 12, 2024 3:35 pm, Fiona Ebner wrote:
> On 12.11.24 1:27 PM, Fabian Grünbichler wrote:
>> On November 7, 2024 5:51 pm, Fiona Ebner wrote:
>>> + my $backup_access_info = eval { mon_cmd($vmid, "backup-access-setup",
>>> $params->%*) };
>>> + my $qmperr = $@;
>>> +
>>> + $task->{clea
thanks!
On November 7, 2024 5:51 pm, Fiona Ebner wrote:
> used for the shared 'COMMON_TAR_FLAGS' variable.
>
> Signed-off-by: Fiona Ebner
> ---
>
> New in v3.
>
> src/PVE/LXC/Create.pm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/PVE/LXC/Create.pm b/src/PVE/LXC/Create.pm
> in
Since we now have a standalone repository for Proxmox VE related
crates, add the required files for packaging the crates contained in
this repository.
Signed-off-by: Stefan Hanreich
---
.cargo/config.toml | 5 ++
.gitignore | 8 +++
Cargo.toml
Currently we are using tuples to represent IP ranges which is
suboptimal. Validation logic and invariant checking needs to happen at
every site using the IP range rather than having a unified struct for
enforcing those invariants.
Signed-off-by: Stefan Hanreich
---
.../src/firewall/types/address
A range can be used to store multiple IP addresses in an ipset that do
not neatly fit into a single CIDR.
Signed-off-by: Stefan Hanreich
---
proxmox-ve-config/src/firewall/types/ipset.rs | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/proxmox-ve-config/src/firewall/ty
Signed-off-by: Stefan Hanreich
---
proxmox-ve-config/src/firewall/types/address.rs | 10 ++
proxmox-ve-config/src/firewall/types/ipset.rs | 14 ++
2 files changed, 24 insertions(+)
diff --git a/proxmox-ve-config/src/firewall/types/address.rs
b/proxmox-ve-config/src/firewal
Signed-off-by: Stefan Hanreich
---
src/PVE/API2/Firewall/Makefile | 1 +
src/PVE/API2/Firewall/Rules.pm | 84 +
src/PVE/API2/Firewall/Vnet.pm | 168 +
src/PVE/Firewall.pm| 10 ++
4 files changed, 263 insertions(+)
create mode 10064
Signed-off-by: Stefan Hanreich
---
src/PVE/Firewall.pm | 80 ++---
1 file changed, 40 insertions(+), 40 deletions(-)
diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm
index 4a13926..efd53fc 100644
--- a/src/PVE/Firewall.pm
+++ b/src/PVE/Firewall.pm
@@
This direction will be used for specifying rules on bridge-level
firewalls as well as rules on the cluster / host level that are for
forwarded network packets.
Since with the introduction of this direction not every type of
firewall configuration can contain all types of directions, we
additionall
This adds the ability to dynamically configure and change the base_url
for the firewall options. This is needed for the SDN firewall dialog,
that updates the firewall components based on the selected vnet. This
avoids having to reinstantiate the component every time the user
selects a new vnet.
Si
Signed-off-by: Stefan Hanreich
---
.../src/firewall/types/address.rs | 81 +++
proxmox-ve-config/src/firewall/types/rule.rs | 6 +-
2 files changed, 31 insertions(+), 56 deletions(-)
diff --git a/proxmox-ve-config/src/firewall/types/address.rs
b/proxmox-ve-config/s
This patch series adds support for autogenerating ipsets for SDN objects. It
autogenerates ipsets for every VNet as follows:
* ipset containing all IP ranges of the VNet
* ipset containing all gateways of the VNet
* ipset containing all IP ranges of the subnet - except gateways
* ipset containing
Enables us to use the new forward direction as an option when creating
or editing firewall rules. By introducing firewall_type we can switch
between the available directions depending on which ruleset is being
edited.
Signed-off-by: Stefan Hanreich
---
www/manager6/dc/Config.js | 1 +
Signed-off-by: Stefan Hanreich
---
proxmox-ve-config/src/firewall/types/ipset.rs | 3 +++
1 file changed, 3 insertions(+)
diff --git a/proxmox-ve-config/src/firewall/types/ipset.rs
b/proxmox-ve-config/src/firewall/types/ipset.rs
index c1af642..6fbdca8 100644
--- a/proxmox-ve-config/src/firewall
some nits/comments/questions below, but the general direction/structure
already looks quite good I think!
On November 7, 2024 5:51 pm, Fiona Ebner wrote:
> The state of the VM's disk images at the time the backup is started is
> preserved via a snapshot-access block node. Old data is moved to the
Additionally add information about the SDN VNet firewall, which has
been introduced with this changes.
Signed-off-by: Stefan Hanreich
---
Makefile | 1 +
gen-pve-firewall-vnet-opts.pl | 12 +++
pve-firewall-vnet-opts.adoc | 8 +
pve-firewall.adoc | 65
We generate the following ipsets for every vnet in the running sdn
configuration:
* {vnet}-all: contains all subnets of the vnet
* {vnet}-no-gateway: contains all subnets of the vnet except for all
gateways
* {vnet}-gateway: contains all gateways in the vnet
* {vnet}-dhcp: contains all dhcp rang
This is mainly used in proxmox-perl-rs, so the generated ipsets can be
used in pve-firewall where only CIDRs are supported.
Signed-off-by: Stefan Hanreich
---
.../src/firewall/types/address.rs | 818 ++
1 file changed, 818 insertions(+)
diff --git a/proxmox-ve-config
Signed-off-by: Stefan Hanreich
---
proxmox-ve-config/src/lib.rs | 1 +
proxmox-ve-config/src/sdn/mod.rs | 248 +++
2 files changed, 249 insertions(+)
create mode 100644 proxmox-ve-config/src/sdn/mod.rs
diff --git a/proxmox-ve-config/src/lib.rs b/proxmox-ve-conf
This also includes support for parsing rules referencing IPSets in the
new SDN scope and generating those IPSets in the firewall.
Loading SDN configuration is optional, since loading it requires root
privileges which we do not have in all call sites. Adding the flag
allows us to selectively load t
They act like virtual ipsets, similar to ipfilter-net, that can be
used for defining firewall rules for sdn objects dynamically.
The changes in proxmox-ve-config also introduced a dedicated struct
for representing ip ranges, so we update the existing code, so that it
uses that struct as well.
Sig
Almost every type should implement them anyway, and many of them are
required for those types to be used in BTreeMaps, which the nftables
firewall uses for generating stable output.
Additionally, we derive Serialize and Deserialize for a few types that
occur in the sdn configuration. The following
Signed-off-by: Stefan Hanreich
---
proxmox-ve-config/src/common/mod.rs | 31 +
proxmox-ve-config/src/lib.rs| 1 +
2 files changed, 32 insertions(+)
create mode 100644 proxmox-ve-config/src/common/mod.rs
diff --git a/proxmox-ve-config/src/common/mod.rs
b/pro
Signed-off-by: Stefan Hanreich
---
proxmox-ve-config/src/host/mod.rs | 1 +
proxmox-ve-config/src/host/types.rs | 46 +
2 files changed, 47 insertions(+)
create mode 100644 proxmox-ve-config/src/host/types.rs
diff --git a/proxmox-ve-config/src/host/mod.rs
b/proxm
We introduce a new type of firewall config file that can be used for
defining rules on bridge-level, similar to the existing
cluster/host/vm configuration files.
Signed-off-by: Stefan Hanreich
---
proxmox-ve-config/src/firewall/bridge.rs | 64
1 file changed, 64 insertio
Used for obtaining the IPSets that get autogenerated by the nftables
firewall. The returned configuration has the same format as the
pve-firewall uses internally, making it compatible with the existing
pve-firewall code.
Signed-off-by: Stefan Hanreich
---
pve-rs/Cargo.toml | 1 +
pve-
For every guest that has at least one entry in the IPAM we generate an
ipset with the name `+sdn/guest-ipam-{vmid}`. The ipset contains all
IPs from all zones for a guest with {vmid}.
Signed-off-by: Stefan Hanreich
---
.../src/firewall/types/address.rs | 9 +
proxmox-ve-config/s
Signed-off-by: Stefan Hanreich
---
src/PVE/API2/Network/SDN/Vnets.pm | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/PVE/API2/Network/SDN/Vnets.pm
b/src/PVE/API2/Network/SDN/Vnets.pm
index 05915f6..e48b048 100644
--- a/src/PVE/API2/Network/SDN/Vnets.pm
+++ b/src/PVE/API2/Network/SD
Signed-off-by: Stefan Hanreich
---
proxmox-nftables/src/types.rs | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/proxmox-nftables/src/types.rs b/proxmox-nftables/src/types.rs
index 3101436..d8f3b62 100644
--- a/proxmox-nftables/src/types.rs
+++ b/proxmox-nftables/src/t
Expose the ability to create vnet-level firewalls in the PVE UI
Signed-off-by: Stefan Hanreich
---
www/manager6/Makefile| 2 +
www/manager6/dc/Config.js| 8 +++
www/manager6/sdn/FirewallPanel.js| 50 ++
www/manager6/sdn/FirewallVnetView.js | 77 +
Similar to how the IPAM module works, we separate the internal
representation from the concrete schema of the configuration file.
We provide structs for parsing the running SDN configuration and a
struct that is used internally for representing an SDN configuration,
as well as a method for convert
Signed-off-by: Stefan Hanreich
---
www/manager6/form/IPRefSelector.js | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/www/manager6/form/IPRefSelector.js
b/www/manager6/form/IPRefSelector.js
index d41cde5f5..16078e428 100644
--- a/www/manager6/form/IPRefSelector.js
+++
This module includes structs for representing the JSON schema from the
PVE ipam. Those can be used to parse the current IPAM state.
We also include a general Ipam struct, and provide a method for
converting the PVE IPAM to the general struct. The idea behind this
is that we have multiple IPAM plug
Add tests for validating the directions in the guest firewall
configuration. While I'm at it, I also added tests for validating
interface names, since this functionality did not get tested before.
Signed-off-by: Stefan Hanreich
---
proxmox-ve-config/src/firewall/guest.rs | 53 +++
## Introduction
This patch series introduces a new direction for firewall rules: forward.
Additionally this patch series introduces defining firewall rules on a vnet
level.
## Use Cases
For hosts:
* hosts utilizing NAT can define firewall rules for NATed traffic
* hosts utilizing EVPN zones can
Signed-off-by: Stefan Hanreich
---
proxmox-ve-config/tests/sdn/main.rs | 144 ++
.../tests/sdn/resources/running-config.json | 54 +++
2 files changed, 198 insertions(+)
create mode 100644 proxmox-ve-config/tests/sdn/main.rs
create mode 100644 proxmox-ve-config/
This is more efficient than draining and collecting the Vec. It also
fixes the respective clippy lint.
Signed-off-by: Stefan Hanreich
---
proxmox-firewall/src/rule.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxmox-firewall/src/rule.rs b/proxmox-firewall/src/rule.rs
i
Since the SDN configuration reads the IPAM config file, which resides
in /etc/pve/priv we need to add the protected flag to several
endpoints.
Signed-off-by: Stefan Hanreich
---
src/PVE/API2/Firewall/Cluster.pm | 8 ++--
src/PVE/API2/Firewall/Rules.pm | 12 +++-
src/PVE/API2/Firew
Signed-off-by: Stefan Hanreich
---
proxmox-firewall/src/config.rs | 88 -
proxmox-firewall/tests/integration_tests.rs | 12 +++
2 files changed, 98 insertions(+), 2 deletions(-)
diff --git a/proxmox-firewall/src/config.rs b/proxmox-firewall/src/config.rs
index c2
Since forward rules only take effect when the nftables firewall is
enabled, show a warning to users that informs them of this.
Signed-off-by: Stefan Hanreich
---
www/manager6/grid/FirewallRules.js | 15 +++
1 file changed, 15 insertions(+)
diff --git a/www/manager6/grid/FirewallRule
Signed-off-by: Stefan Hanreich
---
pvesdn.adoc | 92 +
1 file changed, 92 insertions(+)
diff --git a/pvesdn.adoc b/pvesdn.adoc
index 39de80f..c187365 100644
--- a/pvesdn.adoc
+++ b/pvesdn.adoc
@@ -702,6 +702,98 @@ For more information please co
Signed-off-by: Stefan Hanreich
---
proxmox-ve-config/tests/sdn/main.rs | 45 +++
proxmox-ve-config/tests/sdn/resources/ipam.db | 26 +++
2 files changed, 71 insertions(+)
create mode 100644 proxmox-ve-config/tests/sdn/resources/ipam.db
diff --git a/proxmox-ve-c
Add the configuration options for vnet-level firewalls to the options
component. Additionally add the new policy_forward configuration
option to the datacenter-level firewall as well.
Signed-off-by: Stefan Hanreich
---
www/manager6/grid/FirewallOptions.js | 38 +++-
1 fil
Signed-off-by: Stefan Hanreich
---
src/PVE/Firewall.pm | 127 ++--
src/PVE/Firewall/Helpers.pm | 12
2 files changed, 132 insertions(+), 7 deletions(-)
diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm
index 6e02873..fc71d86 100644
--- a/src/PVE
Signed-off-by: Stefan Hanreich
---
.../resources/proxmox-firewall.nft| 54
proxmox-firewall/src/firewall.rs | 122 +-
proxmox-firewall/src/rule.rs | 5 +-
.../integration_tests__firewall.snap | 86
proxmo
Also add example SDN configuration files that get automatically
loaded, which can be used for future tests.
Signed-off-by: Stefan Hanreich
---
proxmox-firewall/src/config.rs| 69 +++
.../tests/input/.running-config.json | 45
proxmox-firewall
superseded by:
https://lore.proxmox.com/pve-devel/20241112122615.88854-1-s.hanre...@proxmox.com/T/#m646bd4b0be7652b2cc8afc411e6c96366ddb9a14
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-de
superseded by:
https://lore.proxmox.com/pve-devel/20241112122602.88598-1-s.hanre...@proxmox.com/T/#m3c6f184e088b362a92705fb4a5a6ddab11640e43
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-de
Signed-off-by: Timothy Nicholson
---
changes since v3 [0]:
- implement conditional warning message that displays which node(s)
have pending changes.
I'd be thankful for any feedback, as this can probably be refined in
some way.
[0]:
https://lore.proxmox.com/pve-devel/20241112120255.127300-1-t.
one very small nit inline at the end
On 2024-07-24 17:05, Max Carrara wrote:
The build commit is displayed and taken into account when comparing
monitor and manager versions in the client. Specifically, the
shortened build commit is now displayed in parentheses next to the
version for both mon
This adds a metadata-field `$version` to the post-hook json, indicating
which schema version (and thus structure) this document uses.
The field is of format ".", following the semantic
versioning meaning for both the major and minor number. A patch version
is left out here, as it doesn't make much
This adds a metadata-field `$hook` containing a single key `version`
(for now) to the post-hook json, indicating which schema version (and
thus structure) this document uses.
In the resulting JSON, this will look like this:
{
"$hook": {
"version": "1.0"
},
"debian-version": ..,
Am 12.11.24 um 08:51 schrieb Dominik Csapak:
> so it gets cleaned up too
>
> Signed-off-by: Dominik Csapak
> ---
> new in v2
>
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 431dff9..d1159e0 100644
> --- a/Makefile
> +++ b/Makefi
On 11/12/24 14:38, Thomas Lamprecht wrote:
Am 12.11.24 um 12:45 schrieb Dominik Csapak:
and make it configurable in the tree browser settings.
this makes now use of the new sorting order and the more efficient
'getFilterFn' method of the viewSelector
works OK besides some eslint warnings (see
Am 12.11.24 um 08:51 schrieb Dominik Csapak:
> Signed-off-by: Dominik Csapak
> ---
> changes from v1:
> * rebased on master
>
> .../0001-add-PVE-specific-JS-code.patch | 4 ++--
> ...002-add-custom-fbresize-event-on-rfb.patch | 10 +-
> ...nge-scaling-when-toggling-fullscreen.patc
Am 12.11.24 um 08:51 schrieb Dominik Csapak:
> Signed-off-by: Dominik Csapak
> ---
> changes from v1:
> * rebased on master
>
> debian/changelog | 8
> 1 file changed, 8 insertions(+)
>
>
applied, thanks! But I dropped the note w.r.t. to the buildsys fix, for
packages that are not dev
> Dominik Csapak hat am 12.11.2024 10:16 CET geschrieben:
>
>
> one comment inline
>
> On 11/11/24 12:35, Timothy Nicholson wrote:
> > Several strings that should probably also be translated now use
> > the gettext function to be translated.
> >
> > Signed-off-by: Timothy Nicholson
> > ---
Signed-off-by: Timothy Nicholson
---
I missed one occurence of the String 'TFA' not using gettext, so
here is the updated patch.
www/manager6/Workspace.js | 2 +-
www/manager6/ceph/OSD.js | 6 +++---
www/manager6/ceph/OSDDetails.js| 2 +-
www/manager6/dc/Us
On 2024-11-11 21:55, Thomas Lamprecht wrote:
Am 02.10.24 um 15:11 schrieb Aaron Lauterer:
The new optional bridge_vids field allows to set that property via the
GUI. Since the backend needs to support it, the field needs to be
explicitly enabled.
For now, Proxmox VE (PVE) is the use case.
sent a v6
https://lore.proxmox.com/pve-devel/20241112092554.106723-1-a.laute...@proxmox.com/T/#t
On 2024-10-02 15:11, Aaron Lauterer wrote:
Since this version reworks a few things, especially in the logic, I
dropped the r-b and t-b tags in some patches.
The following patch has been dropped a
Am 07.11.24 um 17:51 schrieb Fiona Ebner:
> Fiona Ebner (9):
> block/reqlist: allow adding overlapping requests
> PVE backup: fixup error handling for fleecing
> PVE backup: factor out setting up snapshot access for fleecing
> PVE backup: save device name in device info structure
> PVE ba
From: Alexandre Derumier via pve-devel
Add support for bridge ports isolation
https://github.com/torvalds/linux/commit/7d850abd5f4edb1b1ca4b4141a4453305736f564
This allow to drop traffic between all ports having isolation enabled
on the local bridge, but allow traffic with non isolated ports.
H
Am 12.11.24 um 15:53 schrieb Christoph Heiss:
> This adds a metadata-field `$hook` containing a single key `version`
> (for now) to the post-hook json, indicating which schema version (and
> thus structure) this document uses.
>
> In the resulting JSON, this will look like this:
> {
> "$hook":
From: Alexandre Derumier via pve-devel
We add this as advanced option in the UI and also move vlan-aware
to advanced section.
Signed-off-by: Alexandre Derumier
[ SH: improve naming and commit msg slightly ]
Signed-off-by: Stefan Hanreich
---
www/manager6/sdn/VnetEdit.js | 12
1
Am 12.11.24 um 10:03 schrieb Aaron Lauterer:
> On 2024-11-11 21:55, Thomas Lamprecht wrote:
>> Am 02.10.24 um 15:11 schrieb Aaron Lauterer:
>>> if (me.iftype === 'bridge') {
>>> + let vids = Ext.create('Ext.form.field.Text', {
>>> + fieldLabel: gettext('Bridge VIDS'),
>>
>> I
On Mon, Nov 11, 2024 at 11:31:05PM +0100, Thomas Lamprecht wrote:
> Am 16.08.24 um 18:19 schrieb Christoph Heiss:
> > This adds a separate debian package to the build, containing a
> > statically-built version of `proxmox-auto-install-assistant`, as
> > was suggested in #4788 [0] (for proxmox-backu
On 11.11.24 7:33 PM, Thomas Lamprecht wrote:
> Am 07.11.24 um 17:51 schrieb Fiona Ebner:
>> +package PVE::Env;
>
> can this module and it's name be more specific to doing stuff with/in
> namespaces?
>
> e.g. PVE::Namespaces or PVE::Sys::Namespaces (there might be other stuff that
> might
> fit
Signed-off-by: Stefan Hanreich
---
pvesdn.adoc | 5 +
1 file changed, 5 insertions(+)
diff --git a/pvesdn.adoc b/pvesdn.adoc
index 39de80f..b1f2578 100644
--- a/pvesdn.adoc
+++ b/pvesdn.adoc
@@ -383,6 +383,11 @@ Tag:: The unique VLAN or VXLAN ID
VLAN Aware:: Enables vlan-aware option on the
Tested the series in my test cluster.
Had one node with a newer build recently installed but no services
restarted just yet. The build short IDs were visible where I would
expect it and the Ceph status, MON, OSD and MDS panels showed nicely
that the services should be restarted to run the new
On November 7, 2024 5:51 pm, Fiona Ebner wrote:
> The first use case is running the container backup subroutine for
> external providers inside a user namespace. That allows them to see
> the filesystem to back-up from the containers perspective and also
> improves security because of isolation.
>
Am 12.11.24 um 10:11 schrieb Fabian Grünbichler:
> the HA case could also switch over to this approach, if we want to
> reload HA for all PVE perl modules.. if we only want it for a subset,
> then yes, the/an explicit trigger is better :)
[...]
> see above - the question is whether we want an ex
Am 12.11.24 um 11:07 schrieb Christoph Heiss:
> On Mon, Nov 11, 2024 at 11:31:05PM +0100, Thomas Lamprecht wrote:
>> Am 16.08.24 um 18:19 schrieb Christoph Heiss:
>>> This adds a separate debian package to the build, containing a
>>> statically-built version of `proxmox-auto-install-assistant`, as
> Thomas Lamprecht hat am 12.11.2024 10:52 CET
> geschrieben:
>
>
> Am 12.11.24 um 10:11 schrieb Fabian Grünbichler:
> > the HA case could also switch over to this approach, if we want to
> > reload HA for all PVE perl modules.. if we only want it for a subset,
> > then yes, the/an explicit t
On 2024-11-12 10:55, Thomas Lamprecht wrote:
Am 12.11.24 um 10:03 schrieb Aaron Lauterer:
On 2024-11-11 21:55, Thomas Lamprecht wrote:
Am 02.10.24 um 15:11 schrieb Aaron Lauterer:
if (me.iftype === 'bridge') {
+ let vids = Ext.create('Ext.form.field.Text', {
+
Signed-off-by: Timothy Nicholson
---
changes since v2 [0]:
- changed icon
- modified confirmation message
A conditional confirmation message would definitely be nicer, I can
send a patch for that later on today as v4.
[0]:
https://lore.proxmox.com/pve-devel/20241104122457.95494-1-t.nichol...@
Am 12.11.24 um 10:38 schrieb Timothy Nicholson:
> Signed-off-by: Timothy Nicholson
> ---
>
> I missed one occurence of the String 'TFA' not using gettext, so
> here is the updated patch.
well that's the only one I'm not 100% certain about, how would such an
abbreviation even get translated?
Alb
1 - 100 of 128 matches
Mail list logo
