Tested the series in my test cluster.
Had one node with a newer build recently installed but no services
restarted just yet. The build short IDs were visible where I would
expect it and the Ceph status, MON, OSD and MDS panels showed nicely
that the services should be restarted to run the new build.
One thing I noticed is that if one node has a newer build installed, the
OSDs on that node show, as expected, that they need to be restarted to
run the latest build.
But the other nodes don't show any hint that there is a newer build used
in the cluster, and the remaining nodes should update. I don't see an
easy way how we could achieve that consistently with the current
approach where we don't know the apt package versions used in the cluster.
Only found one tiny nit in patch 1/5 in the phrasing of one message.
Consider this series:
Tested-By: Aaron Lauterer <a.laute...@proxmox.com>
Reviewed-By: Aaron Lauterer <a.laute...@proxmox.com>
On 2024-07-24 17:05, Max Carrara wrote:
Ceph Build Commit in UI - Version 3
===================================
Notable Changes Since v2
------------------------
* Rebase on master branch as v2 was partially applied (thanks!)
* Factor duplicate build commit rendering code into separate helper
as suggested [1] (thanks Thomas!)
* Make variable names more clear / less ambiguous (thanks Thomas!)
* Increase default width of version column in OSD tree view ever so
slightlymore
* Reword commit titles and messages to reflect the changes made
For a detailed list of changes please see the comments in the individual
patches.
NOTE: Any T-b and R-b trailers on patches that received changes are
considered outdated and are thus removed.
Older Versions
--------------
v1: https://lists.proxmox.com/pipermail/pve-devel/2024-April/063772.html
v2: https://lists.proxmox.com/pipermail/pve-devel/2024-July/064349.html
References
----------
[1]: https://lists.proxmox.com/pipermail/pve-devel/2024-July/064789.html
Summary of Changes
------------------
Max Carrara (5):
fix #5366: ui: ceph: services: parse and display build commit
fix #5366: api: ceph: add host build commit to Ceph OSD index data
fix #5366: ui: ceph: osd: rework version field rendering
ui: ceph: osd: increase width of version column
fix #5366: api: ceph: change version format in OSD metadata endpoint
PVE/API2/Ceph/OSD.pm | 9 ++-
www/manager6/Utils.js | 107 +++++++++++++++++++++++++++++++
www/manager6/ceph/OSD.js | 54 ++++++++++++----
www/manager6/ceph/ServiceList.js | 33 +++++++---
www/manager6/ceph/Services.js | 19 +++++-
5 files changed, 198 insertions(+), 24 deletions(-)
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
