Signed-off-by: Timothy Nicholson <t.nichol...@proxmox.com> --- changes since v2 [0]: - changed icon - modified confirmation message
A conditional confirmation message would definitely be nicer, I can send a patch for that later on today as v4. [0]: https://lore.proxmox.com/pve-devel/20241104122457.95494-1-t.nichol...@proxmox.com/ www/manager6/sdn/StatusView.js | 24 ++++++++++++++++-------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/www/manager6/sdn/StatusView.js b/www/manager6/sdn/StatusView.js index 970aa919..ab500897 100644 --- a/www/manager6/sdn/StatusView.js +++ b/www/manager6/sdn/StatusView.js @@ -41,14 +41,22 @@ Ext.define('PVE.sdn.StatusView', { { text: gettext('Apply'), handler: function() { - Proxmox.Utils.API2Request({ - url: '/cluster/sdn/', - method: 'PUT', - waitMsgTarget: me, - failure: function(response, opts) { - Ext.Msg.alert(gettext('Error'), response.htmlStatus); - }, - }); + Ext.Msg.show({ + title: gettext('Confirm'), + icon: Ext.Msg.QUESTION, + msg: gettext('Applying pending SDN changes will also apply any pending local node network changes. Proceed?'), + buttons: Ext.Msg.YESNO, + callback: function(btn) { + if (btn === 'yes') { + Proxmox.Utils.API2Request({ + url: '/cluster/sdn/', + method: 'PUT', + waitMsgTarget: me, + failure: response => Ext.Msg.alert(gettext('Error'), response.htmlStatus), + }); + } + } + }) }, }, ], -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
