[pve-devel] [PATCH storage v4 2/4] pbs: Make it possible to reuse PBS connection for datastore API call

2023-11-27 Thread Philipp Hufnagl
not, it will create a new one. Signed-off-by: Philipp Hufnagl --- src/PVE/Storage/PBSPlugin.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/Storage/PBSPlugin.pm b/src/PVE/Storage/PBSPlugin.pm index 96373a4..b4d7914 100644 --- a/src/PVE/Storage/PBSPlugin.pm +++ b

[pve-devel] [PATCH storage v4 4/4] pbs: fix #5008: Check if datastore and namespace is valid on add- and update hooks

2023-11-27 Thread Philipp Hufnagl
: Philipp Hufnagl --- src/PVE/API2/Storage/Config.pm | 4 ++-- src/PVE/Storage/PBSPlugin.pm | 41 ++ 2 files changed, 43 insertions(+), 2 deletions(-) diff --git a/src/PVE/API2/Storage/Config.pm b/src/PVE/API2/Storage/Config.pm index e04b6ab..651d4bc 100755 --- a

[pve-devel] [PATCH storage v4 3/4] pbs: Extraxt check_datastore_exists from activate_storage

2023-11-27 Thread Philipp Hufnagl
Parts contained in activate_storage are needed to be run to fix #5008, however, implementing a namespace check there would cause unneeded overhead. Therefore, this patch extracts the method check_datastore_exists from activate storage. Signed-off-by: Philipp Hufnagl --- src/PVE/Storage

[pve-devel] [PATCH storage v4 0/4] pbs: fix #5008: Check if datastore and namespace is valid on add- and update hooks

2023-11-27 Thread Philipp Hufnagl
pretty sure that this modification does not break anything, however a second look would be appreciated! Signed-off-by: Philipp Hufnagl --- Changes since v3: * Modify src/PVE/API2/Storage/Config.pm to add server address Changes since v2: * Typos * reuse connecton on one more place previously

[pve-devel] [PATCH storage v4 1/4] pbs: Move pbs_api_connect earlyer in the code

2023-11-27 Thread Philipp Hufnagl
Because it is needed later in this patch series, the method pbs_api_connect is moved earlyer in the code Signed-off-by: Philipp Hufnagl --- src/PVE/Storage/PBSPlugin.pm | 63 ++-- 1 file changed, 32 insertions(+), 31 deletions(-) diff --git a/src/PVE/Storage

Re: [pve-devel] [PATCH storage v3 0/4] pbs: fix #5008: Prevent adding pbs storage with invalid namespace

2023-11-21 Thread Philipp Hufnagl
On 11/21/23 14:40, Christian Ebner wrote: > >> On 21.11.2023 14:12 CET Philipp Hufnagl wrote: >> >> >> Hmmm... thats very curios. I tried that on my end and it worked fine. >> >> What datastore did you try to delete? Did you have a valid >> config

Re: [pve-devel] [PATCH v4 manager 0/4] vzdump: add 'notification-mode' parameter

2023-11-21 Thread Philipp Hufnagl
On 11/21/23 13:52, Lukas Wagner wrote: > This patch series adds the 'notification-mode' setting for backup jobs. > It allows users to choose between the 'old-style' notifications > (mail to configured address, directly via a call to sendmail) or > the 'new-style' notification system. > > noti

Re: [pve-devel] [PATCH storage v3 0/4] pbs: fix #5008: Prevent adding pbs storage with invalid namespace

2023-11-21 Thread Philipp Hufnagl
On 11/21/23 13:16, Christian Ebner wrote: >> On 16.11.2023 11:35 CET Philipp Hufnagl wrote: >> >> >> Currently, when adding a PBS storage with a namespace that does not >> exist, the storage gets added normally, but browsing/using it only >> returns a cryp

Re: [pve-devel] [PATCH v3 pve-manager 3/5] ui: backup jobs: add 'notification-mode' selector for backup jobs

2023-11-21 Thread Philipp Hufnagl
On 11/21/23 13:23, Lukas Wagner wrote: > This selector allows one to selected between the 'old' (send email > directly via sendmail) or the 'new' notification system. > > The default is 'auto', which sends and email if one is configured, > and uses the notification system if no email address is

Re: [pve-devel] [PATCH v2 guest-common/manager 0/4] vzdump: add 'notification-mode' parameter

2023-11-21 Thread Philipp Hufnagl
The build in mail-to-root target can be disabled but not be deleted. Is this on purpose? ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH v2 pve-manager] ui: node summary: use SI units for HD usage

2023-11-21 Thread Philipp Hufnagl
7; + gettext('HD space'), > valueField: 'rootfs', > maxField: 'rootfs', > - renderer: Proxmox.Utils.render_node_size_usage, > + renderer: ({ used, total }) => > Proxmox.Utils.render_size_usage(used, total

Re: [pve-devel] [PATCH pve-manager] ui: node summary: use SI units for HD usage

2023-11-21 Thread Philipp Hufnagl
e, > + renderer: function(record) { > + return Proxmox.Utils.render_size_usage(record.used, > record.total, true); > + }, > }, > { > iconCls: 'fa fa-fw fa-refresh', LGTM Tested-by: Philipp Hufnagl Reviewed-by: Phi

Re: [pve-devel] [RFC access-control/manager 0/4] fix #1148: nested pools

2023-11-16 Thread Philipp Hufnagl
I think you made a mistake when sending this patch. There are only one 3 out of 4 files attached and [pve-devel] [PATCH access-control 2/2] pools: record parent/subpool information appears to be double. ___ pve-devel mailing list pve-devel@lists.prox

Re: [pve-devel] [PATCH common v3 2/5] tools: add is_deeply

2023-11-16 Thread Philipp Hufnagl
On 11/16/23 14:55, Dominik Csapak wrote: > to compare nested hashes/lists and scalar values recursively. > Also includes some tests > > Signed-off-by: Dominik Csapak > --- > new in v3, split out from section config > changes to the is_deeply function: > * incorporate thomas suggestions > * fix

Re: [pve-devel] [PATCH storage v2 4/4] pbs: fix #5008: Check if datastore and namespace is valid on add- and update hooks

2023-11-16 Thread Philipp Hufnagl
On 11/16/23 10:57, Fiona Ebner wrote: > Am 15.11.23 um 17:00 schrieb Philipp Hufnagl: >> @@ -831,10 +855,27 @@ sub check_datastore_exists { >> return 1; >> } >> } >> - >> die "$storeid: Cannot find datastore '$d

[pve-devel] [PATCH storage v3 4/4] pbs: fix #5008: Check if datastore and namespace is valid on add- and update hooks

2023-11-16 Thread Philipp Hufnagl
functionallity to check namespaces is added with this commit. For checking the datastore, existing code that has previously been refactored will be reused Signed-off-by: Philipp Hufnagl --- src/PVE/Storage/PBSPlugin.pm | 41 1 file changed, 41 insertions(+) diff

[pve-devel] [PATCH storage v3 1/4] pbs: Move pbs_api_connect earlyer in the code

2023-11-16 Thread Philipp Hufnagl
Because it is needed later in this patch series, the method pbs_api_connect is moved earlyer in the code Signed-off-by: Philipp Hufnagl --- src/PVE/Storage/PBSPlugin.pm | 63 ++-- 1 file changed, 32 insertions(+), 31 deletions(-) diff --git a/src/PVE/Storage

[pve-devel] [PATCH storage v3 3/4] pbs: Extraxt check_datastore_exists from activate_storage

2023-11-16 Thread Philipp Hufnagl
Parts contained in activate_storage are needed to be run to fix #5008, however, implementing a namespace check there would cause unneeded overhead. Therefore, this patch extracts the method check_datastore_exists from activate storage. Signed-off-by: Philipp Hufnagl --- src/PVE/Storage

[pve-devel] [PATCH storage v3 0/4] pbs: fix #5008: Prevent adding pbs storage with invalid namespace

2023-11-16 Thread Philipp Hufnagl
, the storage will be added without error. This is done by adding code to check if the namespace exists and call it as well as existing code to check if a datastore exists on the add and update hooks of the PBS datastore. Signed-off-by: Philipp Hufnagl --- Changes since v2: * Typos * reuse

[pve-devel] [PATCH storage v3 2/4] pbs: Make it possible to reuse PBS connection for datastore API call

2023-11-16 Thread Philipp Hufnagl
not, it will create a new one. Signed-off-by: Philipp Hufnagl --- src/PVE/Storage/PBSPlugin.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/Storage/PBSPlugin.pm b/src/PVE/Storage/PBSPlugin.pm index 96373a4..b4d7914 100644 --- a/src/PVE/Storage/PBSPlugin.pm +++ b

[pve-devel] [PATCH storage v2 0/4] pbs: fix #5008: Prevent adding pbs storage with invalid namespace

2023-11-15 Thread Philipp Hufnagl
, the storage will be added without error. This is done by adding code to check if the namespace exists and call it as well as existing code to check if a datastore exists on the add and update hooks of the PBS datastore. Signed-off-by: Philipp Hufnagl --- Changes since v1: * do not add any

[pve-devel] [PATCH storage v2 4/4] pbs: fix #5008: Check if datastore and namespace is valid on add- and update hooks

2023-11-15 Thread Philipp Hufnagl
functionallity to check namespaces is added with this commit. For checking the datastore, existing code that has previously been refactored will be reused Signed-off-by: Philipp Hufnagl --- src/PVE/Storage/PBSPlugin.pm | 43 +++- 1 file changed, 42 insertions(+), 1

[pve-devel] [PATCH storage v2 3/4] pbs: Extraxt check_datastore_exists from activate_storage

2023-11-15 Thread Philipp Hufnagl
Parts contained in activate_storage are needed to be run to fix #5008, however, implementing a namespace check there would cause unneded overhead. Therfore, this patch extracts the method check_datastore_exists from activate storage. Signed-off-by: Philipp Hufnagl --- src/PVE/Storage

[pve-devel] [PATCH storage v2 2/4] pbs: Make it possible to reuse PBS connection for datastore API call

2023-11-15 Thread Philipp Hufnagl
not, it will create a new one. Signed-off-by: Philipp Hufnagl --- src/PVE/Storage/PBSPlugin.pm | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/PVE/Storage/PBSPlugin.pm b/src/PVE/Storage/PBSPlugin.pm index 96373a4..81df21e 100644 --- a/src/PVE/Storage/PBSPlugin.pm +++ b

[pve-devel] [PATCH storage v2 1/4] pbs: Move pbs_api_connect earlyer in the code

2023-11-15 Thread Philipp Hufnagl
Because it is needed later in this patch series, the method pbs_api_connect is moved earlyer in the code Signed-off-by: Philipp Hufnagl --- src/PVE/Storage/PBSPlugin.pm | 63 ++-- 1 file changed, 32 insertions(+), 31 deletions(-) diff --git a/src/PVE/Storage

Re: [pve-devel] [PATCH storage] fix #5008: prevent adding pbs storage with invalid namespace

2023-11-15 Thread Philipp Hufnagl
On 11/15/23 11:09, Thomas Lamprecht wrote: > Am 15/11/2023 um 11:05 schrieb Philipp Hufnagl: >> >> >> On 11/15/23 10:52, Thomas Lamprecht wrote: >>> Am 15/11/2023 um 10:37 schrieb Philipp Hufnagl: >>>> On 11/15/23 09:31, Fiona Ebner wrote: >>

Re: [pve-devel] [PATCH storage] fix #5008: prevent adding pbs storage with invalid namespace

2023-11-15 Thread Philipp Hufnagl
On 11/15/23 10:52, Thomas Lamprecht wrote: > Am 15/11/2023 um 10:37 schrieb Philipp Hufnagl: >> On 11/15/23 09:31, Fiona Ebner wrote: >>> Am 14.11.23 um 15:27 schrieb Philipp Hufnagl: >>>> diff --git a/src/PVE/Storage/PBSPlugin.pm b/src/PVE/Storage/PBSPlugin.

Re: [pve-devel] [PATCH storage] fix #5008: prevent adding pbs storage with invalid namespace

2023-11-15 Thread Philipp Hufnagl
On 11/15/23 09:31, Fiona Ebner wrote: > Am 14.11.23 um 15:27 schrieb Philipp Hufnagl: >> Currently, when adding a PBS storage with a namespace that does not >> exist, the storage gets added normally, but browsing/using it only >> returns a cryptic error message. >> &

[pve-devel] [PATCH storage] fix #5008: prevent adding pbs storage with invalid namespace

2023-11-14 Thread Philipp Hufnagl
, the storage will be added without error. Signed-off-by: Philipp Hufnagl --- src/PVE/Storage/PBSPlugin.pm | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/src/PVE/Storage/PBSPlugin.pm b/src/PVE/Storage/PBSPlugin.pm index 4320974..aceb2c4 100644 --- a/src

[pve-devel] [PATCH proxmox-widget-toolkit v2 2/3] fix #4546: utils: Highlight accounts in user management that exprie soon

2023-10-10 Thread Philipp Hufnagl
When a user account is about to expire in the next 7 days, the date column will be highlighted with warning color. Signed-off-by: Philipp Hufnagl --- src/Utils.js | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/Utils.js b/src/Utils.js index f269607..f5769a0 100644

[pve-devel] [PATCH access-control v2 1/1] fix #4546: api: Return user expiration date on access/ticket API call

2023-10-10 Thread Philipp Hufnagl
Adds an additional, optional parameter to the access/tickets api call which tells when the currently used user account will expire. If it will not expire, the parameter will not be added. Signed-off-by: Philipp Hufnagl --- src/PVE/API2/AccessControl.pm | 8 src/PVE/AccessControl.pm

[pve-devel] [PATCH proxmox-widget-toolkit v2 1/1] fix #4546: ui: notify user if there usser account expires soon

2023-10-10 Thread Philipp Hufnagl
-off-by: Philipp Hufnagl --- www/manager6/Workspace.js | 28 1 file changed, 28 insertions(+) diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js index 18d574b7..41d44a00 100644 --- a/www/manager6/Workspace.js +++ b/www/manager6/Workspace.js @@ -42,6

[pve-devel] [PATCH proxmox-widget-toolkit v2 1/3] fix #4546: css: create a new css class for warning texts

2023-10-10 Thread Philipp Hufnagl
or consistency. Signed-off-by: Philipp Hufnagl --- .../scss/abstracts/_variables.scss| 20 ++- src/proxmox-dark/scss/extjs/_menu.scss| 4 src/proxmox-dark/scss/other/_charts.scss | 4 ++-- 3 files changed, 17 insertions(+), 11 deletions(-) diff --git a/s

[pve-devel] [PATCH proxmox-widget-toolkit/manager/access-control v2 0/5] fix #4546: Show warning hint/badge if user account is expiring in next few days

2023-10-10 Thread Philipp Hufnagl
have forgotten something please tell _menu Changes since v1: * Rename variables according to feedback * Reuse existing css colors according to feedback * Rework API parameters according to feedback * Minor code changes Philipp Hufnagl (3): fix #4546: css: create a new css class for

[pve-devel] [PATCH proxmox-widget-toolkit v2 3/3] fix #4546: utils: Expand authentication data with account expiry date

2023-10-10 Thread Philipp Hufnagl
When the authentication data of a session are set, the account expiry date will be set also (provided there is one). Signed-off-by: Philipp Hufnagl --- src/Utils.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/Utils.js b/src/Utils.js index f5769a0..654c907 100644 --- a/src

Re: [pve-devel] [PATCH proxmox-widget-toolkit v1 1/2] fix #4546: css: Inform user administrator about user accounts expiring soon

2023-10-10 Thread Philipp Hufnagl
> for the light theme you could simply use the `.warning` class instead > then you can simply overwrite that with a more specific selector in the > dark theme again, like we already do in a couple of places. Thank you. I tried using .warning. Unfortunately the result was yellow on white backgro

Re: [pve-devel] [PATCH manager v1 1/1] fix #4546: ui: notify user if their user account expires soon

2023-10-10 Thread Philipp Hufnagl
On 10/6/23 15:16, Lukas Wagner wrote: > Comments inline. > > On 9/22/23 16:36, Philipp Hufnagl wrote: >> When the user account that is currently logged in will expire soon, the >> user icon will turn into a yellow exclamation mark. In the user menu >> there will be

Re: [pve-devel] [PATCH manager/access-control/proxmox-widget-toolkit v1 0/4] fix #4546: Show warning hint/badge if user account is expiring in next few days

2023-10-09 Thread Philipp Hufnagl
On 10/6/23 15:16, Lukas Wagner wrote: > > > On 9/22/23 16:36, Philipp Hufnagl wrote: >> Currently, when an user account expires, it catches the users by >> surprise. It would be helpful to notify the the user as well as the >> administrator. >> >> Thi

Re: [pve-devel] [PATCH proxmox-backup] ui: fix #4260: add dynamic notes in backup group comment

2023-09-29 Thread Philipp Hufnagl
On 9/28/23 15:33, Philipp Hufnagl wrote: > When there is no comment for a backup group, the comment of the last > snapshot in this group will be shown slightly grayed out as long as > the group is collapsed. > > Signed-off-by: Philipp Hufnagl > --- > www/css/ext6-pbs.cs

[pve-devel] [PATCH proxmox-backup] ui: fix #4260: add dynamic notes in backup group comment

2023-09-28 Thread Philipp Hufnagl
When there is no comment for a backup group, the comment of the last snapshot in this group will be shown slightly grayed out as long as the group is collapsed. Signed-off-by: Philipp Hufnagl --- www/css/ext6-pbs.css | 3 +++ www/datastore/Content.js | 17 ++--- 2 files changed

Re: [pve-devel] [PATCH manager v8 1/2] fix #4849: api: download to storage: automatically dectect and configure compression

2023-09-27 Thread Philipp Hufnagl
On 9/27/23 10:33, Thomas Lamprecht wrote: > Am 27/09/2023 um 10:03 schrieb Philipp Hufnagl: >>> There are code paths where $filename is not yet defined here, resulting >>> in a rather ugly warning – so this needs upfront checking too – always >>> check where the valu

Re: [pve-devel] [PATCH manager v8 1/2] fix #4849: api: download to storage: automatically dectect and configure compression

2023-09-27 Thread Philipp Hufnagl
> There are code paths where $filename is not yet defined here, resulting > in a rather ugly warning – so this needs upfront checking too – always > check where the value code path is coming in (yeah, Rust would do that for > you, but most API endpoints are small enough to be able to do so quickly

Re: [pve-devel] [PATCH manager v8 1/2] fix #4849: api: download to storage: automatically dectect and configure compression

2023-09-26 Thread Philipp Hufnagl
On 9/26/23 16:23, Thomas Lamprecht wrote: > Am 26/09/2023 um 14:25 schrieb Philipp Hufnagl: >> On 9/26/23 12:56, Thomas Lamprecht wrote: >>> while this is already applied, some comments inline, for a possible next >>> time, and also the big >>> question if th

Re: [pve-devel] [PATCH manager v8 2/2] fix #4849: ui: download to storage: automatically dectect and configure compression

2023-09-26 Thread Philipp Hufnagl
On 9/26/23 12:59, Thomas Lamprecht wrote: > Am 21/09/2023 um 15:09 schrieb Philipp Hufnagl: >> extends the download iso prompt with a "compression algorithm" drop down >> under advanced. User can configure there if a decompression algorithm >> should be use

Re: [pve-devel] [PATCH manager v8 1/2] fix #4849: api: download to storage: automatically dectect and configure compression

2023-09-26 Thread Philipp Hufnagl
ple > string regex match to the backend seems rather odd to me.. The problem with that is that the point where the iso is stored might not be accessible for the client. If it is done by the PVE, it might resolve the url differently. > > Am 21/09/2023 um 15:09 schrieb Philipp Hu

[pve-devel] [PATCH manager/access-control/proxmox-widget-toolkit v1 0/4] fix #4546: Show warning hint/badge if user account is expiring in next few days

2023-09-22 Thread Philipp Hufnagl
adds in this case a new entry briefly saing that the account expires. When this entry is clicked it states this in more detail including the experation date. Sending this for PVE only now to get feedback before implementing this for PMG and PBS Philipp Hufnagl (1): fix #4546: ui: notify user if

[pve-devel] [PATCH access-control v1 1/1] fix #4546: api: Return user expiration date on access/ticket API call

2023-09-22 Thread Philipp Hufnagl
Adds an additional, optional parameter to the access/tickets api call which tells when the currently used user account will expire. If it will not expire, the parameter will not be added. Signed-off-by: Philipp Hufnagl --- src/PVE/API2/AccessControl.pm | 8 src/PVE/AccessControl.pm

[pve-devel] [PATCH proxmox-widget-toolkit v1 2/2] fix #4546: utils: save expiring date of user account for UI

2023-09-22 Thread Philipp Hufnagl
When an user experation date is send with the /accesss/tickets POST API call, it will be stored in a global variable like the username Signed-off-by: Philipp Hufnagl --- src/Utils.js| 3 +++ src/proxmox-dark/scss/abstracts/_variables.scss | 1 + src/proxmox

[pve-devel] [PATCH proxmox-widget-toolkit v1 1/2] fix #4546: css: Inform user administrator about user accounts expiring soon

2023-09-22 Thread Philipp Hufnagl
Adds a new css class to underlay information urgency in table columns for dark and light mode. This underlay color then is used to notifiy user administrators about user accounts that will expire soon Signed-off-by: Philipp Hufnagl --- src/Utils.js| 6

[pve-devel] [PATCH manager v1 1/1] fix #4546: ui: notify user if their user account expires soon

2023-09-22 Thread Philipp Hufnagl
-off-by: Philipp Hufnagl --- www/manager6/Workspace.js | 28 1 file changed, 28 insertions(+) diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js index 18d574b7..9d166493 100644 --- a/www/manager6/Workspace.js +++ b/www/manager6/Workspace.js @@ -42,6

[pve-devel] [PATCH manager v8 2/2] fix #4849: ui: download to storage: automatically dectect and configure compression

2023-09-21 Thread Philipp Hufnagl
extends the download iso prompt with a "compression algorithm" drop down under advanced. User can configure there if a decompression algorithm should be used from the storage backend. The compression algorithm will be automatically guessed when calling query_url_metadata Signed-off-b

[pve-devel] [PATCH manager v8 0/2] fix #4849: allow download of compressed ISOs

2023-09-21 Thread Philipp Hufnagl
improvements Changes since v1: * Improve code quality as suggested by feedback Philipp Hufnagl (2): fix #4849: api: download to storage: automatically dectect and configure compression fix #4849: ui: download to storage: automatically dectect and configure compression PVE/API2

[pve-devel] [PATCH manager v8 1/2] fix #4849: api: download to storage: automatically dectect and configure compression

2023-09-21 Thread Philipp Hufnagl
extends the query_url_metadata callback with the functionallity to detect used compressions. If a compression is used it tells the ui which one Signed-off-by: Philipp Hufnagl --- PVE/API2/Nodes.pm | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/PVE

Re: [pve-devel] [PATCH manager v7 0/2] fix #4849: allow download of compressed ISOs

2023-09-20 Thread Philipp Hufnagl
On 9/20/23 14:09, Fabian Grünbichler wrote: On September 20, 2023 1:50 pm, Dominik Csapak wrote: On 9/20/23 13:46, Fabian Grünbichler wrote: On September 20, 2023 1:07 pm, Dominik Csapak wrote: LGTM and works as advertised. it breaks downloading container templates that are compressed with on

[pve-devel] [PATCH manager v7 0/2] fix #4849: allow download of compressed ISOs

2023-09-11 Thread Philipp Hufnagl
common * minor code improvements Changes since v1: * Improve code quality as suggested by feedback Philipp Hufnagl (2): fix #4849: api: download to storage: automatically dectect and configure compression fix #4849: ui: download to storage: automatically dectect and configure

[pve-devel] [PATCH manager v7 2/2] fix #4849: ui: download to storage: automatically dectect and configure compression

2023-09-11 Thread Philipp Hufnagl
extends the download iso prompt with a "compression algorithm" drop down under advanced. User can configure there if a decompression algorithm should be used from the storage backend. The compression algorithm will be automatically guessed when calling query_url_metadata Signed-off-b

[pve-devel] [PATCH manager v7 1/2] fix #4849: api: download to storage: automatically dectect and configure compression

2023-09-11 Thread Philipp Hufnagl
extends the query_url_metadata callback with the functionallity to detect used compressions. If a compression is used it tells the ui which one Signed-off-by: Philipp Hufnagl --- PVE/API2/Nodes.pm | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/PVE/API2

[pve-devel] [PATCH manager v3] ui: improve user experience for vm/container transfer between pools

2023-09-08 Thread Philipp Hufnagl
grate". However and API change would break already implemented usage and so it has been decided to call it (for now) transfer everywhere to Signed-off-by: Philipp Hufnagl --- www/manager6/grid/PoolMembers.js | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(

Re: [pve-devel] [PATCH manager v2] ui: improve user experience for vm/container transfer between pools

2023-09-08 Thread Philipp Hufnagl
Please dont merge. It appers i made an error at testing On 9/8/23 13:56, Philipp Hufnagl wrote: After the implementation of fix #474, it has been suggested that instead of requiring the user to click a checkbox allowing migration, it should be allowed automatically and and a warning should be

[pve-devel] [PATCH manager v2] ui: improve user experience for vm/container transfer between pools

2023-09-08 Thread Philipp Hufnagl
grate". However and API change would break already implemented usage and so it has been decided to call it (for now) transfer everywhere to Signed-off-by: Philipp Hufnagl modified: www/manager6/grid/PoolMembers.js --- www/manager6/grid/PoolMembers.js | 26 +++---

Re: [pve-devel] [PATCH manager] ui: improve vm/container migration user experience

2023-09-08 Thread Philipp Hufnagl
On 9/6/23 11:18, Thomas Lamprecht wrote: subject is quite confusing, this isn't for what's commonly understood w.r.t. the "VM/CT migration", i.e., live migration to another host. You at least need to use the word "pool" somewhere.. Am 05/09/2023 um 15:51 schri

[pve-devel] [PATCH manager] ui: improve vm/container migration user experience

2023-09-05 Thread Philipp Hufnagl
grate". However and API change would break already implemented usage and so it has been decided to call it (for now) transfer everywhere to avoid confusion Signed-off-by: Philipp Hufnagl --- www/manager6/grid/PoolMembers.js | 29 ++--- 1 file changed, 22 insert

Re: [pve-devel] applied: [PATCH manager v4 0/2] fix #474: allow transfer from container/vms

2023-08-31 Thread Philipp Hufnagl
On 8/30/23 16:29, Dominik Csapak wrote: On 8/30/23 14:43, Philipp Hufnagl wrote: On 8/14/23 12:42, Dominik Csapak wrote: On 8/14/23 12:36, Wolfgang Bumiller wrote: applied, thanks @Dominik: does extjs have an 'enableFn' for rows in a grid? IMO we should either disable the ones

Re: [pve-devel] applied: [PATCH manager v4 0/2] fix #474: allow transfer from container/vms

2023-08-30 Thread Philipp Hufnagl
On 8/24/23 16:46, Thomas Lamprecht wrote: Am 14/08/2023 um 12:42 schrieb Dominik Csapak: On 8/14/23 12:36, Wolfgang Bumiller wrote: applied, thanks @Dominik: does extjs have an 'enableFn' for rows in a grid? IMO we should either disable the ones with pools when the transfer checkbox is not che

Re: [pve-devel] applied: [PATCH manager v4 0/2] fix #474: allow transfer from container/vms

2023-08-30 Thread Philipp Hufnagl
On 8/14/23 12:42, Dominik Csapak wrote: On 8/14/23 12:36, Wolfgang Bumiller wrote: applied, thanks @Dominik: does extjs have an 'enableFn' for rows in a grid? IMO we should either disable the ones with pools when the transfer checkbox is not checked, or hide them (but when hiding them after al

[pve-devel] [PATCH storage v6 1/1] fix #4849: download-url: allow download and decompression of compressed ISOs

2023-08-14 Thread Philipp Hufnagl
adds information for how to decompress isos. generates the compressor regex from a list of comression formats (to avoid redundancy) extends the download_url wtih the functionality to handley compression for images Signed-off-by: Philipp Hufnagl --- src/PVE/API2/Storage/Status.pm | 14

[pve-devel] [PATCH manager v6 2/2] fix #4849: ui: download to storage: automatically dectect and configure compression

2023-08-14 Thread Philipp Hufnagl
extends the download iso prompt with a "compression algorithm" drop down under advanced. User can configure there if a decompression algorithm should be used from the storage backend. The compression algorithm will be automatically guessed when calling query_url_metadata Signed-off-b

[pve-devel] [PATCH manager/storage v6 0/3] fix #4849: allow download of compressed ISOs

2023-08-14 Thread Philipp Hufnagl
Philipp Hufnagl (2): fix #4849: api: download to storage: automatically dectect and configure compression fix #4849: ui: download to storage: automatically dectect and configure compression PVE/API2/Nodes.pm | 20 www/manager6/Makefile

[pve-devel] [PATCH manager v6 1/2] fix #4849: api: download to storage: automatically dectect and configure compression

2023-08-14 Thread Philipp Hufnagl
extends the query_url_metadata callback with the functionallity to detect used compressions. If a compression is used it tells the ui which one Signed-off-by: Philipp Hufnagl --- PVE/API2/Nodes.pm | 20 1 file changed, 20 insertions(+) diff --git a/PVE/API2/Nodes.pm b/PVE

[pve-devel] [PATCH manager v4 0/2] fix #474: allow transfer from container/vms

2023-08-10 Thread Philipp Hufnagl
between pools, guarded by a checkbox from accidental transfers changes to v4: * check for allocate permissions of the originating pool changes to v3: * fix subject typo * at version log changes to v2: * split patch in front and backend Philipp Hufnagl (2): fix #474: api: allow transfer from

[pve-devel] [PATCH manager v4 2/2] fix #474: ui: allow transfer from container/vms

2023-08-10 Thread Philipp Hufnagl
A user can no see all vms/containers, even the ones that are already a member of a pool. They can be transfered now after checking the newly introduced "allow transfer" checkbox. Signed-off-by: Philipp Hufnagl --- www/manager6/grid/PoolMembers.js | 17 ++--- 1 file c

[pve-devel] [PATCH manager v4 1/2] fix #474: api: allow transfer from container/vms

2023-08-10 Thread Philipp Hufnagl
When the newly introduced optional parameter "transfer" is set, the user add a vm/container to a pool even if it is already in one. If so it will be removed from the old pool Signed-off-by: Philipp Hufnagl --- PVE/API2/Pool.pm | 16 ++-- 1 file changed, 14 insertions(+), 2

Re: [pve-devel] [PATCH manager] fix #474: allow transfer from container/vms

2023-08-10 Thread Philipp Hufnagl
On 8/10/23 09:16, Fiona Ebner wrote: But it should. After all, the operation is modifying the original pool, so the user better have an appropriate permission to do so. Currently, Permissions.Modify|VM.Allocate on the VM and Pool.Allocate on the target pool would be enough to "steal" the gue

[pve-devel] [PATCH manager v3 0/2] fix #474: allow transfer from container/vms

2023-08-09 Thread Philipp Hufnagl
privileges of the pool member for this vm/contianer. This feature introduces a way to transfer a vm between pools, guarded by a checkbox from accidental transfers Philipp Hufnagl (2): fix #474: backend allow transfer from container/vms fix #474: backend allow transfer from container/vms PVE/API2

[pve-devel] [PATCH manager v3 2/2] fix #474: frontend: allow transfer from container/vms

2023-08-09 Thread Philipp Hufnagl
between pools, guarded by a checkbox from accidental transfers This is the patch for the frontend changes Signed-off-by: Philipp Hufnagl --- www/manager6/grid/PoolMembers.js | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/www/manager6/grid/PoolMembers.js b

[pve-devel] [PATCH manager v3 1/2] fix #474: backend: allow transfer from container/vms

2023-08-09 Thread Philipp Hufnagl
between pools, guarded by a checkbox from accidental transfers This is the patch for the backend changes Signed-off-by: Philipp Hufnagl --- PVE/API2/Pool.pm | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Pool.pm b/PVE/API2/Pool.pm index 007fc815

[pve-devel] [PATCH manager v2 2/2] fix #474: backend allow transfer from container/vms

2023-08-09 Thread Philipp Hufnagl
between pools, guarded by a checkbox from accidental transfers This is the patch for the frontend changes Signed-off-by: Philipp Hufnagl --- www/manager6/grid/PoolMembers.js | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/www/manager6/grid/PoolMembers.js b

[pve-devel] [PATCH manager v2 0/2] fix #474: allow transfer from container/vms

2023-08-09 Thread Philipp Hufnagl
between pools, guarded by a checkbox from accidental transfers Philipp Hufnagl (2): fix #474: backend allow transfer from container/vms fix #474: backend allow transfer from container/vms PVE/API2/Pool.pm | 15 +-- www/manager6/grid/PoolMembers.js | 17

[pve-devel] [PATCH manager v2 1/2] fix #474: backend: allow transfer from container/vms

2023-08-09 Thread Philipp Hufnagl
between pools, guarded by a checkbox from accidental transfers This is the patch for the backend changes Signed-off-by: Philipp Hufnagl --- PVE/API2/Pool.pm | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Pool.pm b/PVE/API2/Pool.pm index 007fc815

Re: [pve-devel] [PATCH manager] fix #474: allow transfer from container/vms

2023-08-09 Thread Philipp Hufnagl
On 8/9/23 13:32, Fiona Ebner wrote: The permission for the original pool should be checked here?! Or is that already done somewhere? The permission of the original pool does not matter. The permission of the VM is important (maybe the original pool granting the user permission on the VM). H

[pve-devel] [PATCH storage/manager v5 1/1] fix #4849: download to storage: automatically dectect and configure compression

2023-08-09 Thread Philipp Hufnagl
ically set in the UI Signed-off-by: Philipp Hufnagl --- PVE/API2/Nodes.pm | 21 - www/manager6/Makefile | 1 + www/manager6/form/DecompressionSelector.js | 13 + www/manager6/window/DownloadUrlToStora

[pve-devel] [PATCH storage/manager v5 0/2] fix #4849: allow download of compressed ISOs

2023-08-09 Thread Philipp Hufnagl
list * fix logic errors Changes since v2: * move compression code to the download function in common * minor code improvements Changes since v1: * Improve code quality as suggested by feedback Philipp Hufnagl (1): fix #4849: download-url: allow download and decompression of compressed

[pve-devel] [PATCH storage/manager v5 1/1] fix #4849: download-url: allow download and decompression of compressed ISOs

2023-08-09 Thread Philipp Hufnagl
extend the download_url function with the capabillity to handle compression add decopressor info for images build compression algorithm regex dynamically to avoid duplication Signed-off-by: Philipp Hufnagl --- src/PVE/API2/Storage/Status.pm | 14 +- src/PVE/Storage.pm

[pve-devel] [PATCH manager] fix #474: allow transfer from container/vms

2023-08-08 Thread Philipp Hufnagl
between pools, guarded by a checkbox from accidental transfers Signed-off-by: Philipp Hufnagl --- PVE/API2/Pool.pm | 19 +-- www/manager6/grid/PoolMembers.js | 17 ++--- 2 files changed, 31 insertions(+), 5 deletions(-) diff --git a/PVE/API2/Pool.pm b/PVE

[pve-devel] [PATCH common v4 2/2] fix whitespaces

2023-08-01 Thread Philipp Hufnagl
Signed-off-by: Philipp Hufnagl --- src/PVE/Tools.pm | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index 159ec82..28e70f0 100644 --- a/src/PVE/Tools.pm +++ b/src/PVE/Tools.pm @@ -92,23 +92,23 @@ our

[pve-devel] [PATCH storage/manager/common v4 0/6] fix #4849: allow download of compressed ISOs

2023-08-01 Thread Philipp Hufnagl
Changes since v3: * generate compression regex from compression list * fix logic errors Changes since v2: * move compression code to the download function in common * minor code improvements Changes since v1: * Improve code quality as suggested by feedback Philipp Hufnagl (2): fix

[pve-devel] [PATCH storage v4 2/2] fix whitespaces

2023-08-01 Thread Philipp Hufnagl
Signed-off-by: Philipp Hufnagl --- src/PVE/Storage/Plugin.pm | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index 18cb5d5..1795ae3 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PVE/Storage

[pve-devel] [PATCH common v4 1/2] fix #4849: download file from url: add opt parameter for a decompression command

2023-08-01 Thread Philipp Hufnagl
Signed-off-by: Philipp Hufnagl --- src/PVE/Tools.pm | 31 +-- 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index 9ffac12..159ec82 100644 --- a/src/PVE/Tools.pm +++ b/src/PVE/Tools.pm @@ -2013,10 +2013,13 @@ sub

[pve-devel] [PATCH manager v4 1/2] fix #4849: download to storage: automatically dectect and configure compression

2023-08-01 Thread Philipp Hufnagl
Signed-off-by: Philipp Hufnagl --- PVE/API2/Nodes.pm | 21 - www/manager6/Makefile | 1 + www/manager6/form/DecompressionSelector.js | 13 + www/manager6/window/DownloadUrlToStorage.js | 17 + 4

[pve-devel] [PATCH manager v4 2/2] fix whitespaces

2023-08-01 Thread Philipp Hufnagl
Signed-off-by: Philipp Hufnagl --- PVE/API2/Nodes.pm | 16 www/manager6/window/DownloadUrlToStorage.js | 4 ++-- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 2bae4e6f..6fa138fb 100644

[pve-devel] [PATCH storage v4 1/2] fix #4849: download-url: allow download and decompression of compressed ISOs

2023-08-01 Thread Philipp Hufnagl
Signed-off-by: Philipp Hufnagl --- src/PVE/API2/Storage/Status.pm | 14 +- src/PVE/Storage.pm | 6 ++ src/PVE/Storage/Plugin.pm | 3 ++- 3 files changed, 21 insertions(+), 2 deletions(-) diff --git a/src/PVE/API2/Storage/Status.pm b/src/PVE/API2/Storage

[pve-devel] [V3 PATCH storage 1/1] fix #4849: download-url: allow download and decompression of compressed ISOs

2023-07-31 Thread Philipp Hufnagl
Signed-off-by: Philipp Hufnagl --- src/PVE/API2/Storage/Status.pm | 17 +++-- src/PVE/Storage.pm | 6 ++ 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/src/PVE/API2/Storage/Status.pm b/src/PVE/API2/Storage/Status.pm index 2aaeff6..1d73c96 100644

[pve-devel] [V3 PATCH manager 1/1] fix #4849: download to storage: automatically dectect and configure compression

2023-07-31 Thread Philipp Hufnagl
Signed-off-by: Philipp Hufnagl --- PVE/API2/Nodes.pm | 21 - www/manager6/Makefile | 1 + www/manager6/form/DecompressionSelector.js | 14 ++ www/manager6/window/DownloadUrlToStorage.js | 21

[pve-devel] [V3 PATCH common 1/1] fix #4849: download file from url: add opt parameter for a decompression command

2023-07-31 Thread Philipp Hufnagl
Signed-off-by: Philipp Hufnagl --- src/PVE/Tools.pm | 59 +++- 1 file changed, 38 insertions(+), 21 deletions(-) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index 9ffac12..ab97129 100644 --- a/src/PVE/Tools.pm +++ b/src/PVE/Tools.pm @@ -92,23

[pve-devel] [V3 PATCH storage/manager/common 0/3]fix #4849: allow download of compressed ISOs

2023-07-31 Thread Philipp Hufnagl
v1: * Improve code quality as suggested by feedback Philipp Hufnagl (1): fix #4849: download-url: allow download and decompression of compressed ISOs src/PVE/API2/Storage/Status.pm | 17 +++-- src/PVE/Storage.pm | 6 ++ 2 files changed, 21 insertions(+), 2

[pve-devel] [PATCH V2 manager 1/1] fix #4849: download to storage: automatically dectect and configure compression

2023-07-27 Thread Philipp Hufnagl
Signed-off-by: Philipp Hufnagl --- PVE/API2/Nodes.pm | 21 - www/manager6/Makefile | 1 + www/manager6/form/DecompressionSelector.js | 14 ++ www/manager6/window/DownloadUrlToStorage.js | 21

[pve-devel] [PATCH V2 storage 1/1] fix #4849: download-url: allow download and decompression of compressed ISOs

2023-07-27 Thread Philipp Hufnagl
Signed-off-by: Philipp Hufnagl --- src/PVE/API2/Storage/Status.pm | 22 +++--- src/PVE/Storage.pm | 6 ++ 2 files changed, 25 insertions(+), 3 deletions(-) diff --git a/src/PVE/API2/Storage/Status.pm b/src/PVE/API2/Storage/Status.pm index 2aaeff6..a087c53 100644

[pve-devel] [PATCH V2 storage/manager/common 0/3] allow download of compressed ISOs

2023-07-27 Thread Philipp Hufnagl
Many web pages offer the download of the disk images compressed. This patch allows the download of archives (like .gz), automatically detects the format and decompresses it Philipp Hufnagl (1): fix #4849: download-url: allow download and decompression of compressed ISOs src/PVE/API2

[pve-devel] [PATCH V2 common 1/1] fix #4849: download file from url: add opt parameter for a decompression command

2023-07-27 Thread Philipp Hufnagl
Signed-off-by: Philipp Hufnagl --- src/PVE/Tools.pm | 9 + 1 file changed, 9 insertions(+) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index 9ffac12..d9869e8 100644 --- a/src/PVE/Tools.pm +++ b/src/PVE/Tools.pm @@ -2059,6 +2059,15 @@ sub download_file_from_url { } print

[pve-devel] [PATCH pve-storage 2/2] clean: fix whitspaces and minor code issues

2023-07-25 Thread Philipp Hufnagl
removed Data::Dumper and a newline Signed-off-by: Philipp Hufnagl --- src/PVE/API2/Storage/Status.pm | 18 +-- src/PVE/Storage.pm | 55 +- src/PVE/Storage/Plugin.pm | 3 +- 3 files changed, 37 insertions(+), 39 deletions(-) diff --git a

  1   2   >