Re: [pve-devel] [PATCH v2 pve-manager] fix #5936: ui: backup: add CT PBS change detection mode selector

2025-02-11 Thread Christian Ebner
Ping! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager] pvestatd: improve broadcast of node version-info

2025-01-16 Thread Christian Ebner
On 1/16/25 17:30, Aaron Lauterer wrote: Until now, the pvestatd did broadcast the pve-manager version only once after startup of the service. But there are some situations, where the local pmxcfs (pve-cluster) restarts and loses that information. Basically everytime we restart the pmxcfs without

Re: [pve-devel] [PATCH manager] pvestatd: improve broadcast of node version-info

2025-01-16 Thread Christian Ebner
On 1/16/25 17:38, Aaron Lauterer wrote: On  2025-01-16  17:35, Christian Ebner wrote: On 1/16/25 17:30, Aaron Lauterer wrote: […] This will close issue 5894 I guess [0]? [0] https://bugzilla.proxmox.com/show_bug.cgi?id=5894 Specifically, the 'version-info', yes. Are t

Re: [pve-devel] [PATCH pve-manager] fix #5936: ui: backup: add CT PBS change detection mode selector

2024-11-29 Thread Christian Ebner
superseded-by version 2: https://lore.proxmox.com/pve-devel/20241129150013.323432-1-c.eb...@proxmox.com/T/ ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH v2 pve-manager] fix #5936: ui: backup: add CT PBS change detection mode selector

2024-11-29 Thread Christian Ebner
shown for virtual machine and container backup in order to maintain the same layout for both, but only enabled for container backup with a Proxmox Backup Server selected as target storage. Link to issue in bugtracker: https://bugzilla.proxmox.com/show_bug.cgi?id=5936 Signed-off-by: Christian Ebner -

Re: [pve-devel] [PATCH pve-manager] fix #5936: ui: backup: add CT PBS change detection mode selector

2024-11-29 Thread Christian Ebner
On 11/29/24 14:25, Shannon Sterz wrote: On Fri Nov 29, 2024 at 2:18 PM CET, Christian Ebner wrote: On 11/29/24 14:09, Shannon Sterz wrote: On Fri Nov 29, 2024 at 1:40 PM CET, Christian Ebner wrote: Allow to select the change detection mode when performing manual backups of containers with

Re: [pve-devel] [PATCH pve-manager] fix #5936: ui: backup: add CT PBS change detection mode selector

2024-11-29 Thread Christian Ebner
On 11/29/24 14:09, Shannon Sterz wrote: On Fri Nov 29, 2024 at 1:40 PM CET, Christian Ebner wrote: Allow to select the change detection mode when performing manual backups of containers with Proxmox Backup Server as target, just like for the advanced backup job options introduced by commit

[pve-devel] [PATCH pve-manager] fix #5936: ui: backup: add CT PBS change detection mode selector

2024-11-29 Thread Christian Ebner
y shown in the backup window for containers and only enabled when a Proxmox Backup Server is selected as target storage. Link to issue in bugtracker: https://bugzilla.proxmox.com/show_bug.cgi?id=5936 Signed-off-by: Christian Ebner --- www/manager6/window/Backup.js | 32 +

[pve-devel] [PATCH proxmox-widget-toolkit 1/2] panel: disk list: return consistent value for unknown smart status

2024-11-29 Thread Christian Ebner
values window. Signed-off-by: Christian Ebner --- src/panel/DiskList.js | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/panel/DiskList.js b/src/panel/DiskList.js index dc10ac5..dfd8c8e 100644 --- a/src/panel/DiskList.js +++ b/src/panel/DiskList.js @@ -7,7 +7,12

[pve-devel] [PATCH proxmox-widget-toolkit 2/2] disk list: disable show smart values button if status unknown

2024-11-29 Thread Christian Ebner
datastores in Proxmox Backup Server. Reported in the community forum: https://forum.proxmox.com/threads/158217/ Signed-off-by: Christian Ebner --- src/panel/DiskList.js | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/panel/DiskList.js b/src/panel/DiskList.js index dfd8c8e

Re: [pve-devel] [PATCH proxmox-i18n] update Italian translations

2024-11-19 Thread Christian Ebner
On 11/19/24 12:48, Maximiliano Sandoval wrote: Christian Ebner writes: #: proxmox-widget-toolkit/src/Utils.js:315 -#, fuzzy msgid "static" -msgstr "Statico" +msgstr "" This translation is missing. -- Maximiliano

[pve-devel] [PATCH v2 proxmox-i18] update Italian translations

2024-11-19 Thread Christian Ebner
Signed-off-by: Christian Ebner --- changes since version 1: - Do not translate system unit states, dropped by [0] - set message string even if keeping English text - rephase package update available translation - rename all occurrences of `etichetta` to `tag` and variants thereof [0] https

[pve-devel] [PATCH proxmox-widget-toolkit] utils: never translate systemd unit states

2024-11-19 Thread Christian Ebner
Translating unit states might be counter productive in case of debugging, opt for not translating them and drop usage of the translation helper. Signed-off-by: Christian Ebner --- src/Utils.js| 12 src/node/ServiceView.js | 10 ++ 2 files changed, 2 insertions

Re: [pve-devel] [PATCH proxmox-i18n] update Italian translations

2024-11-19 Thread Christian Ebner
On 11/19/24 13:30, Thomas Lamprecht wrote: Am 19.11.24 um 13:09 schrieb Shannon Sterz: This is intentional since that is the description for the systemd state, not sure if it makes to translate that in this case? Maybe, but perhaps then it makes sense to remove the english string? I mean there

Re: [pve-devel] [PATCH v2 proxmox-i18] update Italian translations

2024-11-19 Thread Christian Ebner
Unfortunately you were to late, Thomas already applied this patch. Can you send your suggested changes as followup patch? ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH proxmox-i18n] update Italian translations

2024-11-19 Thread Christian Ebner
On 11/19/24 13:33, Gabriel Goller wrote: On 19.11.2024 12:37, Christian Ebner wrote: Signed-off-by: Christian Ebner --- it.po | 126 +++--- 1 file changed, 41 insertions(+), 85 deletions(-) diff --git a/it.po b/it.po index a1a5c48..da5516c

Re: [pve-devel] [PATCH proxmox-i18n] update Italian translations

2024-11-19 Thread Christian Ebner
On 11/19/24 13:04, Maximiliano Sandoval wrote: "Shannon Sterz" writes: On Tue Nov 19, 2024 at 12:55 PM CET, Christian Ebner wrote: On 11/19/24 12:48, Maximiliano Sandoval wrote: Christian Ebner writes: #: proxmox-widget-toolkit/src/Utils.js:315 -#, fuzzy msgid "

Re: [pve-devel] [PATCH proxmox-i18n] update Italian translations

2024-11-19 Thread Christian Ebner
On 11/19/24 12:58, Maximiliano Sandoval wrote: Christian Ebner writes: On 11/19/24 12:48, Maximiliano Sandoval wrote: Christian Ebner writes: #: proxmox-widget-toolkit/src/Utils.js:315 -#, fuzzy msgid "static" -msgstr "Statico" +msgstr ""

[pve-devel] [PATCH proxmox-i18n] update Italian translations

2024-11-19 Thread Christian Ebner
Signed-off-by: Christian Ebner --- it.po | 126 +++--- 1 file changed, 41 insertions(+), 85 deletions(-) diff --git a/it.po b/it.po index a1a5c48..da5516c 100644 --- a/it.po +++ b/it.po @@ -81,9 +81,8 @@ msgid "ACME Directory" m

[pve-devel] [PATCH installer] install: zfs: rename pre-existing `rpool` also if in degraded state

2024-11-15 Thread Christian Ebner
not available. Renaming by zpool import is not possible for that case. Partially-fixes: 43591049 ("low-level: install: check for already-existing `rpool` on install") Signed-off-by: Christian Ebner --- Proxmox/Install.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) di

Re: [pve-devel] [PATCH installer] install: ask for patience when making system bootable

2024-11-15 Thread Christian Ebner
> On 15.11.2024 14:35 CET Thomas Lamprecht wrote: > > > Am 15.11.24 um 13:43 schrieb Christian Ebner: > > Making the system bootable can take some time if many disks are used > > for installation, which could be misinterpreted as a hanging > > installer. Add a

[pve-devel] [PATCH installer] install: ask for patience when making system bootable

2024-11-15 Thread Christian Ebner
)` Signed-off-by: Christian Ebner --- Proxmox/Install.pm | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm index 5c64c3d..5c59485 100644 --- a/Proxmox/Install.pm +++ b/Proxmox/Install.pm @@ -723,6 +723,7 @@ sub extract_data

[pve-devel] [PATCH manager] ui: remove experimental from change detection modes description

2024-11-11 Thread Christian Ebner
As no issues with the change detection mode set to `metadata` or `data` have been reported during the prolonged test period, drop the `experimental` warnings from the description. Signed-off-by: Christian Ebner --- www/manager6/panel/BackupAdvancedOptions.js | 6 +++--- 1 file changed, 3

[pve-devel] [PATCH docs] docs: drop experimental warning for change detection modes

2024-11-11 Thread Christian Ebner
Signed-off-by: Christian Ebner --- vzdump.adoc | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/vzdump.adoc b/vzdump.adoc index 6f4cfc2..aecb353 100644 --- a/vzdump.adoc +++ b/vzdump.adoc @@ -196,12 +196,12 @@ There are 3 change detection modes available: | Mode

Re: [pve-devel] [[PATCH kernel]] fix 5683: netfs: reset subreq iov iter before tail clean

2024-10-27 Thread Christian Ebner
Send the patch requesting to be included in upstream linux-stable: https://lore.kernel.org/stable/20241027114315.730407-1-c.eb...@proxmox.com/T/ ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/p

Re: [pve-devel] [[PATCH kernel]] fix 5683: netfs: reset subreq iov iter before tail clean

2024-10-23 Thread Christian Ebner
On 10/23/24 10:28, Thomas Lamprecht wrote: Am 22/10/2024 um 17:46 schrieb Christian Ebner: I refrained from doing so as I saw that typically fixes to mainline are back-ported to stable, but since this is already fixed in the latest version, I was hoping for upstream guidance on how to proceed

Re: [pve-devel] [[PATCH kernel]] fix 5683: netfs: reset subreq iov iter before tail clean

2024-10-22 Thread Christian Ebner
On 10/22/24 14:50, Fiona Ebner wrote: Am 02.10.24 um 16:36 schrieb Christian Ebner: Fixes rare read corruption issues using the in kernel ceph client. On incomplete read requests, the clean tail flag should make sure to zero fill the remaining bytes for the subrequest. If the iov iterator is

Re: [pve-devel] [[PATCH kernel]] fix 5683: netfs: reset subreq iov iter before tail clean

2024-10-22 Thread Christian Ebner
On 10/22/24 15:57, Thomas Lamprecht wrote: Am 02/10/2024 um 16:36 schrieb Christian Ebner: Also, I reached out once again to the kernel developers asking if this fix is a valid approach, hoping this can be included in current stable (as the patch does fix the issue also when applied on 6.11.1

[pve-devel] [[PATCH kernel]] fix 5683: netfs: reset subreq iov iter before tail clean

2024-10-02 Thread Christian Ebner
read content. Link to issue: https://bugzilla.proxmox.com/show_bug.cgi?id=5683 Link to upstream issue: https://bugzilla.kernel.org/show_bug.cgi?id=219237 Signed-off-by: Christian Ebner --- This fixes the read corruption issue with my local reproducer. Providing a patched kernel to users

Re: [pve-devel] [PATCH storage] storage: add bzip2 support

2024-08-04 Thread Christian Ebner
On 8/2/24 18:41, Stoiko Ivanov wrote: [2] https://opnsense.org/download/ src/PVE/Storage.pm | 3 +++ src/PVE/Storage/Plugin.pm | 2 +- src/test/archive_info_test.pm | 6 -- src/test/list_volumes_test.pm | 11 ++- src/test/parse_volname_tes

Re: [pve-devel] [PATCH v2 pve-docs] vzdump: add section describing PBS change detection mode

2024-07-11 Thread Christian Ebner
superseded-by version 3: https://lists.proxmox.com/pipermail/pve-devel/2024-July/064617.html ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH v3 pve-docs] vzdump: add section describing PBS change detection mode

2024-07-11 Thread Christian Ebner
Add a concise section about what PBS change detection mode is, where to configure the option and what it affects, including a table with a description of the modes. Signed-off-by: Christian Ebner --- changes since version 2 (thanks @Aaron for the suggestions!): - Incorporated suggested paragraph

Re: [pve-devel] [PATCH v2 pve-docs] vzdump: add section describing PBS change detection mode

2024-07-11 Thread Christian Ebner
On 7/11/24 10:24, Aaron Lauterer wrote: could we have a short paragraph on where to set these options? Similar to how it is done in the fleecing section? Sure, I agree as it is not obvious where to find the configuration option. Will send a v3 incorporating the suggestions. Thanks! ___

Re: [pve-devel] [PATCH pve-docs] vzdump: add section describing PBS change detection mode

2024-07-10 Thread Christian Ebner
superseded-by version 2: https://lists.proxmox.com/pipermail/pve-devel/2024-July/064599.html ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH v2 pve-docs] vzdump: add section describing PBS change detection mode

2024-07-10 Thread Christian Ebner
Add a concise section about what PBS change detection mode is and what it affects, including a table with a description of the modes. Signed-off-by: Christian Ebner --- vzdump.adoc | 24 1 file changed, 24 insertions(+) diff --git a/vzdump.adoc b/vzdump.adoc index

[pve-devel] [PATCH pve-docs] vzdump: add section describing PBS change detection mode

2024-06-26 Thread Christian Ebner
Add a concise section about what PBS change detection mode is and what it affects, including a table with a description of the modes. Signed-off-by: Christian Ebner --- vzdump.adoc | 24 1 file changed, 24 insertions(+) diff --git a/vzdump.adoc b/vzdump.adoc index

[pve-devel] [PATCH pve-manager] www: backup: clarify experimental change detection modes

2024-06-26 Thread Christian Ebner
modes and explicitly mention the experimental modes in the message. Also, make it more clear that the archive encoding format depends on the selected mode. Signed-off-by: Christian Ebner --- www/manager6/panel/BackupAdvancedOptions.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[pve-devel] [PATCH v4 pve-guest-common 1/4] vzdump: add PBS change detection mode configuration

2024-06-10 Thread Christian Ebner
Define the possible modes to be configured in a PBS file change detection mode. Signed-off-by: Christian Ebner --- changes since version 3: - dropped default value, use the PBS default src/PVE/VZDump/Common.pm | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/PVE/VZDump/Common.pm

[pve-devel] [PATCH v4 pve-manager 4/4] vzdump: add pbs-change-detection-mode to config template

2024-06-10 Thread Christian Ebner
Include the additional parameter to set the `change-detection-mode` for backup jobs with Proxmox Backup Server target as node wide configuration, including possible variants to be set. Signed-off-by: Christian Ebner --- changes since version 3: - no changes configs/vzdump.conf | 1 + 1 file

[pve-devel] [PATCH v4 pve-manager 3/4] www: advanced backup: add pbs change detection mode selector

2024-06-10 Thread Christian Ebner
The proxmox backup client allows to switch the method used to encode data based on a change-detection-mode parameter. Expose this setting as experimental feature in the advanced panel for a backup job. Signed-off-by: Christian Ebner --- changes since version 3: - drop default value on set www

[pve-devel] [PATCH v4 pve-container 2/4] vzdump: conditionally set PBS change detection mode option

2024-06-10 Thread Christian Ebner
Allows to switch the backup clients change detection mode based on the option set in the backup jobs configuration for backup jobs with Proxmox Backup Server target. Signed-off-by: Christian Ebner --- changes since version 4: - no changes src/PVE/VZDump/LXC.pm | 2 ++ 1 file changed, 2

[pve-devel] [PATCH v4 pve-guest-common pve-container pve-manager 0/4] change-detection-mode for PBS

2024-06-10 Thread Christian Ebner
since version 3: - Use PBS default instead of redefining on PVE side pve-guest-common: Christian Ebner (1): vzdump: add PBS change detection mode configuration src/PVE/VZDump/Common.pm | 7 +++ 1 file changed, 7 insertions(+) pve-container: Christian Ebner (1): vzdump: conditionally

[pve-devel] [PATCH v3 pve-manager 4/4] vzdump: add pbs-change-detection-mode to config template

2024-06-07 Thread Christian Ebner
Include the additional parameter to set the `change-detection-mode` for backup jobs with Proxmox Backup Server target as node wide configuration, including possible variants to be set. Signed-off-by: Christian Ebner --- changes since version 2: - s/default/legacy configs/vzdump.conf | 1 + 1

[pve-devel] [PATCH v3 pve-guest-common pve-container pve-manager 0/4] change-detection-mode for PBS

2024-06-07 Thread Christian Ebner
since version 2: - Adapted to new default change detection mode being called `legacy` pve-guest-common: Christian Ebner (1): vzdump: add PBS change detection mode configuration src/PVE/VZDump/Common.pm | 8 1 file changed, 8 insertions(+) pve-container: Christian Ebner (1): vzdump

[pve-devel] [PATCH v3 pve-manager 3/4] www: advanced backup: add pbs change detection mode selector

2024-06-07 Thread Christian Ebner
The proxmox backup client allows to switch the method used to encode data based on a change-detection-mode parameter. Expose this setting as experimental feature in the advanced panel for a backup job. Signed-off-by: Christian Ebner --- changes since version 2: - no changes www/manager6/panel

[pve-devel] [PATCH v3 pve-container 2/4] vzdump: conditionally set PBS change detection mode option

2024-06-07 Thread Christian Ebner
Allows to switch the backup clients change detection mode based on the option set in the backup jobs configuration for backup jobs with Proxmox Backup Server target. Signed-off-by: Christian Ebner --- changes since version 2: - no changes src/PVE/VZDump/LXC.pm | 2 ++ 1 file changed, 2

[pve-devel] [PATCH v3 pve-guest-common 1/4] vzdump: add PBS change detection mode configuration

2024-06-07 Thread Christian Ebner
Define the possible modes to be configured in a PBS file change detection mode. Signed-off-by: Christian Ebner --- changes since version 2: - s/default/legacy src/PVE/VZDump/Common.pm | 8 1 file changed, 8 insertions(+) diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump

Re: [pve-devel] [PATCH pve-guest-common 0/4] change-detection-mode for PBS

2024-05-29 Thread Christian Ebner
Superseded by version 2, which correctly prefixes the repositories the patches must be applied to: https://lists.proxmox.com/pipermail/pve-devel/2024-May/064024.html ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-b

[pve-devel] [PATCH v2 pve-guest-common pve-container pve-manager 0/4] change-detection-mode for PBS

2024-05-29 Thread Christian Ebner
-guest-common: Christian Ebner (1): vzdump: add PBS change detection mode configuration src/PVE/VZDump/Common.pm | 8 1 file changed, 8 insertions(+) pve-container: Christian Ebner (1): vzdump: conditionally set PBS change detection mode option src/PVE/VZDump/LXC.pm | 2 ++ 1 file

[pve-devel] [PATCH v2 pve-container 2/4] vzdump: conditionally set PBS change detection mode option

2024-05-29 Thread Christian Ebner
Allows to switch the backup clients change detection mode based on the option set in the backup jobs configuration for backup jobs with Proxmox Backup Server target. Signed-off-by: Christian Ebner --- changes since version 1: - no changes src/PVE/VZDump/LXC.pm | 2 ++ 1 file changed, 2

[pve-devel] [PATCH v2 pve-manager 3/4] www: advanced backup: add pbs change detection mode selector

2024-05-29 Thread Christian Ebner
The proxmox backup client allows to switch the method used to encode data based on a change-detection-mode parameter. Expose this setting as experimental feature in the advanced panel for a backup job. Signed-off-by: Christian Ebner --- changes since version 1: - prefix subject with correct

[pve-devel] [PATCH v2 pve-manager 4/4] vzdump: add pbs-change-detection-mode to config template

2024-05-29 Thread Christian Ebner
Include the additional parameter to set the `change-detection-mode` for backup jobs with Proxmox Backup Server target as node wide configuration, including possible variants to be set. Signed-off-by: Christian Ebner --- changes since version 1: - prefix subject with correct repo configs

[pve-devel] [PATCH v2 pve-guest-common 1/4] vzdump: add PBS change detection mode configuration

2024-05-29 Thread Christian Ebner
Define the possible modes to be configured in a PBS file change detection mode to the vzdump confdesc. Signed-off-by: Christian Ebner --- changes since version 1: - no changes src/PVE/VZDump/Common.pm | 8 1 file changed, 8 insertions(+) diff --git a/src/PVE/VZDump/Common.pm b/src

[pve-devel] [PATCH pve-container 3/4] www: advanced backup: add pbs change detection mode selector

2024-05-29 Thread Christian Ebner
The proxmox backup client allows to switch the method used to encode data based on a change-detection-mode parameter. Expose this setting as experimental feature in the advanced panel for a backup job. Signed-off-by: Christian Ebner --- www/manager6/panel/BackupAdvancedOptions.js | 20

[pve-devel] [PATCH pve-guest-common 1/4] vzdump: add PBS change detection mode configuration

2024-05-29 Thread Christian Ebner
Define the possible modes to be configured in a PBS file change detection mode to the vzdump confdesc. Signed-off-by: Christian Ebner --- src/PVE/VZDump/Common.pm | 8 1 file changed, 8 insertions(+) diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm index 1539444

[pve-devel] [PATCH pve-container 2/4] vzdump: conditionally set PBS change detection mode option

2024-05-29 Thread Christian Ebner
Allows to switch the backup clients change detection mode based on the option set in the backup jobs configuration for backup jobs with Proxmox Backup Server target. Signed-off-by: Christian Ebner --- src/PVE/VZDump/LXC.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/VZDump

[pve-devel] [PATCH pve-container 4/4] vzdump: add pbs-change-detection-mode to config template

2024-05-29 Thread Christian Ebner
Include the additional parameter to set the `change-detection-mode` for backup jobs with Proxmox Backup Server target as node wide configuration, including possible variants to be set. Signed-off-by: Christian Ebner --- configs/vzdump.conf | 1 + 1 file changed, 1 insertion(+) diff --git a

[pve-devel] [PATCH pve-guest-common 0/4] change-detection-mode for PBS

2024-05-29 Thread Christian Ebner
notes-template {{guestname}} storage pbs-local vmid 100 ``` This patches depend on a proxmox-backup-client compiled with the following patch series applied: https://lists.proxmox.com/pipermail/pbs-devel/2024-May/009526.html pve-guest-common: Christian Ebner (1): vzdump

Re: [pve-devel] [PATCH pve-installer] answer: perform basic input validation for keyboard

2024-04-24 Thread Christian Ebner
On 4/24/24 11:20, Stoiko Ivanov wrote: On Wed, 24 Apr 2024 10:48:50 +0200 Christian Ebner wrote: Currently it is possible to validate and create an iso with an invalid keyboad layout, only failing later during installation. Add a basic check for correct keyboard layout by defining an enum

[pve-devel] [PATCH pve-installer] answer: perform basic input validation for keyboard

2024-04-24 Thread Christian Ebner
Currently it is possible to validate and create an iso with an invalid keyboad layout, only failing later during installation. Add a basic check for correct keyboard layout by defining an enum with allowed variants. Signed-off-by: Christian Ebner --- proxmox-auto-installer/src/answer.rs | 39

[pve-devel] [PATCH proxmox-i18n] update Italian translations

2024-04-22 Thread Christian Ebner
Signed-off-by: Christian Ebner --- it.po | 118 +++--- 1 file changed, 39 insertions(+), 79 deletions(-) diff --git a/it.po b/it.po index af63294..26e6e69 100644 --- a/it.po +++ b/it.po @@ -714,9 +714,8 @@ msgid "Are you sure you wa

[pve-devel] [PATCH pve-manager] ui: node: extend option editor for wake on lan

2024-04-03 Thread Christian Ebner
editor component. The editor is used for the wake on lan record of the grid only, by adding the `handle_editor` function, to calls the required editor based on the selected record of the grid. Signed-off-by: Christian Ebner --- www/manager6/node/NodeOptionsView.js | 87

Re: [pve-devel] applied-series: [PATCH v2 pve-manager pve-docs 0/4] add optional WoL config options

2024-03-29 Thread Christian Ebner
On 3/28/24 18:27, Thomas Lamprecht wrote: applied, thanks! I did some very minor follow-ups mostly to document the current default in the schema and docs and a small style fix (well not even really style wise, but rather making the part with assigning and checking the $bind_interface variable s

Re: [pve-devel] [PATCH manager 1/3] fix #5255: node: wol: add optional bind interface

2024-03-26 Thread Christian Ebner
> On 22.03.2024 15:37 CET Christian Ebner wrote: > > Agreed, will send a new version with the suggested changes to the format > string. Version 2 of the patches: https://lists.proxmox.com/pipermail/pve-devel/2024-March/062397.html _

[pve-devel] [PATCH v2 pve-manager 3/4] fix #5255: node: wol: configurable broadcast address

2024-03-26 Thread Christian Ebner
Allows to configure a custom broadcast address to use when sending a wake on lan packet to wake a remote node. Default behaviour remains to fallback to 255.255.255.255. Signed-off-by: Christian Ebner --- changes since version 1: - Adapted to use property string PVE/API2/Nodes.pm | 3 ++- PVE

[pve-devel] [PATCH v2 pve-docs 4/4] pvenode/wake-on-lan: mention optional config options

2024-03-26 Thread Christian Ebner
Show how to configure the optional bind interface and broadcast address options via `pvenode`. Signed-off-by: Christian Ebner --- pvenode.adoc | 14 ++ 1 file changed, 14 insertions(+) diff --git a/pvenode.adoc b/pvenode.adoc index 59eeecb..6cf5bc9 100644 --- a/pvenode.adoc +++ b

[pve-devel] [PATCH v2 pve-manager 2/4] fix #5255: node: wol: add optional bind interface

2024-03-26 Thread Christian Ebner
Allows to optionally configure a local interface name to which to bind to when sending a wake on lan packet to wake a remote node. Default behaviour remains to send the packet via the interface for the default gateway. Signed-off-by: Christian Ebner --- changes since version 1: - Adapted to use

[pve-devel] [PATCH v2 pve-manager pve-docs 0/4] add optional WoL config options

2024-03-26 Thread Christian Ebner
XX:XX:XX:XX:XX:XX,broadcast-address=`. See also the thread in the community forum https://forum.proxmox.com/threads/123459/ pve-manager: Christian Ebner (3): node: config: make wakeonlan a property string fix #5255: node: wol: add optional bind interface fix #5255: node: wol: configurable

[pve-devel] [PATCH v2 pve-manager 1/4] node: config: make wakeonlan a property string

2024-03-26 Thread Christian Ebner
. Signed-off-by: Christian Ebner --- changes since version 1: - not present in previous version PVE/API2/Nodes.pm | 6 -- PVE/NodeConfig.pm | 39 +-- 2 files changed, 37 insertions(+), 8 deletions(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index

Re: [pve-devel] [PATCH manager 1/3] fix #5255: node: wol: add optional bind interface

2024-03-22 Thread Christian Ebner
> On 21.03.2024 18:27 CET Thomas Lamprecht wrote: > > > On 05/03/2024 13:54, Christian Ebner wrote: > > +'wakeonlan-bind-interface' => { > > + type => 'string', > > + description => 'Bind to this interfac

[pve-devel] [PATCH manager docs 0/3] add optional WoL config options

2024-03-05 Thread Christian Ebner
`. See also the thread in the community forum https://forum.proxmox.com/threads/123459/ pve-manager: Christian Ebner (2): fix #5255: node: wol: add optional bind interface fix #5255: node: wol: configurable broadcast address PVE/API2/Nodes.pm | 16 ++-- PVE/NodeConfig.pm | 12

[pve-devel] [PATCH manager 2/3] fix #5255: node: wol: configurable broadcast address

2024-03-05 Thread Christian Ebner
Allows to configure a custom broadcast address to use when sending a wake on lan packet to wake a remote node. Default behaviour remains to fallback to 255.255.255.255. Signed-off-by: Christian Ebner --- PVE/API2/Nodes.pm | 3 ++- PVE/NodeConfig.pm | 6 ++ 2 files changed, 8 insertions

[pve-devel] [PATCH docs 3/3] pvenode/wake-on-lan: mention optional config options

2024-03-05 Thread Christian Ebner
Show how to configure the optional bind interface and broadcast address options via `pvenode`. Signed-off-by: Christian Ebner --- pvenode.adoc | 14 ++ 1 file changed, 14 insertions(+) diff --git a/pvenode.adoc b/pvenode.adoc index 59eeecb..8a1da08 100644 --- a/pvenode.adoc +++ b

[pve-devel] [PATCH manager 1/3] fix #5255: node: wol: add optional bind interface

2024-03-05 Thread Christian Ebner
Allows to optionally configure a local interface name to which to bind to when sending a wake on lan packet to wake a remote node. Default behaviour remains to send the packet via the interface for the default gateway. Signed-off-by: Christian Ebner --- PVE/API2/Nodes.pm | 13

Re: [pve-devel] [PATCH pve-manager] ui: lxc: add firewall log view filtering

2024-03-05 Thread Christian Ebner
ping, still applies! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH proxmox-i18n] update Italian translations

2024-02-27 Thread Christian Ebner
Signed-off-by: Christian Ebner --- it.po | 1028 - 1 file changed, 351 insertions(+), 677 deletions(-) diff --git a/it.po b/it.po index 40d0c7f..e073711 100644 --- a/it.po +++ b/it.po @@ -323,9 +323,8 @@ msgid "Add Remote&quo

[pve-devel] [PATCH v2 proxmox stable-2 2/2] apt: repos: Remove unneeded unwrap for codename variant

2024-02-06 Thread Christian Ebner
://forum.proxmox.com/threads/141004/ Signed-off-by: Christian Ebner --- Changes since v1: - No changes proxmox-apt/src/repositories/mod.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/proxmox-apt/src/repositories/mod.rs b/proxmox-apt/src/repositories/mod.rs index 6588b90

Re: [pve-devel] [PATCH proxmox master stable-2 1/2] apt: repos: extend `Codename` by `Unknown` variant

2024-02-06 Thread Christian Ebner
> You only match the current codename and DebianCodename::Unknown(_, _). > Any known newer codename will just fall through to the default arm (and > the default arm can/should be avoided by pulling in the check for the > older codename from above). Ah now I see, thanks for noticing and for clarifi

Re: [pve-devel] [PATCH proxmox master stable-2 1/2] apt: repos: extend `Codename` by `Unknown` variant

2024-02-06 Thread Christian Ebner
> > > > -if Some(codename) == current_codename.next() { > > -add_info("ignore-pre-upgrade-warning", > > message_new(base_suite)); > > -} else if codename > current_codename { > > -add_info("warning", message_new(base_suite

[pve-devel] [PATCH proxmox stable-2 2/2] apt: repos: Remove unneeded unwrap for codename variant

2024-02-05 Thread Christian Ebner
://forum.proxmox.com/threads/141004/ Signed-off-by: Christian Ebner --- proxmox-apt/src/repositories/mod.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/proxmox-apt/src/repositories/mod.rs b/proxmox-apt/src/repositories/mod.rs index 6588b90..ccb49cd 100644 --- a/proxmox-apt

[pve-devel] [PATCH v2 pve-docs] notifications: fix typos and improve reading flow

2024-01-10 Thread Christian Ebner
Signed-off-by: Christian Ebner --- changes since v1: - fix an additional typo spotted Lukas notifications.adoc | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/notifications.adoc b/notifications.adoc index cddb8ca..46aff6a 100644 --- a/notifications.adoc +++ b

Re: [pve-devel] [PATCH pve-docs] notifications: fix typos and improve reading flow

2024-01-10 Thread Christian Ebner
> On 10.01.2024 14:37 CET Lukas Wagner wrote: > > > On 1/10/24 14:14, Christian Ebner wrote: > > Signed-off-by: Christian Ebner > > --- > > notifications.adoc | 10 +- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff

[pve-devel] [PATCH pve-docs] notifications: fix typos and improve reading flow

2024-01-10 Thread Christian Ebner
Signed-off-by: Christian Ebner --- notifications.adoc | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/notifications.adoc b/notifications.adoc index cddb8ca..9be23f8 100644 --- a/notifications.adoc +++ b/notifications.adoc @@ -172,11 +172,11 @@ Notification Matchers

[pve-devel] [PATCH pve-manager] ui: lxc: add firewall log view filtering

2023-12-05 Thread Christian Ebner
Allow to filter firewall logs analogous to node and VM firewall logs. Signed-off-by: Christian Ebner --- www/manager6/lxc/Config.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/www/manager6/lxc/Config.js b/www/manager6/lxc/Config.js index 4516ee8f..8ef66f39 100644 --- a/www/manager6

[pve-devel] [PATCH pve-manager] ui: sdn: use all upper case for acronyms

2023-11-22 Thread Christian Ebner
Signed-off-by: Christian Ebner --- www/manager6/sdn/ZoneView.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/www/manager6/sdn/ZoneView.js b/www/manager6/sdn/ZoneView.js index 71890dd3..67e86e16 100644 --- a/www/manager6/sdn/ZoneView.js +++ b/www/manager6/sdn

[pve-devel] [PATCH pve-docs] pvesdn: Fix heading for NetBox IPAM plugin section

2023-11-22 Thread Christian Ebner
Signed-off-by: Christian Ebner --- pvesdn.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvesdn.adoc b/pvesdn.adoc index f362da4..fdc6ea7 100644 --- a/pvesdn.adoc +++ b/pvesdn.adoc @@ -538,7 +538,7 @@ stack of the guest or rebooting it. [[pvesdn_ipam_plugin_netbox

[pve-devel] [PATCH pve-docs] pvesdn: remove double occurrence of 'external'

2023-11-22 Thread Christian Ebner
Signed-off-by: Christian Ebner --- pvesdn.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvesdn.adoc b/pvesdn.adoc index 5d87d09..f362da4 100644 --- a/pvesdn.adoc +++ b/pvesdn.adoc @@ -423,7 +423,7 @@ Controllers --- Some zones implement a separated control

Re: [pve-devel] [PATCH storage v3 0/4] pbs: fix #5008: Prevent adding pbs storage with invalid namespace

2023-11-21 Thread Christian Ebner
> On 21.11.2023 14:12 CET Philipp Hufnagl wrote: > > > Hmmm... thats very curios. I tried that on my end and it worked fine. > > What datastore did you try to delete? Did you have a valid > configuration for it? Not deleting a datastore (that works fine), I was testing if I am able to deact

Re: [pve-devel] [PATCH storage v3 0/4] pbs: fix #5008: Prevent adding pbs storage with invalid namespace

2023-11-21 Thread Christian Ebner
> On 16.11.2023 11:35 CET Philipp Hufnagl wrote: > > > Currently, when adding a PBS storage with a namespace that does not > exist, the storage gets added normally, but browsing/using it only > returns a cryptic error message. > > This change checks if the namespace entered when adding is vali

[pve-devel] [PATCH v2 pve-manager] ui: node summary: use SI units for HD usage

2023-11-21 Thread Christian Ebner
SI units are used for storage size information, as typically used by hard disk manufacturers. Change the root filesystem usage values in the node summary to be consistent. Signed-off-by: Christian Ebner --- Will also send a patch for PMG to be consistent across all of them. changes since v1

Re: [pve-devel] [PATCH pve-manager] ui: node summary: use SI units for HD usage

2023-11-21 Thread Christian Ebner
> On 21.11.2023 12:03 CET Christian Ebner wrote: > > > > On 21.11.2023 11:05 CET Fiona Ebner wrote: > > > > > > Am 21.11.23 um 10:00 schrieb Christian Ebner: > > > diff --git a/www/manager6/node/StatusView.js > > > b/www/manager6/node/

Re: [pve-devel] [PATCH pve-manager] ui: node summary: use SI units for HD usage

2023-11-21 Thread Christian Ebner
> On 21.11.2023 11:05 CET Fiona Ebner wrote: > > > Am 21.11.23 um 10:00 schrieb Christian Ebner: > > diff --git a/www/manager6/node/StatusView.js > > b/www/manager6/node/StatusView.js > > index d34724f7..a6975b6e 100644 > > --- a/www/manager6/node/Statu

[pve-devel] [PATCH pve-manager] ui: node summary: use SI units for HD usage

2023-11-21 Thread Christian Ebner
SI units are used for storage size information, as typically used by hard disk manufacturers. Change the root filesystem usage values in the node summary to be consistent. Signed-off-by: Christian Ebner --- www/manager6/node/StatusView.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion

[pve-devel] [PATCH proxmox-i18n] update Italian translation

2023-11-20 Thread Christian Ebner
Signed-off-by: Christian Ebner --- it.po | 556 -- 1 file changed, 187 insertions(+), 369 deletions(-) diff --git a/it.po b/it.po index ca149df..6ae242d 100644 --- a/it.po +++ b/it.po @@ -96,9 +96,8 @@ msgid "API Data" msgstr &q

Re: [pve-devel] [PATCH storage v2 4/4] pbs: fix #5008: Check if datastore and namespace is valid on add- and update hooks

2023-11-16 Thread Christian Ebner
> On 15.11.2023 17:00 CET Philipp Hufnagl wrote: > > > This adds a check if the datastore and the namespace is valid when a > user attempts to add a new PBS datastore. > > Since the namespace only can be checked after the datastore is > validated, the datastore will be checked as well, regar

Re: [pve-devel] [PATCH storage v2 3/4] pbs: Extraxt check_datastore_exists from activate_storage

2023-11-16 Thread Christian Ebner
Typi in heading s/Extraxt/Extract, maybe call it factor out instead. > On 15.11.2023 17:00 CET Philipp Hufnagl wrote: > > > Parts contained in activate_storage are needed to be run to fix #5008, > however, implementing a namespace check there would cause unneded > overhead. Typo s/unneded/unn

Re: [pve-devel] [PATCH storage v2 2/4] pbs: Make it possible to reuse PBS connection for datastore API call

2023-11-16 Thread Christian Ebner
> On 15.11.2023 17:00 CET Philipp Hufnagl wrote: > > > It would be nice to reuse an existing PBS connection for scan_datastore. > Because scan_datastore is used multiple in the code, it can not be > canged without breaking existing code. Typo s/canged/changed. > > This change add an optio

[pve-devel] [PATCH pve-manager 2/2] lxc: options: add PBS change detecion mode selector

2023-11-15 Thread Christian Ebner
Add selector to switch between default and metadata based change detection mode for backups using PBS as backend. Signed-off-by: Christian Ebner --- www/manager6/lxc/Options.js | 19 +++ 1 file changed, 19 insertions(+) diff --git a/www/manager6/lxc/Options.js b/www/manager6

[pve-devel] [PATCH pve-container 1/2] config: backup: add PBS change detection mode

2023-11-15 Thread Christian Ebner
Adds the config option to switch from regular to metadata based change detection mode when using PBS as backend. Signed-off-by: Christian Ebner --- src/PVE/LXC/Config.pm | 7 +++ src/PVE/VZDump/LXC.pm | 5 + 2 files changed, 12 insertions(+) diff --git a/src/PVE/LXC/Config.pm b/src/PVE

[pve-devel] [PATCH pve-container pve-manager 0/2] add config option for metadata based PBS backup

2023-11-15 Thread Christian Ebner
Christian Ebner (1): lxc: options: add PBS change detecion mode selector www/manager6/lxc/Options.js | 19 +++ 1 file changed, 19 insertions(+) -- 2.39.2 ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com

  1   2   >