On 2/25/25 17:19, Thomas Lamprecht wrote:
Am 29.11.24 um 11:41 schrieb Christian Ebner:
Do not allow to open the smart values window by either double clicking
the record or clicking the show button, if the selected drives status
is unknown.
Fetching the smart values for such devices might fail. Devices which
do not support this can be, e.g. USB pen drives used as removable
datastores in Proxmox Backup Server.
Reported in the community forum:
https://forum.proxmox.com/threads/158217/
Signed-off-by: Christian Ebner <c.eb...@proxmox.com>
---
src/panel/DiskList.js | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/panel/DiskList.js b/src/panel/DiskList.js
index dfd8c8e..3a1632c 100644
--- a/src/panel/DiskList.js
+++ b/src/panel/DiskList.js
@@ -86,6 +86,9 @@ Ext.define('Proxmox.DiskList', {
if (!selection || selection.length < 1) return;
let rec = selection[0];
+ if (!rec.data.status || rec.data.status ===
Proxmox.Utils.unknownText) {
+ return;
+ }
Ext.create('Proxmox.window.DiskSmart', {
baseurl: view.baseurl,
dev: rec.data.name,
@@ -369,7 +372,8 @@ Ext.define('Proxmox.DiskList', {
parentXType: 'treepanel',
disabled: true,
enableFn: function(rec) {
- if (!rec || rec.data.parent) {
+ if (!rec || rec.data.parent || !rec.data.status ||
+ rec.data.status === Proxmox.Utils.unknownText) {
return false;
} else {
return true;
pre-existing but an if-else that returns boolean seldomly makes sense,
i.e. this could be:
enableFn: rec => rec && !rec.data.parent && rec.data.status && rec.data.status
!== Proxmox.Utils.unknownText,
or with my comment for patch 1 addressed it might be:
enableFn: rec => rec && !rec.data.parent && rec.data.status && rec.data.status
!== 'unknown',
Acked, will incorporate the suggestions for both patches in a v2, thanks
for feedback!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
