On 8/2/24 18:41, Stoiko Ivanov wrote:

[2] https://opnsense.org/download/

  src/PVE/Storage.pm                 |  3 +++
  src/PVE/Storage/Plugin.pm          |  2 +-
  src/test/archive_info_test.pm      |  6 ++++--
  src/test/list_volumes_test.pm      | 11 ++++++++++-
  src/test/parse_volname_test.pm     |  4 ++--
  src/test/path_to_volume_id_test.pm | 13 ++++++++-----
  6 files changed, 28 insertions(+), 11 deletions(-)

diff --git a/src/PVE/Storage.pm b/src/PVE/Storage.pm
index 57b2038..0caac71 100755
--- a/src/PVE/Storage.pm
+++ b/src/PVE/Storage.pm
@@ -1550,16 +1550,19 @@ sub decompressor_info {
            gz => ['tar', '-z'],
            lzo => ['tar', '--lzop'],
            zst => ['tar', '--zstd'],
+           bz2 => ['tar', '--bzip2'],
        },
        vma => {
            gz => ['zcat'],
            lzo => ['lzop', '-d', '-c'],
            zst => ['zstd', '-q', '-d', '-c'],
+           bz2 => ['bzcat', '-q'],
... but add it for tar and vma here?
(haven't tried if adding it only for one of the formats works explicitly
though)


Same as Stoiko, I was a bit surprised to finding this hunk here and the others related to vma archives further below as well, while looking at your patch. I suggest to add a bit more description to the commit message and additional context to the commit title as well.



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to