Superseded
byhttps://lore.proxmox.com/pve-devel/20250321103511.66722-1-m.koe...@proxmox.com/
Thank you for having a look and your detailed suggestions!
style nit: we mainly use `let` variables for new code as that has less confusing
scope rules, i.e. variables declared through var are also ava
Am 25.03.25 um 16:12 schrieb Daniel Kral:
> Implement helper subroutines, which implement basic set operations done
> on hash sets, i.e. hashes with elements set to a true value, e.g. 1.
>
> These will be used for various tasks in the HA Manager colocation rules,
> e.g. for verifying the satisfiab
--- Begin Message ---
On 28/01/2025 01:16, Fabian Grünbichler wrote:
> if we only add it when the VM is removed via the API, we might miss those
> where an admin just does "rm /etc/pve/../XXX.conf" (which might happen if
> something is blocking regular removal)? wouldn't it be safer to add them w
--- Begin Message ---
On 28/01/2025 01:16, Fabian Grünbichler wrote:
> Hi!
>
> sorry it took so long to get back at this series! next will be faster :)
No worries! As you can see it took me a while to get back to this too... I've
implemented all the suggestions around style and will post the upd
--- Begin Message ---
On 29/01/2025 03:57, Thomas Lamprecht wrote:
> Am 27.01.25 um 13:18 schrieb Fabian Grünbichler:
>>> Severen Redwood via pve-devel hat am
>>> 08.11.2024 02:46 CET geschrieben:
>>
>>> Add `/etc/pve/used_vmids.list` to the list of cluster files, which will
>>> be used for recor
Factor out the prioritized node hash set in the select_service_node as
it is used multiple times and makes the intent a little clearer.
Signed-off-by: Daniel Kral
---
src/PVE/HA/Manager.pm | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/PVE/HA/Manager.pm b/src/PV
Am 21.03.25 um 10:56 schrieb Lukas Wagner:
> To quote from RFC 9110 [1]:
>
> A user agent SHOULD send Content-Length in a request when
> the method defines a meaning for enclosed content and it
> is not sending Transfer-Encoding. For example, a user agent
> normally sends Content-Length in
Implement helper subroutines, which implement basic set operations done
on hash sets, i.e. hashes with elements set to a true value, e.g. 1.
These will be used for various tasks in the HA Manager colocation rules,
e.g. for verifying the satisfiability of the rules or applying the
colocation rules
Am 18.03.25 um 10:09 schrieb Dominik Csapak:
> instead of simply waiting 250ms after we send the credentials, wait
> until after the server responded with 'OK' to fit the terminal size.
> Still keep the timeout to not do that in the onmessage handler itself,
> but rather at a later point in time.
Am 20.03.25 um 15:23 schrieb Victor Seva:
> Check if there is already a logged session present and
> fall back to previous TCP check port connection.
>
> pvestatd is calling check_connection every 10 seconds.
> This check produces a lot of noise at the iscsi server logging.
>
> Signed-off-by: Vic
Am 27.02.25 um 10:02 schrieb Matthieu Pignolet:
> This fixes an issue with dual stacking, when using a zone with both a V4 and
> V6
> subnet and the same dns suffix, pve-network will try to set both dns records
> (type A and ) in the
> same powerdns rrset, causing an api error, and effectivel
Am 25.03.25 um 16:01 schrieb Michael Köppl:
> While the format_task_description function is used in other parts of the
> UI, this still leaves these use cases intact. The guest name is an
> optional addition in parantheses.
s/parantheses/parentheses/
>
> Signed-off-by: Michael Köppl
> ---
> sr
Am 25.03.25 um 16:12 schrieb Daniel Kral:
> Signed-off-by: Daniel Kral
> ---
> .gitignore | 2 ++
> 1 file changed, 2 insertions(+)
>
>
applied this one already, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.co
On Tue Mar 25, 2025 at 4:26 PM CET, Aaron Lauterer wrote:
> Overall, a nice overhaul to make the section a lot easier to grasp.
> Thanks! A bit more content wise inline.
Thank you for the review! Will prepare a v2, see comments below.
>
> On 2025-02-10 11:36, Alexander Zeidler wrote:
>> * Remo
Am 25.03.25 um 10:18 schrieb Aaron Lauterer:
> Some users configure their VMs to use serial as their display. The big
> benefit is that in combination with the xtermjs remote console, copy &
> paste works a lot better than via novnc.
>
> While the console button in the top right allows to manually
On 3/25/25 16:12, Daniel Kral wrote:
Colocation Rules
The two properties of colocation rules, as described in the
introduction, are rather straightforward. A typical colocation rule
inside of the config would look like the following:
colocation: some-lonely-services
ser
Am 25.03.25 um 13:27 schrieb Christoph Heiss:
> Everywhere else (including in the Ceph documentation itself [0]) it is
> spelled without a space in "metadata", so fix this lonely occurrence for
> consistency.
>
> [0] https://docs.ceph.com/en/latest/glossary/#term-Ceph-Metadata-Server
>
> Signed-o
> Thomas Skinner hat am 24.03.2025 03:37 CET geschrieben:
>
>
> Signed-off-by: Thomas Skinner
> ---
> pveum.adoc | 37 +
> 1 file changed, 37 insertions(+)
>
> diff --git a/pveum.adoc b/pveum.adoc
> index 81565ab..5da0e98 100644
> --- a/pveum.adoc
> +++ b/
> Thomas Skinner hat am 24.03.2025 03:37 CET geschrieben:
>
>
> Changes since v3:
> - removed all code/settings/docs for group name replacement characters
> - conditionally print user added to groups message
>
> access-control:
>
> Thomas Skinner (1):
> fix #4411: openid: add logic for open
Add a mechanism to the node selection subroutine, which enforces the
colocation rules defined in the rules config.
The algorithm manipulates the set of nodes directly, which the service
is allowed to run on, depending on the type and strictness of the
colocation rules, if there are any.
This make
Add a rules section config base plugin to allow users to specify
different kinds of rules in a single configuration file.
The interface is designed to allow sub plugins to implement their own
{decode,encode}_value() methods and also offer a canonicalized version
of their rules with canonicalize(),
Signed-off-by: Daniel Kral
---
.gitignore | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.gitignore b/.gitignore
index 5b748c4..c35280e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -4,3 +4,5 @@
*.buildinfo
*.tar.gz
/src/test/test-*/status/*
+/src/test/fence_cfgs/*.cfg.commands
+/src/test
Some users configure their VMs to use serial as their display. The big
benefit is that in combination with the xtermjs remote console, copy &
paste works a lot better than via novnc.
While the console button in the top right allows to manually choose the
console type, the Console in the main subme
Add test cases for loose positive and negative colocation rules, i.e.
where services should be kept on the same node together or kept separate
nodes. These are copies of their strict counterpart tests, but verify
the behavior if the colocation rule cannot be met, i.e. not adhering to
the colocation
Overall, a nice overhaul to make the section a lot easier to grasp.
Thanks! A bit more content wise inline.
On 2025-02-10 11:36, Alexander Zeidler wrote:
* Remove duplicated text to maintain clarity
* Mention available installation methods (web-based wizard, CLI tool)
* Create a table to see
most of the building blocks are already there:
* we can have qcow2 files in an import storage
* we can import qcow2 files via the api from such a storage
this series fills in the missing bits & pieces:
* allow uploading qcow2 files into an import storage via the webgui
* adding the possibility to
This came up in support, and there is no reason to not have it in
the UI, while having it in the API.
Signed-off-by: Hannes Laimer
---
v2:
- use Aaron's improved help text
v3, thanks @Fabian and @Fiona:
- handle if a path is set correctly
- move to BaseStorage, so we don't have the same code
sent a v3:
https://lore.proxmox.com/pve-devel/20250325151421.3182493-1-d.csa...@proxmox.com/
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
adds a checkbox 'import image' above the storage selector which:
* hides the original storage selector
* shows a 'source storage' selector
* shows a 'import file' selector
* shows a 'target storage' selector
Since the wizard and the hd edit share this panel, this also works in
the wizard.
Signed-
this sometimes comes in handy when we only want to show specific files.
Signed-off-by: Dominik Csapak
---
no changes in v3
www/manager6/form/FileSelector.js | 10 ++
1 file changed, 10 insertions(+)
diff --git a/www/manager6/form/FileSelector.js
b/www/manager6/form/FileSelector.js
inde
partially fixes #2424
Signed-off-by: Dominik Csapak
---
no changes in v3
www/manager6/window/UploadToStorage.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/window/UploadToStorage.js
b/www/manager6/window/UploadToStorage.js
index cdf548a8..3ce2d1f5 100644
---
so users can upload qcow2 files directly in the ui
Signed-off-by: Dominik Csapak
---
no changes in v3
src/PVE/API2/Storage/Status.pm | 17 -
src/PVE/Storage.pm | 2 +-
2 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/src/PVE/API2/Storage/Status.pm b/sr
Add test cases, where colocation rules are used with the static
utilization scheduler and the rebalance on start option enabled. These
verify the behavior in the following scenarios:
- 7 services with intertwined colocation rules in a 3 node cluster;
1 node failing
- 3 neg. colocated services in
This RFC patch series is a draft for the implementation to allow users
to specify colocation rules (or affinity/anti-affinity) for the HA
Manager, so that two or more services are either kept together or apart
with respect to each other in case of service recovery or if
auto-rebalancing on service
Add test cases for strict positive colocation rules, i.e. where services
must be kept on the same node together. These verify the behavior of the
services in strict positive colocation rules in case of a failover of
their assigned nodes in the following scenarios:
- 2 pos. colocated services in a
Add test cases to verify the correct transformation of various types of
ill-defined colocation rules:
- Merging multiple, transitive positive colocation rules of the same
strictness level
- Dropping colocation rules with not enough defined services
- Dropping colocation rules which have inner co
Add the colocation rule plugin to allow users to specify inter-service
affinity constraints.
These colocation rules can either be positive (keeping services
together) or negative (keeping service separate). Their strictness can
also be specified as either a MUST or a SHOULD, where the first
specif
Add an option to the VirtFail's name to allow the start and migrate fail
counts to only apply on a certain node number with a specific naming
scheme.
This allows a slightly more elaborate test type, e.g. where a service
can start on one node (or any other in that case), but fails to start on
a spe
Adds methods to the HA environment to read and parse the rules
configuration file for the specific environment implementation.
Signed-off-by: Daniel Kral
---
src/PVE/HA/Config.pm | 12
src/PVE/HA/Env.pm | 6 ++
src/PVE/HA/Env/PVE2.pm | 13 +
src/P
Add methods get_service_node() and pin_service_node() to the Usage class
to retrieve and pin the current node of a specific service.
This is used to retrieve the current node of a service for colocation
rules inside of select_service_node(), where there is currently no
access to the global service
Signed-off-by: Daniel Kral
---
src/PVE/Cluster.pm | 1 +
src/pmxcfs/status.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm
index e0e3ee9..afbb36f 100644
--- a/src/PVE/Cluster.pm
+++ b/src/PVE/Cluster.pm
@@ -69,6 +69,7 @@ my $observed = {
'ha/c
Closes #3181 [0].
The goal of this series is to extend the information displayed in the
confirmation dialogs when cloning, migrating, removing VMs or CTs by
adding the guest name in addition to the VM ID. This also unifies the
displayed information since there are multiple actions that already
inc
While the format_task_description function is used in other parts of the
UI, this still leaves these use cases intact. The guest name is an
optional addition in parantheses.
Signed-off-by: Michael Köppl
---
src/Utils.js | 8 ++--
src/window/SafeDestroy.js | 3 ++-
2 files change
Am 24.03.25 um 13:38 schrieb Wolfgang Bumiller:
> On Fri, Mar 21, 2025 at 02:48:44PM +0100, Fiona Ebner wrote:
>> diff --git a/src/PVE/LXC/Namespaces.pm b/src/PVE/LXC/Namespaces.pm
>> new file mode 100644
>> index 000..e4b1e5f
>> --- /dev/null
>> +++ b/src/PVE/LXC/Namespaces.pm
>> @@ -0,0 +1,60
--- Begin Message ---
> There are pre-built packages with the series incorporated available at [0]
> with SHA256SUM [1].
Does that mean the backup provider plugin is not yet available as part of any
qemu/proxmox release? If not in the released version, then which version would
have these change
Am 24.03.25 um 16:43 schrieb Wolfgang Bumiller:
> Just a short high level nit today, will have to look more closely at
> this and the series the next days:
>
> There's a `new()` which takes an $scfg + $storeid.
>
> But later there are some methods taking `$self` (which usually means the
> thing r
Everywhere else (including in the Ceph documentation itself [0]) it is
spelled without a space in "metadata", so fix this lonely occurrence for
consistency.
[0] https://docs.ceph.com/en/latest/glossary/#term-Ceph-Metadata-Server
Signed-off-by: Christoph Heiss
---
www/manager6/ceph/Services.js |
Signed-off-by: Christoph Heiss
---
.gitignore | 7 +++
1 file changed, 7 insertions(+)
diff --git a/.gitignore b/.gitignore
index e1fc9d6..8e46926 100644
--- a/.gitignore
+++ b/.gitignore
@@ -2,3 +2,10 @@ build
*.deb
*.1.pod
*.1.gz
+/libpve-access-control-[0-9]*/
+/libpve-access-control_[
For external backup providers, the state of the VM's disk images at
the time the backup is started is preserved via a snapshot-access
block node. Old data is moved to the fleecing image when new guest
writes come in. The snapshot-access block node, as well as the
associated bitmap in case of increm
The bug from before is solved, but instead a different bug has appeared:
When I enable the "Import Image" checkbox on the "Disks" tab of the
virtual machine creation wizard, the "Select Image" selector is disabled
by default. It can be enabled by switching the import storage.
On 20/03/2025 14:40,
Am 25.03.25 um 12:11 schrieb Fiona Ebner:
> Am 24.03.25 um 14:02 schrieb Wolfgang Bumiller:
>> The code below can also be factored out as AFAICT it, too, is a copy, if
>> `backup_file` is a parameter (which which `NULL` may be passed, as
>> `g_strdup()` explicitly maps NULL to NULL), and `uuid` as
On Mon Mar 24, 2025 at 5:50 PM CET, Aaron Lauterer wrote:
>
>
> On 2025-02-10 11:36, Alexander Zeidler wrote:
>> * Remove duplicated text to maintain clarity
>> * Mention available installation methods (web-based wizard, CLI tool)
>> * Create a table to see the support state of Ceph releases
>
>
Am 24.03.25 um 14:02 schrieb Wolfgang Bumiller:
> The code below can also be factored out as AFAICT it, too, is a copy, if
> `backup_file` is a parameter (which which `NULL` may be passed, as
> `g_strdup()` explicitly maps NULL to NULL), and `uuid` as well I guess
> (here it's not touched but may a
Am 24.03.25 um 14:02 schrieb Wolfgang Bumiller:
> On Fri, Mar 21, 2025 at 02:48:23PM +0100, Fiona Ebner wrote:
>> +if (setup_snapshot_access(di, &local_err) < 0) {
>> +cleanup_snapshot_access(di);
>
> (not part of this patch, but why does our `setup_snapshot_access()` not
> cal
Originally reported in the forum [0].
This is only a cosmetic fix and has no user-visible impact, just fixing
a code warning in the syslog. Applies only for case-insensitive realms
too, where Active Directory is the only type to support that.
When looking up a non-existing username on case-insens
This primarily fixes a Perl warning in the syslog about a undef
variable, with no impact on the actual functionality though.
The two other patches #2 and #3 just clean up some small things I came
across while at it.
Christoph Heiss (3):
access: lookup: fix undef warning for case-insensitive rea
Given that the information is only needed for case-sensitive realms,
move the read into the conditional.
No functional changes.
Signed-off-by: Christoph Heiss
---
src/PVE/AccessControl.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/AccessControl.pm b/src/PVE/Acce
Am 25.03.25 um 11:23 schrieb Prashant Patil:
>> There are pre-built packages with the series incorporated available at [0]
>> with SHA256SUM [1].
>
> Does that mean the backup provider plugin is not yet available as part of any
> qemu/proxmox release? If not in the released version, then which v
I sent out a v4 with the suggested changes by Friedrich and the bug
number that Hannes found. Thanks!
https://lore.proxmox.com/pve-devel/20250325091854.1051956-1-a.laute...@proxmox.com/T/#u
On 2025-02-25 16:47, Aaron Lauterer wrote:
Some users configure their VMs to use serial as their displ
Am 24.03.25 um 06:20 schrieb Prashant Patil:
> We would like to do plugin integration POC. So, for that to get started, we
> would like to know various interfaces of these plugins. Is there any detailed
> API documentation available for these plugins? Also, do you have any test app
> code which
I just noticed that there is a open bugtracker for this issue/feature
request [0], so you can assign your self and add the bugtracker number
to the commit message.
[0] https://bugzilla.proxmox.com/show_bug.cgi?id=1926
On 2/25/25 16:47, Aaron Lauterer wrote:
[...]
___
Instead of our own fix for the extra keys, backport the proper one from
upstream. As mentioned in the commit message, this also fixes
the clibpoard textarea margin.
We can drop this patch then when we update to a new upstream release
with this included.
Signed-off-by: Dominik Csapak
---
...-Fix
62 matches
Mail list logo
